From: Sean Young <sean@mess.org>
To: Sean Wang <sean.wang@mediatek.com>
Cc: mchehab@osg.samsung.com, hdegoede@redhat.com,
hkallweit1@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
matthias.bgg@gmail.com, andi.shyti@samsung.com,
hverkuil@xs4all.nl, ivo.g.dimitrov.75@gmail.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, keyhaede@gmail.com
Subject: Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
Date: Mon, 9 Jan 2017 12:39:42 +0000 [thread overview]
Message-ID: <20170109123942.GA15215@gofer.mess.org> (raw)
In-Reply-To: <1483931601.16976.48.camel@mtkswgap22>
On Mon, Jan 09, 2017 at 11:13:21AM +0800, Sean Wang wrote:
> I had another question. I found multiple and same IR messages being
> received when using SONY remote controller. Should driver needs to
> report each message or only one of these to the upper layer ?
In general the driver shouldn't try to change any IR message, this should
be done in rc-core if necessary.
rc-core should handle this correctly. If the same key is received twice
within IR_KEYPRESS_TIMEOUT (250ms) then it not reported to the input
layer.
Thanks
Sean
WARNING: multiple messages have this Message-ID (diff)
From: Sean Young <sean@mess.org>
To: Sean Wang <sean.wang@mediatek.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
ivo.g.dimitrov.75@gmail.com, keyhaede@gmail.com,
mchehab@osg.samsung.com, linux-kernel@vger.kernel.org,
andi.shyti@samsung.com, hverkuil@xs4all.nl, hdegoede@redhat.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com
Subject: Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
Date: Mon, 9 Jan 2017 12:39:42 +0000 [thread overview]
Message-ID: <20170109123942.GA15215@gofer.mess.org> (raw)
In-Reply-To: <1483931601.16976.48.camel@mtkswgap22>
On Mon, Jan 09, 2017 at 11:13:21AM +0800, Sean Wang wrote:
> I had another question. I found multiple and same IR messages being
> received when using SONY remote controller. Should driver needs to
> report each message or only one of these to the upper layer ?
In general the driver shouldn't try to change any IR message, this should
be done in rc-core if necessary.
rc-core should handle this correctly. If the same key is received twice
within IR_KEYPRESS_TIMEOUT (250ms) then it not reported to the input
layer.
Thanks
Sean
WARNING: multiple messages have this Message-ID (diff)
From: sean@mess.org (Sean Young)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
Date: Mon, 9 Jan 2017 12:39:42 +0000 [thread overview]
Message-ID: <20170109123942.GA15215@gofer.mess.org> (raw)
In-Reply-To: <1483931601.16976.48.camel@mtkswgap22>
On Mon, Jan 09, 2017 at 11:13:21AM +0800, Sean Wang wrote:
> I had another question. I found multiple and same IR messages being
> received when using SONY remote controller. Should driver needs to
> report each message or only one of these to the upper layer ?
In general the driver shouldn't try to change any IR message, this should
be done in rc-core if necessary.
rc-core should handle this correctly. If the same key is received twice
within IR_KEYPRESS_TIMEOUT (250ms) then it not reported to the input
layer.
Thanks
Sean
next prev parent reply other threads:[~2017-01-09 12:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 16:06 [PATCH 0/2] media: rc: add support for IR receiver on MT7623 SoC sean.wang
2017-01-05 16:06 ` sean.wang at mediatek.com
2017-01-05 16:06 ` sean.wang
2017-01-05 16:06 ` [PATCH 1/2] Documentation: devicetree: Add document bindings for mtk-cir sean.wang
2017-01-05 16:06 ` sean.wang at mediatek.com
2017-01-05 16:06 ` sean.wang
2017-01-09 18:32 ` Rob Herring
2017-01-09 18:32 ` Rob Herring
2017-01-09 18:32 ` Rob Herring
2017-01-10 2:35 ` Sean Wang
2017-01-10 2:35 ` Sean Wang
2017-01-10 2:35 ` Sean Wang
2017-01-11 21:27 ` Rob Herring
2017-01-11 21:27 ` Rob Herring
2017-01-11 21:27 ` Rob Herring
2017-01-05 16:06 ` [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC sean.wang
2017-01-05 16:06 ` sean.wang at mediatek.com
2017-01-05 16:06 ` sean.wang
2017-01-05 17:12 ` Sean Young
2017-01-05 17:12 ` Sean Young
2017-01-05 17:12 ` Sean Young
2017-01-06 7:31 ` Sean Wang
2017-01-06 7:31 ` Sean Wang
2017-01-06 7:31 ` Sean Wang
2017-01-08 21:16 ` Sean Young
2017-01-08 21:16 ` Sean Young
2017-01-09 3:13 ` Sean Wang
2017-01-09 3:13 ` Sean Wang
2017-01-09 3:13 ` Sean Wang
2017-01-09 12:39 ` Sean Young [this message]
2017-01-09 12:39 ` Sean Young
2017-01-09 12:39 ` Sean Young
2017-01-06 3:43 ` Andi Shyti
2017-01-06 3:43 ` Andi Shyti
2017-01-06 3:43 ` Andi Shyti
2017-01-06 7:41 ` Sean Wang
2017-01-06 7:41 ` Sean Wang
2017-01-06 7:41 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109123942.GA15215@gofer.mess.org \
--to=sean@mess.org \
--cc=andi.shyti@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=keyhaede@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.