* [PATCH v7 0/3] Add touch key driver support for TM2 [not found] <CGME20170117055443epcas1p40b08d361f8f95090ad7b4d855a5bfad4@epcas1p4.samsung.com> 2017-01-17 5:54 ` Jaechul Lee @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas Cc: Jaechul Lee, Andi Shyti, Chanwoo Choi, beomho.seo, galaxyra, linux-arm-kernel, linux-input, devicetree, linux-kernel, linux-samsung-soc Hi, This patch is last three patch from https://lkml.org/lkml/2017/1/6/277. because 1 and 2 patches have already been merged by Krzysztof. This patchset adds support for the tm2 touchkey device. The driver has been ported from Tizen Kernel, originally written by Beomho. I ported it to the latest mainline Kernel. Best Regard, Jaechul Changes in v7 - added Chanwoo's reviewed and tested. - fixed reviews from Dmitry. Changes in v6: - changed compatible name from samsaung to cypress. - updated commit tags. - removed first two patches from the original patchset. Changes in v5: - patch 1: removed a spurious regulator-always-off inherited from a different patch. Thanks Krzysztof. - patch 2: fixed a slip on the model, thanks Javier (this patch confuses me quite a lot, this was all right some patches ago and re appeared on this one). - patch 2: removed 'regulator' label and used the original ldo3x labels. Krzysztof: it looks better indeed. - added Javier's reviews and Krzysztof's acks on the related patches. Changes in v4: - patch 1 has been rebased on top of 7c294e002641 (arm64: dts: exynos: Remove unsupported regulator-always-off property from TM2E) - patch 2 has been generated with -B50% diff option using git 2.11 Changes in v3: - Changed the commit ordering, the tm2-touchkey related patches are the last 3. - Added Chanwoo's patch which fixes the wrong voltage of ldo23 and ldo25. - Andi (patch 3) moves the ldo31 and ldo38 in the tm2 and tm2e files as they have different values. Changes in v2: - fixed reviews from Javier, Dmitry - refactored power enable/disable functions. - reordered signed-offs in patch 2, while patch 4 is left as it was as Andi copy pasted the node to the new tm2.dts file - added Jarvier's (patch 1,2,4) and Krzysztof's (patch 4) reviews and Rob's Ack - patch 3 diff has been generated with -B50% Jaechul Lee (3): input: Add support for the tm2 touchkey device driver input: tm2-touchkey: Add touchkey driver support for TM2 arm64: dts: exynos: Add tm2 touchkey node .../bindings/input/cypress,tm2-touchkey.txt | 27 ++ arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 + drivers/input/keyboard/Kconfig | 11 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/tm2-touchkey.c | 287 +++++++++++++++++++++ 5 files changed, 339 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt create mode 100644 drivers/input/keyboard/tm2-touchkey.c -- 2.7.4 ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 0/3] Add touch key driver support for TM2 @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: linux-arm-kernel Hi, This patch is last three patch from https://lkml.org/lkml/2017/1/6/277. because 1 and 2 patches have already been merged by Krzysztof. This patchset adds support for the tm2 touchkey device. The driver has been ported from Tizen Kernel, originally written by Beomho. I ported it to the latest mainline Kernel. Best Regard, Jaechul Changes in v7 - added Chanwoo's reviewed and tested. - fixed reviews from Dmitry. Changes in v6: - changed compatible name from samsaung to cypress. - updated commit tags. - removed first two patches from the original patchset. Changes in v5: - patch 1: removed a spurious regulator-always-off inherited from a different patch. Thanks Krzysztof. - patch 2: fixed a slip on the model, thanks Javier (this patch confuses me quite a lot, this was all right some patches ago and re appeared on this one). - patch 2: removed 'regulator' label and used the original ldo3x labels. Krzysztof: it looks better indeed. - added Javier's reviews and Krzysztof's acks on the related patches. Changes in v4: - patch 1 has been rebased on top of 7c294e002641 (arm64: dts: exynos: Remove unsupported regulator-always-off property from TM2E) - patch 2 has been generated with -B50% diff option using git 2.11 Changes in v3: - Changed the commit ordering, the tm2-touchkey related patches are the last 3. - Added Chanwoo's patch which fixes the wrong voltage of ldo23 and ldo25. - Andi (patch 3) moves the ldo31 and ldo38 in the tm2 and tm2e files as they have different values. Changes in v2: - fixed reviews from Javier, Dmitry - refactored power enable/disable functions. - reordered signed-offs in patch 2, while patch 4 is left as it was as Andi copy pasted the node to the new tm2.dts file - added Jarvier's (patch 1,2,4) and Krzysztof's (patch 4) reviews and Rob's Ack - patch 3 diff has been generated with -B50% Jaechul Lee (3): input: Add support for the tm2 touchkey device driver input: tm2-touchkey: Add touchkey driver support for TM2 arm64: dts: exynos: Add tm2 touchkey node .../bindings/input/cypress,tm2-touchkey.txt | 27 ++ arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 + drivers/input/keyboard/Kconfig | 11 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/tm2-touchkey.c | 287 +++++++++++++++++++++ 5 files changed, 339 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt create mode 100644 drivers/input/keyboard/tm2-touchkey.c -- 2.7.4 ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 0/3] Add touch key driver support for TM2 @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas Cc: Jaechul Lee, Andi Shyti, Chanwoo Choi, beomho.seo-Sze3O3UU22JBDgjK7y7TUQ, galaxyra-Re5JQEeQqe8AvxtiuMwx3w, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-input-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA Hi, This patch is last three patch from https://lkml.org/lkml/2017/1/6/277. because 1 and 2 patches have already been merged by Krzysztof. This patchset adds support for the tm2 touchkey device. The driver has been ported from Tizen Kernel, originally written by Beomho. I ported it to the latest mainline Kernel. Best Regard, Jaechul Changes in v7 - added Chanwoo's reviewed and tested. - fixed reviews from Dmitry. Changes in v6: - changed compatible name from samsaung to cypress. - updated commit tags. - removed first two patches from the original patchset. Changes in v5: - patch 1: removed a spurious regulator-always-off inherited from a different patch. Thanks Krzysztof. - patch 2: fixed a slip on the model, thanks Javier (this patch confuses me quite a lot, this was all right some patches ago and re appeared on this one). - patch 2: removed 'regulator' label and used the original ldo3x labels. Krzysztof: it looks better indeed. - added Javier's reviews and Krzysztof's acks on the related patches. Changes in v4: - patch 1 has been rebased on top of 7c294e002641 (arm64: dts: exynos: Remove unsupported regulator-always-off property from TM2E) - patch 2 has been generated with -B50% diff option using git 2.11 Changes in v3: - Changed the commit ordering, the tm2-touchkey related patches are the last 3. - Added Chanwoo's patch which fixes the wrong voltage of ldo23 and ldo25. - Andi (patch 3) moves the ldo31 and ldo38 in the tm2 and tm2e files as they have different values. Changes in v2: - fixed reviews from Javier, Dmitry - refactored power enable/disable functions. - reordered signed-offs in patch 2, while patch 4 is left as it was as Andi copy pasted the node to the new tm2.dts file - added Jarvier's (patch 1,2,4) and Krzysztof's (patch 4) reviews and Rob's Ack - patch 3 diff has been generated with -B50% Jaechul Lee (3): input: Add support for the tm2 touchkey device driver input: tm2-touchkey: Add touchkey driver support for TM2 arm64: dts: exynos: Add tm2 touchkey node .../bindings/input/cypress,tm2-touchkey.txt | 27 ++ arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 + drivers/input/keyboard/Kconfig | 11 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/tm2-touchkey.c | 287 +++++++++++++++++++++ 5 files changed, 339 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt create mode 100644 drivers/input/keyboard/tm2-touchkey.c -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 29+ messages in thread
[parent not found: <CGME20170117055444epcas1p4942aeca8896c9b81512d383cbbca4dbf@epcas1p4.samsung.com>]
* [PATCH v7 1/3] input: Add support for the tm2 touchkey device driver @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas Cc: Jaechul Lee, Andi Shyti, Chanwoo Choi, beomho.seo, galaxyra, linux-arm-kernel, linux-input, devicetree, linux-kernel, linux-samsung-soc This patch adds the binding description of the tm2 touchkey device driver. Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: Rob Herring <robh@kernel.org> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> --- .../bindings/input/cypress,tm2-touchkey.txt | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt diff --git a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt new file mode 100644 index 0000000..635f62c --- /dev/null +++ b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt @@ -0,0 +1,27 @@ +Samsung tm2-touchkey + +Required properties: +- compatible: must be "cypress,tm2-touchkey" +- reg: I2C address of the chip. +- interrupt-parent: a phandle for the interrupt controller (see interrupt + binding[0]). +- interrupts: interrupt to which the chip is connected (see interrupt + binding[0]). +- vcc-supply : internal regulator output. 1.8V +- vdd-supply : power supply for IC 3.3V + +[0]: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt + +Example: + &i2c0 { + /* ... */ + + touchkey@20 { + compatible = "cypress,tm2-touchkey"; + reg = <0x20>; + interrupt-parent = <&gpa3>; + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + vcc-supply=<&ldo32_reg>; + vdd-supply=<&ldo33_reg>; + }; + }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v7 1/3] input: Add support for the tm2 touchkey device driver @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: linux-arm-kernel This patch adds the binding description of the tm2 touchkey device driver. Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: Rob Herring <robh@kernel.org> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> --- .../bindings/input/cypress,tm2-touchkey.txt | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt diff --git a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt new file mode 100644 index 0000000..635f62c --- /dev/null +++ b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt @@ -0,0 +1,27 @@ +Samsung tm2-touchkey + +Required properties: +- compatible: must be "cypress,tm2-touchkey" +- reg: I2C address of the chip. +- interrupt-parent: a phandle for the interrupt controller (see interrupt + binding[0]). +- interrupts: interrupt to which the chip is connected (see interrupt + binding[0]). +- vcc-supply : internal regulator output. 1.8V +- vdd-supply : power supply for IC 3.3V + +[0]: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt + +Example: + &i2c0 { + /* ... */ + + touchkey at 20 { + compatible = "cypress,tm2-touchkey"; + reg = <0x20>; + interrupt-parent = <&gpa3>; + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + vcc-supply=<&ldo32_reg>; + vdd-supply=<&ldo33_reg>; + }; + }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v7 1/3] input: Add support for the tm2 touchkey device driver @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas Cc: Jaechul Lee, Andi Shyti, Chanwoo Choi, beomho.seo-Sze3O3UU22JBDgjK7y7TUQ, galaxyra-Re5JQEeQqe8AvxtiuMwx3w, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-input-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA This patch adds the binding description of the tm2 touchkey device driver. Signed-off-by: Jaechul Lee <jcsing.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Reviewed-by: Andi Shyti <andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Acked-by: Krzysztof Kozlowski <krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> --- .../bindings/input/cypress,tm2-touchkey.txt | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt diff --git a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt new file mode 100644 index 0000000..635f62c --- /dev/null +++ b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt @@ -0,0 +1,27 @@ +Samsung tm2-touchkey + +Required properties: +- compatible: must be "cypress,tm2-touchkey" +- reg: I2C address of the chip. +- interrupt-parent: a phandle for the interrupt controller (see interrupt + binding[0]). +- interrupts: interrupt to which the chip is connected (see interrupt + binding[0]). +- vcc-supply : internal regulator output. 1.8V +- vdd-supply : power supply for IC 3.3V + +[0]: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt + +Example: + &i2c0 { + /* ... */ + + touchkey@20 { + compatible = "cypress,tm2-touchkey"; + reg = <0x20>; + interrupt-parent = <&gpa3>; + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + vcc-supply=<&ldo32_reg>; + vdd-supply=<&ldo33_reg>; + }; + }; -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 29+ messages in thread
[parent not found: <CGME20170117055444epcas1p47b0b0a0ae3260b22fa61d2b92362050b@epcas1p4.samsung.com>]
* [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 [not found] ` <CGME20170117055444epcas1p47b0b0a0ae3260b22fa61d2b92362050b@epcas1p4.samsung.com> @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas Cc: Jaechul Lee, Andi Shyti, Chanwoo Choi, beomho.seo, galaxyra, linux-arm-kernel, linux-input, devicetree, linux-kernel, linux-samsung-soc This patch adds support for the TM2 touch key and led functionality. The driver interfaces with userspace through an input device and reports KEY_PHONE and KEY_BACK event types. LED brightness can be controlled by "/sys/class/leds/tm2-touchkey/brightness". Signed-off-by: Beomho Seo <beomho.seo@samsung.com> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/keyboard/Kconfig | 11 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/tm2-touchkey.c | 286 ++++++++++++++++++++++++++++++++++ 3 files changed, 298 insertions(+) create mode 100644 drivers/input/keyboard/tm2-touchkey.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index cbd75cf..97acd65 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -666,6 +666,17 @@ config KEYBOARD_TC3589X To compile this driver as a module, choose M here: the module will be called tc3589x-keypad. +config KEYBOARD_TM2_TOUCHKEY + tristate "TM2 touchkey support" + depends on I2C + depends on LEDS_CLASS + help + Say Y here to enable device driver for tm2-touchkey with + LED control for the Exynos5433 TM2 board. + + To compile this driver as a module, choose M here. + module will be called tm2-touchkey. + config KEYBOARD_TWL4030 tristate "TI TWL4030/TWL5030/TPS659x0 keypad support" depends on TWL4030_CORE diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index d9f4cfc..7d9acff 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -61,6 +61,7 @@ obj-$(CONFIG_KEYBOARD_SUN4I_LRADC) += sun4i-lradc-keys.o obj-$(CONFIG_KEYBOARD_SUNKBD) += sunkbd.o obj-$(CONFIG_KEYBOARD_TC3589X) += tc3589x-keypad.o obj-$(CONFIG_KEYBOARD_TEGRA) += tegra-kbc.o +obj-$(CONFIG_KEYBOARD_TM2_TOUCHKEY) += tm2-touchkey.o obj-$(CONFIG_KEYBOARD_TWL4030) += twl4030_keypad.o obj-$(CONFIG_KEYBOARD_XTKBD) += xtkbd.o obj-$(CONFIG_KEYBOARD_W90P910) += w90p910_keypad.o diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c new file mode 100644 index 0000000..916e2f3 --- /dev/null +++ b/drivers/input/keyboard/tm2-touchkey.c @@ -0,0 +1,286 @@ +/* + * TM2 touchkey device driver + * + * Copyright 2005 Phil Blundell + * Copyright 2016 Samsung Electronics Co., Ltd. + * + * Author: Beomho Seo <beomho.seo@samsung.com> + * Author: Jaechul Lee <jcsing.lee@samsung.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include <linux/bitops.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/i2c.h> +#include <linux/input.h> +#include <linux/interrupt.h> +#include <linux/irq.h> +#include <linux/leds.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/pm.h> +#include <linux/regulator/consumer.h> + +#define TM2_TOUCHKEY_DEV_NAME "tm2-touchkey" +#define TM2_TOUCHKEY_KEYCODE_REG 0x03 +#define TM2_TOUCHKEY_BASE_REG 0x00 +#define TM2_TOUCHKEY_CMD_LED_ON 0x10 +#define TM2_TOUCHKEY_CMD_LED_OFF 0x20 +#define TM2_TOUCHKEY_BIT_PRESS_EV BIT(3) +#define TM2_TOUCHKEY_BIT_KEYCODE GENMASK(2, 0) +#define TM2_TOUCHKEY_LED_VOLTAGE_MIN 2500000 +#define TM2_TOUCHKEY_LED_VOLTAGE_MAX 3300000 + +enum { + TM2_TOUCHKEY_KEY_MENU = 0x1, + TM2_TOUCHKEY_KEY_BACK, +}; + +struct tm2_touchkey_data { + struct i2c_client *client; + struct input_dev *input_dev; + struct led_classdev led_dev; + struct regulator *vdd; + struct regulator_bulk_data regulators[2]; +}; + +static void tm2_touchkey_led_brightness_set(struct led_classdev *led_dev, + enum led_brightness brightness) +{ + struct tm2_touchkey_data *touchkey = + container_of(led_dev, struct tm2_touchkey_data, led_dev); + u32 volt; + u8 data; + + if (brightness == LED_OFF) { + volt = TM2_TOUCHKEY_LED_VOLTAGE_MIN; + data = TM2_TOUCHKEY_CMD_LED_OFF; + } else { + volt = TM2_TOUCHKEY_LED_VOLTAGE_MAX; + data = TM2_TOUCHKEY_CMD_LED_ON; + } + + regulator_set_voltage(touchkey->vdd, volt, volt); + i2c_smbus_write_byte_data(touchkey->client, + TM2_TOUCHKEY_BASE_REG, data); +} + +static int tm2_touchkey_power_enable(struct tm2_touchkey_data *touchkey) +{ + int error; + + error = regulator_bulk_enable(ARRAY_SIZE(touchkey->regulators), + touchkey->regulators); + if (error) + return error; + + /* waiting for device initialization, at least 150ms */ + msleep(150); + + return 0; +} + +static void tm2_touchkey_power_disable(void *data) +{ + struct tm2_touchkey_data *touchkey = data; + + regulator_bulk_disable(ARRAY_SIZE(touchkey->regulators), + touchkey->regulators); +} + +static irqreturn_t tm2_touchkey_irq_handler(int irq, void *devid) +{ + struct tm2_touchkey_data *touchkey = devid; + int data; + int key; + + data = i2c_smbus_read_byte_data(touchkey->client, + TM2_TOUCHKEY_KEYCODE_REG); + if (data < 0) { + dev_err(&touchkey->client->dev, + "failed to read i2c data: %d\n", data); + goto out; + } + + switch (data & TM2_TOUCHKEY_BIT_KEYCODE) { + case TM2_TOUCHKEY_KEY_MENU: + key = KEY_PHONE; + break; + + case TM2_TOUCHKEY_KEY_BACK: + key = KEY_BACK; + break; + + default: + dev_warn(&touchkey->client->dev, + "unhandled keycode, data %#02x\n", data); + goto out; + } + + if (data & TM2_TOUCHKEY_BIT_PRESS_EV) { + input_report_key(touchkey->input_dev, KEY_PHONE, 0); + input_report_key(touchkey->input_dev, KEY_BACK, 0); + } else { + input_report_key(touchkey->input_dev, key, 1); + } + + input_sync(touchkey->input_dev); + +out: + return IRQ_HANDLED; +} + +static int tm2_touchkey_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct tm2_touchkey_data *touchkey; + int error; + + if (!i2c_check_functionality(client->adapter, + I2C_FUNC_SMBUS_BYTE | I2C_FUNC_SMBUS_BYTE_DATA)) { + dev_err(&client->dev, "incompatible I2C adapter\n"); + return -EIO; + } + + touchkey = devm_kzalloc(&client->dev, sizeof(*touchkey), GFP_KERNEL); + if (!touchkey) + return -ENOMEM; + + touchkey->client = client; + i2c_set_clientdata(client, touchkey); + + touchkey->regulators[0].supply = "vcc"; + touchkey->regulators[1].supply = "vdd"; + error = devm_regulator_bulk_get(&client->dev, + ARRAY_SIZE(touchkey->regulators), + touchkey->regulators); + if (error) { + dev_err(&client->dev, "failed to get regulators: %d\n", error); + return error; + } + + /* Save VDD for easy access */ + touchkey->vdd = touchkey->regulators[1].consumer; + + error = tm2_touchkey_power_enable(touchkey); + if (error) { + dev_err(&client->dev, "failed to power up device: %d\n", error); + return error; + } + + error = devm_add_action_or_reset(&client->dev, + tm2_touchkey_power_disable, touchkey); + if (error) { + dev_err(&client->dev, + "failed to install poweroff handler: %d\n", error); + return error; + } + + /* input device */ + touchkey->input_dev = devm_input_allocate_device(&client->dev); + if (!touchkey->input_dev) { + dev_err(&client->dev, "failed to allocate input device\n"); + return -ENOMEM; + } + + touchkey->input_dev->name = TM2_TOUCHKEY_DEV_NAME; + touchkey->input_dev->id.bustype = BUS_I2C; + + input_set_capability(touchkey->input_dev, EV_KEY, KEY_PHONE); + input_set_capability(touchkey->input_dev, EV_KEY, KEY_BACK); + + input_set_drvdata(touchkey->input_dev, touchkey); + + error = input_register_device(touchkey->input_dev); + if (error) { + dev_err(&client->dev, + "failed to register input device: %d\n", error); + return error; + } + + error = devm_request_threaded_irq(&client->dev, client->irq, + NULL, tm2_touchkey_irq_handler, + IRQF_ONESHOT, + TM2_TOUCHKEY_DEV_NAME, touchkey); + if (error) { + dev_err(&client->dev, + "failed to request threaded irq: %d\n", error); + return error; + } + + /* led device */ + touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME; + touchkey->led_dev.brightness = LED_FULL; + touchkey->led_dev.max_brightness = LED_FULL; + touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set; + + error = devm_led_classdev_register(&client->dev, &touchkey->led_dev); + if (error) { + dev_err(&client->dev, + "failed to register touchkey led: %d\n", error); + return error; + } + + return 0; +} + +static int __maybe_unused tm2_touchkey_suspend(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct tm2_touchkey_data *touchkey = i2c_get_clientdata(client); + + disable_irq(client->irq); + tm2_touchkey_power_disable(touchkey); + + return 0; +} + +static int __maybe_unused tm2_touchkey_resume(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct tm2_touchkey_data *touchkey = i2c_get_clientdata(client); + int ret; + + enable_irq(client->irq); + + ret = tm2_touchkey_power_enable(touchkey); + if (ret) + dev_err(dev, "failed to enable power: %d\n", ret); + + return ret; +} + +static SIMPLE_DEV_PM_OPS(tm2_touchkey_pm_ops, + tm2_touchkey_suspend, tm2_touchkey_resume); + +static const struct i2c_device_id tm2_touchkey_id_table[] = { + { TM2_TOUCHKEY_DEV_NAME, 0 }, + { }, +}; +MODULE_DEVICE_TABLE(i2c, tm2_touchkey_id_table); + +static const struct of_device_id tm2_touchkey_of_match[] = { + { .compatible = "cypress,tm2-touchkey", }, + { }, +}; +MODULE_DEVICE_TABLE(of, tm2_touchkey_of_match); + +static struct i2c_driver tm2_touchkey_driver = { + .driver = { + .name = TM2_TOUCHKEY_DEV_NAME, + .pm = &tm2_touchkey_pm_ops, + .of_match_table = of_match_ptr(tm2_touchkey_of_match), + }, + .probe = tm2_touchkey_probe, + .id_table = tm2_touchkey_id_table, +}; +module_i2c_driver(tm2_touchkey_driver); + +MODULE_AUTHOR("Beomho Seo <beomho.seo@samsung.com>"); +MODULE_AUTHOR("Jaechul Lee <jcsing.lee@samsung.com>"); +MODULE_DESCRIPTION("Samsung touchkey driver"); +MODULE_LICENSE("GPL v2"); -- 2.7.4 ^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: linux-arm-kernel This patch adds support for the TM2 touch key and led functionality. The driver interfaces with userspace through an input device and reports KEY_PHONE and KEY_BACK event types. LED brightness can be controlled by "/sys/class/leds/tm2-touchkey/brightness". Signed-off-by: Beomho Seo <beomho.seo@samsung.com> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/keyboard/Kconfig | 11 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/tm2-touchkey.c | 286 ++++++++++++++++++++++++++++++++++ 3 files changed, 298 insertions(+) create mode 100644 drivers/input/keyboard/tm2-touchkey.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index cbd75cf..97acd65 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -666,6 +666,17 @@ config KEYBOARD_TC3589X To compile this driver as a module, choose M here: the module will be called tc3589x-keypad. +config KEYBOARD_TM2_TOUCHKEY + tristate "TM2 touchkey support" + depends on I2C + depends on LEDS_CLASS + help + Say Y here to enable device driver for tm2-touchkey with + LED control for the Exynos5433 TM2 board. + + To compile this driver as a module, choose M here. + module will be called tm2-touchkey. + config KEYBOARD_TWL4030 tristate "TI TWL4030/TWL5030/TPS659x0 keypad support" depends on TWL4030_CORE diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index d9f4cfc..7d9acff 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -61,6 +61,7 @@ obj-$(CONFIG_KEYBOARD_SUN4I_LRADC) += sun4i-lradc-keys.o obj-$(CONFIG_KEYBOARD_SUNKBD) += sunkbd.o obj-$(CONFIG_KEYBOARD_TC3589X) += tc3589x-keypad.o obj-$(CONFIG_KEYBOARD_TEGRA) += tegra-kbc.o +obj-$(CONFIG_KEYBOARD_TM2_TOUCHKEY) += tm2-touchkey.o obj-$(CONFIG_KEYBOARD_TWL4030) += twl4030_keypad.o obj-$(CONFIG_KEYBOARD_XTKBD) += xtkbd.o obj-$(CONFIG_KEYBOARD_W90P910) += w90p910_keypad.o diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c new file mode 100644 index 0000000..916e2f3 --- /dev/null +++ b/drivers/input/keyboard/tm2-touchkey.c @@ -0,0 +1,286 @@ +/* + * TM2 touchkey device driver + * + * Copyright 2005 Phil Blundell + * Copyright 2016 Samsung Electronics Co., Ltd. + * + * Author: Beomho Seo <beomho.seo@samsung.com> + * Author: Jaechul Lee <jcsing.lee@samsung.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include <linux/bitops.h> +#include <linux/delay.h> +#include <linux/device.h> +#include <linux/i2c.h> +#include <linux/input.h> +#include <linux/interrupt.h> +#include <linux/irq.h> +#include <linux/leds.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/pm.h> +#include <linux/regulator/consumer.h> + +#define TM2_TOUCHKEY_DEV_NAME "tm2-touchkey" +#define TM2_TOUCHKEY_KEYCODE_REG 0x03 +#define TM2_TOUCHKEY_BASE_REG 0x00 +#define TM2_TOUCHKEY_CMD_LED_ON 0x10 +#define TM2_TOUCHKEY_CMD_LED_OFF 0x20 +#define TM2_TOUCHKEY_BIT_PRESS_EV BIT(3) +#define TM2_TOUCHKEY_BIT_KEYCODE GENMASK(2, 0) +#define TM2_TOUCHKEY_LED_VOLTAGE_MIN 2500000 +#define TM2_TOUCHKEY_LED_VOLTAGE_MAX 3300000 + +enum { + TM2_TOUCHKEY_KEY_MENU = 0x1, + TM2_TOUCHKEY_KEY_BACK, +}; + +struct tm2_touchkey_data { + struct i2c_client *client; + struct input_dev *input_dev; + struct led_classdev led_dev; + struct regulator *vdd; + struct regulator_bulk_data regulators[2]; +}; + +static void tm2_touchkey_led_brightness_set(struct led_classdev *led_dev, + enum led_brightness brightness) +{ + struct tm2_touchkey_data *touchkey = + container_of(led_dev, struct tm2_touchkey_data, led_dev); + u32 volt; + u8 data; + + if (brightness == LED_OFF) { + volt = TM2_TOUCHKEY_LED_VOLTAGE_MIN; + data = TM2_TOUCHKEY_CMD_LED_OFF; + } else { + volt = TM2_TOUCHKEY_LED_VOLTAGE_MAX; + data = TM2_TOUCHKEY_CMD_LED_ON; + } + + regulator_set_voltage(touchkey->vdd, volt, volt); + i2c_smbus_write_byte_data(touchkey->client, + TM2_TOUCHKEY_BASE_REG, data); +} + +static int tm2_touchkey_power_enable(struct tm2_touchkey_data *touchkey) +{ + int error; + + error = regulator_bulk_enable(ARRAY_SIZE(touchkey->regulators), + touchkey->regulators); + if (error) + return error; + + /* waiting for device initialization, at least 150ms */ + msleep(150); + + return 0; +} + +static void tm2_touchkey_power_disable(void *data) +{ + struct tm2_touchkey_data *touchkey = data; + + regulator_bulk_disable(ARRAY_SIZE(touchkey->regulators), + touchkey->regulators); +} + +static irqreturn_t tm2_touchkey_irq_handler(int irq, void *devid) +{ + struct tm2_touchkey_data *touchkey = devid; + int data; + int key; + + data = i2c_smbus_read_byte_data(touchkey->client, + TM2_TOUCHKEY_KEYCODE_REG); + if (data < 0) { + dev_err(&touchkey->client->dev, + "failed to read i2c data: %d\n", data); + goto out; + } + + switch (data & TM2_TOUCHKEY_BIT_KEYCODE) { + case TM2_TOUCHKEY_KEY_MENU: + key = KEY_PHONE; + break; + + case TM2_TOUCHKEY_KEY_BACK: + key = KEY_BACK; + break; + + default: + dev_warn(&touchkey->client->dev, + "unhandled keycode, data %#02x\n", data); + goto out; + } + + if (data & TM2_TOUCHKEY_BIT_PRESS_EV) { + input_report_key(touchkey->input_dev, KEY_PHONE, 0); + input_report_key(touchkey->input_dev, KEY_BACK, 0); + } else { + input_report_key(touchkey->input_dev, key, 1); + } + + input_sync(touchkey->input_dev); + +out: + return IRQ_HANDLED; +} + +static int tm2_touchkey_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct tm2_touchkey_data *touchkey; + int error; + + if (!i2c_check_functionality(client->adapter, + I2C_FUNC_SMBUS_BYTE | I2C_FUNC_SMBUS_BYTE_DATA)) { + dev_err(&client->dev, "incompatible I2C adapter\n"); + return -EIO; + } + + touchkey = devm_kzalloc(&client->dev, sizeof(*touchkey), GFP_KERNEL); + if (!touchkey) + return -ENOMEM; + + touchkey->client = client; + i2c_set_clientdata(client, touchkey); + + touchkey->regulators[0].supply = "vcc"; + touchkey->regulators[1].supply = "vdd"; + error = devm_regulator_bulk_get(&client->dev, + ARRAY_SIZE(touchkey->regulators), + touchkey->regulators); + if (error) { + dev_err(&client->dev, "failed to get regulators: %d\n", error); + return error; + } + + /* Save VDD for easy access */ + touchkey->vdd = touchkey->regulators[1].consumer; + + error = tm2_touchkey_power_enable(touchkey); + if (error) { + dev_err(&client->dev, "failed to power up device: %d\n", error); + return error; + } + + error = devm_add_action_or_reset(&client->dev, + tm2_touchkey_power_disable, touchkey); + if (error) { + dev_err(&client->dev, + "failed to install poweroff handler: %d\n", error); + return error; + } + + /* input device */ + touchkey->input_dev = devm_input_allocate_device(&client->dev); + if (!touchkey->input_dev) { + dev_err(&client->dev, "failed to allocate input device\n"); + return -ENOMEM; + } + + touchkey->input_dev->name = TM2_TOUCHKEY_DEV_NAME; + touchkey->input_dev->id.bustype = BUS_I2C; + + input_set_capability(touchkey->input_dev, EV_KEY, KEY_PHONE); + input_set_capability(touchkey->input_dev, EV_KEY, KEY_BACK); + + input_set_drvdata(touchkey->input_dev, touchkey); + + error = input_register_device(touchkey->input_dev); + if (error) { + dev_err(&client->dev, + "failed to register input device: %d\n", error); + return error; + } + + error = devm_request_threaded_irq(&client->dev, client->irq, + NULL, tm2_touchkey_irq_handler, + IRQF_ONESHOT, + TM2_TOUCHKEY_DEV_NAME, touchkey); + if (error) { + dev_err(&client->dev, + "failed to request threaded irq: %d\n", error); + return error; + } + + /* led device */ + touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME; + touchkey->led_dev.brightness = LED_FULL; + touchkey->led_dev.max_brightness = LED_FULL; + touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set; + + error = devm_led_classdev_register(&client->dev, &touchkey->led_dev); + if (error) { + dev_err(&client->dev, + "failed to register touchkey led: %d\n", error); + return error; + } + + return 0; +} + +static int __maybe_unused tm2_touchkey_suspend(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct tm2_touchkey_data *touchkey = i2c_get_clientdata(client); + + disable_irq(client->irq); + tm2_touchkey_power_disable(touchkey); + + return 0; +} + +static int __maybe_unused tm2_touchkey_resume(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct tm2_touchkey_data *touchkey = i2c_get_clientdata(client); + int ret; + + enable_irq(client->irq); + + ret = tm2_touchkey_power_enable(touchkey); + if (ret) + dev_err(dev, "failed to enable power: %d\n", ret); + + return ret; +} + +static SIMPLE_DEV_PM_OPS(tm2_touchkey_pm_ops, + tm2_touchkey_suspend, tm2_touchkey_resume); + +static const struct i2c_device_id tm2_touchkey_id_table[] = { + { TM2_TOUCHKEY_DEV_NAME, 0 }, + { }, +}; +MODULE_DEVICE_TABLE(i2c, tm2_touchkey_id_table); + +static const struct of_device_id tm2_touchkey_of_match[] = { + { .compatible = "cypress,tm2-touchkey", }, + { }, +}; +MODULE_DEVICE_TABLE(of, tm2_touchkey_of_match); + +static struct i2c_driver tm2_touchkey_driver = { + .driver = { + .name = TM2_TOUCHKEY_DEV_NAME, + .pm = &tm2_touchkey_pm_ops, + .of_match_table = of_match_ptr(tm2_touchkey_of_match), + }, + .probe = tm2_touchkey_probe, + .id_table = tm2_touchkey_id_table, +}; +module_i2c_driver(tm2_touchkey_driver); + +MODULE_AUTHOR("Beomho Seo <beomho.seo@samsung.com>"); +MODULE_AUTHOR("Jaechul Lee <jcsing.lee@samsung.com>"); +MODULE_DESCRIPTION("Samsung touchkey driver"); +MODULE_LICENSE("GPL v2"); -- 2.7.4 ^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 2017-01-17 5:54 ` Jaechul Lee (?) @ 2017-01-17 17:20 ` Krzysztof Kozlowski -1 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-17 17:20 UTC (permalink / raw) To: Jaechul Lee Cc: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Andi Shyti, Chanwoo Choi, beomho.seo, galaxyra, linux-arm-kernel, linux-input, devicetree, linux-kernel, linux-samsung-soc On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > This patch adds support for the TM2 touch key and led > functionality. > > The driver interfaces with userspace through an input device and > reports KEY_PHONE and KEY_BACK event types. LED brightness can be > controlled by "/sys/class/leds/tm2-touchkey/brightness". > > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> This looks unusual. How did Dmitry's Sob end here? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-17 17:20 ` Krzysztof Kozlowski 0 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-17 17:20 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > This patch adds support for the TM2 touch key and led > functionality. > > The driver interfaces with userspace through an input device and > reports KEY_PHONE and KEY_BACK event types. LED brightness can be > controlled by "/sys/class/leds/tm2-touchkey/brightness". > > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> This looks unusual. How did Dmitry's Sob end here? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-17 17:20 ` Krzysztof Kozlowski 0 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-17 17:20 UTC (permalink / raw) To: Jaechul Lee Cc: Mark Rutland, devicetree, linux-samsung-soc, Andi Shyti, Chanwoo Choi, Catalin Marinas, Dmitry Torokhov, Will Deacon, linux-kernel, Rob Herring, Javier Martinez Canillas, Kukjin Kim, Krzysztof Kozlowski, linux-input, galaxyra, beomho.seo, linux-arm-kernel On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > This patch adds support for the TM2 touch key and led > functionality. > > The driver interfaces with userspace through an input device and > reports KEY_PHONE and KEY_BACK event types. LED brightness can be > controlled by "/sys/class/leds/tm2-touchkey/brightness". > > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> This looks unusual. How did Dmitry's Sob end here? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 2017-01-17 17:20 ` Krzysztof Kozlowski (?) @ 2017-01-17 18:06 ` Dmitry Torokhov -1 siblings, 0 replies; 29+ messages in thread From: Dmitry Torokhov @ 2017-01-17 18:06 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Jaechul Lee, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Javier Martinez Canillas, Andi Shyti, Chanwoo Choi, Beomho Seo, 이재철, linux-arm-kernel, linux-input, devicetree, lkml, linux-samsung-soc On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: >> This patch adds support for the TM2 touch key and led >> functionality. >> >> The driver interfaces with userspace through an input device and >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be >> controlled by "/sys/class/leds/tm2-touchkey/brightness". >> >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > This looks unusual. How did Dmitry's Sob end here? I sent Jaechul a version of the patch to try out. -- Dmitry ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-17 18:06 ` Dmitry Torokhov 0 siblings, 0 replies; 29+ messages in thread From: Dmitry Torokhov @ 2017-01-17 18:06 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: >> This patch adds support for the TM2 touch key and led >> functionality. >> >> The driver interfaces with userspace through an input device and >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be >> controlled by "/sys/class/leds/tm2-touchkey/brightness". >> >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > This looks unusual. How did Dmitry's Sob end here? I sent Jaechul a version of the patch to try out. -- Dmitry ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-17 18:06 ` Dmitry Torokhov 0 siblings, 0 replies; 29+ messages in thread From: Dmitry Torokhov @ 2017-01-17 18:06 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Mark Rutland, devicetree, linux-samsung-soc, Chanwoo Choi, Catalin Marinas, Jaechul Lee, Will Deacon, lkml, Rob Herring, Javier Martinez Canillas, Kukjin Kim, Andi Shyti, linux-input, 이재철, Beomho Seo, linux-arm-kernel On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: >> This patch adds support for the TM2 touch key and led >> functionality. >> >> The driver interfaces with userspace through an input device and >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be >> controlled by "/sys/class/leds/tm2-touchkey/brightness". >> >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > This looks unusual. How did Dmitry's Sob end here? I sent Jaechul a version of the patch to try out. -- Dmitry ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 2017-01-17 18:06 ` Dmitry Torokhov (?) @ 2017-01-17 18:10 ` Krzysztof Kozlowski -1 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-17 18:10 UTC (permalink / raw) To: Dmitry Torokhov Cc: Krzysztof Kozlowski, Jaechul Lee, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Javier Martinez Canillas, Andi Shyti, Chanwoo Choi, Beomho Seo, 이재철, linux-arm-kernel, linux-input, devicetree, lkml, linux-samsung-soc On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > >> This patch adds support for the TM2 touch key and led > >> functionality. > >> > >> The driver interfaces with userspace through an input device and > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > >> > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > This looks unusual. How did Dmitry's Sob end here? > > I sent Jaechul a version of the patch to try out. Ah, makes sense then. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-17 18:10 ` Krzysztof Kozlowski 0 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-17 18:10 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > >> This patch adds support for the TM2 touch key and led > >> functionality. > >> > >> The driver interfaces with userspace through an input device and > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > >> > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > This looks unusual. How did Dmitry's Sob end here? > > I sent Jaechul a version of the patch to try out. Ah, makes sense then. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-17 18:10 ` Krzysztof Kozlowski 0 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-17 18:10 UTC (permalink / raw) To: Dmitry Torokhov Cc: Mark Rutland, devicetree, linux-samsung-soc, Andi Shyti, Chanwoo Choi, Catalin Marinas, Jaechul Lee, Will Deacon, lkml, Krzysztof Kozlowski, Javier Martinez Canillas, Rob Herring, Kukjin Kim, linux-input, 이재철, Beomho Seo, linux-arm-kernel On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > >> This patch adds support for the TM2 touch key and led > >> functionality. > >> > >> The driver interfaces with userspace through an input device and > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > >> > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > This looks unusual. How did Dmitry's Sob end here? > > I sent Jaechul a version of the patch to try out. Ah, makes sense then. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 2017-01-17 18:10 ` Krzysztof Kozlowski (?) @ 2017-01-18 22:47 ` Dmitry Torokhov -1 siblings, 0 replies; 29+ messages in thread From: Dmitry Torokhov @ 2017-01-18 22:47 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Jaechul Lee, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Javier Martinez Canillas, Andi Shyti, Chanwoo Choi, Beomho Seo, 이재철, linux-arm-kernel, linux-input, devicetree, lkml, linux-samsung-soc On Tue, Jan 17, 2017 at 08:10:56PM +0200, Krzysztof Kozlowski wrote: > On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > > >> This patch adds support for the TM2 touch key and led > > >> functionality. > > >> > > >> The driver interfaces with userspace through an input device and > > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > > >> > > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > > >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > > >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > > >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > > This looks unusual. How did Dmitry's Sob end here? > > > > I sent Jaechul a version of the patch to try out. > > Ah, makes sense then. I picked up (and folded) the binding doc and driver patches, DTS should go through some other tree I believe. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-18 22:47 ` Dmitry Torokhov 0 siblings, 0 replies; 29+ messages in thread From: Dmitry Torokhov @ 2017-01-18 22:47 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 17, 2017 at 08:10:56PM +0200, Krzysztof Kozlowski wrote: > On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > > >> This patch adds support for the TM2 touch key and led > > >> functionality. > > >> > > >> The driver interfaces with userspace through an input device and > > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > > >> > > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > > >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > > >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > > >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > > This looks unusual. How did Dmitry's Sob end here? > > > > I sent Jaechul a version of the patch to try out. > > Ah, makes sense then. I picked up (and folded) the binding doc and driver patches, DTS should go through some other tree I believe. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-18 22:47 ` Dmitry Torokhov 0 siblings, 0 replies; 29+ messages in thread From: Dmitry Torokhov @ 2017-01-18 22:47 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Mark Rutland, devicetree, linux-samsung-soc, Chanwoo Choi, Catalin Marinas, Jaechul Lee, Will Deacon, lkml, Rob Herring, Javier Martinez Canillas, Kukjin Kim, Andi Shyti, linux-input, 이재철, Beomho Seo, linux-arm-kernel On Tue, Jan 17, 2017 at 08:10:56PM +0200, Krzysztof Kozlowski wrote: > On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > > >> This patch adds support for the TM2 touch key and led > > >> functionality. > > >> > > >> The driver interfaces with userspace through an input device and > > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > > >> > > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > > >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > > >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > > >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > > This looks unusual. How did Dmitry's Sob end here? > > > > I sent Jaechul a version of the patch to try out. > > Ah, makes sense then. I picked up (and folded) the binding doc and driver patches, DTS should go through some other tree I believe. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 2017-01-18 22:47 ` Dmitry Torokhov @ 2017-01-19 7:17 ` Krzysztof Kozlowski -1 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-19 7:17 UTC (permalink / raw) To: Dmitry Torokhov Cc: Jaechul Lee, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Javier Martinez Canillas, Andi Shyti, Chanwoo Choi, Beomho Seo, 이재철, linux-arm-kernel, linux-input, devicetree, lkml, linux-samsung-soc On Thu, Jan 19, 2017 at 12:47 AM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Tue, Jan 17, 2017 at 08:10:56PM +0200, Krzysztof Kozlowski wrote: >> On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: >> > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: >> > >> This patch adds support for the TM2 touch key and led >> > >> functionality. >> > >> >> > >> The driver interfaces with userspace through an input device and >> > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be >> > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". >> > >> >> > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> >> > >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> >> > >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> > >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> >> > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >> > >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> > >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> >> > > >> > > This looks unusual. How did Dmitry's Sob end here? >> > >> > I sent Jaechul a version of the patch to try out. >> >> Ah, makes sense then. > > I picked up (and folded) the binding doc and driver patches, DTS should > go through some other tree I believe. Yes, I will take it. I waited for driver and bindings to be accepted. Thanks, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 @ 2017-01-19 7:17 ` Krzysztof Kozlowski 0 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-19 7:17 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 19, 2017 at 12:47 AM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Tue, Jan 17, 2017 at 08:10:56PM +0200, Krzysztof Kozlowski wrote: >> On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: >> > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: >> > >> This patch adds support for the TM2 touch key and led >> > >> functionality. >> > >> >> > >> The driver interfaces with userspace through an input device and >> > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be >> > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". >> > >> >> > >> Signed-off-by: Beomho Seo <beomho.seo@samsung.com> >> > >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> >> > >> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> > >> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> >> > >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >> > >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> > >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> >> > > >> > > This looks unusual. How did Dmitry's Sob end here? >> > >> > I sent Jaechul a version of the patch to try out. >> >> Ah, makes sense then. > > I picked up (and folded) the binding doc and driver patches, DTS should > go through some other tree I believe. Yes, I will take it. I waited for driver and bindings to be accepted. Thanks, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
[parent not found: <CGME20170117055444epcas1p430376a7c03940ded299e374367170b03@epcas1p4.samsung.com>]
* [PATCH v7 3/3] arm64: dts: exynos: Add tm2 touchkey node [not found] ` <CGME20170117055444epcas1p430376a7c03940ded299e374367170b03@epcas1p4.samsung.com> @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas Cc: Jaechul Lee, Andi Shyti, Chanwoo Choi, beomho.seo, galaxyra, linux-arm-kernel, linux-input, devicetree, linux-kernel, linux-samsung-soc Add DT node support for TM2 touchkey device. Signed-off-by: Beomho Seo <beomho.seo@samsung.com> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> Signed-off-by: Andi Shyti <andi.shyti@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 2449266..ddba2f8 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -18,6 +18,19 @@ compatible = "samsung,tm2", "samsung,exynos5433"; }; +&hsi2c_9 { + status = "okay"; + + touchkey@20 { + compatible = "cypress,tm2-touchkey"; + reg = <0x20>; + interrupt-parent = <&gpa3>; + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + vcc-supply = <&ldo32_reg>; + vdd-supply = <&ldo33_reg>; + }; +}; + &ldo31_reg { regulator-name = "TSP_VDD_1.85V_AP"; regulator-min-microvolt = <1850000>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v7 3/3] arm64: dts: exynos: Add tm2 touchkey node @ 2017-01-17 5:54 ` Jaechul Lee 0 siblings, 0 replies; 29+ messages in thread From: Jaechul Lee @ 2017-01-17 5:54 UTC (permalink / raw) To: linux-arm-kernel Add DT node support for TM2 touchkey device. Signed-off-by: Beomho Seo <beomho.seo@samsung.com> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> Signed-off-by: Andi Shyti <andi.shyti@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 2449266..ddba2f8 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -18,6 +18,19 @@ compatible = "samsung,tm2", "samsung,exynos5433"; }; +&hsi2c_9 { + status = "okay"; + + touchkey at 20 { + compatible = "cypress,tm2-touchkey"; + reg = <0x20>; + interrupt-parent = <&gpa3>; + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + vcc-supply = <&ldo32_reg>; + vdd-supply = <&ldo33_reg>; + }; +}; + &ldo31_reg { regulator-name = "TSP_VDD_1.85V_AP"; regulator-min-microvolt = <1850000>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v7 3/3] arm64: dts: exynos: Add tm2 touchkey node 2017-01-17 5:54 ` Jaechul Lee @ 2017-01-17 6:12 ` Chanwoo Choi -1 siblings, 0 replies; 29+ messages in thread From: Chanwoo Choi @ 2017-01-17 6:12 UTC (permalink / raw) To: Jaechul Lee, Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas Cc: Andi Shyti, beomho.seo, galaxyra, linux-arm-kernel, linux-input, devicetree, linux-kernel, linux-samsung-soc Hi, I tested this patch on v6[1] and replied it. But, this version is missing the my tested-by and reviewed-by tag. [1] https://patchwork.kernel.org/patch/9504139/ So, I add my reviewed-by and tested-by tag again. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> On 2017년 01월 17일 14:54, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 2449266..ddba2f8 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -18,6 +18,19 @@ > compatible = "samsung,tm2", "samsung,exynos5433"; > }; > > +&hsi2c_9 { > + status = "okay"; > + > + touchkey@20 { > + compatible = "cypress,tm2-touchkey"; > + reg = <0x20>; > + interrupt-parent = <&gpa3>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + vcc-supply = <&ldo32_reg>; > + vdd-supply = <&ldo33_reg>; > + }; > +}; > + > &ldo31_reg { > regulator-name = "TSP_VDD_1.85V_AP"; > regulator-min-microvolt = <1850000>; > -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 3/3] arm64: dts: exynos: Add tm2 touchkey node @ 2017-01-17 6:12 ` Chanwoo Choi 0 siblings, 0 replies; 29+ messages in thread From: Chanwoo Choi @ 2017-01-17 6:12 UTC (permalink / raw) To: linux-arm-kernel Hi, I tested this patch on v6[1] and replied it. But, this version is missing the my tested-by and reviewed-by tag. [1] https://patchwork.kernel.org/patch/9504139/ So, I add my reviewed-by and tested-by tag again. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> On 2017? 01? 17? 14:54, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 2449266..ddba2f8 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -18,6 +18,19 @@ > compatible = "samsung,tm2", "samsung,exynos5433"; > }; > > +&hsi2c_9 { > + status = "okay"; > + > + touchkey at 20 { > + compatible = "cypress,tm2-touchkey"; > + reg = <0x20>; > + interrupt-parent = <&gpa3>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + vcc-supply = <&ldo32_reg>; > + vdd-supply = <&ldo33_reg>; > + }; > +}; > + > &ldo31_reg { > regulator-name = "TSP_VDD_1.85V_AP"; > regulator-min-microvolt = <1850000>; > -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 3/3] arm64: dts: exynos: Add tm2 touchkey node @ 2017-01-19 20:10 ` Krzysztof Kozlowski 0 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-19 20:10 UTC (permalink / raw) To: Jaechul Lee Cc: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Andi Shyti, Chanwoo Choi, beomho.seo, galaxyra, linux-arm-kernel, linux-input, devicetree, linux-kernel, linux-samsung-soc On Tue, Jan 17, 2017 at 02:54:39PM +0900, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7 3/3] arm64: dts: exynos: Add tm2 touchkey node @ 2017-01-19 20:10 ` Krzysztof Kozlowski 0 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-19 20:10 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 17, 2017 at 02:54:39PM +0900, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7 3/3] arm64: dts: exynos: Add tm2 touchkey node @ 2017-01-19 20:10 ` Krzysztof Kozlowski 0 siblings, 0 replies; 29+ messages in thread From: Krzysztof Kozlowski @ 2017-01-19 20:10 UTC (permalink / raw) To: Jaechul Lee Cc: Dmitry Torokhov, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Andi Shyti, Chanwoo Choi, beomho.seo-Sze3O3UU22JBDgjK7y7TUQ, galaxyra-Re5JQEeQqe8AvxtiuMwx3w, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-input-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA On Tue, Jan 17, 2017 at 02:54:39PM +0900, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Beomho Seo <beomho.seo-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Signed-off-by: Jaechul Lee <jcsing.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Signed-off-by: Andi Shyti <andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) Thanks, applied. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2017-01-19 20:19 UTC | newest] Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CGME20170117055443epcas1p40b08d361f8f95090ad7b4d855a5bfad4@epcas1p4.samsung.com> 2017-01-17 5:54 ` [PATCH v7 0/3] Add touch key driver support for TM2 Jaechul Lee 2017-01-17 5:54 ` Jaechul Lee 2017-01-17 5:54 ` Jaechul Lee [not found] ` <CGME20170117055444epcas1p4942aeca8896c9b81512d383cbbca4dbf@epcas1p4.samsung.com> 2017-01-17 5:54 ` [PATCH v7 1/3] input: Add support for the tm2 touchkey device driver Jaechul Lee 2017-01-17 5:54 ` Jaechul Lee 2017-01-17 5:54 ` Jaechul Lee [not found] ` <CGME20170117055444epcas1p47b0b0a0ae3260b22fa61d2b92362050b@epcas1p4.samsung.com> 2017-01-17 5:54 ` [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 Jaechul Lee 2017-01-17 5:54 ` Jaechul Lee 2017-01-17 17:20 ` Krzysztof Kozlowski 2017-01-17 17:20 ` Krzysztof Kozlowski 2017-01-17 17:20 ` Krzysztof Kozlowski 2017-01-17 18:06 ` Dmitry Torokhov 2017-01-17 18:06 ` Dmitry Torokhov 2017-01-17 18:06 ` Dmitry Torokhov 2017-01-17 18:10 ` Krzysztof Kozlowski 2017-01-17 18:10 ` Krzysztof Kozlowski 2017-01-17 18:10 ` Krzysztof Kozlowski 2017-01-18 22:47 ` Dmitry Torokhov 2017-01-18 22:47 ` Dmitry Torokhov 2017-01-18 22:47 ` Dmitry Torokhov 2017-01-19 7:17 ` Krzysztof Kozlowski 2017-01-19 7:17 ` Krzysztof Kozlowski [not found] ` <CGME20170117055444epcas1p430376a7c03940ded299e374367170b03@epcas1p4.samsung.com> 2017-01-17 5:54 ` [PATCH v7 3/3] arm64: dts: exynos: Add tm2 touchkey node Jaechul Lee 2017-01-17 5:54 ` Jaechul Lee 2017-01-17 6:12 ` Chanwoo Choi 2017-01-17 6:12 ` Chanwoo Choi 2017-01-19 20:10 ` Krzysztof Kozlowski 2017-01-19 20:10 ` Krzysztof Kozlowski 2017-01-19 20:10 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.