From: Dario Faggioli <dario.faggioli@citrix.com>
To: Yi Sun <yi.y.sun@linux.intel.com>, xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, konrad.wilk@oracle.com,
andrew.cooper3@citrix.com, he.chen@linux.intel.com,
ian.jackson@eu.citrix.com, mengxu@cis.upenn.edu,
jbeulich@suse.com, chao.p.peng@linux.intel.com
Subject: Re: [PATCH v5 21/24] tools: L2 CAT: support get HW info for L2 CAT.
Date: Wed, 18 Jan 2017 09:33:48 +0100 [thread overview]
Message-ID: <1484728428.7492.45.camel@citrix.com> (raw)
In-Reply-To: <1484704967-5609-22-git-send-email-yi.y.sun@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1442 bytes --]
On Wed, 2017-01-18 at 10:02 +0800, Yi Sun wrote:
> This patch implements xl/xc changes to support get HW info
> for L2 CAT.
>
> 'xl psr-hwinfo' is updated to show both L3 CAT and L2 CAT
> info.
>
> Example(on machine which only supports L2 CAT):
> Cache Monitoring Technology (CMT):
> Enabled : 0
> Cache Allocation Technology (CAT): L3
> libxl: error: libxl_psr.c:100:libxl__psr_cat_log_err_msg: CAT is not
> enabled on the socket: No such file or directory
> Failed to get l3 cat info
> Cache Allocation Technology (CAT): L2
> Socket ID : 0
> Maximum COS : 3
> CBM length : 8
> Default CBM : 0xff
>
I think we settled, in v4, for not having this awkward error message
showing itself in this way "only" because of (legitimate!) lack of
hardware support for some of the features?
https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg00604.html
https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg00792.html
https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg00797.html
Nevertheless, I've had a look at the code, and it looks good to me.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-18 8:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 2:02 [PATCH v5 00/24] Enable L2 Cache Allocation Technology & Refactor psr.c Yi Sun
2017-01-18 2:02 ` [PATCH v5 01/24] docs: create L2 Cache Allocation Technology (CAT) feature document Yi Sun
2017-01-18 9:11 ` Dario Faggioli
2017-01-18 9:37 ` Yi Sun
2017-01-19 6:11 ` Yi Sun
2017-01-18 2:02 ` [PATCH v5 02/24] x86: refactor psr: remove L3 CAT/CDP codes Yi Sun
2017-01-18 2:02 ` [PATCH v5 03/24] x86: refactor psr: implement main data structures Yi Sun
2017-01-18 2:02 ` [PATCH v5 04/24] x86: refactor psr: implement CPU init and free flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 05/24] x86: refactor psr: implement Domain init/free and schedule flows Yi Sun
2017-01-18 2:02 ` [PATCH v5 06/24] x86: refactor psr: implement get hw info flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 07/24] x86: refactor psr: implement get value flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 08/24] x86: refactor psr: set value: implement framework Yi Sun
2017-01-18 2:02 ` [PATCH v5 09/24] x86: refactor psr: set value: assemble features value array Yi Sun
2017-01-18 2:02 ` [PATCH v5 10/24] x86: refactor psr: set value: implement cos finding flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 11/24] x86: refactor psr: set value: implement cos id picking flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 12/24] x86: refactor psr: set value: implement write msr flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 13/24] x86: refactor psr: implement CPU init and free flow for CDP Yi Sun
2017-01-18 2:02 ` [PATCH v5 14/24] x86: refactor psr: implement get hw info " Yi Sun
2017-01-18 2:02 ` [PATCH v5 15/24] x86: refactor psr: implement get value " Yi Sun
2017-01-18 2:02 ` [PATCH v5 16/24] x86: refactor psr: implement set value callback functions " Yi Sun
2017-01-18 2:02 ` [PATCH v5 17/24] x86: L2 CAT: implement CPU init and free flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 18/24] x86: L2 CAT: implement get hw info flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 19/24] x86: L2 CAT: implement get value flow Yi Sun
2017-01-18 2:02 ` [PATCH v5 20/24] x86: L2 CAT: implement set " Yi Sun
2017-01-18 2:02 ` [PATCH v5 21/24] tools: L2 CAT: support get HW info for L2 CAT Yi Sun
2017-01-18 8:33 ` Dario Faggioli [this message]
2017-01-18 2:02 ` [PATCH v5 22/24] tools: L2 CAT: support show cbm " Yi Sun
2017-01-18 2:02 ` [PATCH v5 23/24] tools: L2 CAT: support set " Yi Sun
2017-01-18 8:51 ` Dario Faggioli
2017-01-18 2:02 ` [PATCH v5 24/24] docs: add L2 CAT description in docs Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484728428.7492.45.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=he.chen@linux.intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.