All of lore.kernel.org
 help / color / mirror / Atom feed
From: CK Hu <ck.hu@mediatek.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: David Airlie <airlied@linux.ie>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	Cawa Cheng <cawa.cheng@mediatek.com>,
	Daniel Kurtz <djkurtz@chromium.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	YT Shen <yt.shen@mediatek.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	Mao Huang <littlecvr@chromium.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	"Sascha Hauer" <kernel@pengutronix.de>
Subject: Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
Date: Tue, 24 Jan 2017 14:12:45 +0800	[thread overview]
Message-ID: <1485238365.30572.5.camel@mtksdaap41> (raw)
In-Reply-To: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com>

Hi, Bibby:

On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
> 
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>

Acked-by: CK Hu <ck.hu@mediatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
>  			return MODE_BAD;
>  	}
>  
> +	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> +		return MODE_NO_INTERLACE;
>  	if (mode->clock < 27000)
>  		return MODE_CLOCK_LOW;
>  	if (mode->clock > 297000)

WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: linux-kernel@vger.kernel.org,
	Sascha Hauer <kernel@pengutronix.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Cawa Cheng <cawa.cheng@mediatek.com>,
	dri-devel@lists.freedesktop.org,
	Mao Huang <littlecvr@chromium.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
Date: Tue, 24 Jan 2017 14:12:45 +0800	[thread overview]
Message-ID: <1485238365.30572.5.camel@mtksdaap41> (raw)
In-Reply-To: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com>

Hi, Bibby:

On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
> 
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>

Acked-by: CK Hu <ck.hu@mediatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
>  			return MODE_BAD;
>  	}
>  
> +	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> +		return MODE_NO_INTERLACE;
>  	if (mode->clock < 27000)
>  		return MODE_CLOCK_LOW;
>  	if (mode->clock > 297000)


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions
Date: Tue, 24 Jan 2017 14:12:45 +0800	[thread overview]
Message-ID: <1485238365.30572.5.camel@mtksdaap41> (raw)
In-Reply-To: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com>

Hi, Bibby:

On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote:
> Current Mediatek DRM driver does not support interlaced mode, and
> will hang if such resolution is used: Filter those to prevent
> kernel hangs, until the DRM driver is fixed properly.
> 
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>

Acked-by: CK Hu <ck.hu@mediatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0e8c4d9..e33678d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn,
>  			return MODE_BAD;
>  	}
>  
> +	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
> +		return MODE_NO_INTERLACE;
>  	if (mode->clock < 27000)
>  		return MODE_CLOCK_LOW;
>  	if (mode->clock > 297000)

  reply	other threads:[~2017-01-24  6:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24  5:10 [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions Bibby Hsieh
2017-01-24  5:10 ` Bibby Hsieh
2017-01-24  5:10 ` Bibby Hsieh
2017-01-24  6:12 ` CK Hu [this message]
2017-01-24  6:12   ` CK Hu
2017-01-24  6:12   ` CK Hu
2017-05-23  9:28 ` CK Hu
2017-05-23  9:28   ` CK Hu
2017-05-23  9:28   ` CK Hu
2017-05-23 13:12   ` Daniel Vetter
2017-05-23 13:12     ` Daniel Vetter
2017-05-23 13:12     ` Daniel Vetter
2017-05-24  9:20     ` CK Hu
2017-05-24  9:20       ` CK Hu
2017-05-24  9:20       ` CK Hu
2017-05-24 12:24       ` Daniel Vetter
2017-05-24 12:24         ` Daniel Vetter
2017-05-24 12:24         ` Daniel Vetter
2017-05-25  3:38         ` CK Hu
2017-05-25  3:38           ` CK Hu
2017-05-25  3:38           ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485238365.30572.5.camel@mtksdaap41 \
    --to=ck.hu@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=bibby.hsieh@mediatek.com \
    --cc=cawa.cheng@mediatek.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=djkurtz@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=littlecvr@chromium.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=yingjoe.chen@mediatek.com \
    --cc=yt.shen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.