[meta-oe][PATCH] luajit: test SITEINFO_BITS instead of maintaining a list of 32bit targets

[meta-oe][PATCH] luajit: test SITEINFO_BITS instead of maintaining a list of 32bit targets

[Andre McCurdy]

When cross compiling, the word size of the compiler set via HOST_CC
must match the word size of the target. That's achieved by appending
"-m32" to BUILD_CC_ARCH if the target word size is known to be 32bits.

Unfortunately the current list of over-rides (powerpc, x86 and arm)
does not cover all cases (e.g. it ignores MIPS). Using SITEINFO_BITS
is a more generic solution.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
index 964dc1d..430279f 100644
--- a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
+++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
@@ -11,7 +11,7 @@ SRC_URI[sha256sum] = "620fa4eb12375021bef6e4f237cbd2dd5d49e56beb414bee052c746bee
 
 S = "${WORKDIR}/LuaJIT-${PV}"
 
-inherit pkgconfig binconfig
+inherit pkgconfig binconfig siteinfo
 
 BBCLASSEXTEND = "native"
 
@@ -21,9 +21,7 @@ BBCLASSEXTEND = "native"
 # you need to install the multilib development package (e.g.
 # libc6-dev-i386 on Debian/Ubuntu) and build a 32 bit host part
 # (HOST_CC="gcc -m32").
-BUILD_CC_ARCH_append_powerpc = ' -m32'
-BUILD_CC_ARCH_append_x86 = ' -m32'
-BUILD_CC_ARCH_append_arm = ' -m32'
+BUILD_CC_ARCH_append = " ${@['-m32',''][d.getVar('SITEINFO_BITS') != '32']}"
 
 # The lua makefiles expect the TARGET_SYS to be from uname -s
 # Values: Windows, Linux, Darwin, iOS, SunOS, PS3, GNU/kFreeBSD
-- 
1.9.1

Re: [meta-oe][PATCH] luajit: test SITEINFO_BITS instead of maintaining a list of 32bit targets

[Khem Raj]

On 1/25/17 1:43 PM, Andre McCurdy wrote:
> When cross compiling, the word size of the compiler set via HOST_CC
> must match the word size of the target. That's achieved by appending
> "-m32" to BUILD_CC_ARCH if the target word size is known to be 32bits.
> 
> Unfortunately the current list of over-rides (powerpc, x86 and arm)
> does not cover all cases (e.g. it ignores MIPS). Using SITEINFO_BITS
> is a more generic solution.
> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
> index 964dc1d..430279f 100644
> --- a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
> +++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
> @@ -11,7 +11,7 @@ SRC_URI[sha256sum] = "620fa4eb12375021bef6e4f237cbd2dd5d49e56beb414bee052c746bee
>  
>  S = "${WORKDIR}/LuaJIT-${PV}"
>  
> -inherit pkgconfig binconfig
> +inherit pkgconfig binconfig siteinfo
>  
>  BBCLASSEXTEND = "native"
>  
> @@ -21,9 +21,7 @@ BBCLASSEXTEND = "native"
>  # you need to install the multilib development package (e.g.
>  # libc6-dev-i386 on Debian/Ubuntu) and build a 32 bit host part
>  # (HOST_CC="gcc -m32").
> -BUILD_CC_ARCH_append_powerpc = ' -m32'
> -BUILD_CC_ARCH_append_x86 = ' -m32'
> -BUILD_CC_ARCH_append_arm = ' -m32'
> +BUILD_CC_ARCH_append = " ${@['-m32',''][d.getVar('SITEINFO_BITS') != '32']}"
>  

not related but
This makes me think about another issue, will it work on non-x86 build
machines, currently we do have aarch64 based boxes

>  # The lua makefiles expect the TARGET_SYS to be from uname -s
>  # Values: Windows, Linux, Darwin, iOS, SunOS, PS3, GNU/kFreeBSD
> 

Re: [meta-oe][PATCH] luajit: test SITEINFO_BITS instead of maintaining a list of 32bit targets

[Andre McCurdy]

On Thu, Jan 26, 2017 at 2:41 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On 1/25/17 1:43 PM, Andre McCurdy wrote:
>> When cross compiling, the word size of the compiler set via HOST_CC
>> must match the word size of the target. That's achieved by appending
>> "-m32" to BUILD_CC_ARCH if the target word size is known to be 32bits.
>>
>> Unfortunately the current list of over-rides (powerpc, x86 and arm)
>> does not cover all cases (e.g. it ignores MIPS). Using SITEINFO_BITS
>> is a more generic solution.
>>
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> index 964dc1d..430279f 100644
>> --- a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> +++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> @@ -11,7 +11,7 @@ SRC_URI[sha256sum] = "620fa4eb12375021bef6e4f237cbd2dd5d49e56beb414bee052c746bee
>>
>>  S = "${WORKDIR}/LuaJIT-${PV}"
>>
>> -inherit pkgconfig binconfig
>> +inherit pkgconfig binconfig siteinfo
>>
>>  BBCLASSEXTEND = "native"
>>
>> @@ -21,9 +21,7 @@ BBCLASSEXTEND = "native"
>>  # you need to install the multilib development package (e.g.
>>  # libc6-dev-i386 on Debian/Ubuntu) and build a 32 bit host part
>>  # (HOST_CC="gcc -m32").
>> -BUILD_CC_ARCH_append_powerpc = ' -m32'
>> -BUILD_CC_ARCH_append_x86 = ' -m32'
>> -BUILD_CC_ARCH_append_arm = ' -m32'
>> +BUILD_CC_ARCH_append = " ${@['-m32',''][d.getVar('SITEINFO_BITS') != '32']}"
>
> not related but
> This makes me think about another issue, will it work on non-x86 build
> machines, currently we do have aarch64 based boxes

Right (unless aarch64 host toolchains accept "-m32"?)

Building on 32bit x86 is probably broken too.

>>  # The lua makefiles expect the TARGET_SYS to be from uname -s
>>  # Values: Windows, Linux, Darwin, iOS, SunOS, PS3, GNU/kFreeBSD
>>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][PATCH] luajit: test SITEINFO_BITS instead of maintaining a list of 32bit targets

[Andre McCurdy]

On Wed, Jan 25, 2017 at 1:43 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> When cross compiling, the word size of the compiler set via HOST_CC
> must match the word size of the target. That's achieved by appending
> "-m32" to BUILD_CC_ARCH if the target word size is known to be 32bits.
>
> Unfortunately the current list of over-rides (powerpc, x86 and arm)
> does not cover all cases (e.g. it ignores MIPS). Using SITEINFO_BITS
> is a more generic solution.

Ping.

> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
> index 964dc1d..430279f 100644
> --- a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
> +++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
> @@ -11,7 +11,7 @@ SRC_URI[sha256sum] = "620fa4eb12375021bef6e4f237cbd2dd5d49e56beb414bee052c746bee
>
>  S = "${WORKDIR}/LuaJIT-${PV}"
>
> -inherit pkgconfig binconfig
> +inherit pkgconfig binconfig siteinfo
>
>  BBCLASSEXTEND = "native"
>
> @@ -21,9 +21,7 @@ BBCLASSEXTEND = "native"
>  # you need to install the multilib development package (e.g.
>  # libc6-dev-i386 on Debian/Ubuntu) and build a 32 bit host part
>  # (HOST_CC="gcc -m32").
> -BUILD_CC_ARCH_append_powerpc = ' -m32'
> -BUILD_CC_ARCH_append_x86 = ' -m32'
> -BUILD_CC_ARCH_append_arm = ' -m32'
> +BUILD_CC_ARCH_append = " ${@['-m32',''][d.getVar('SITEINFO_BITS') != '32']}"
>
>  # The lua makefiles expect the TARGET_SYS to be from uname -s
>  # Values: Windows, Linux, Darwin, iOS, SunOS, PS3, GNU/kFreeBSD
> --
> 1.9.1
>

Re: [meta-oe][PATCH] luajit: test SITEINFO_BITS instead of maintaining a list of 32bit targets

[Andre McCurdy]

On Mon, Mar 13, 2017 at 12:24 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Wed, Jan 25, 2017 at 1:43 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> When cross compiling, the word size of the compiler set via HOST_CC
>> must match the word size of the target. That's achieved by appending
>> "-m32" to BUILD_CC_ARCH if the target word size is known to be 32bits.
>>
>> Unfortunately the current list of over-rides (powerpc, x86 and arm)
>> does not cover all cases (e.g. it ignores MIPS). Using SITEINFO_BITS
>> is a more generic solution.
>
> Ping.

Actually this patch needs to be rebased since the earlier (incomplete)
fix was merged. Sending a v2.

>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> index 964dc1d..430279f 100644
>> --- a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> +++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> @@ -11,7 +11,7 @@ SRC_URI[sha256sum] = "620fa4eb12375021bef6e4f237cbd2dd5d49e56beb414bee052c746bee
>>
>>  S = "${WORKDIR}/LuaJIT-${PV}"
>>
>> -inherit pkgconfig binconfig
>> +inherit pkgconfig binconfig siteinfo
>>
>>  BBCLASSEXTEND = "native"
>>
>> @@ -21,9 +21,7 @@ BBCLASSEXTEND = "native"
>>  # you need to install the multilib development package (e.g.
>>  # libc6-dev-i386 on Debian/Ubuntu) and build a 32 bit host part
>>  # (HOST_CC="gcc -m32").
>> -BUILD_CC_ARCH_append_powerpc = ' -m32'
>> -BUILD_CC_ARCH_append_x86 = ' -m32'
>> -BUILD_CC_ARCH_append_arm = ' -m32'
>> +BUILD_CC_ARCH_append = " ${@['-m32',''][d.getVar('SITEINFO_BITS') != '32']}"
>>
>>  # The lua makefiles expect the TARGET_SYS to be from uname -s
>>  # Values: Windows, Linux, Darwin, iOS, SunOS, PS3, GNU/kFreeBSD
>> --
>> 1.9.1
>>