* [PATCH v2] somedriver: remove the initialization of static pointers.
@ 2017-02-07 21:55 ` AbdAllah-MEZITI
0 siblings, 0 replies; 4+ messages in thread
From: AbdAllah-MEZITI @ 2017-02-07 21:55 UTC (permalink / raw)
To: gregkh
Cc: Stephen Warren, Lee Jones, Eric Anholt, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list, Michael Zoran,
devel, linux-rpi-kernel, linux-arm-kernel, linux-kernel
In C a static pointer will be initialized to NULL.
The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
If an object that has static storage duration is not initialized
explicitly, then:
__ if it has pointer type, it is initialized to a null pointer.
Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
v2: -fix the line-wrapping of the changelog.
-fix the ref. documentation: C99 standards release,
and not the draft.
-this patch is the Task 10 Eudyptula Challenge
that only fix one code style problem.
---
drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74d..265fe55 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/bcm2835-audio/bcm2835.c
@@ -28,8 +28,8 @@
* to debug if we run into issues
*/
-static struct snd_card *g_card = NULL;
-static struct bcm2835_chip *g_chip = NULL;
+static struct snd_card *g_card;
+static struct bcm2835_chip *g_chip;
static int snd_bcm2835_free(struct bcm2835_chip *chip)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] somedriver: remove the initialization of static pointers.
@ 2017-02-07 21:55 ` AbdAllah-MEZITI
0 siblings, 0 replies; 4+ messages in thread
From: AbdAllah-MEZITI @ 2017-02-07 21:55 UTC (permalink / raw)
To: linux-arm-kernel
In C a static pointer will be initialized to NULL.
The ?6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
If an object that has static storage duration is not initialized
explicitly, then:
__ if it has pointer type, it is initialized to a null pointer.
Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
v2: -fix the line-wrapping of the changelog.
-fix the ref. documentation: C99 standards release,
and not the draft.
-this patch is the Task 10 Eudyptula Challenge
that only fix one code style problem.
---
drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74d..265fe55 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/bcm2835-audio/bcm2835.c
@@ -28,8 +28,8 @@
* to debug if we run into issues
*/
-static struct snd_card *g_card = NULL;
-static struct bcm2835_chip *g_chip = NULL;
+static struct snd_card *g_card;
+static struct bcm2835_chip *g_chip;
static int snd_bcm2835_free(struct bcm2835_chip *chip)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] somedriver: remove the initialization of static pointers.
2017-02-07 21:55 ` AbdAllah-MEZITI
@ 2017-02-07 23:09 ` Florian Fainelli
-1 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2017-02-07 23:09 UTC (permalink / raw)
To: AbdAllah-MEZITI, gregkh
Cc: Stephen Warren, Lee Jones, Eric Anholt, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michael Zoran, devel, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
On 02/07/2017 01:55 PM, AbdAllah-MEZITI wrote:
> In C a static pointer will be initialized to NULL.
> The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
> If an object that has static storage duration is not initialized
> explicitly, then:
> __ if it has pointer type, it is initialized to a null pointer.
The commit subject should be based on previous submissions, if you do a
git log --oneline drivers/staging/bcm2835-audio/bcm2835.c you will see
that the most frequent subject used was:
Staging: bcm2835-audio:
So you should utilize the same subject prefix, and make your prefix be
something like:
Staging: bcm2835-audio: Remove the initialization of static pointers
>
> Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
>
> v2: -fix the line-wrapping of the changelog.
> -fix the ref. documentation: C99 standards release,
> and not the draft.
> -this patch is the Task 10 Eudyptula Challenge
> that only fix one code style problem.
> ---
> drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
> index a84d74d..265fe55 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835.c
> @@ -28,8 +28,8 @@
> * to debug if we run into issues
> */
>
> -static struct snd_card *g_card = NULL;
> -static struct bcm2835_chip *g_chip = NULL;
> +static struct snd_card *g_card;
> +static struct bcm2835_chip *g_chip;
>
> static int snd_bcm2835_free(struct bcm2835_chip *chip)
> {
>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] somedriver: remove the initialization of static pointers.
@ 2017-02-07 23:09 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2017-02-07 23:09 UTC (permalink / raw)
To: linux-arm-kernel
On 02/07/2017 01:55 PM, AbdAllah-MEZITI wrote:
> In C a static pointer will be initialized to NULL.
> The ?6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
> If an object that has static storage duration is not initialized
> explicitly, then:
> __ if it has pointer type, it is initialized to a null pointer.
The commit subject should be based on previous submissions, if you do a
git log --oneline drivers/staging/bcm2835-audio/bcm2835.c you will see
that the most frequent subject used was:
Staging: bcm2835-audio:
So you should utilize the same subject prefix, and make your prefix be
something like:
Staging: bcm2835-audio: Remove the initialization of static pointers
>
> Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
>
> v2: -fix the line-wrapping of the changelog.
> -fix the ref. documentation: C99 standards release,
> and not the draft.
> -this patch is the Task 10 Eudyptula Challenge
> that only fix one code style problem.
> ---
> drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
> index a84d74d..265fe55 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835.c
> @@ -28,8 +28,8 @@
> * to debug if we run into issues
> */
>
> -static struct snd_card *g_card = NULL;
> -static struct bcm2835_chip *g_chip = NULL;
> +static struct snd_card *g_card;
> +static struct bcm2835_chip *g_chip;
>
> static int snd_bcm2835_free(struct bcm2835_chip *chip)
> {
>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-07 23:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-07 21:55 [PATCH v2] somedriver: remove the initialization of static pointers AbdAllah-MEZITI
2017-02-07 21:55 ` AbdAllah-MEZITI
2017-02-07 23:09 ` Florian Fainelli
2017-02-07 23:09 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.