* [PATCH] staging: wlan-ng: add blank line after declaration
@ 2017-02-16 10:12 Gargi Sharma
2017-02-16 10:19 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 5+ messages in thread
From: Gargi Sharma @ 2017-02-16 10:12 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
add blank line after struct declaration to fix the checkpatch issue, add
blank line after declarations.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 5f1851c..f199847 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
enum ctlx_state state; /* Tracks running state */
struct completion done;
+
volatile int reapable; /* Food for the reaper task */
ctlx_cmdcb_t cmdcb; /* Async command callback */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: wlan-ng: add blank line after declaration
2017-02-16 10:12 [PATCH] staging: wlan-ng: add blank line after declaration Gargi Sharma
@ 2017-02-16 10:19 ` Julia Lawall
2017-02-16 10:59 ` Gargi Sharma
0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2017-02-16 10:19 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, gregkh
On Thu, 16 Feb 2017, Gargi Sharma wrote:
> add blank line after struct declaration to fix the checkpatch issue, add
> blank line after declarations.
This does not look right. The code before and the code after are all
declarations. I think that checkpatch is misinterpreting the code. This
warning is normally targeted at local variables in functions.
The code is fine as is.
julia
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c..f199847 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> enum ctlx_state state; /* Tracks running state */
>
> struct completion done;
> +
> volatile int reapable; /* Food for the reaper task */
>
> ctlx_cmdcb_t cmdcb; /* Async command callback */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1487239937-26115-1-git-send-email-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: wlan-ng: add blank line after declaration
2017-02-16 10:19 ` [Outreachy kernel] " Julia Lawall
@ 2017-02-16 10:59 ` Gargi Sharma
0 siblings, 0 replies; 5+ messages in thread
From: Gargi Sharma @ 2017-02-16 10:59 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel, Greg KH
[-- Attachment #1: Type: text/plain, Size: 1748 bytes --]
On Thu, Feb 16, 2017 at 3:49 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>
> On Thu, 16 Feb 2017, Gargi Sharma wrote:
>
> > add blank line after struct declaration to fix the checkpatch issue, add
> > blank line after declarations.
>
> This does not look right. The code before and the code after are all
> declarations. I think that checkpatch is misinterpreting the code. This
Okay, will revert this commit.
Thanks,
Gargi
> warning is normally targeted at local variables in functions.
>
> The code is fine as is.
>
> julia
>
> > Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> > ---
> > drivers/staging/wlan-ng/hfa384x.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
> > index 5f1851c..f199847 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> > enum ctlx_state state; /* Tracks running state */
> >
> > struct completion done;
> > +
> > volatile int reapable; /* Food for the reaper task */
> >
> > ctlx_cmdcb_t cmdcb; /* Async command callback */
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/
msgid/outreachy-kernel/1487239937-26115-1-git-send-
email-gs051095%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
[-- Attachment #2: Type: text/html, Size: 2738 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: wlan-ng: add blank line after declaration
2017-02-16 16:56 Gargi Sharma
@ 2017-02-16 17:13 ` Gargi Sharma
0 siblings, 0 replies; 5+ messages in thread
From: Gargi Sharma @ 2017-02-16 17:13 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg KH, Gargi Sharma
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Thu, Feb 16, 2017 at 10:26 PM, Gargi Sharma <gs051095@gmail.com> wrote:
>
> add blank line after struct declaration to fix the checkpatch issue, add
> blank line after declarations.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c..f199847 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> enum ctlx_state state; /* Tracks running state */
>
> struct completion done;
> +
> volatile int reapable; /* Food for the reaper task */
>
> ctlx_cmdcb_t cmdcb; /* Async command callback */
> --
> 2.7.4
>
Please ignore. Sent by mistake.
Thanks,
Gargi
[-- Attachment #2: Type: text/html, Size: 1218 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: wlan-ng: add blank line after declaration
@ 2017-02-16 16:56 Gargi Sharma
2017-02-16 17:13 ` Gargi Sharma
0 siblings, 1 reply; 5+ messages in thread
From: Gargi Sharma @ 2017-02-16 16:56 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
add blank line after struct declaration to fix the checkpatch issue, add
blank line after declarations.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 5f1851c..f199847 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
enum ctlx_state state; /* Tracks running state */
struct completion done;
+
volatile int reapable; /* Food for the reaper task */
ctlx_cmdcb_t cmdcb; /* Async command callback */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-16 17:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-16 10:12 [PATCH] staging: wlan-ng: add blank line after declaration Gargi Sharma
2017-02-16 10:19 ` [Outreachy kernel] " Julia Lawall
2017-02-16 10:59 ` Gargi Sharma
2017-02-16 16:56 Gargi Sharma
2017-02-16 17:13 ` Gargi Sharma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.