All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>,
	Rob Herring <robh@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
	linux-watchdog@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-kernel@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
	Guenter Roeck <linux@roeck-us.net>,
	Sascha Hauer <kernel@pengutronix.de>,
	Kumar Gala <galak@codeaurora.org>,
	kernel@savoirfairelinux.com, Lee Jones <lee.jones@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v7 2/6] mfd: syscon: add a DT property to set value width
Date: Fri, 04 Dec 2015 17:02:53 +0100	[thread overview]
Message-ID: <1488444.chqN1XL3OQ@wuerfel> (raw)
In-Reply-To: <20151202232102.GB6055@localhost>

On Wednesday 02 December 2015 18:21:02 Damien Riegel wrote:
> Lee, Arnd,
> 
> I had to make changes in this patch to address Rob's comments.
> reg-io-width is now in bytes while bus-width was a value in bits. Could
> you please review this patch ?


Ok, that's fine.

> 
> On Mon, Nov 30, 2015 at 01:00:15PM -0600, Rob Herring wrote:
> > On Mon, Nov 30, 2015 at 10:59:47AM -0500, Damien Riegel wrote:
> > > Currently syscon has a fixed configuration of 32 bits for register and
> > > values widths. In some cases, it would be desirable to be able to
> > > customize the value width.
> > > 
> > > For example, certain boards (like the ones manufactured by Technologic
> > > Systems) have a FPGA that is memory-mapped, but its registers are only
> > > 16-bit wide.
> > > 
> > > This patch adds an optional "reg-io-width" DT binding for syscon that
> > > allows to change the width for the data bus (i.e. val_bits). If this
> > > property is provided, it will also set the register stride to
> > > reg-io-width's value. If not provided, the default configuration is
> > > used.
> > > 
> > > Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > 
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 2/6] mfd: syscon: add a DT property to set value width
Date: Fri, 04 Dec 2015 17:02:53 +0100	[thread overview]
Message-ID: <1488444.chqN1XL3OQ@wuerfel> (raw)
In-Reply-To: <20151202232102.GB6055@localhost>

On Wednesday 02 December 2015 18:21:02 Damien Riegel wrote:
> Lee, Arnd,
> 
> I had to make changes in this patch to address Rob's comments.
> reg-io-width is now in bytes while bus-width was a value in bits. Could
> you please review this patch ?


Ok, that's fine.

> 
> On Mon, Nov 30, 2015 at 01:00:15PM -0600, Rob Herring wrote:
> > On Mon, Nov 30, 2015 at 10:59:47AM -0500, Damien Riegel wrote:
> > > Currently syscon has a fixed configuration of 32 bits for register and
> > > values widths. In some cases, it would be desirable to be able to
> > > customize the value width.
> > > 
> > > For example, certain boards (like the ones manufactured by Technologic
> > > Systems) have a FPGA that is memory-mapped, but its registers are only
> > > 16-bit wide.
> > > 
> > > This patch adds an optional "reg-io-width" DT binding for syscon that
> > > allows to change the width for the data bus (i.e. val_bits). If this
> > > property is provided, it will also set the register stride to
> > > reg-io-width's value. If not provided, the default configuration is
> > > used.
> > > 
> > > Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > 
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

  reply	other threads:[~2015-12-04 16:04 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 15:59 [PATCH v7 0/6] Add board support for TS-4800 Damien Riegel
2015-11-30 15:59 ` Damien Riegel
2015-11-30 15:59 ` Damien Riegel
2015-11-30 15:59 ` [PATCH v7 1/6] of: add vendor prefix for Technologic Systems Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 15:59 ` [PATCH v7 2/6] mfd: syscon: add a DT property to set value width Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 19:00   ` Rob Herring
2015-11-30 19:00     ` Rob Herring
2015-11-30 19:00     ` Rob Herring
2015-12-02 23:21     ` Damien Riegel
2015-12-02 23:21       ` Damien Riegel
2015-12-04 16:02       ` Arnd Bergmann [this message]
2015-12-04 16:02         ` Arnd Bergmann
2015-12-07  9:40   ` Lee Jones
2015-12-07  9:40     ` Lee Jones
2015-12-07  9:40     ` Lee Jones
2015-12-07 19:42     ` Damien Riegel
2015-12-07 19:42       ` Damien Riegel
2015-12-07 19:42       ` Damien Riegel
2015-12-07 19:42       ` Damien Riegel
2015-12-08 10:02       ` Arnd Bergmann
2015-12-08 10:02         ` Arnd Bergmann
2015-12-08 10:02         ` Arnd Bergmann
2015-12-08 13:50       ` Lee Jones
2015-12-08 13:50         ` Lee Jones
2015-12-08 13:50         ` Lee Jones
2015-12-08 13:50         ` Lee Jones
2015-12-08 14:18         ` Lee Jones
2015-12-08 14:18           ` Lee Jones
2015-12-08 14:18           ` Lee Jones
2015-11-30 15:59 ` [PATCH v7 3/6] watchdog: ts4800: add driver for TS-4800 watchdog Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 16:14   ` Guenter Roeck
2015-11-30 16:14     ` Guenter Roeck
2015-12-04 18:49     ` Damien Riegel
2015-12-04 18:49       ` Damien Riegel
2015-12-04 18:49       ` Damien Riegel
2015-11-30 19:01   ` Rob Herring
2015-11-30 19:01     ` Rob Herring
2015-11-30 19:01     ` Rob Herring
2015-11-30 15:59 ` [PATCH v7 4/6] ARM: imx_v6_v7_defconfig: add " Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 15:59 ` [PATCH v7 5/6] of: documentation: add bindings documentation for TS-4800 Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 15:59 ` [PATCH v7 6/6] ARM: dts: TS-4800: add basic device tree Damien Riegel
2015-11-30 15:59   ` Damien Riegel
2015-11-30 15:59   ` Damien Riegel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488444.chqN1XL3OQ@wuerfel \
    --to=arnd@arndb.de \
    --cc=damien.riegel@savoirfairelinux.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pengutronix.de \
    --cc=kernel@savoirfairelinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=shawnguo@kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.