From: "Jérôme Glisse" <jglisse@redhat.com> To: akpm@linux-foundation.org, <linux-kernel@vger.kernel.org>, linux-mm@kvack.org Cc: "John Hubbard" <jhubbard@nvidia.com>, "Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>, "David Nellans" <dnellans@nvidia.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Dan Williams" <dan.j.williams@intel.com>, "Ross Zwisler" <ross.zwisler@linux.intel.com> Subject: [HMM 02/16] mm/put_page: move ref decrement to put_zone_device_page() Date: Thu, 16 Mar 2017 12:05:21 -0400 [thread overview] Message-ID: <1489680335-6594-3-git-send-email-jglisse@redhat.com> (raw) In-Reply-To: <1489680335-6594-1-git-send-email-jglisse@redhat.com> This does not affect non ZONE_DEVICE page. In order to allow ZONE_DEVICE page to be tracked we need to detect when refcount of a ZONE_DEVICE page reach 1 (not 0 as non ZONE_DEVICE page). This patch just move put_page_testzero() from put_page() to put_zone_device_page() and only for ZONE_DEVICE. It does not add any overhead compare to existing code. Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> --- include/linux/mm.h | 8 +++++--- kernel/memremap.c | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 5f01c88..28e8b28 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -793,11 +793,13 @@ static inline void put_page(struct page *page) { page = compound_head(page); + if (unlikely(is_zone_device_page(page))) { + put_zone_device_page(page); + return; + } + if (put_page_testzero(page)) __put_page(page); - - if (unlikely(is_zone_device_page(page))) - put_zone_device_page(page); } #if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP) diff --git a/kernel/memremap.c b/kernel/memremap.c index 40d4af8..c821946 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -190,6 +190,8 @@ EXPORT_SYMBOL(get_zone_device_page); void put_zone_device_page(struct page *page) { + page_ref_dec(page); + put_dev_pagemap(page->pgmap); } EXPORT_SYMBOL(put_zone_device_page); -- 2.4.11
WARNING: multiple messages have this Message-ID (diff)
From: "Jérôme Glisse" <jglisse@redhat.com> To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "John Hubbard" <jhubbard@nvidia.com>, "Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>, "David Nellans" <dnellans@nvidia.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Dan Williams" <dan.j.williams@intel.com>, "Ross Zwisler" <ross.zwisler@linux.intel.com> Subject: [HMM 02/16] mm/put_page: move ref decrement to put_zone_device_page() Date: Thu, 16 Mar 2017 12:05:21 -0400 [thread overview] Message-ID: <1489680335-6594-3-git-send-email-jglisse@redhat.com> (raw) In-Reply-To: <1489680335-6594-1-git-send-email-jglisse@redhat.com> This does not affect non ZONE_DEVICE page. In order to allow ZONE_DEVICE page to be tracked we need to detect when refcount of a ZONE_DEVICE page reach 1 (not 0 as non ZONE_DEVICE page). This patch just move put_page_testzero() from put_page() to put_zone_device_page() and only for ZONE_DEVICE. It does not add any overhead compare to existing code. Signed-off-by: JA(C)rA'me Glisse <jglisse@redhat.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> --- include/linux/mm.h | 8 +++++--- kernel/memremap.c | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 5f01c88..28e8b28 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -793,11 +793,13 @@ static inline void put_page(struct page *page) { page = compound_head(page); + if (unlikely(is_zone_device_page(page))) { + put_zone_device_page(page); + return; + } + if (put_page_testzero(page)) __put_page(page); - - if (unlikely(is_zone_device_page(page))) - put_zone_device_page(page); } #if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP) diff --git a/kernel/memremap.c b/kernel/memremap.c index 40d4af8..c821946 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -190,6 +190,8 @@ EXPORT_SYMBOL(get_zone_device_page); void put_zone_device_page(struct page *page) { + page_ref_dec(page); + put_dev_pagemap(page->pgmap); } EXPORT_SYMBOL(put_zone_device_page); -- 2.4.11 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-16 15:21 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-16 16:05 [HMM 00/16] HMM (Heterogeneous Memory Management) v18 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 01/16] mm/memory/hotplug: convert device bool to int to allow for more flags v3 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:08 ` Mel Gorman 2017-03-19 20:08 ` Mel Gorman 2017-03-16 16:05 ` Jérôme Glisse [this message] 2017-03-16 16:05 ` [HMM 02/16] mm/put_page: move ref decrement to put_zone_device_page() Jérôme Glisse 2017-03-19 20:08 ` Mel Gorman 2017-03-19 20:08 ` Mel Gorman 2017-03-16 16:05 ` [HMM 03/16] mm/ZONE_DEVICE/free-page: callback when page is freed v3 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:08 ` Mel Gorman 2017-03-19 20:08 ` Mel Gorman 2017-03-16 16:05 ` [HMM 04/16] mm/ZONE_DEVICE/unaddressable: add support for un-addressable device memory v3 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 05/16] mm/ZONE_DEVICE/x86: add support for un-addressable device memory Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 06/16] mm/migrate: add new boolean copy flag to migratepage() callback Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:24 ` Reza Arbab 2017-03-16 16:24 ` Reza Arbab 2017-03-16 20:58 ` Balbir Singh 2017-03-16 20:58 ` Balbir Singh 2017-03-16 23:05 ` Andrew Morton 2017-03-16 23:05 ` Andrew Morton 2017-03-17 0:22 ` John Hubbard 2017-03-17 0:22 ` John Hubbard 2017-03-17 0:45 ` Balbir Singh 2017-03-17 0:45 ` Balbir Singh 2017-03-17 0:57 ` John Hubbard 2017-03-17 0:57 ` John Hubbard 2017-03-17 1:52 ` Jerome Glisse 2017-03-17 1:52 ` Jerome Glisse 2017-03-17 3:32 ` Andrew Morton 2017-03-17 3:32 ` Andrew Morton 2017-03-17 3:42 ` Balbir Singh 2017-03-17 3:42 ` Balbir Singh 2017-03-17 4:51 ` Balbir Singh 2017-03-17 4:51 ` Balbir Singh 2017-03-17 7:17 ` John Hubbard 2017-03-17 7:17 ` John Hubbard 2017-03-16 16:05 ` [HMM 08/16] mm/migrate: migrate_vma() unmap page from vma while collecting pages Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 09/16] mm/hmm: heterogeneous memory management (HMM for short) Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 10/16] mm/hmm/mirror: mirror process address space on device with HMM helpers Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 11/16] mm/hmm/mirror: helper to snapshot CPU page table v2 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 12/16] mm/hmm/mirror: device page fault handler Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 13/16] mm/hmm/migrate: support un-addressable ZONE_DEVICE page in migration Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 14/16] mm/migrate: allow migrate_vma() to alloc new page on empty entry Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 15/16] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 16/16] mm/hmm/devmem: dummy HMM device for ZONE_DEVICE memory v2 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-17 6:55 ` Bob Liu 2017-03-17 6:55 ` Bob Liu 2017-03-17 16:53 ` Jerome Glisse 2017-03-17 16:53 ` Jerome Glisse 2017-03-16 20:43 ` [HMM 00/16] HMM (Heterogeneous Memory Management) v18 Andrew Morton 2017-03-16 20:43 ` Andrew Morton 2017-03-16 23:49 ` Jerome Glisse 2017-03-16 23:49 ` Jerome Glisse 2017-03-17 8:29 ` Bob Liu 2017-03-17 8:29 ` Bob Liu 2017-03-17 15:57 ` Jerome Glisse 2017-03-17 15:57 ` Jerome Glisse 2017-03-17 8:39 ` Bob Liu 2017-03-17 8:39 ` Bob Liu 2017-03-17 15:52 ` Jerome Glisse 2017-03-17 15:52 ` Jerome Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1489680335-6594-3-git-send-email-jglisse@redhat.com \ --to=jglisse@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=dan.j.williams@intel.com \ --cc=dnellans@nvidia.com \ --cc=jhubbard@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=ross.zwisler@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.