From: Mel Gorman <mgorman@techsingularity.net>
To: J?r?me Glisse <jglisse@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, John Hubbard <jhubbard@nvidia.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Nellans <dnellans@nvidia.com>,
Russell King <linux@armlinux.org.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Chris Metcalf <cmetcalf@mellanox.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [HMM 01/16] mm/memory/hotplug: convert device bool to int to allow for more flags v3
Date: Sun, 19 Mar 2017 20:08:21 +0000 [thread overview]
Message-ID: <20170319200821.GB2774@techsingularity.net> (raw)
In-Reply-To: <1489680335-6594-2-git-send-email-jglisse@redhat.com>
On Thu, Mar 16, 2017 at 12:05:20PM -0400, J?r?me Glisse wrote:
> When hotpluging memory we want more informations on the type of memory and
> its properties. Replace the device boolean flag by an int and define a set
> of flags.
>
> New property for device memory is an opt-in flag to allow page migration
> from and to a ZONE_DEVICE. Existing user of ZONE_DEVICE are not expecting
> page migration to work for their pages. New changes to page migration i
> changing that and we now need a flag to explicitly opt-in page migration.
>
> Changes since v2:
> - pr_err() in case of hotplug failure
>
> Changes since v1:
> - Improved commit message
> - Improved define name
> - Improved comments
> - Typos
>
> Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Fairly minor but it's standard for flags to be unsigned due to
uncertainity about what happens when a signed type is bit shifted.
May not apply to your case but fairly trivial to address.
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: J?r?me Glisse <jglisse@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, John Hubbard <jhubbard@nvidia.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Nellans <dnellans@nvidia.com>,
Russell King <linux@armlinux.org.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Chris Metcalf <cmetcalf@mellanox.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [HMM 01/16] mm/memory/hotplug: convert device bool to int to allow for more flags v3
Date: Sun, 19 Mar 2017 20:08:21 +0000 [thread overview]
Message-ID: <20170319200821.GB2774@techsingularity.net> (raw)
In-Reply-To: <1489680335-6594-2-git-send-email-jglisse@redhat.com>
On Thu, Mar 16, 2017 at 12:05:20PM -0400, J?r?me Glisse wrote:
> When hotpluging memory we want more informations on the type of memory and
> its properties. Replace the device boolean flag by an int and define a set
> of flags.
>
> New property for device memory is an opt-in flag to allow page migration
> from and to a ZONE_DEVICE. Existing user of ZONE_DEVICE are not expecting
> page migration to work for their pages. New changes to page migration i
> changing that and we now need a flag to explicitly opt-in page migration.
>
> Changes since v2:
> - pr_err() in case of hotplug failure
>
> Changes since v1:
> - Improved commit message
> - Improved define name
> - Improved comments
> - Typos
>
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>
Fairly minor but it's standard for flags to be unsigned due to
uncertainity about what happens when a signed type is bit shifted.
May not apply to your case but fairly trivial to address.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-19 20:08 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 16:05 [HMM 00/16] HMM (Heterogeneous Memory Management) v18 Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-16 16:05 ` [HMM 01/16] mm/memory/hotplug: convert device bool to int to allow for more flags v3 Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-19 20:08 ` Mel Gorman [this message]
2017-03-19 20:08 ` Mel Gorman
2017-03-16 16:05 ` [HMM 02/16] mm/put_page: move ref decrement to put_zone_device_page() Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-19 20:08 ` Mel Gorman
2017-03-19 20:08 ` Mel Gorman
2017-03-16 16:05 ` [HMM 03/16] mm/ZONE_DEVICE/free-page: callback when page is freed v3 Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-19 20:08 ` Mel Gorman
2017-03-19 20:08 ` Mel Gorman
2017-03-16 16:05 ` [HMM 04/16] mm/ZONE_DEVICE/unaddressable: add support for un-addressable device memory v3 Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-19 20:09 ` Mel Gorman
2017-03-19 20:09 ` Mel Gorman
2017-03-16 16:05 ` [HMM 05/16] mm/ZONE_DEVICE/x86: add support for un-addressable device memory Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-16 16:05 ` [HMM 06/16] mm/migrate: add new boolean copy flag to migratepage() callback Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-19 20:09 ` Mel Gorman
2017-03-19 20:09 ` Mel Gorman
2017-03-16 16:05 ` [HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4 Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-16 16:24 ` Reza Arbab
2017-03-16 16:24 ` Reza Arbab
2017-03-16 20:58 ` Balbir Singh
2017-03-16 20:58 ` Balbir Singh
2017-03-16 23:05 ` Andrew Morton
2017-03-16 23:05 ` Andrew Morton
2017-03-17 0:22 ` John Hubbard
2017-03-17 0:22 ` John Hubbard
2017-03-17 0:45 ` Balbir Singh
2017-03-17 0:45 ` Balbir Singh
2017-03-17 0:57 ` John Hubbard
2017-03-17 0:57 ` John Hubbard
2017-03-17 1:52 ` Jerome Glisse
2017-03-17 1:52 ` Jerome Glisse
2017-03-17 3:32 ` Andrew Morton
2017-03-17 3:32 ` Andrew Morton
2017-03-17 3:42 ` Balbir Singh
2017-03-17 3:42 ` Balbir Singh
2017-03-17 4:51 ` Balbir Singh
2017-03-17 4:51 ` Balbir Singh
2017-03-17 7:17 ` John Hubbard
2017-03-17 7:17 ` John Hubbard
2017-03-16 16:05 ` [HMM 08/16] mm/migrate: migrate_vma() unmap page from vma while collecting pages Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-16 16:05 ` [HMM 09/16] mm/hmm: heterogeneous memory management (HMM for short) Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-19 20:09 ` Mel Gorman
2017-03-19 20:09 ` Mel Gorman
2017-03-16 16:05 ` [HMM 10/16] mm/hmm/mirror: mirror process address space on device with HMM helpers Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-19 20:09 ` Mel Gorman
2017-03-19 20:09 ` Mel Gorman
2017-03-16 16:05 ` [HMM 11/16] mm/hmm/mirror: helper to snapshot CPU page table v2 Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-19 20:09 ` Mel Gorman
2017-03-19 20:09 ` Mel Gorman
2017-03-16 16:05 ` [HMM 12/16] mm/hmm/mirror: device page fault handler Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-16 16:05 ` [HMM 13/16] mm/hmm/migrate: support un-addressable ZONE_DEVICE page in migration Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-16 16:05 ` [HMM 14/16] mm/migrate: allow migrate_vma() to alloc new page on empty entry Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-16 16:05 ` [HMM 15/16] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-16 16:05 ` [HMM 16/16] mm/hmm/devmem: dummy HMM device for ZONE_DEVICE memory v2 Jérôme Glisse
2017-03-16 16:05 ` Jérôme Glisse
2017-03-17 6:55 ` Bob Liu
2017-03-17 6:55 ` Bob Liu
2017-03-17 16:53 ` Jerome Glisse
2017-03-17 16:53 ` Jerome Glisse
2017-03-16 20:43 ` [HMM 00/16] HMM (Heterogeneous Memory Management) v18 Andrew Morton
2017-03-16 20:43 ` Andrew Morton
2017-03-16 23:49 ` Jerome Glisse
2017-03-16 23:49 ` Jerome Glisse
2017-03-17 8:29 ` Bob Liu
2017-03-17 8:29 ` Bob Liu
2017-03-17 15:57 ` Jerome Glisse
2017-03-17 15:57 ` Jerome Glisse
2017-03-17 8:39 ` Bob Liu
2017-03-17 8:39 ` Bob Liu
2017-03-17 15:52 ` Jerome Glisse
2017-03-17 15:52 ` Jerome Glisse
2017-03-19 20:09 ` Mel Gorman
2017-03-19 20:09 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170319200821.GB2774@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cmetcalf@mellanox.com \
--cc=dalias@libc.org \
--cc=dnellans@nvidia.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.