* [Qemu-devel] [PATCH] ppc_booke: drop useless assignment
@ 2017-03-24 12:55 fred.konrad
2017-03-25 10:58 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-04-22 17:56 ` [Qemu-devel] " Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: fred.konrad @ 2017-03-24 12:55 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: fred.konrad
From: KONRAD Frederic <fred.konrad@greensocs.com>
The tb_env variable is set two lines above. So just drop the double assignment.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
---
hw/ppc/ppc_booke.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c
index 60baffa..23bcf1b 100644
--- a/hw/ppc/ppc_booke.c
+++ b/hw/ppc/ppc_booke.c
@@ -282,7 +282,6 @@ void store_booke_tcr(CPUPPCState *env, target_ulong val)
ppc_tb_t *tb_env = env->tb_env;
booke_timer_t *booke_timer = tb_env->opaque;
- tb_env = env->tb_env;
env->spr[SPR_BOOKE_TCR] = val;
kvmppc_set_tcr(cpu);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] ppc_booke: drop useless assignment
2017-03-24 12:55 [Qemu-devel] [PATCH] ppc_booke: drop useless assignment fred.konrad
@ 2017-03-25 10:58 ` Laurent Vivier
2017-04-22 17:56 ` [Qemu-devel] " Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2017-03-25 10:58 UTC (permalink / raw)
To: fred.konrad, qemu-trivial, qemu-devel
Le 24/03/2017 à 13:55, fred.konrad@greensocs.com a écrit :
> From: KONRAD Frederic <fred.konrad@greensocs.com>
>
> The tb_env variable is set two lines above. So just drop the double assignment.
>
> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
> ---
> hw/ppc/ppc_booke.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c
> index 60baffa..23bcf1b 100644
> --- a/hw/ppc/ppc_booke.c
> +++ b/hw/ppc/ppc_booke.c
> @@ -282,7 +282,6 @@ void store_booke_tcr(CPUPPCState *env, target_ulong val)
> ppc_tb_t *tb_env = env->tb_env;
> booke_timer_t *booke_timer = tb_env->opaque;
>
> - tb_env = env->tb_env;
> env->spr[SPR_BOOKE_TCR] = val;
> kvmppc_set_tcr(cpu);
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] ppc_booke: drop useless assignment
2017-03-24 12:55 [Qemu-devel] [PATCH] ppc_booke: drop useless assignment fred.konrad
2017-03-25 10:58 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2017-04-22 17:56 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2017-04-22 17:56 UTC (permalink / raw)
To: fred.konrad, qemu-trivial, qemu-devel
24.03.2017 15:55, fred.konrad@greensocs.com wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
>
> The tb_env variable is set two lines above. So just drop the double assignment.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-22 17:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-24 12:55 [Qemu-devel] [PATCH] ppc_booke: drop useless assignment fred.konrad
2017-03-25 10:58 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-04-22 17:56 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.