[Qemu-devel] [PATCH] channel-file: fix wrong parameter comments

[Qemu-devel] [PATCH] channel-file: fix wrong parameter comments

[sochin.jiang]

From: "sochin.jiang" <sochin@aliyun.com>

    fix wrong parameter comments in channel-file.h.

Signed-off-by: sochin.jiang <sochin@aliyun.com>
---
 include/io/channel-file.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/io/channel-file.h b/include/io/channel-file.h
index d2462c2..79245f1 100644
--- a/include/io/channel-file.h
+++ b/include/io/channel-file.h
@@ -71,7 +71,7 @@ qio_channel_file_new_fd(int fd);
 
 /**
  * qio_channel_file_new_path:
- * @fd: the file descriptor
+ * @path: the file path
  * @flags: the open flags (O_RDONLY|O_WRONLY|O_RDWR, etc)
  * @mode: the file creation mode if O_WRONLY is set in @flags
  * @errp: pointer to initialized error object
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments

[Marc-André Lureau]

On Fri, Mar 24, 2017 at 7:32 PM sochin.jiang <sochin@aliyun.com> wrote:

> From: "sochin.jiang" <sochin@aliyun.com>
>
>     fix wrong parameter comments in channel-file.h.
>
> Signed-off-by: sochin.jiang <sochin@aliyun.com>
>


Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>



> ---
>  include/io/channel-file.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/io/channel-file.h b/include/io/channel-file.h
> index d2462c2..79245f1 100644
> --- a/include/io/channel-file.h
> +++ b/include/io/channel-file.h
> @@ -71,7 +71,7 @@ qio_channel_file_new_fd(int fd);
>
>  /**
>   * qio_channel_file_new_path:
> - * @fd: the file descriptor
> + * @path: the file path
>   * @flags: the open flags (O_RDONLY|O_WRONLY|O_RDWR, etc)
>   * @mode: the file creation mode if O_WRONLY is set in @flags
>   * @errp: pointer to initialized error object
> --
> 1.8.3.1
>
>
> --
Marc-André Lureau

Re: [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments

[Michael Tokarev]

24.03.2017 17:28, sochin.jiang wrote:
> From: "sochin.jiang" <sochin@aliyun.com>
> 
>     fix wrong parameter comments in channel-file.h.

Applied to -trivial.  Please don't duplicate subject and commit comment,
it's enough to leave commit empty if everything is said in the subject :)

Thanks,

/mjt