From: Leo Yan <leo.yan@linaro.org> To: Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Wei Xu <xuwei5@hisilicon.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Guodong Xu <guodong.xu@linaro.org>, John Stultz <john.stultz@linaro.org>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, mike.leach@linaro.org, Suzuki.Poulose@arm.com, sudeep.holla@arm.com Cc: Suzuki K Poulose <suzuki.poulose@arm.com>, Leo Yan <leo.yan@linaro.org> Subject: [PATCH v5 3/9] coresight: of_get_coresight_platform_data: Add missing of_node_put Date: Sun, 26 Mar 2017 02:23:11 +0800 [thread overview] Message-ID: <1490466197-29163-4-git-send-email-leo.yan@linaro.org> (raw) In-Reply-To: <1490466197-29163-1-git-send-email-leo.yan@linaro.org> From: Suzuki K Poulose <suzuki.poulose@arm.com> The of_get_coresight_platform_data iterates over the possible CPU nodes to find a given cpu phandle. However it does not drop the reference to the node pointer returned by the of_get_coresight_platform_data. This patch also introduces another minor fix is to use of_cpu_device_node_get() to replace of_get_cpu_node(). Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> [Leo: minor tweaks for of_get_coresight_platform_data] Signed-off-by: Leo Yan <leo.yan@linaro.org> --- drivers/hwtracing/coresight/of_coresight.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index 629e031..1a77280 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -108,7 +108,8 @@ struct coresight_platform_data *of_get_coresight_platform_data( struct coresight_platform_data *pdata; struct of_endpoint endpoint, rendpoint; struct device *rdev; - struct device_node *dn; + bool found; + struct device_node *dn, *np; struct device_node *ep = NULL; struct device_node *rparent = NULL; struct device_node *rport = NULL; @@ -175,17 +176,19 @@ struct coresight_platform_data *of_get_coresight_platform_data( } while (ep); } - /* Affinity defaults to CPU0 */ - pdata->cpu = 0; dn = of_parse_phandle(node, "cpu", 0); - for (cpu = 0; dn && cpu < nr_cpu_ids; cpu++) { - if (dn == of_get_cpu_node(cpu, NULL)) { - pdata->cpu = cpu; + for_each_possible_cpu(cpu) { + np = of_cpu_device_node_get(cpu); + found = (dn == np); + of_node_put(np); + if (found) break; - } } of_node_put(dn); + /* Affinity to CPU0 if no cpu nodes are found */ + pdata->cpu = found ? cpu : 0; + return pdata; } EXPORT_SYMBOL_GPL(of_get_coresight_platform_data); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: leo.yan@linaro.org (Leo Yan) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 3/9] coresight: of_get_coresight_platform_data: Add missing of_node_put Date: Sun, 26 Mar 2017 02:23:11 +0800 [thread overview] Message-ID: <1490466197-29163-4-git-send-email-leo.yan@linaro.org> (raw) In-Reply-To: <1490466197-29163-1-git-send-email-leo.yan@linaro.org> From: Suzuki K Poulose <suzuki.poulose@arm.com> The of_get_coresight_platform_data iterates over the possible CPU nodes to find a given cpu phandle. However it does not drop the reference to the node pointer returned by the of_get_coresight_platform_data. This patch also introduces another minor fix is to use of_cpu_device_node_get() to replace of_get_cpu_node(). Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> [Leo: minor tweaks for of_get_coresight_platform_data] Signed-off-by: Leo Yan <leo.yan@linaro.org> --- drivers/hwtracing/coresight/of_coresight.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index 629e031..1a77280 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -108,7 +108,8 @@ struct coresight_platform_data *of_get_coresight_platform_data( struct coresight_platform_data *pdata; struct of_endpoint endpoint, rendpoint; struct device *rdev; - struct device_node *dn; + bool found; + struct device_node *dn, *np; struct device_node *ep = NULL; struct device_node *rparent = NULL; struct device_node *rport = NULL; @@ -175,17 +176,19 @@ struct coresight_platform_data *of_get_coresight_platform_data( } while (ep); } - /* Affinity defaults to CPU0 */ - pdata->cpu = 0; dn = of_parse_phandle(node, "cpu", 0); - for (cpu = 0; dn && cpu < nr_cpu_ids; cpu++) { - if (dn == of_get_cpu_node(cpu, NULL)) { - pdata->cpu = cpu; + for_each_possible_cpu(cpu) { + np = of_cpu_device_node_get(cpu); + found = (dn == np); + of_node_put(np); + if (found) break; - } } of_node_put(dn); + /* Affinity to CPU0 if no cpu nodes are found */ + pdata->cpu = found ? cpu : 0; + return pdata; } EXPORT_SYMBOL_GPL(of_get_coresight_platform_data); -- 2.7.4
next prev parent reply other threads:[~2017-03-25 18:23 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-25 18:23 [PATCH v5 0/9] coresight: enable debug module Leo Yan 2017-03-25 18:23 ` Leo Yan 2017-03-25 18:23 ` [PATCH v5 1/9] coresight: bindings for CPU " Leo Yan 2017-03-25 18:23 ` Leo Yan 2017-03-30 22:49 ` Rob Herring 2017-03-30 22:49 ` Rob Herring 2017-03-31 9:04 ` Suzuki K Poulose 2017-03-31 9:04 ` Suzuki K Poulose 2017-03-31 9:04 ` Suzuki K Poulose 2017-03-25 18:23 ` [PATCH v5 2/9] doc: Add documentation for Coresight CPU debug Leo Yan 2017-03-25 18:23 ` Leo Yan 2017-03-25 18:23 ` Leo Yan [this message] 2017-03-25 18:23 ` [PATCH v5 3/9] coresight: of_get_coresight_platform_data: Add missing of_node_put Leo Yan 2017-03-25 18:23 ` [PATCH v5 4/9] coresight: refactor with function of_coresight_get_cpu Leo Yan 2017-03-25 18:23 ` Leo Yan 2017-03-31 9:05 ` Suzuki K Poulose 2017-03-31 9:05 ` Suzuki K Poulose 2017-03-31 9:05 ` Suzuki K Poulose 2017-03-25 18:23 ` [PATCH v5 6/9] coresight: add support for CPU debug module Leo Yan 2017-03-25 18:23 ` Leo Yan 2017-03-27 16:34 ` Suzuki K Poulose 2017-03-27 16:34 ` Suzuki K Poulose 2017-03-27 16:34 ` Suzuki K Poulose 2017-03-29 3:07 ` Leo Yan 2017-03-29 3:07 ` Leo Yan 2017-03-29 9:07 ` Suzuki K Poulose 2017-03-29 9:07 ` Suzuki K Poulose 2017-03-29 9:07 ` Suzuki K Poulose 2017-03-29 10:27 ` Leo Yan 2017-03-29 10:27 ` Leo Yan 2017-03-29 10:31 ` Suzuki K Poulose 2017-03-29 10:31 ` Suzuki K Poulose [not found] ` <89b6c6c7-0da0-6891-312a-c9221851c20a-5wv7dgnIgG8@public.gmane.org> 2017-03-29 10:37 ` Leo Yan 2017-03-29 10:37 ` Leo Yan 2017-03-29 10:37 ` Leo Yan 2017-03-29 15:50 ` Suzuki K Poulose 2017-03-29 15:50 ` Suzuki K Poulose 2017-03-29 15:50 ` Suzuki K Poulose 2017-03-29 15:17 ` Mike Leach 2017-03-29 15:17 ` Mike Leach 2017-03-29 15:17 ` Mike Leach 2017-03-30 1:18 ` Leo Yan 2017-03-30 1:18 ` Leo Yan 2017-03-30 1:18 ` Leo Yan 2017-03-29 15:41 ` Mathieu Poirier 2017-03-29 15:41 ` Mathieu Poirier 2017-03-29 15:41 ` Mathieu Poirier 2017-03-28 16:50 ` Mathieu Poirier 2017-03-28 16:50 ` Mathieu Poirier 2017-03-29 1:54 ` Leo Yan 2017-03-29 1:54 ` Leo Yan 2017-03-29 14:56 ` Mike Leach 2017-03-29 14:56 ` Mike Leach 2017-03-29 14:56 ` Mike Leach 2017-03-30 1:03 ` Leo Yan 2017-03-30 1:03 ` Leo Yan 2017-03-30 1:03 ` Leo Yan 2017-03-30 9:00 ` Suzuki K Poulose 2017-03-30 9:00 ` Suzuki K Poulose 2017-03-30 9:00 ` Suzuki K Poulose 2017-03-30 13:51 ` Leo Yan 2017-03-30 13:51 ` Leo Yan 2017-03-30 13:51 ` Leo Yan 2017-03-30 15:47 ` Sudeep Holla 2017-03-30 15:47 ` Sudeep Holla 2017-03-30 15:47 ` Sudeep Holla 2017-03-29 16:55 ` Mathieu Poirier 2017-03-29 16:55 ` Mathieu Poirier [not found] ` <20170329165535.GB24889-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-03-30 1:59 ` Leo Yan 2017-03-30 1:59 ` Leo Yan 2017-03-30 1:59 ` Leo Yan 2017-03-30 15:46 ` Mathieu Poirier 2017-03-30 15:46 ` Mathieu Poirier 2017-03-30 15:46 ` Mathieu Poirier 2017-03-30 15:46 ` Mathieu Poirier [not found] ` <CANLsYkwPYSvy2xjf8uuvx1WGWpGdMFy7kF=30VbvgW+jDvnFuw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-03-30 16:04 ` Sudeep Holla 2017-03-30 16:04 ` Sudeep Holla 2017-03-30 16:04 ` Sudeep Holla 2017-03-30 16:04 ` Sudeep Holla [not found] ` <1490466197-29163-7-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-03-30 15:56 ` Sudeep Holla 2017-03-30 15:56 ` Sudeep Holla 2017-03-30 15:56 ` Sudeep Holla 2017-03-31 0:54 ` Leo Yan 2017-03-31 0:54 ` Leo Yan 2017-03-25 18:23 ` [PATCH v5 7/9] clk: hi6220: add debug APB clock Leo Yan 2017-03-25 18:23 ` Leo Yan 2017-04-04 21:51 ` Stephen Boyd 2017-04-04 21:51 ` Stephen Boyd [not found] ` <20170404215109.GH18246-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2017-04-06 13:59 ` Leo Yan 2017-04-06 13:59 ` Leo Yan 2017-04-06 13:59 ` Leo Yan 2017-03-25 18:23 ` [PATCH v5 8/9] arm64: dts: hi6220: register debug module Leo Yan 2017-03-25 18:23 ` Leo Yan [not found] ` <1490466197-29163-1-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-03-25 18:23 ` [PATCH v5 5/9] coresight: use const for device_node structures Leo Yan 2017-03-25 18:23 ` Leo Yan 2017-03-25 18:23 ` Leo Yan [not found] ` <1490466197-29163-6-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-04-04 21:48 ` Stephen Boyd 2017-04-04 21:48 ` Stephen Boyd 2017-04-04 21:48 ` Stephen Boyd 2017-03-25 18:23 ` [PATCH v5 9/9] arm64: dts: qcom: msm8916: Add debug unit Leo Yan 2017-03-25 18:23 ` Leo Yan 2017-03-25 18:23 ` Leo Yan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1490466197-29163-4-git-send-email-leo.yan@linaro.org \ --to=leo.yan@linaro.org \ --cc=Suzuki.Poulose@arm.com \ --cc=andy.gross@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=guodong.xu@linaro.org \ --cc=john.stultz@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=sudeep.holla@arm.com \ --cc=will.deacon@arm.com \ --cc=xuwei5@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.