From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> To: Ding Tianhong <dingtianhong@huawei.com>, catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com, robin.murphy@arm.com, davem@davemloft.net, alexander.duyck@gmail.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/4] ixgbe: enable Relaxed Order for ARM64 Date: Sat, 01 Apr 2017 01:39:22 -0700 [thread overview] Message-ID: <1491035962.3211.3.camel@intel.com> (raw) In-Reply-To: <1491031554-19516-1-git-send-email-dingtianhong@huawei.com> [-- Attachment #1: Type: text/plain, Size: 2458 bytes --] On Sat, 2017-04-01 at 15:25 +0800, Ding Tianhong wrote: > The IXGBE_ALLOW_RELAXED_ORDER will enable Relaxed Ordering (RO) which > allows > transactions that do not have any order of completion requirements to > complete more efficiently compare to the Stricted Ordering (SO) for > ixbge > nic card. Some architecture will see high write-to-memory performance > when RO is > enabled on the data transactions just like the SPARC did. > > The aarch64 could both support Relaxed Ordering (RO) and Stricted > Ordering (SO), > so enable this config could get much more better performance, didn't > see any > adverse effects. > > The ARCH_WANT_RELAX_ORDER looks more general and would cause > misleading and > ambiguous, and till now only ixgbe could enable this "flag", so > rename this > config more specific. > > After discussion with the architecture maintainer, enable this config > in driver > looks more appropriate to compatible several architecture just like > SPARC and ARM64, > maybe we need more discussion about this, so let's begin by this > patch set. > > In the last patch 1a8b6d76(net:add one common config ...), Mao only > fix the > config name issue for 82599 pf, but the 82598 and 82599 vf still need > to be fixed, > so rename the config all in the drivers to instead of CONFIG_SPARC. Thank you for at least CC'ing me, but please remember to also CC intel- wired-lan@lists.osuosl.org mailing list. It make it easier for me to add your patches to my queue and makes it visible for the developers/validation people who will be reviewing and testing your changes. > > Ding Tianhong (4): > ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to > IXGBE_ALLOW_RELAXED_ORDER > ixgbe: ixgbevf: Clear the CONFIG_SPARC for ixgbevf and 82598 > ixgbe: move IXGBE_ALLOW_RELAXED_ORDER from architecture to driver > ixgbe: enable IXGBE_ALLOW_RELAXED_ORDER for ARM64 > > arch/Kconfig | 3 --- > arch/sparc/Kconfig | 1 - > drivers/net/ethernet/intel/Kconfig | 4 ++++ > drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c | 4 ++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +- > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- > 6 files changed, 8 insertions(+), 8 deletions(-) [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: jeffrey.t.kirsher@intel.com (Jeff Kirsher) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next 0/4] ixgbe: enable Relaxed Order for ARM64 Date: Sat, 01 Apr 2017 01:39:22 -0700 [thread overview] Message-ID: <1491035962.3211.3.camel@intel.com> (raw) In-Reply-To: <1491031554-19516-1-git-send-email-dingtianhong@huawei.com> On Sat, 2017-04-01 at 15:25 +0800, Ding Tianhong wrote: > The IXGBE_ALLOW_RELAXED_ORDER will enable Relaxed Ordering (RO) which > allows > transactions that do not have any order of completion requirements to > complete more efficiently compare to the Stricted Ordering (SO) for > ixbge > nic card. Some architecture will see high write-to-memory performance > when RO is > enabled on the data transactions just like the SPARC did. > > The aarch64 could both support Relaxed Ordering (RO) and Stricted > Ordering (SO), > so enable this config could get much more better performance, didn't > see any > adverse effects. > > The ARCH_WANT_RELAX_ORDER looks more general and would cause > misleading and > ambiguous, and till now only ixgbe could enable this "flag", so > rename this > config more specific. > > After discussion with the architecture maintainer, enable this config > in driver > looks more appropriate to compatible several architecture just like > SPARC and ARM64, > maybe we need more discussion about this, so let's begin by this > patch set. > > In the last patch 1a8b6d76(net:add one common config ...), Mao only > fix the > config name issue for 82599 pf, but the 82598 and 82599 vf still need > to be fixed, > so rename the config all in the drivers to instead of CONFIG_SPARC. Thank you for at least CC'ing me, but please remember to also CC intel- wired-lan at lists.osuosl.org mailing list. It make it easier for me to add your patches to my queue and makes it visible for the developers/validation people who will be reviewing and testing your changes. > > Ding Tianhong (4): > ? ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to > ??? IXGBE_ALLOW_RELAXED_ORDER > ? ixgbe: ixgbevf: Clear the CONFIG_SPARC for ixgbevf and 82598 > ? ixgbe: move IXGBE_ALLOW_RELAXED_ORDER from architecture to driver > ? ixgbe: enable IXGBE_ALLOW_RELAXED_ORDER for ARM64 > > ?arch/Kconfig????????????????????????????????????? | 3 --- > ?arch/sparc/Kconfig??????????????????????????????? | 1 - > ?drivers/net/ethernet/intel/Kconfig??????????????? | 4 ++++ > ?drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c??? | 4 ++-- > ?drivers/net/ethernet/intel/ixgbe/ixgbe_common.c?? | 2 +- > ?drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- > ?6 files changed, 8 insertions(+), 8 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: This is a digitally signed message part URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170401/9e0cfe41/attachment.sig>
next prev parent reply other threads:[~2017-04-01 8:39 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-01 7:25 [PATCH net-next 0/4] ixgbe: enable Relaxed Order for ARM64 Ding Tianhong 2017-04-01 7:25 ` Ding Tianhong 2017-04-01 7:25 ` [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER Ding Tianhong 2017-04-01 7:25 ` Ding Tianhong 2017-04-01 18:26 ` David Miller 2017-04-01 18:26 ` David Miller 2017-04-02 6:49 ` Ding Tianhong 2017-04-02 6:49 ` [Intel-wired-lan] " Ding Tianhong 2017-04-02 6:49 ` Ding Tianhong 2017-04-05 13:05 ` John Garry 2017-04-05 13:05 ` [Intel-wired-lan] " John Garry 2017-04-05 13:05 ` John Garry 2017-04-06 11:28 ` Ding Tianhong 2017-04-06 11:28 ` [Intel-wired-lan] " Ding Tianhong 2017-04-06 11:28 ` Ding Tianhong [not found] ` <42428725-89f1-1508-4e3d-723e087b3bbb@huawei.com> 2017-04-13 9:10 ` Gabriele Paoloni 2017-04-13 9:10 ` Gabriele Paoloni 2017-04-13 14:53 ` David Miller 2017-04-13 14:53 ` David Miller 2017-04-18 13:25 ` David Laight 2017-04-18 13:25 ` David Laight 2017-04-19 14:28 ` Gabriele Paoloni 2017-04-19 14:28 ` Gabriele Paoloni [not found] ` <DB5PR05MB138288172B04713EB0C1DB55D3190@DB5PR05MB1382.eurprd05.prod.outlook.com> [not found] ` <EE11001F9E5DDD47B7634E2F8A612F2E205352FC@FRAEML521-MBX.china.huawei.com> 2017-04-19 14:46 ` Gabriele Paoloni 2017-04-19 14:46 ` Gabriele Paoloni 2017-04-24 14:53 ` Will Deacon 2017-04-24 14:53 ` Will Deacon 2017-04-26 9:26 ` Ding Tianhong 2017-04-26 9:26 ` Ding Tianhong 2017-04-26 16:18 ` Alexander Duyck 2017-04-26 16:18 ` Alexander Duyck 2017-04-26 16:18 ` Alexander Duyck 2017-04-27 17:19 ` Bjorn Helgaas 2017-04-27 17:19 ` Bjorn Helgaas 2017-04-27 17:19 ` Bjorn Helgaas 2017-04-27 19:00 ` Casey Leedom 2017-04-27 19:00 ` Casey Leedom 2017-04-27 19:00 ` Casey Leedom 2017-04-27 20:34 ` Casey Leedom 2017-04-27 20:34 ` Casey Leedom 2017-04-27 20:34 ` Casey Leedom 2017-04-28 9:12 ` Gabriele Paoloni 2017-04-28 9:12 ` Gabriele Paoloni 2017-04-28 9:12 ` Gabriele Paoloni 2017-04-28 8:51 ` Lucas Stach 2017-04-28 8:51 ` Lucas Stach 2017-04-28 8:51 ` Lucas Stach 2017-04-28 18:42 ` Casey Leedom 2017-04-28 18:42 ` Casey Leedom 2017-04-28 18:42 ` Casey Leedom 2017-04-01 7:25 ` [PATCH net-next 2/4] ixgbe: ixgbevf: Clear the CONFIG_SPARC for ixgbevf and 82598 Ding Tianhong 2017-04-01 7:25 ` Ding Tianhong 2017-04-01 7:25 ` [PATCH net-next 3/4] ixgbe: move IXGBE_ALLOW_RELAXED_ORDER from architecture to driver Ding Tianhong 2017-04-01 7:25 ` Ding Tianhong 2017-04-01 7:25 ` [PATCH net-next 4/4] ixgbe: enable IXGBE_ALLOW_RELAXED_ORDER for ARM64 Ding Tianhong 2017-04-01 7:25 ` Ding Tianhong 2017-04-01 8:39 ` Jeff Kirsher [this message] 2017-04-01 8:39 ` [PATCH net-next 0/4] ixgbe: enable Relaxed Order " Jeff Kirsher 2017-04-01 8:49 ` Ding Tianhong 2017-04-01 8:49 ` Ding Tianhong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1491035962.3211.3.camel@intel.com \ --to=jeffrey.t.kirsher@intel.com \ --cc=alexander.duyck@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=davem@davemloft.net \ --cc=dingtianhong@huawei.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=netdev@vger.kernel.org \ --cc=robin.murphy@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.