From: Ding Tianhong <dingtianhong@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, alexander.duyck@gmail.com,
intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER
Date: Sun, 2 Apr 2017 14:49:47 +0800 [thread overview]
Message-ID: <819bc6c1-581b-3ab9-d189-1befaaf43548@huawei.com> (raw)
In-Reply-To: <20170401.112603.1991545644693496714.davem@davemloft.net>
On 2017/4/2 2:26, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>
> Date: Sat, 1 Apr 2017 15:25:51 +0800
>
>> Till now only the Intel ixgbe could support enable
>> Relaxed ordering in the drivers for special architecture,
>> but the ARCH_WANT_RELAX_ORDER is looks like a general name
>> for all arch, so rename to a specific name for intel
>> card looks more appropriate.
>>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>
> This is not a driver specific facility.
>
> Any driver can test this symbol and act accordingly.
>
> Just because IXGBE is the first and only user, doesn't mean
> the facility is driver specific.
>
Understand clearly，but the ARCH_WANT_RELAX_ORDER is really too generic and simple,
cause much misleading to indicate that it looks like the hack code for some architecture.
what do you think of the ETHERNET_ALLOW_RELAXED_ORDER in the drivers/net/ethernet/*,
it will only affect ethernet and not only for Ixgbe.
Thanks
Ding
> Thank you.
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: dingtianhong@huawei.com (Ding Tianhong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER
Date: Sun, 2 Apr 2017 14:49:47 +0800 [thread overview]
Message-ID: <819bc6c1-581b-3ab9-d189-1befaaf43548@huawei.com> (raw)
In-Reply-To: <20170401.112603.1991545644693496714.davem@davemloft.net>
On 2017/4/2 2:26, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>
> Date: Sat, 1 Apr 2017 15:25:51 +0800
>
>> Till now only the Intel ixgbe could support enable
>> Relaxed ordering in the drivers for special architecture,
>> but the ARCH_WANT_RELAX_ORDER is looks like a general name
>> for all arch, so rename to a specific name for intel
>> card looks more appropriate.
>>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>
> This is not a driver specific facility.
>
> Any driver can test this symbol and act accordingly.
>
> Just because IXGBE is the first and only user, doesn't mean
> the facility is driver specific.
>
Understand clearly?but the ARCH_WANT_RELAX_ORDER is really too generic and simple,
cause much misleading to indicate that it looks like the hack code for some architecture.
what do you think of the ETHERNET_ALLOW_RELAXED_ORDER in the drivers/net/ethernet/*,
it will only affect ethernet and not only for Ixgbe.
Thanks
Ding
> Thank you.
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: Ding Tianhong <dingtianhong@huawei.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER
Date: Sun, 2 Apr 2017 14:49:47 +0800 [thread overview]
Message-ID: <819bc6c1-581b-3ab9-d189-1befaaf43548@huawei.com> (raw)
In-Reply-To: <20170401.112603.1991545644693496714.davem@davemloft.net>
On 2017/4/2 2:26, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei.com>
> Date: Sat, 1 Apr 2017 15:25:51 +0800
>
>> Till now only the Intel ixgbe could support enable
>> Relaxed ordering in the drivers for special architecture,
>> but the ARCH_WANT_RELAX_ORDER is looks like a general name
>> for all arch, so rename to a specific name for intel
>> card looks more appropriate.
>>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>
> This is not a driver specific facility.
>
> Any driver can test this symbol and act accordingly.
>
> Just because IXGBE is the first and only user, doesn't mean
> the facility is driver specific.
>
Understand clearly?but the ARCH_WANT_RELAX_ORDER is really too generic and simple,
cause much misleading to indicate that it looks like the hack code for some architecture.
what do you think of the ETHERNET_ALLOW_RELAXED_ORDER in the drivers/net/ethernet/*,
it will only affect ethernet and not only for Ixgbe.
Thanks
Ding
> Thank you.
>
> .
>
next prev parent reply other threads:[~2017-04-02 6:49 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 7:25 [PATCH net-next 0/4] ixgbe: enable Relaxed Order for ARM64 Ding Tianhong
2017-04-01 7:25 ` Ding Tianhong
2017-04-01 7:25 ` [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER Ding Tianhong
2017-04-01 7:25 ` Ding Tianhong
2017-04-01 18:26 ` David Miller
2017-04-01 18:26 ` David Miller
2017-04-02 6:49 ` Ding Tianhong [this message]
2017-04-02 6:49 ` [Intel-wired-lan] " Ding Tianhong
2017-04-02 6:49 ` Ding Tianhong
2017-04-05 13:05 ` John Garry
2017-04-05 13:05 ` [Intel-wired-lan] " John Garry
2017-04-05 13:05 ` John Garry
2017-04-06 11:28 ` Ding Tianhong
2017-04-06 11:28 ` [Intel-wired-lan] " Ding Tianhong
2017-04-06 11:28 ` Ding Tianhong
[not found] ` <42428725-89f1-1508-4e3d-723e087b3bbb@huawei.com>
2017-04-13 9:10 ` Gabriele Paoloni
2017-04-13 9:10 ` Gabriele Paoloni
2017-04-13 14:53 ` David Miller
2017-04-13 14:53 ` David Miller
2017-04-18 13:25 ` David Laight
2017-04-18 13:25 ` David Laight
2017-04-19 14:28 ` Gabriele Paoloni
2017-04-19 14:28 ` Gabriele Paoloni
[not found] ` <DB5PR05MB138288172B04713EB0C1DB55D3190@DB5PR05MB1382.eurprd05.prod.outlook.com>
[not found] ` <EE11001F9E5DDD47B7634E2F8A612F2E205352FC@FRAEML521-MBX.china.huawei.com>
2017-04-19 14:46 ` Gabriele Paoloni
2017-04-19 14:46 ` Gabriele Paoloni
2017-04-24 14:53 ` Will Deacon
2017-04-24 14:53 ` Will Deacon
2017-04-26 9:26 ` Ding Tianhong
2017-04-26 9:26 ` Ding Tianhong
2017-04-26 16:18 ` Alexander Duyck
2017-04-26 16:18 ` Alexander Duyck
2017-04-26 16:18 ` Alexander Duyck
2017-04-27 17:19 ` Bjorn Helgaas
2017-04-27 17:19 ` Bjorn Helgaas
2017-04-27 17:19 ` Bjorn Helgaas
2017-04-27 19:00 ` Casey Leedom
2017-04-27 19:00 ` Casey Leedom
2017-04-27 19:00 ` Casey Leedom
2017-04-27 20:34 ` Casey Leedom
2017-04-27 20:34 ` Casey Leedom
2017-04-27 20:34 ` Casey Leedom
2017-04-28 9:12 ` Gabriele Paoloni
2017-04-28 9:12 ` Gabriele Paoloni
2017-04-28 9:12 ` Gabriele Paoloni
2017-04-28 8:51 ` Lucas Stach
2017-04-28 8:51 ` Lucas Stach
2017-04-28 8:51 ` Lucas Stach
2017-04-28 18:42 ` Casey Leedom
2017-04-28 18:42 ` Casey Leedom
2017-04-28 18:42 ` Casey Leedom
2017-04-01 7:25 ` [PATCH net-next 2/4] ixgbe: ixgbevf: Clear the CONFIG_SPARC for ixgbevf and 82598 Ding Tianhong
2017-04-01 7:25 ` Ding Tianhong
2017-04-01 7:25 ` [PATCH net-next 3/4] ixgbe: move IXGBE_ALLOW_RELAXED_ORDER from architecture to driver Ding Tianhong
2017-04-01 7:25 ` Ding Tianhong
2017-04-01 7:25 ` [PATCH net-next 4/4] ixgbe: enable IXGBE_ALLOW_RELAXED_ORDER for ARM64 Ding Tianhong
2017-04-01 7:25 ` Ding Tianhong
2017-04-01 8:39 ` [PATCH net-next 0/4] ixgbe: enable Relaxed Order " Jeff Kirsher
2017-04-01 8:39 ` Jeff Kirsher
2017-04-01 8:49 ` Ding Tianhong
2017-04-01 8:49 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=819bc6c1-581b-3ab9-d189-1befaaf43548@huawei.com \
--to=dingtianhong@huawei.com \
--cc=alexander.duyck@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.