* [U-Boot] [PATCH v3] fdt: allow address translation in case of SPL_OF_TRANSLATE
@ 2017-04-04 21:59 Vikas Manocha
2017-04-05 3:27 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Vikas Manocha @ 2017-04-04 21:59 UTC (permalink / raw)
To: u-boot
Address translation is not working at present even if SPL_OF_TRANSLATE is
enabled which makes this configuration useless. This patch enables address
translation for SPL U-Boot when SPL_OF_TRANSLATE is selected.
Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
Changes in v3: changed "u-boot" to "U-Boot" in commit message.
Changes in v2: Added commit message
lib/fdtdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index 81f47ef..a1c4d16 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -112,7 +112,7 @@ fdt_addr_t fdtdec_get_addr_size_fixed(const void *blob, int node,
return FDT_ADDR_T_NONE;
}
-#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_OF_LIBFDT)
+#if defined(CONFIG_SPL_OF_TRANSLATE) || defined(CONFIG_OF_LIBFDT)
if (translate)
addr = fdt_translate_address(blob, node, prop_addr);
else
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v3] fdt: allow address translation in case of SPL_OF_TRANSLATE
2017-04-04 21:59 [U-Boot] [PATCH v3] fdt: allow address translation in case of SPL_OF_TRANSLATE Vikas Manocha
@ 2017-04-05 3:27 ` Simon Glass
2017-04-05 16:12 ` Vikas Manocha
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2017-04-05 3:27 UTC (permalink / raw)
To: u-boot
Hi Vikas,
On 4 April 2017 at 15:59, Vikas Manocha <vikas.manocha@st.com> wrote:
> Address translation is not working at present even if SPL_OF_TRANSLATE is
> enabled which makes this configuration useless. This patch enables address
> translation for SPL U-Boot when SPL_OF_TRANSLATE is selected.
>
> Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v3: changed "u-boot" to "U-Boot" in commit message.
> Changes in v2: Added commit message
>
> lib/fdtdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index 81f47ef..a1c4d16 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -112,7 +112,7 @@ fdt_addr_t fdtdec_get_addr_size_fixed(const void *blob, int node,
> return FDT_ADDR_T_NONE;
> }
>
> -#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_OF_LIBFDT)
> +#if defined(CONFIG_SPL_OF_TRANSLATE) || defined(CONFIG_OF_LIBFDT)
> if (translate)
> addr = fdt_translate_address(blob, node, prop_addr);
> else
> --
> 1.9.1
>
Actually I'm a bit unsure about this patch. You already have a patch applied:
5efa1bf libfdt: use CONFIG_IS_ENABLED for OF_LIBFDT
Do you actually want this one else well? If so, please resend it as it
conflicts.
Regards,
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v3] fdt: allow address translation in case of SPL_OF_TRANSLATE
2017-04-05 3:27 ` Simon Glass
@ 2017-04-05 16:12 ` Vikas Manocha
0 siblings, 0 replies; 3+ messages in thread
From: Vikas Manocha @ 2017-04-05 16:12 UTC (permalink / raw)
To: u-boot
Hi Simon,
On 04/04/2017 08:27 PM, Simon Glass wrote:
> Hi Vikas,
>
> On 4 April 2017 at 15:59, Vikas Manocha <vikas.manocha@st.com> wrote:
>> Address translation is not working at present even if SPL_OF_TRANSLATE is
>> enabled which makes this configuration useless. This patch enables address
>> translation for SPL U-Boot when SPL_OF_TRANSLATE is selected.
>>
>> Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> Changes in v3: changed "u-boot" to "U-Boot" in commit message.
>> Changes in v2: Added commit message
>>
>> lib/fdtdec.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
>> index 81f47ef..a1c4d16 100644
>> --- a/lib/fdtdec.c
>> +++ b/lib/fdtdec.c
>> @@ -112,7 +112,7 @@ fdt_addr_t fdtdec_get_addr_size_fixed(const void *blob, int node,
>> return FDT_ADDR_T_NONE;
>> }
>>
>> -#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_OF_LIBFDT)
>> +#if defined(CONFIG_SPL_OF_TRANSLATE) || defined(CONFIG_OF_LIBFDT)
>> if (translate)
>> addr = fdt_translate_address(blob, node, prop_addr);
>> else
>> --
>> 1.9.1
>>
>
> Actually I'm a bit unsure about this patch. You already have a patch applied:
>
> 5efa1bf libfdt: use CONFIG_IS_ENABLED for OF_LIBFDT
This patch(5efa1bf) was recently applied & serves the same purpose.
We can ignore my patch.
Cheers,
Vikas
>
> Do you actually want this one else well? If so, please resend it as it
> conflicts.
>
> Regards,
> Simon
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-05 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 21:59 [U-Boot] [PATCH v3] fdt: allow address translation in case of SPL_OF_TRANSLATE Vikas Manocha
2017-04-05 3:27 ` Simon Glass
2017-04-05 16:12 ` Vikas Manocha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.