From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> To: Borislav Petkov <bp@suse.de> Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Andrew Morton <akpm@linux-foundation.org>, Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>, Dave Hansen <dave.hansen@linux.intel.com>, Paolo Bonzini <pbonzini@redhat.com>, Liang Z Li <liang.z.li@intel.com>, Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>, Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>, "Michael S. Tsirkin" <mst@redhat.com>, Paul Gortmaker <paul.gortmaker@windriver.com>, Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>, Alexandre Julliard <julliard@winehq.org>, Stas Sergeev <stsp@list.ru>, Fenghua Yu <fenghua.yu@intel.com>, "Ravi V. Shankar" <ravi.v.shankar@intel.com>, Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org, x86@kernel.org, linux-msdos@vger.kernel.org, wine-devel@winehq.org, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Josh Poimboeuf <jpoimboe@redhat.com> Subject: Re: [PATCH v7 02/26] x86/mm: Relocate page fault error codes to traps.h Date: Fri, 26 May 2017 20:40:26 -0700 [thread overview] Message-ID: <1495856426.24288.47.camel@ranerica-desktop> (raw) In-Reply-To: <20170521142330.GC5676@nazgul.tnic> On Sun, 2017-05-21 at 16:23 +0200, Borislav Petkov wrote: > On Fri, May 05, 2017 at 11:17:00AM -0700, Ricardo Neri wrote: > > Up to this point, only fault.c used the definitions of the page fault error > > codes. Thus, it made sense to keep them within such file. Other portions of > > code might be interested in those definitions too. For instance, the User- > > Mode Instruction Prevention emulation code will use such definitions to > > emulate a page fault when it is unable to successfully copy the results > > of the emulated instructions to user space. > > > > While relocating the error code enumeration, the prefix X86_ is used to > > make it consistent with the rest of the definitions in traps.h. Of course, > > code using the enumeration had to be updated as well. No functional changes > > were performed. > > > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: "H. Peter Anvin" <hpa@zytor.com> > > Cc: Andy Lutomirski <luto@kernel.org> > > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > > Cc: Dave Hansen <dave.hansen@linux.intel.com> > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com> > > Cc: x86@kernel.org > > Reviewed-by: Andy Lutomirski <luto@kernel.org> > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> > > --- > > arch/x86/include/asm/traps.h | 18 +++++++++ > > arch/x86/mm/fault.c | 88 +++++++++++++++++--------------------------- > > 2 files changed, 52 insertions(+), 54 deletions(-) > > ... > > > @@ -1382,7 +1362,7 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code, > > * space check, thus avoiding the deadlock: > > */ > > if (unlikely(!down_read_trylock(&mm->mmap_sem))) { > > - if ((error_code & PF_USER) == 0 && > > + if ((error_code & X86_PF_USER) == 0 && > > if (!(error_code & X86_PF_USER)) This change was initially intended to only rename the error codes, without functional changes. Would making change be considered a change in functionality? The behavior would be preserved, though. Thanks and BR, Ricardo > > With that fixed: > > Reviewed-by: Borislav Petkov <bp@suse.de> Thank you for your review! BR, Ricardo > > -- > Regards/Gruss, > Boris. > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> To: Borislav Petkov <bp@suse.de> Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Andrew Morton <akpm@linux-foundation.org>, Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>, Dave Hansen <dave.hansen@linux.intel.com>, Paolo Bonzini <pbonzini@redhat.com>, Liang Z Li <liang.z.li@intel.com>, Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>, Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>, "Michael S. Tsirkin" <mst@redhat.com>, Paul Gortmaker <paul.gortmaker@windriver.com>, Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>, Alexandre Julliard <julliard@winehq.org>, Stas Subject: Re: [PATCH v7 02/26] x86/mm: Relocate page fault error codes to traps.h Date: Fri, 26 May 2017 20:40:26 -0700 [thread overview] Message-ID: <1495856426.24288.47.camel@ranerica-desktop> (raw) In-Reply-To: <20170521142330.GC5676@nazgul.tnic> On Sun, 2017-05-21 at 16:23 +0200, Borislav Petkov wrote: > On Fri, May 05, 2017 at 11:17:00AM -0700, Ricardo Neri wrote: > > Up to this point, only fault.c used the definitions of the page fault error > > codes. Thus, it made sense to keep them within such file. Other portions of > > code might be interested in those definitions too. For instance, the User- > > Mode Instruction Prevention emulation code will use such definitions to > > emulate a page fault when it is unable to successfully copy the results > > of the emulated instructions to user space. > > > > While relocating the error code enumeration, the prefix X86_ is used to > > make it consistent with the rest of the definitions in traps.h. Of course, > > code using the enumeration had to be updated as well. No functional changes > > were performed. > > > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: "H. Peter Anvin" <hpa@zytor.com> > > Cc: Andy Lutomirski <luto@kernel.org> > > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > > Cc: Dave Hansen <dave.hansen@linux.intel.com> > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com> > > Cc: x86@kernel.org > > Reviewed-by: Andy Lutomirski <luto@kernel.org> > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> > > --- > > arch/x86/include/asm/traps.h | 18 +++++++++ > > arch/x86/mm/fault.c | 88 +++++++++++++++++--------------------------- > > 2 files changed, 52 insertions(+), 54 deletions(-) > > ... > > > @@ -1382,7 +1362,7 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code, > > * space check, thus avoiding the deadlock: > > */ > > if (unlikely(!down_read_trylock(&mm->mmap_sem))) { > > - if ((error_code & PF_USER) == 0 && > > + if ((error_code & X86_PF_USER) == 0 && > > if (!(error_code & X86_PF_USER)) This change was initially intended to only rename the error codes, without functional changes. Would making change be considered a change in functionality? The behavior would be preserved, though. Thanks and BR, Ricardo > > With that fixed: > > Reviewed-by: Borislav Petkov <bp@suse.de> Thank you for your review! BR, Ricardo > > -- > Regards/Gruss, > Boris. > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-05-27 4:16 UTC|newest] Thread overview: 164+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-05 18:16 [PATCH v7 00/26] x86: Enable User-Mode Instruction Prevention Ricardo Neri 2017-05-05 18:16 ` Ricardo Neri 2017-05-05 18:16 ` [PATCH v7 01/26] ptrace,x86: Make user_64bit_mode() available to 32-bit builds Ricardo Neri 2017-05-05 18:16 ` Ricardo Neri 2017-05-21 14:19 ` Borislav Petkov 2017-05-21 14:19 ` Borislav Petkov 2017-05-05 18:17 ` [PATCH v7 02/26] x86/mm: Relocate page fault error codes to traps.h Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-21 14:23 ` Borislav Petkov 2017-05-21 14:23 ` Borislav Petkov 2017-05-27 3:40 ` Ricardo Neri [this message] 2017-05-27 3:40 ` Ricardo Neri 2017-05-27 10:13 ` Borislav Petkov 2017-05-27 10:13 ` Borislav Petkov 2017-06-01 3:09 ` Ricardo Neri 2017-06-01 3:09 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 03/26] x86/mpx: Use signed variables to compute effective addresses Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 04/26] x86/mpx: Do not use SIB.index if its value is 100b and ModRM.mod is not 11b Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-24 13:37 ` Borislav Petkov 2017-05-24 13:37 ` Borislav Petkov 2017-05-27 3:36 ` Ricardo Neri 2017-05-27 3:36 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 05/26] x86/mpx: Do not use SIB.base if its value is 101b and ModRM.mod = 0 Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-29 13:07 ` Borislav Petkov 2017-05-29 13:07 ` Borislav Petkov 2017-06-06 6:08 ` Ricardo Neri 2017-06-06 6:08 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 06/26] x86/mpx, x86/insn: Relocate insn util functions to a new insn-eval file Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register type Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-29 16:37 ` Borislav Petkov 2017-05-29 16:37 ` Borislav Petkov 2017-06-06 6:06 ` Ricardo Neri 2017-06-06 6:06 ` Ricardo Neri 2017-06-06 11:58 ` Borislav Petkov 2017-06-06 11:58 ` Borislav Petkov 2017-06-07 0:28 ` Ricardo Neri 2017-06-07 0:28 ` Ricardo Neri 2017-06-07 12:21 ` Borislav Petkov 2017-06-07 12:21 ` Borislav Petkov 2017-06-07 18:54 ` Stas Sergeev 2017-06-27 19:03 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 08/26] x86/insn-eval: Add a utility function to get register offsets Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-29 17:16 ` Borislav Petkov 2017-05-29 17:16 ` Borislav Petkov 2017-06-06 6:02 ` Ricardo Neri 2017-06-06 6:02 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 09/26] x86/insn-eval: Add utility function to identify string instructions Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-29 21:48 ` Borislav Petkov 2017-05-29 21:48 ` Borislav Petkov 2017-06-06 6:01 ` Ricardo Neri 2017-06-06 6:01 ` Ricardo Neri 2017-06-06 12:04 ` Borislav Petkov 2017-06-06 12:04 ` Borislav Petkov 2017-05-05 18:17 ` [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-30 10:35 ` Borislav Petkov 2017-05-30 10:35 ` Borislav Petkov 2017-06-15 18:37 ` Ricardo Neri 2017-06-15 18:37 ` Ricardo Neri 2017-06-15 19:04 ` Ricardo Neri 2017-06-15 19:04 ` Ricardo Neri 2017-06-19 15:29 ` Borislav Petkov 2017-06-19 15:29 ` Borislav Petkov 2017-06-19 15:37 ` Borislav Petkov 2017-06-19 15:37 ` Borislav Petkov 2017-05-05 18:17 ` [PATCH v7 11/26] x86/insn-eval: Add utility function to get segment descriptor Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 12/26] x86/insn-eval: Add utility functions to get segment descriptor base address and limit Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-31 16:58 ` Borislav Petkov 2017-05-31 16:58 ` Borislav Petkov 2017-06-03 17:23 ` Ricardo Neri 2017-06-03 17:23 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 13/26] x86/insn-eval: Add function to get default params of code segment Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-06-07 12:59 ` Borislav Petkov 2017-06-07 12:59 ` Borislav Petkov 2017-06-15 19:24 ` Ricardo Neri 2017-06-15 19:24 ` Ricardo Neri 2017-06-19 17:11 ` Borislav Petkov 2017-06-19 17:11 ` Borislav Petkov 2017-05-05 18:17 ` [PATCH v7 14/26] x86/insn-eval: Indicate a 32-bit displacement if ModRM.mod is 0 and ModRM.rm is 5 Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-06-07 13:15 ` Borislav Petkov 2017-06-07 13:15 ` Borislav Petkov 2017-06-15 19:36 ` Ricardo Neri 2017-06-15 19:36 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 15/26] x86/insn-eval: Incorporate segment base and limit in linear address computation Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 16/26] x86/insn-eval: Support both signed 32-bit and 64-bit effective addresses Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-06-07 15:48 ` Borislav Petkov 2017-06-07 15:48 ` Borislav Petkov 2017-07-25 23:48 ` Ricardo Neri 2017-07-25 23:48 ` Ricardo Neri 2017-07-27 13:26 ` Borislav Petkov 2017-07-27 13:26 ` Borislav Petkov 2017-07-28 2:04 ` Ricardo Neri 2017-07-28 2:04 ` Ricardo Neri 2017-07-28 6:50 ` Borislav Petkov 2017-07-28 6:50 ` Borislav Petkov 2017-06-07 15:49 ` Borislav Petkov 2017-06-07 15:49 ` Borislav Petkov 2017-06-15 19:58 ` Ricardo Neri 2017-06-15 19:58 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 17/26] x86/insn-eval: Handle 32-bit address encodings in virtual-8086 mode Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 18/26] x86/insn-eval: Add support to resolve 16-bit addressing encodings Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-06-07 16:28 ` Borislav Petkov 2017-06-07 16:28 ` Borislav Petkov 2017-06-15 21:50 ` Ricardo Neri 2017-06-15 21:50 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 19/26] x86/insn-eval: Add wrapper function for 16-bit and 32-bit address encodings Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 20/26] x86/cpufeature: Add User-Mode Instruction Prevention definitions Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-06 9:04 ` Paolo Bonzini 2017-05-06 9:04 ` Paolo Bonzini 2017-05-11 3:23 ` Ricardo Neri 2017-05-11 3:23 ` Ricardo Neri 2017-06-07 18:24 ` Borislav Petkov 2017-06-07 18:24 ` Borislav Petkov 2017-05-05 18:17 ` [PATCH v7 21/26] x86: Add emulation code for UMIP instructions Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-06-08 18:38 ` Borislav Petkov 2017-06-08 18:38 ` Borislav Petkov 2017-06-17 1:34 ` Ricardo Neri 2017-06-17 1:34 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 22/26] x86/umip: Force a page fault when unable to copy emulated result to user Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-06-09 11:02 ` Borislav Petkov 2017-06-09 11:02 ` Borislav Petkov 2017-07-25 23:50 ` Ricardo Neri 2017-07-25 23:50 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 23/26] x86/traps: Fixup general protection faults caused by UMIP Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-06-09 13:02 ` Borislav Petkov 2017-06-09 13:02 ` Borislav Petkov 2017-07-25 23:51 ` Ricardo Neri 2017-07-25 23:51 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 24/26] x86: Enable User-Mode Instruction Prevention Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-06-09 16:10 ` Borislav Petkov 2017-06-09 16:10 ` Borislav Petkov 2017-07-26 0:44 ` Ricardo Neri 2017-07-26 0:44 ` Ricardo Neri 2017-07-27 13:57 ` Borislav Petkov 2017-07-27 13:57 ` Borislav Petkov 2017-05-05 18:17 ` [PATCH v7 25/26] selftests/x86: Add tests for " Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-05 18:17 ` [PATCH v7 26/26] selftests/x86: Add tests for instruction str and sldt Ricardo Neri 2017-05-05 18:17 ` Ricardo Neri 2017-05-17 18:42 ` [PATCH v7 00/26] x86: Enable User-Mode Instruction Prevention Ricardo Neri 2017-05-17 18:42 ` Ricardo Neri 2017-05-27 3:49 ` Neri, Ricardo 2017-05-27 3:49 ` Neri, Ricardo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1495856426.24288.47.camel@ranerica-desktop \ --to=ricardo.neri-calderon@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=bp@suse.de \ --cc=brgerst@gmail.com \ --cc=cmetcalf@mellanox.com \ --cc=corbet@lwn.net \ --cc=dave.hansen@linux.intel.com \ --cc=fenghua.yu@intel.com \ --cc=hpa@zytor.com \ --cc=jpoimboe@redhat.com \ --cc=jslaby@suse.cz \ --cc=julliard@winehq.org \ --cc=kirill.shutemov@linux.intel.com \ --cc=liang.z.li@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-msdos@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mhiramat@kernel.org \ --cc=mingo@redhat.com \ --cc=mst@redhat.com \ --cc=paul.gortmaker@windriver.com \ --cc=pbonzini@redhat.com \ --cc=peterz@infradead.org \ --cc=ravi.v.shankar@intel.com \ --cc=ray.huang@amd.com \ --cc=shuah@kernel.org \ --cc=slaoub@gmail.com \ --cc=stsp@list.ru \ --cc=tglx@linutronix.de \ --cc=vbabka@suse.cz \ --cc=wine-devel@winehq.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.