[PATCH iproute2] iplink: Update usage in help message

[PATCH iproute2] iplink: Update usage in help message

[Tariq Toukan]

From: Eli Cohen <eli@mellanox.com>

Add to usage message a description of how to configure Infiniband node
and port GUIDs.

Fixes: d91fb3f4c7e4 ('Add support for configuring Infiniband GUIDs')
Signed-off-by: Eli Cohen <eli@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
---
 ip/iplink.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ip/iplink.c b/ip/iplink.c
index da3f9a779351..ea112f71befc 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -91,6 +91,8 @@ void iplink_usage(void)
 		"				   [ query_rss { on | off} ]\n"
 		"				   [ state { auto | enable | disable} ] ]\n"
 		"				   [ trust { on | off} ] ]\n"
+		"				   [ node_guid { eui64 } ]\n"
+		"				   [ port_guid { eui64 } ]\n"
 		"			  [ xdp { off |\n"
 		"				  object FILE [ section NAME ] [ verbose ] |\n"
 		"				  pinned FILE } ]\n"
-- 
1.8.3.1

Re: [PATCH iproute2] iplink: Update usage in help message

[Or Gerlitz]

On Thu, Jun 1, 2017 at 11:00 AM, Tariq Toukan <tariqt@mellanox.com> wrote:
> From: Eli Cohen <eli@mellanox.com>
>
> Add to usage message a description of how to configure Infiniband node
> and port GUIDs.
>
> Fixes: d91fb3f4c7e4 ('Add support for configuring Infiniband GUIDs')
> Signed-off-by: Eli Cohen <eli@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> ---
>  ip/iplink.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/ip/iplink.c b/ip/iplink.c
> index da3f9a779351..ea112f71befc 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -91,6 +91,8 @@ void iplink_usage(void)
>                 "                                  [ query_rss { on | off} ]\n"
>                 "                                  [ state { auto | enable | disable} ] ]\n"
>                 "                                  [ trust { on | off} ] ]\n"
> +               "                                  [ node_guid { eui64 } ]\n"
> +               "                                  [ port_guid { eui64 } ]\n"
>                 "                         [ xdp { off |\n"
>                 "                                 object FILE [ section NAME ] [ verbose ] |\n"
>                 "                                 pinned FILE } ]\n"


Eli,

I see now that your original patch touched the man page but the word
infiniband isn't mentioned:

@@ -1196,6 +1200,12 @@ sent by the VF.
 .BI trust " on|off"
 - trust the specified VF user. This enables that VF user can set a
specific feature
 which may impact security and/or performance. (e.g. VF multicast
promiscuous mode)
+.sp
+.BI node_guid " eui64"
+- configure node GUID for the VF.
+.sp
+.BI port_guid " eui64"
+- configure port GUID for the VF.


would be good if you enhance this patch to spell something like

configure node GUID for infiniband VFs.

configure port GUID for infiniband VFs.

Or.

RE: [PATCH iproute2] iplink: Update usage in help message

[Eli Cohen]

Sure, will do.

-----Original Message-----
From: Or Gerlitz [mailto:gerlitz.or@gmail.com] 
Sent: Thursday, June 1, 2017 5:56 AM
To: Tariq Toukan <tariqt@mellanox.com>; Eli Cohen <eli@mellanox.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>; Linux Netdev List <netdev@vger.kernel.org>; Eran Ben Elisha <eranbe@mellanox.com>
Subject: Re: [PATCH iproute2] iplink: Update usage in help message

On Thu, Jun 1, 2017 at 11:00 AM, Tariq Toukan <tariqt@mellanox.com> wrote:
> From: Eli Cohen <eli@mellanox.com>
>
> Add to usage message a description of how to configure Infiniband node 
> and port GUIDs.
>
> Fixes: d91fb3f4c7e4 ('Add support for configuring Infiniband GUIDs')
> Signed-off-by: Eli Cohen <eli@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> ---
>  ip/iplink.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/ip/iplink.c b/ip/iplink.c index 
> da3f9a779351..ea112f71befc 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -91,6 +91,8 @@ void iplink_usage(void)
>                 "                                  [ query_rss { on | off} ]\n"
>                 "                                  [ state { auto | enable | disable} ] ]\n"
>                 "                                  [ trust { on | off} ] ]\n"
> +               "                                  [ node_guid { eui64 } ]\n"
> +               "                                  [ port_guid { eui64 } ]\n"
>                 "                         [ xdp { off |\n"
>                 "                                 object FILE [ section NAME ] [ verbose ] |\n"
>                 "                                 pinned FILE } ]\n"


Eli,

I see now that your original patch touched the man page but the word infiniband isn't mentioned:

@@ -1196,6 +1200,12 @@ sent by the VF.
 .BI trust " on|off"
 - trust the specified VF user. This enables that VF user can set a specific feature  which may impact security and/or performance. (e.g. VF multicast promiscuous mode)
+.sp
+.BI node_guid " eui64"
+- configure node GUID for the VF.
+.sp
+.BI port_guid " eui64"
+- configure port GUID for the VF.


would be good if you enhance this patch to spell something like

configure node GUID for infiniband VFs.

configure port GUID for infiniband VFs.

Or.