From: Benjamin Gaignard <benjamin.gaignard@linaro.org> To: benjamin.gaignard@linaro.org Cc: linaro-kernel@lists.linaro.org, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH 36/51] rtc: rs5c348: stop using rtc deprecated functions Date: Tue, 20 Jun 2017 11:35:44 +0200 [thread overview] Message-ID: <1497951359-13334-37-git-send-email-benjamin.gaignard@linaro.org> (raw) In-Reply-To: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. Stop using those two functions to safer 64bits ones. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> CC: Alessandro Zummo <a.zummo@towertech.it> CC: Alexandre Belloni <alexandre.belloni@free-electrons.com> CC: rtc-linux@googlegroups.com CC: linux-kernel@vger.kernel.org --- drivers/rtc/rtc-rs5c348.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c index 9a30698..f82c0bc 100644 --- a/drivers/rtc/rtc-rs5c348.c +++ b/drivers/rtc/rtc-rs5c348.c @@ -137,7 +137,7 @@ struct rs5c348_plat_data { if (rtc_valid_tm(tm) < 0) { dev_err(&spi->dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, tm); + rtc_time64_to_tm(0, tm); } return 0; @@ -183,7 +183,7 @@ static int rs5c348_probe(struct spi_device *spi) dev_warn(&spi->dev, "voltage-low detected.\n"); if (ret & RS5C348_BIT_XSTP) dev_warn(&spi->dev, "oscillator-stop detected.\n"); - rtc_time_to_tm(0, &tm); /* 1970/1/1 */ + rtc_time64_to_tm(0, &tm); /* 1970/1/1 */ ret = rs5c348_rtc_set_time(&spi->dev, &tm); if (ret < 0) goto kfree_exit; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard@linaro.org> To: benjamin.gaignard@linaro.org Cc: linaro-kernel@lists.linaro.org, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH 36/51] rtc: rs5c348: stop using rtc deprecated functions Date: Tue, 20 Jun 2017 11:35:44 +0200 [thread overview] Message-ID: <1497951359-13334-37-git-send-email-benjamin.gaignard@linaro.org> (raw) In-Reply-To: <1497951359-13334-1-git-send-email-benjamin.gaignard@linaro.org> rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. Stop using those two functions to safer 64bits ones. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> CC: Alessandro Zummo <a.zummo@towertech.it> CC: Alexandre Belloni <alexandre.belloni@free-electrons.com> CC: rtc-linux@googlegroups.com CC: linux-kernel@vger.kernel.org --- drivers/rtc/rtc-rs5c348.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c index 9a30698..f82c0bc 100644 --- a/drivers/rtc/rtc-rs5c348.c +++ b/drivers/rtc/rtc-rs5c348.c @@ -137,7 +137,7 @@ struct rs5c348_plat_data { if (rtc_valid_tm(tm) < 0) { dev_err(&spi->dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, tm); + rtc_time64_to_tm(0, tm); } return 0; @@ -183,7 +183,7 @@ static int rs5c348_probe(struct spi_device *spi) dev_warn(&spi->dev, "voltage-low detected.\n"); if (ret & RS5C348_BIT_XSTP) dev_warn(&spi->dev, "oscillator-stop detected.\n"); - rtc_time_to_tm(0, &tm); /* 1970/1/1 */ + rtc_time64_to_tm(0, &tm); /* 1970/1/1 */ ret = rs5c348_rtc_set_time(&spi->dev, &tm); if (ret < 0) goto kfree_exit; -- 1.9.1 -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2017-06-20 9:46 UTC|newest] Thread overview: 216+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-20 9:35 [PATCH 00/51] rtc: stop using rtc deprecated functions Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 01/51] x86: " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 02/51] x86: intel-mid: vrtc: " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 03/51] net: broadcom: " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 04/51] rtc: 88pm80x: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 05/51] rtc: 88pm860x: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 06/51] rtc: ab-b5ze-s3: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 07/51] rtc: ab8500: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 16:06 ` Linus Walleij 2017-06-20 16:06 ` Linus Walleij 2017-06-20 16:06 ` [rtc-linux] " Linus Walleij 2017-06-21 6:57 ` kbuild test robot 2017-06-21 6:57 ` kbuild test robot 2017-06-21 6:57 ` [rtc-linux] " kbuild test robot 2017-06-20 9:35 ` [PATCH 08/51] rtc: armada38x: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 09/51] rtc: at32ap700x: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 10/51] rtc: at91sam9: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 11/51] rtc: bfin: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 12/51] rtc: coh901331: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 16:07 ` Linus Walleij 2017-06-20 16:07 ` Linus Walleij 2017-06-20 16:07 ` Linus Walleij 2017-06-20 21:21 ` Russell King - ARM Linux 2017-06-20 21:21 ` Russell King - ARM Linux 2017-06-20 21:21 ` [rtc-linux] " Russell King - ARM Linux 2017-06-20 9:35 ` [PATCH 13/51] rtc: cpcap: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-21 4:37 ` kbuild test robot 2017-06-21 4:37 ` [rtc-linux] " kbuild test robot 2017-06-20 9:35 ` [PATCH 14/51] rtc: da9063: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 13:41 ` Steve Twiss 2017-06-20 13:41 ` [rtc-linux] " Steve Twiss 2017-06-20 14:18 ` Benjamin Gaignard 2017-06-20 14:18 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 15/51] " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 16/51] rtc: davinci: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 17/51] rtc: digicolor: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 18/51] rtc: dm355evm: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 19/51] rtc: ds1305: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 20/51] rtc: ds1374: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 21/51] rtc: ds1511: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 22/51] rtc: ds1553: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 23/51] rtc: ds1672: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 24/51] rtc: ds2404: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 25/51] rtc: ep93xx: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 26/51] rtc: gemini: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 27/51] rtc: imxdi: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 28/51] rtc: jz4740: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 29/51] rtc: lpc32xx: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 30/51] rtc: mv: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 31/51] rtc: omap: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 32/51] rtc: pcap: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-21 4:45 ` kbuild test robot 2017-06-21 4:45 ` [rtc-linux] " kbuild test robot 2017-06-21 5:07 ` kbuild test robot 2017-06-21 5:07 ` [rtc-linux] " kbuild test robot 2017-06-20 9:35 ` [PATCH 33/51] rtc: pl030: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 34/51] rtc: pl031: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 16:08 ` Linus Walleij 2017-06-20 16:08 ` Linus Walleij 2017-06-20 16:08 ` [rtc-linux] " Linus Walleij 2017-06-20 21:05 ` Russell King - ARM Linux 2017-06-20 21:05 ` Russell King - ARM Linux 2017-06-20 21:05 ` [rtc-linux] " Russell King - ARM Linux 2017-06-20 9:35 ` [PATCH 35/51] rtc: pm8xxx: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-21 16:54 ` kbuild test robot 2017-06-21 16:54 ` [rtc-linux] " kbuild test robot 2017-07-03 10:12 ` Arnd Bergmann 2017-07-03 10:12 ` [rtc-linux] " Arnd Bergmann 2017-06-20 9:35 ` Benjamin Gaignard [this message] 2017-06-20 9:35 ` [rtc-linux] [PATCH 36/51] rtc: rs5c348: " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 37/51] rtc: sa1100: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 38/51] rtc: sh: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 39/51] rtc: sirfsoc: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 40/51] rtc: snvs: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 41/51] rtc: stk17ta8: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 42/51] rtc: stmp3xxx: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 43/51] rtc: sun6i: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 44/51] rtc: sysfs: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 46/51] rtc: test: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 47/51] rtc: tps6586: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 48/51] rtc: vr41xx: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 49/51] rtc: wm831x: " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 50/51] rtc: xgene " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` [PATCH 51/51] power: suspend test: " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 12:10 ` Pavel Machek 2017-06-20 12:10 ` [rtc-linux] " Pavel Machek [not found] ` <1497951359-13334-1-git-send-email-benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-06-20 9:35 ` [PATCH 45/51] rtc: tegra " Benjamin Gaignard 2017-06-20 9:35 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 9:35 ` Benjamin Gaignard 2017-06-20 10:03 ` [PATCH 00/51] rtc: " Alexandre Belloni 2017-06-20 10:03 ` Alexandre Belloni 2017-06-20 10:03 ` Alexandre Belloni 2017-06-20 10:03 ` [rtc-linux] " Alexandre Belloni 2017-06-20 10:03 ` Alexandre Belloni [not found] ` <20170620100348.zh4ygvjjgnhxvmvl-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> 2017-06-20 10:07 ` Alexandre Belloni 2017-06-20 10:07 ` Alexandre Belloni 2017-06-20 10:07 ` Alexandre Belloni 2017-06-20 10:07 ` [rtc-linux] " Alexandre Belloni 2017-06-20 10:07 ` Alexandre Belloni 2017-06-20 12:10 ` Pavel Machek 2017-06-20 12:10 ` Pavel Machek 2017-06-20 12:10 ` Pavel Machek 2017-06-20 12:10 ` [rtc-linux] " Pavel Machek 2017-06-20 12:10 ` Pavel Machek 2017-06-20 12:24 ` Alexandre Belloni 2017-06-20 12:24 ` Alexandre Belloni 2017-06-20 12:24 ` Alexandre Belloni 2017-06-20 12:24 ` [rtc-linux] " Alexandre Belloni 2017-06-20 12:24 ` Alexandre Belloni [not found] ` <20170620122400.sm7qqvwyj6cuzarw-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> 2017-06-20 13:26 ` Pavel Machek 2017-06-20 13:26 ` Pavel Machek 2017-06-20 13:26 ` Pavel Machek 2017-06-20 13:26 ` [rtc-linux] " Pavel Machek 2017-06-20 13:26 ` Pavel Machek 2017-06-20 13:37 ` Steve Twiss 2017-06-20 13:37 ` Steve Twiss 2017-06-20 13:37 ` Steve Twiss 2017-06-20 13:37 ` [rtc-linux] " Steve Twiss 2017-06-20 13:37 ` Steve Twiss [not found] ` <6ED8E3B22081A4459DAC7699F3695FB7018CD96FCD-68WUHU125fLzLL1Oxlh9IgLouzNaz+3S@public.gmane.org> 2017-06-20 13:44 ` Pavel Machek 2017-06-20 13:44 ` Pavel Machek 2017-06-20 13:44 ` Pavel Machek 2017-06-20 13:44 ` [rtc-linux] " Pavel Machek 2017-06-20 13:44 ` Pavel Machek 2017-06-20 13:48 ` Alexandre Belloni 2017-06-20 13:48 ` Alexandre Belloni 2017-06-20 13:48 ` Alexandre Belloni 2017-06-20 13:48 ` [rtc-linux] " Alexandre Belloni 2017-06-20 13:48 ` Alexandre Belloni [not found] ` <20170620134827.ubvzhh25klaotupv-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> 2017-06-20 15:07 ` Benjamin Gaignard 2017-06-20 15:07 ` Benjamin Gaignard 2017-06-20 15:07 ` Benjamin Gaignard 2017-06-20 15:07 ` [rtc-linux] " Benjamin Gaignard 2017-06-20 15:07 ` Benjamin Gaignard [not found] ` <CA+M3ks68+z6nDtYM8CDpso7SxjB6Nt5E=rOc1yxx=kDz6PUeVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-06-20 21:15 ` Russell King - ARM Linux 2017-06-20 21:15 ` Russell King - ARM Linux 2017-06-20 21:15 ` Russell King - ARM Linux 2017-06-20 21:15 ` [rtc-linux] " Russell King - ARM Linux 2017-06-20 21:15 ` Russell King - ARM Linux [not found] ` <20170620211536.GM4902-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org> 2017-06-21 9:26 ` David Laight 2017-06-21 9:26 ` David Laight 2017-06-21 9:26 ` David Laight 2017-06-21 9:26 ` [rtc-linux] " David Laight 2017-06-21 9:26 ` David Laight [not found] ` <063D6719AE5E284EB5DD2968C1650D6DD00278C0-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org> 2017-06-21 9:35 ` Russell King - ARM Linux 2017-06-21 9:35 ` Russell King - ARM Linux 2017-06-21 9:35 ` [rtc-linux] " Russell King - ARM Linux 2017-06-21 9:35 ` Russell King - ARM Linux 2017-06-20 22:08 ` Pavel Machek 2017-06-20 22:08 ` Pavel Machek 2017-06-20 22:08 ` Pavel Machek 2017-06-20 22:08 ` [rtc-linux] " Pavel Machek 2017-06-20 22:08 ` Pavel Machek 2017-06-21 9:14 ` Benjamin Gaignard 2017-06-21 9:14 ` Benjamin Gaignard 2017-06-21 9:14 ` [rtc-linux] " Benjamin Gaignard 2017-06-21 9:14 ` Benjamin Gaignard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1497951359-13334-37-git-send-email-benjamin.gaignard@linaro.org \ --to=benjamin.gaignard@linaro.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@free-electrons.com \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rtc-linux@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.