From: Ryder Lee <ryder.lee@mediatek.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
<devicetree@vger.kernel.org>, Red Hung <red.hung@mediatek.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support
Date: Thu, 29 Jun 2017 10:00:23 +0800 [thread overview]
Message-ID: <1498701623.32475.9.camel@mtkswgap22> (raw)
In-Reply-To: <20170628195325.GR17844@bhelgaas-glaptop.roam.corp.google.com>
On Wed, 2017-06-28 at 14:53 -0500, Bjorn Helgaas wrote:
> On Sun, May 21, 2017 at 11:42:24AM +0800, Ryder Lee wrote:
> > Add support for the Mediatek PCIe Gen2 controller which can
> > be found on MT7623 series SoCs.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> > drivers/pci/host/Kconfig | 11 +
> > drivers/pci/host/Makefile | 1 +
> > drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 565 insertions(+)
> > create mode 100644 drivers/pci/host/pcie-mediatek.c
> >...
>
> > +static int mtk_pcie_register_host(struct pci_host_bridge *host)
> > +{
> > + struct mtk_pcie *pcie = pci_host_bridge_priv(host);
> > + struct pci_bus *child;
> > + int err;
> > +
> > + pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
>
> Do you really need the PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS
> flags? I'd like to get rid of them because we should automatically
> assign resources if the firmware hasn't done it.
>
> Bjorn
You're right! These flags are not needed and should be removed.
Thanks for catching that.
Ryder
WARNING: multiple messages have this Message-ID (diff)
From: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Bjorn Helgaas <helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Red Hung <red.hung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support
Date: Thu, 29 Jun 2017 10:00:23 +0800 [thread overview]
Message-ID: <1498701623.32475.9.camel@mtkswgap22> (raw)
In-Reply-To: <20170628195325.GR17844-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
On Wed, 2017-06-28 at 14:53 -0500, Bjorn Helgaas wrote:
> On Sun, May 21, 2017 at 11:42:24AM +0800, Ryder Lee wrote:
> > Add support for the Mediatek PCIe Gen2 controller which can
> > be found on MT7623 series SoCs.
> >
> > Signed-off-by: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > drivers/pci/host/Kconfig | 11 +
> > drivers/pci/host/Makefile | 1 +
> > drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 565 insertions(+)
> > create mode 100644 drivers/pci/host/pcie-mediatek.c
> >...
>
> > +static int mtk_pcie_register_host(struct pci_host_bridge *host)
> > +{
> > + struct mtk_pcie *pcie = pci_host_bridge_priv(host);
> > + struct pci_bus *child;
> > + int err;
> > +
> > + pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
>
> Do you really need the PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS
> flags? I'd like to get rid of them because we should automatically
> assign resources if the firmware hasn't done it.
>
> Bjorn
You're right! These flags are not needed and should be removed.
Thanks for catching that.
Ryder
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ryder.lee@mediatek.com (Ryder Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support
Date: Thu, 29 Jun 2017 10:00:23 +0800 [thread overview]
Message-ID: <1498701623.32475.9.camel@mtkswgap22> (raw)
In-Reply-To: <20170628195325.GR17844@bhelgaas-glaptop.roam.corp.google.com>
On Wed, 2017-06-28 at 14:53 -0500, Bjorn Helgaas wrote:
> On Sun, May 21, 2017 at 11:42:24AM +0800, Ryder Lee wrote:
> > Add support for the Mediatek PCIe Gen2 controller which can
> > be found on MT7623 series SoCs.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> > drivers/pci/host/Kconfig | 11 +
> > drivers/pci/host/Makefile | 1 +
> > drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 565 insertions(+)
> > create mode 100644 drivers/pci/host/pcie-mediatek.c
> >...
>
> > +static int mtk_pcie_register_host(struct pci_host_bridge *host)
> > +{
> > + struct mtk_pcie *pcie = pci_host_bridge_priv(host);
> > + struct pci_bus *child;
> > + int err;
> > +
> > + pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
>
> Do you really need the PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS
> flags? I'd like to get rid of them because we should automatically
> assign resources if the firmware hasn't done it.
>
> Bjorn
You're right! These flags are not needed and should be removed.
Thanks for catching that.
Ryder
next prev parent reply other threads:[~2017-06-29 2:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 3:42 [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-06-28 19:53 ` Bjorn Helgaas
2017-06-28 19:53 ` Bjorn Helgaas
2017-06-28 19:53 ` Bjorn Helgaas
2017-06-28 19:53 ` Bjorn Helgaas
2017-06-29 2:00 ` Ryder Lee [this message]
2017-06-29 2:00 ` Ryder Lee
2017-06-29 2:00 ` Ryder Lee
2017-05-21 3:42 ` [PATCH v5 2/2] dt-bindings: pcie: Add documentation for Mediatek PCIe Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-24 21:56 ` [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs Bjorn Helgaas
2017-05-24 21:56 ` Bjorn Helgaas
2017-05-24 21:56 ` Bjorn Helgaas
2017-05-24 21:56 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498701623.32475.9.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=red.hung@mediatek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.