From: Bjorn Helgaas <helgaas@kernel.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, Red Hung <red.hung@mediatek.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs
Date: Wed, 24 May 2017 16:56:41 -0500 [thread overview]
Message-ID: <20170524215641.GE2794@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1495338145-9384-1-git-send-email-ryder.lee@mediatek.com>
On Sun, May 21, 2017 at 11:42:23AM +0800, Ryder Lee wrote:
> Hi,
>
> This patch series add Mediatek Gen2 PCIe host controller driver and
> dt-binding document. It can be found on MT7623 series SoCs.
>
> This driver was validated using Broadcom Tigon3 and Intel(R) 82575/82576
> gigabit ethernet card.
>
>
> Changes since v5:
> - rebase to Linux 4.12-rc1.
> - remove redundant module.h header and MODULE macros.
>
> Changes since v4:
> - move the per-port registers to the parent node.
> - use a valid compatible for hifsys controller.
> - use the 'sysirq' instead of 'gic' as a correct 'interrupt-parent' of the
> interrupt-map properties.
>
> 'sysirq' is an interrupt-controller that could help us to reverse GIC SPIs polarity
> so that we could properly set irq type to level low without any extra properties.
> It was a mistake to select wrong interrupt-parent on the previous versions.
> Now, we could remove unnecessary interrupt properties entirely from binding.
>
> Changes since v3:
> - correct sub-nodes unit addresses.
>
> Changes since v2:
> - modify Kconfig to avoid kbuild test error on some architecture.
> - change compatible string.
> - revise binding document:
> add missing interrupt-names.
> remove the board dts example and drop 'status' properties.
> remove unnecessary descriptions bout standard PCI bus binding.
>
> Changes since v1:
> - add .suppress_bind_attrs.
> - remove unnecessary *_valid_device() pattern.
> - remove PCI_PROBE_ONLY.
> - use the regular readl() instead of readl_relaxed().
> - add .map_bus() and change to use pci_generic_config_read/pci_generic_config_write.
> - revise dt-binding document and move nonstandard properties to root node.
> - change compatible string.
> - use interrupt-map property and replace mtk_pcie_map_irq() with of_irq_parse_and_map_pci().
> - use the new pci_register_host_bridge() method instead of pci_scan_root_bus()*
>
> Ryder Lee (2):
> PCI: mediatek: Add Mediatek PCIe host controller support
> dt-bindings: pcie: Add documentation for Mediatek PCIe
>
> .../bindings/pci/mediatek,mt7623-pcie.txt | 130 +++++
> drivers/pci/host/Kconfig | 11 +
> drivers/pci/host/Makefile | 1 +
> drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++
> 4 files changed, 695 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/mediatek,mt7623-pcie.txt
> create mode 100644 drivers/pci/host/pcie-mediatek.c
Applied to pci/host-mediatek for v4.13, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Red Hung <red.hung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs
Date: Wed, 24 May 2017 16:56:41 -0500 [thread overview]
Message-ID: <20170524215641.GE2794@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1495338145-9384-1-git-send-email-ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Sun, May 21, 2017 at 11:42:23AM +0800, Ryder Lee wrote:
> Hi,
>
> This patch series add Mediatek Gen2 PCIe host controller driver and
> dt-binding document. It can be found on MT7623 series SoCs.
>
> This driver was validated using Broadcom Tigon3 and Intel(R) 82575/82576
> gigabit ethernet card.
>
>
> Changes since v5:
> - rebase to Linux 4.12-rc1.
> - remove redundant module.h header and MODULE macros.
>
> Changes since v4:
> - move the per-port registers to the parent node.
> - use a valid compatible for hifsys controller.
> - use the 'sysirq' instead of 'gic' as a correct 'interrupt-parent' of the
> interrupt-map properties.
>
> 'sysirq' is an interrupt-controller that could help us to reverse GIC SPIs polarity
> so that we could properly set irq type to level low without any extra properties.
> It was a mistake to select wrong interrupt-parent on the previous versions.
> Now, we could remove unnecessary interrupt properties entirely from binding.
>
> Changes since v3:
> - correct sub-nodes unit addresses.
>
> Changes since v2:
> - modify Kconfig to avoid kbuild test error on some architecture.
> - change compatible string.
> - revise binding document:
> add missing interrupt-names.
> remove the board dts example and drop 'status' properties.
> remove unnecessary descriptions bout standard PCI bus binding.
>
> Changes since v1:
> - add .suppress_bind_attrs.
> - remove unnecessary *_valid_device() pattern.
> - remove PCI_PROBE_ONLY.
> - use the regular readl() instead of readl_relaxed().
> - add .map_bus() and change to use pci_generic_config_read/pci_generic_config_write.
> - revise dt-binding document and move nonstandard properties to root node.
> - change compatible string.
> - use interrupt-map property and replace mtk_pcie_map_irq() with of_irq_parse_and_map_pci().
> - use the new pci_register_host_bridge() method instead of pci_scan_root_bus()*
>
> Ryder Lee (2):
> PCI: mediatek: Add Mediatek PCIe host controller support
> dt-bindings: pcie: Add documentation for Mediatek PCIe
>
> .../bindings/pci/mediatek,mt7623-pcie.txt | 130 +++++
> drivers/pci/host/Kconfig | 11 +
> drivers/pci/host/Makefile | 1 +
> drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++
> 4 files changed, 695 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/mediatek,mt7623-pcie.txt
> create mode 100644 drivers/pci/host/pcie-mediatek.c
Applied to pci/host-mediatek for v4.13, thanks!
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: devicetree@vger.kernel.org, Red Hung <red.hung@mediatek.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs
Date: Wed, 24 May 2017 16:56:41 -0500 [thread overview]
Message-ID: <20170524215641.GE2794@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1495338145-9384-1-git-send-email-ryder.lee@mediatek.com>
On Sun, May 21, 2017 at 11:42:23AM +0800, Ryder Lee wrote:
> Hi,
>
> This patch series add Mediatek Gen2 PCIe host controller driver and
> dt-binding document. It can be found on MT7623 series SoCs.
>
> This driver was validated using Broadcom Tigon3 and Intel(R) 82575/82576
> gigabit ethernet card.
>
>
> Changes since v5:
> - rebase to Linux 4.12-rc1.
> - remove redundant module.h header and MODULE macros.
>
> Changes since v4:
> - move the per-port registers to the parent node.
> - use a valid compatible for hifsys controller.
> - use the 'sysirq' instead of 'gic' as a correct 'interrupt-parent' of the
> interrupt-map properties.
>
> 'sysirq' is an interrupt-controller that could help us to reverse GIC SPIs polarity
> so that we could properly set irq type to level low without any extra properties.
> It was a mistake to select wrong interrupt-parent on the previous versions.
> Now, we could remove unnecessary interrupt properties entirely from binding.
>
> Changes since v3:
> - correct sub-nodes unit addresses.
>
> Changes since v2:
> - modify Kconfig to avoid kbuild test error on some architecture.
> - change compatible string.
> - revise binding document:
> add missing interrupt-names.
> remove the board dts example and drop 'status' properties.
> remove unnecessary descriptions bout standard PCI bus binding.
>
> Changes since v1:
> - add .suppress_bind_attrs.
> - remove unnecessary *_valid_device() pattern.
> - remove PCI_PROBE_ONLY.
> - use the regular readl() instead of readl_relaxed().
> - add .map_bus() and change to use pci_generic_config_read/pci_generic_config_write.
> - revise dt-binding document and move nonstandard properties to root node.
> - change compatible string.
> - use interrupt-map property and replace mtk_pcie_map_irq() with of_irq_parse_and_map_pci().
> - use the new pci_register_host_bridge() method instead of pci_scan_root_bus()*
>
> Ryder Lee (2):
> PCI: mediatek: Add Mediatek PCIe host controller support
> dt-bindings: pcie: Add documentation for Mediatek PCIe
>
> .../bindings/pci/mediatek,mt7623-pcie.txt | 130 +++++
> drivers/pci/host/Kconfig | 11 +
> drivers/pci/host/Makefile | 1 +
> drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++
> 4 files changed, 695 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/mediatek,mt7623-pcie.txt
> create mode 100644 drivers/pci/host/pcie-mediatek.c
Applied to pci/host-mediatek for v4.13, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs
Date: Wed, 24 May 2017 16:56:41 -0500 [thread overview]
Message-ID: <20170524215641.GE2794@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1495338145-9384-1-git-send-email-ryder.lee@mediatek.com>
On Sun, May 21, 2017 at 11:42:23AM +0800, Ryder Lee wrote:
> Hi,
>
> This patch series add Mediatek Gen2 PCIe host controller driver and
> dt-binding document. It can be found on MT7623 series SoCs.
>
> This driver was validated using Broadcom Tigon3 and Intel(R) 82575/82576
> gigabit ethernet card.
>
>
> Changes since v5:
> - rebase to Linux 4.12-rc1.
> - remove redundant module.h header and MODULE macros.
>
> Changes since v4:
> - move the per-port registers to the parent node.
> - use a valid compatible for hifsys controller.
> - use the 'sysirq' instead of 'gic' as a correct 'interrupt-parent' of the
> interrupt-map properties.
>
> 'sysirq' is an interrupt-controller that could help us to reverse GIC SPIs polarity
> so that we could properly set irq type to level low without any extra properties.
> It was a mistake to select wrong interrupt-parent on the previous versions.
> Now, we could remove unnecessary interrupt properties entirely from binding.
>
> Changes since v3:
> - correct sub-nodes unit addresses.
>
> Changes since v2:
> - modify Kconfig to avoid kbuild test error on some architecture.
> - change compatible string.
> - revise binding document:
> add missing interrupt-names.
> remove the board dts example and drop 'status' properties.
> remove unnecessary descriptions bout standard PCI bus binding.
>
> Changes since v1:
> - add .suppress_bind_attrs.
> - remove unnecessary *_valid_device() pattern.
> - remove PCI_PROBE_ONLY.
> - use the regular readl() instead of readl_relaxed().
> - add .map_bus() and change to use pci_generic_config_read/pci_generic_config_write.
> - revise dt-binding document and move nonstandard properties to root node.
> - change compatible string.
> - use interrupt-map property and replace mtk_pcie_map_irq() with of_irq_parse_and_map_pci().
> - use the new pci_register_host_bridge() method instead of pci_scan_root_bus()*
>
> Ryder Lee (2):
> PCI: mediatek: Add Mediatek PCIe host controller support
> dt-bindings: pcie: Add documentation for Mediatek PCIe
>
> .../bindings/pci/mediatek,mt7623-pcie.txt | 130 +++++
> drivers/pci/host/Kconfig | 11 +
> drivers/pci/host/Makefile | 1 +
> drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++
> 4 files changed, 695 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/mediatek,mt7623-pcie.txt
> create mode 100644 drivers/pci/host/pcie-mediatek.c
Applied to pci/host-mediatek for v4.13, thanks!
next prev parent reply other threads:[~2017-05-24 21:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 3:42 [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-06-28 19:53 ` Bjorn Helgaas
2017-06-28 19:53 ` Bjorn Helgaas
2017-06-28 19:53 ` Bjorn Helgaas
2017-06-28 19:53 ` Bjorn Helgaas
2017-06-29 2:00 ` Ryder Lee
2017-06-29 2:00 ` Ryder Lee
2017-06-29 2:00 ` Ryder Lee
2017-05-21 3:42 ` [PATCH v5 2/2] dt-bindings: pcie: Add documentation for Mediatek PCIe Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-21 3:42 ` Ryder Lee
2017-05-24 21:56 ` Bjorn Helgaas [this message]
2017-05-24 21:56 ` [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs Bjorn Helgaas
2017-05-24 21:56 ` Bjorn Helgaas
2017-05-24 21:56 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524215641.GE2794@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=red.hung@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.