From: Paul Kocialkowski <contact@paulk.fr>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
linux-kernel@vger.kernel.org,
Mikko Perttunen <mperttunen@nvidia.com>,
linux-tegra@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124
Date: Mon, 10 Jul 2017 09:05:39 +0300 [thread overview]
Message-ID: <1499666739.1313.1.camel@paulk.fr> (raw)
In-Reply-To: <20170710052140.GA18089@ulmo.fritz.box>
[-- Attachment #1.1: Type: text/plain, Size: 1926 bytes --]
Le lundi 10 juillet 2017 à 07:21 +0200, Thierry Reding a écrit :
> On Sun, Jul 09, 2017 at 07:36:14PM +0300, Paul Kocialkowski wrote:
> > This registers the host1x node with the SMMU (as HC swgroup) to
> > allow
> > the host1x code to attach to it. It avoid failing the probe
> > sequence,
> > which resulted in the tegra drm driver not probing and thus nothing
> > being displayed on-screen.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> > arch/arm/boot/dts/tegra124.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
>
> Thanks for tracking this down. However, I don't think this is an
> appropriate fix for v4.12 because it requires an update to the DTB in
> order to preserve functionality, which means we've broken DT ABI. The
> proper fix I think needs to be to make usage of the IOMMU completely
> optional in the host1x driver.
I see, that makes sense.
> So I think what happens without this DT change is that the call to
> iommu_attach_device() fails and we have no way to recover from that.
That is exactly what is happening, indeed.
> I think what we need to do is to free the domain in that case and make
> sure we can continue without one. It's probably best to add an error
> message, or maybe a warning to make sure people are aware.
By freeing the domain, do you mean continuing without IOMMU support?
If so, then we should make sure to only behave that way for -ENODEV and
generally still fail for other errors.
> Do you have the time to address this? If not, perhaps Mikko can take a
> look?
I can craft a patch this evening, but if someone else wants to work on
it earlier, they are totally welcome to do it!
--
Paul Kocialkowski,
developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <contact@paulk.fr>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: Re: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124
Date: Mon, 10 Jul 2017 09:05:39 +0300 [thread overview]
Message-ID: <1499666739.1313.1.camel@paulk.fr> (raw)
In-Reply-To: <20170710052140.GA18089@ulmo.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]
Le lundi 10 juillet 2017 à 07:21 +0200, Thierry Reding a écrit :
> On Sun, Jul 09, 2017 at 07:36:14PM +0300, Paul Kocialkowski wrote:
> > This registers the host1x node with the SMMU (as HC swgroup) to
> > allow
> > the host1x code to attach to it. It avoid failing the probe
> > sequence,
> > which resulted in the tegra drm driver not probing and thus nothing
> > being displayed on-screen.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> > arch/arm/boot/dts/tegra124.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
>
> Thanks for tracking this down. However, I don't think this is an
> appropriate fix for v4.12 because it requires an update to the DTB in
> order to preserve functionality, which means we've broken DT ABI. The
> proper fix I think needs to be to make usage of the IOMMU completely
> optional in the host1x driver.
I see, that makes sense.
> So I think what happens without this DT change is that the call to
> iommu_attach_device() fails and we have no way to recover from that.
That is exactly what is happening, indeed.
> I think what we need to do is to free the domain in that case and make
> sure we can continue without one. It's probably best to add an error
> message, or maybe a warning to make sure people are aware.
By freeing the domain, do you mean continuing without IOMMU support?
If so, then we should make sure to only behave that way for -ENODEV and
generally still fail for other errors.
> Do you have the time to address this? If not, perhaps Mikko can take a
> look?
I can craft a patch this evening, but if someone else wants to work on
it earlier, they are totally welcome to do it!
--
Paul Kocialkowski,
developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: contact@paulk.fr (Paul Kocialkowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124
Date: Mon, 10 Jul 2017 09:05:39 +0300 [thread overview]
Message-ID: <1499666739.1313.1.camel@paulk.fr> (raw)
In-Reply-To: <20170710052140.GA18089@ulmo.fritz.box>
Le lundi 10 juillet 2017 ? 07:21 +0200, Thierry Reding a ?crit :
> On Sun, Jul 09, 2017 at 07:36:14PM +0300, Paul Kocialkowski wrote:
> > This registers the host1x node with the SMMU (as HC swgroup) to
> > allow
> > the host1x code to attach to it. It avoid failing the probe
> > sequence,
> > which resulted in the tegra drm driver not probing and thus nothing
> > being displayed on-screen.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> > arch/arm/boot/dts/tegra124.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
>
> Thanks for tracking this down. However, I don't think this is an
> appropriate fix for v4.12 because it requires an update to the DTB in
> order to preserve functionality, which means we've broken DT ABI. The
> proper fix I think needs to be to make usage of the IOMMU completely
> optional in the host1x driver.
I see, that makes sense.
> So I think what happens without this DT change is that the call to
> iommu_attach_device() fails and we have no way to recover from that.
That is exactly what is happening, indeed.
> I think what we need to do is to free the domain in that case and make
> sure we can continue without one. It's probably best to add an error
> message, or maybe a warning to make sure people are aware.
By freeing the domain, do you mean continuing without IOMMU support?
If so, then we should make sure to only behave that way for -ENODEV and
generally still fail for other errors.
> Do you have the time to address this? If not, perhaps Mikko can take a
> look?
I can craft a patch this evening, but if someone else wants to work on
it earlier, they are totally welcome to do it!
--
Paul Kocialkowski,
developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170710/4b70d545/attachment.sig>
next prev parent reply other threads:[~2017-07-10 6:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 16:36 [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124 Paul Kocialkowski
2017-07-09 16:36 ` Paul Kocialkowski
2017-07-09 16:36 ` Paul Kocialkowski
[not found] ` <20170709163614.6746-1-contact-W9ppeneeCTY@public.gmane.org>
2017-07-10 5:21 ` Thierry Reding
2017-07-10 5:21 ` Thierry Reding
2017-07-10 5:21 ` Thierry Reding
2017-07-10 6:05 ` Paul Kocialkowski [this message]
2017-07-10 6:05 ` Paul Kocialkowski
2017-07-10 6:05 ` Paul Kocialkowski
2017-07-11 8:50 ` Paul Kocialkowski
2017-07-11 8:50 ` Paul Kocialkowski
2017-07-11 8:50 ` Paul Kocialkowski
[not found] ` <1499763009.1340.11.camel-W9ppeneeCTY@public.gmane.org>
2017-07-11 14:54 ` Marcel Ziswiler
2017-07-11 14:54 ` Marcel Ziswiler
2017-07-11 14:54 ` Marcel Ziswiler
2017-07-11 15:05 ` Paul Kocialkowski
2017-07-11 15:05 ` Paul Kocialkowski
2017-07-11 15:05 ` Paul Kocialkowski
2017-07-11 15:17 ` Marcel Ziswiler
2017-07-11 15:17 ` Marcel Ziswiler
2017-07-11 15:17 ` Marcel Ziswiler
2017-07-31 15:23 ` Thierry Reding
2017-07-31 15:23 ` Thierry Reding
2017-07-31 15:23 ` Thierry Reding
2017-08-01 9:56 ` Paul Kocialkowski
2017-08-01 9:56 ` Paul Kocialkowski
2017-08-01 9:56 ` Paul Kocialkowski
2017-07-31 14:48 ` Thierry Reding
2017-07-31 14:48 ` Thierry Reding
2017-07-31 14:48 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499666739.1313.1.camel@paulk.fr \
--to=contact@paulk.fr \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.