All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jonathan Hunter
	<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Mikko Perttunen
	<mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124
Date: Mon, 10 Jul 2017 07:21:40 +0200	[thread overview]
Message-ID: <20170710052140.GA18089@ulmo.fritz.box> (raw)
In-Reply-To: <20170709163614.6746-1-contact-W9ppeneeCTY@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On Sun, Jul 09, 2017 at 07:36:14PM +0300, Paul Kocialkowski wrote:
> This registers the host1x node with the SMMU (as HC swgroup) to allow
> the host1x code to attach to it. It avoid failing the probe sequence,
> which resulted in the tegra drm driver not probing and thus nothing
> being displayed on-screen.
> 
> Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> ---
>  arch/arm/boot/dts/tegra124.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Thanks for tracking this down. However, I don't think this is an
appropriate fix for v4.12 because it requires an update to the DTB in
order to preserve functionality, which means we've broken DT ABI. The
proper fix I think needs to be to make usage of the IOMMU completely
optional in the host1x driver.

So I think what happens without this DT change is that the call to
iommu_attach_device() fails and we have no way to recover from that. I
think what we need to do is to free the domain in that case and make
sure we can continue without one. It's probably best to add an error
message, or maybe a warning to make sure people are aware.

Do you have the time to address this? If not, perhaps Mikko can take a
look?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Paul Kocialkowski <contact@paulk.fr>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Mikko Perttunen <mperttunen@nvidia.com>
Subject: Re: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124
Date: Mon, 10 Jul 2017 07:21:40 +0200	[thread overview]
Message-ID: <20170710052140.GA18089@ulmo.fritz.box> (raw)
In-Reply-To: <20170709163614.6746-1-contact@paulk.fr>

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]

On Sun, Jul 09, 2017 at 07:36:14PM +0300, Paul Kocialkowski wrote:
> This registers the host1x node with the SMMU (as HC swgroup) to allow
> the host1x code to attach to it. It avoid failing the probe sequence,
> which resulted in the tegra drm driver not probing and thus nothing
> being displayed on-screen.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  arch/arm/boot/dts/tegra124.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Thanks for tracking this down. However, I don't think this is an
appropriate fix for v4.12 because it requires an update to the DTB in
order to preserve functionality, which means we've broken DT ABI. The
proper fix I think needs to be to make usage of the IOMMU completely
optional in the host1x driver.

So I think what happens without this DT change is that the call to
iommu_attach_device() fails and we have no way to recover from that. I
think what we need to do is to free the domain in that case and make
sure we can continue without one. It's probably best to add an error
message, or maybe a warning to make sure people are aware.

Do you have the time to address this? If not, perhaps Mikko can take a
look?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124
Date: Mon, 10 Jul 2017 07:21:40 +0200	[thread overview]
Message-ID: <20170710052140.GA18089@ulmo.fritz.box> (raw)
In-Reply-To: <20170709163614.6746-1-contact@paulk.fr>

On Sun, Jul 09, 2017 at 07:36:14PM +0300, Paul Kocialkowski wrote:
> This registers the host1x node with the SMMU (as HC swgroup) to allow
> the host1x code to attach to it. It avoid failing the probe sequence,
> which resulted in the tegra drm driver not probing and thus nothing
> being displayed on-screen.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  arch/arm/boot/dts/tegra124.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Thanks for tracking this down. However, I don't think this is an
appropriate fix for v4.12 because it requires an update to the DTB in
order to preserve functionality, which means we've broken DT ABI. The
proper fix I think needs to be to make usage of the IOMMU completely
optional in the host1x driver.

So I think what happens without this DT change is that the call to
iommu_attach_device() fails and we have no way to recover from that. I
think what we need to do is to free the domain in that case and make
sure we can continue without one. It's probably best to add an error
message, or maybe a warning to make sure people are aware.

Do you have the time to address this? If not, perhaps Mikko can take a
look?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170710/59e471ab/attachment.sig>

  parent reply	other threads:[~2017-07-10  5:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-09 16:36 [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124 Paul Kocialkowski
2017-07-09 16:36 ` Paul Kocialkowski
2017-07-09 16:36 ` Paul Kocialkowski
     [not found] ` <20170709163614.6746-1-contact-W9ppeneeCTY@public.gmane.org>
2017-07-10  5:21   ` Thierry Reding [this message]
2017-07-10  5:21     ` Thierry Reding
2017-07-10  5:21     ` Thierry Reding
2017-07-10  6:05     ` Paul Kocialkowski
2017-07-10  6:05       ` Paul Kocialkowski
2017-07-10  6:05       ` Paul Kocialkowski
2017-07-11  8:50   ` Paul Kocialkowski
2017-07-11  8:50     ` Paul Kocialkowski
2017-07-11  8:50     ` Paul Kocialkowski
     [not found]     ` <1499763009.1340.11.camel-W9ppeneeCTY@public.gmane.org>
2017-07-11 14:54       ` Marcel Ziswiler
2017-07-11 14:54         ` Marcel Ziswiler
2017-07-11 14:54         ` Marcel Ziswiler
2017-07-11 15:05         ` Paul Kocialkowski
2017-07-11 15:05           ` Paul Kocialkowski
2017-07-11 15:05           ` Paul Kocialkowski
2017-07-11 15:17           ` Marcel Ziswiler
2017-07-11 15:17             ` Marcel Ziswiler
2017-07-11 15:17             ` Marcel Ziswiler
2017-07-31 15:23             ` Thierry Reding
2017-07-31 15:23               ` Thierry Reding
2017-07-31 15:23               ` Thierry Reding
2017-08-01  9:56               ` Paul Kocialkowski
2017-08-01  9:56                 ` Paul Kocialkowski
2017-08-01  9:56                 ` Paul Kocialkowski
2017-07-31 14:48   ` Thierry Reding
2017-07-31 14:48     ` Thierry Reding
2017-07-31 14:48     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710052140.GA18089@ulmo.fritz.box \
    --to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=contact-W9ppeneeCTY@public.gmane.org \
    --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.