All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kni: fix build on RHEL 7.6-ALT on IBM POWER9
@ 2018-12-21  6:03 David Zeng
  2018-12-21 14:34 ` Ferruh Yigit
  2018-12-21 16:15 ` [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT David Zeng
  0 siblings, 2 replies; 9+ messages in thread
From: David Zeng @ 2018-12-21  6:03 UTC (permalink / raw)
  To: dev; +Cc: David Zeng

Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
---
 kernel/linux/kni/compat.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 5aadebb..1afa3b8 100644
--- a/kernel/linux/kni/compat.h
+++ b/kernel/linux/kni/compat.h
@@ -102,8 +102,14 @@
 #undef NET_NAME_UNKNOWN
 #endif
 
+/*
+ * RHEL has two different version with different kernel version: 
+ * 3.10 is for AMD, Intel, IBM POWER7 and POWER8;
+ * 4.14 is for ARM and IBM POWER9
+ */
 #if (defined(RHEL_RELEASE_CODE) && \
-	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+	(LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
 #define ndo_change_mtu ndo_change_mtu_rh74
 #endif
 
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] kni: fix build on RHEL 7.6-ALT on IBM POWER9
  2018-12-21  6:03 [PATCH] kni: fix build on RHEL 7.6-ALT on IBM POWER9 David Zeng
@ 2018-12-21 14:34 ` Ferruh Yigit
  2018-12-21 16:15 ` [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT David Zeng
  1 sibling, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2018-12-21 14:34 UTC (permalink / raw)
  To: David Zeng, dev; +Cc: David Zeng

On 12/21/2018 6:03 AM, David Zeng wrote:
> Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
> ---
>  kernel/linux/kni/compat.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> index 5aadebb..1afa3b8 100644
> --- a/kernel/linux/kni/compat.h
> +++ b/kernel/linux/kni/compat.h
> @@ -102,8 +102,14 @@
>  #undef NET_NAME_UNKNOWN
>  #endif
>  
> +/*
> + * RHEL has two different version with different kernel version: 
> + * 3.10 is for AMD, Intel, IBM POWER7 and POWER8;
> + * 4.14 is for ARM and IBM POWER9
> + */
>  #if (defined(RHEL_RELEASE_CODE) && \
> -	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
> +	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
> +	(LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
>  #define ndo_change_mtu ndo_change_mtu_rh74
>  #endif

Do you need to update 'kernel/linux/kni/ethtool/igb/kcompat.h' for same check?

Also there is another update on same line for RHEL8 fix [1], if you can rebase
on top of it makes maintainers life easier.

[1] https://patches.dpdk.org/patch/49104/

Thanks,
ferruh

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT
  2018-12-21  6:03 [PATCH] kni: fix build on RHEL 7.6-ALT on IBM POWER9 David Zeng
  2018-12-21 14:34 ` Ferruh Yigit
@ 2018-12-21 16:15 ` David Zeng
  2018-12-21 16:15   ` David Zeng
  1 sibling, 1 reply; 9+ messages in thread
From: David Zeng @ 2018-12-21 16:15 UTC (permalink / raw)
  To: dev


Thanks, Ferruh!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT
  2018-12-21 16:15 ` [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT David Zeng
@ 2018-12-21 16:15   ` David Zeng
  2018-12-21 16:27     ` David Zeng
  2018-12-21 16:27     ` Ferruh Yigit
  0 siblings, 2 replies; 9+ messages in thread
From: David Zeng @ 2018-12-21 16:15 UTC (permalink / raw)
  To: dev; +Cc: David Zeng

Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
---
 kernel/linux/kni/compat.h              | 9 ++++++++-
 kernel/linux/kni/ethtool/igb/kcompat.h | 4 +++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 5aadebb..3c575c7 100644
--- a/kernel/linux/kni/compat.h
+++ b/kernel/linux/kni/compat.h
@@ -102,8 +102,15 @@
 #undef NET_NAME_UNKNOWN
 #endif
 
+/*
+ * RHEL has two different version with different kernel version:
+ * 3.10 is for AMD, Intel, IBM POWER7 and POWER8;
+ * 4.14 is for ARM and IBM POWER9
+ */
 #if (defined(RHEL_RELEASE_CODE) && \
-	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \
+	(LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
 #define ndo_change_mtu ndo_change_mtu_rh74
 #endif
 
diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
index ae1b530..3c0c8e3 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux/kni/ethtool/igb/kcompat.h
@@ -3930,7 +3930,9 @@ static inline struct sk_buff *__kc__vlan_hwaccel_put_tag(struct sk_buff *skb,
 #endif
 
 #if (defined(RHEL_RELEASE_CODE) && \
-	(RHEL_RELEASE_VERSION(7, 5) <= RHEL_RELEASE_CODE))
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+        (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \
+        (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
 #define ndo_change_mtu ndo_change_mtu_rh74
 #endif
 
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* kni: fix build on RHEL8 and RHEL7.6-ALT
  2018-12-21 16:15   ` David Zeng
@ 2018-12-21 16:27     ` David Zeng
  2018-12-21 16:27       ` [PATCH] " David Zeng
  2018-12-21 16:27     ` Ferruh Yigit
  1 sibling, 1 reply; 9+ messages in thread
From: David Zeng @ 2018-12-21 16:27 UTC (permalink / raw)
  To: dev

Fix the coding style.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT
  2018-12-21 16:27     ` David Zeng
@ 2018-12-21 16:27       ` David Zeng
  2018-12-21 17:02         ` Ferruh Yigit
  0 siblings, 1 reply; 9+ messages in thread
From: David Zeng @ 2018-12-21 16:27 UTC (permalink / raw)
  To: dev; +Cc: David Zeng

Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
---
 kernel/linux/kni/compat.h              | 9 ++++++++-
 kernel/linux/kni/ethtool/igb/kcompat.h | 4 +++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 5aadebb..3c575c7 100644
--- a/kernel/linux/kni/compat.h
+++ b/kernel/linux/kni/compat.h
@@ -102,8 +102,15 @@
 #undef NET_NAME_UNKNOWN
 #endif
 
+/*
+ * RHEL has two different version with different kernel version:
+ * 3.10 is for AMD, Intel, IBM POWER7 and POWER8;
+ * 4.14 is for ARM and IBM POWER9
+ */
 #if (defined(RHEL_RELEASE_CODE) && \
-	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \
+	(LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
 #define ndo_change_mtu ndo_change_mtu_rh74
 #endif
 
diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
index ae1b530..430aaba 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux/kni/ethtool/igb/kcompat.h
@@ -3930,7 +3930,9 @@ static inline struct sk_buff *__kc__vlan_hwaccel_put_tag(struct sk_buff *skb,
 #endif
 
 #if (defined(RHEL_RELEASE_CODE) && \
-	(RHEL_RELEASE_VERSION(7, 5) <= RHEL_RELEASE_CODE))
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \
+	(LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
 #define ndo_change_mtu ndo_change_mtu_rh74
 #endif
 
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT
  2018-12-21 16:15   ` David Zeng
  2018-12-21 16:27     ` David Zeng
@ 2018-12-21 16:27     ` Ferruh Yigit
  1 sibling, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2018-12-21 16:27 UTC (permalink / raw)
  To: David Zeng, dev; +Cc: David Zeng

On 12/21/2018 4:15 PM, David Zeng wrote:
> Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT
  2018-12-21 16:27       ` [PATCH] " David Zeng
@ 2018-12-21 17:02         ` Ferruh Yigit
  2019-01-14 13:34           ` Thomas Monjalon
  0 siblings, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2018-12-21 17:02 UTC (permalink / raw)
  To: David Zeng, dev; +Cc: David Zeng

On 12/21/2018 4:27 PM, David Zeng wrote:
> Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT
  2018-12-21 17:02         ` Ferruh Yigit
@ 2019-01-14 13:34           ` Thomas Monjalon
  0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2019-01-14 13:34 UTC (permalink / raw)
  To: David Zeng; +Cc: dev, Ferruh Yigit, David Zeng

21/12/2018 18:02, Ferruh Yigit:
> On 12/21/2018 4:27 PM, David Zeng wrote:
> > Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied on top of another fix:
	http://git.dpdk.org/dpdk/commit/?id=4c820b22
and renamed:
	kni: fix build on RHEL8 for arm and Power9

Thanks

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-01-14 13:34 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-21  6:03 [PATCH] kni: fix build on RHEL 7.6-ALT on IBM POWER9 David Zeng
2018-12-21 14:34 ` Ferruh Yigit
2018-12-21 16:15 ` [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT David Zeng
2018-12-21 16:15   ` David Zeng
2018-12-21 16:27     ` David Zeng
2018-12-21 16:27       ` [PATCH] " David Zeng
2018-12-21 17:02         ` Ferruh Yigit
2019-01-14 13:34           ` Thomas Monjalon
2018-12-21 16:27     ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.