* [PATCH] nvme: fix the definition of Amin doorbell buffer config support
2017-08-31 3:22 [PATCH] nvme: fix the definition of Amin doorbell buffer config support Changpeng Liu
@ 2017-08-30 7:04 ` Christoph Hellwig
2017-08-30 7:17 ` Max Gurtovoy
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2017-08-30 7:04 UTC (permalink / raw)
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme: fix the definition of Amin doorbell buffer config support
2017-08-31 3:22 [PATCH] nvme: fix the definition of Amin doorbell buffer config support Changpeng Liu
2017-08-30 7:04 ` Christoph Hellwig
@ 2017-08-30 7:17 ` Max Gurtovoy
2017-08-30 7:35 ` Liu, Changpeng
1 sibling, 1 reply; 4+ messages in thread
From: Max Gurtovoy @ 2017-08-30 7:17 UTC (permalink / raw)
On 8/31/2017 6:22 AM, Changpeng Liu wrote:
> NVMe 1.3 specification defines the Optioal Admin Command Support
> feature flags, bit 8 set to '1' then the controller supports the
> Doorbell Buffer Config command. Bit 7 is used for Virtualization
> Mangement command.
>
> Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
> ---
> include/linux/nvme.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
Looks good (need to update the typo Optioal -> Optional during the merge),
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme: fix the definition of Amin doorbell buffer config support
2017-08-30 7:17 ` Max Gurtovoy
@ 2017-08-30 7:35 ` Liu, Changpeng
0 siblings, 0 replies; 4+ messages in thread
From: Liu, Changpeng @ 2017-08-30 7:35 UTC (permalink / raw)
> -----Original Message-----
> From: Max Gurtovoy [mailto:maxg at mellanox.com]
> Sent: Wednesday, August 30, 2017 3:18 PM
> To: Liu, Changpeng <changpeng.liu at intel.com>; linux-nvme at lists.infradead.org;
> Busch, Keith <keith.busch at intel.com>; axboe at fb.com; hch at lst.de;
> sagi at grimberg.me
> Subject: Re: [PATCH] nvme: fix the definition of Amin doorbell buffer config
> support
>
>
>
> On 8/31/2017 6:22 AM, Changpeng Liu wrote:
> > NVMe 1.3 specification defines the Optioal Admin Command Support
> > feature flags, bit 8 set to '1' then the controller supports the
> > Doorbell Buffer Config command. Bit 7 is used for Virtualization
> > Mangement command.
> >
> > Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
> > ---
> > include/linux/nvme.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/nvme.h b/include/linux/nvme.h
>
> Looks good (need to update the typo Optioal -> Optional during the merge),
Thanks, will send v2 to fix the typo.
>
> Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nvme: fix the definition of Amin doorbell buffer config support
@ 2017-08-31 3:22 Changpeng Liu
2017-08-30 7:04 ` Christoph Hellwig
2017-08-30 7:17 ` Max Gurtovoy
0 siblings, 2 replies; 4+ messages in thread
From: Changpeng Liu @ 2017-08-31 3:22 UTC (permalink / raw)
NVMe 1.3 specification defines the Optioal Admin Command Support
feature flags, bit 8 set to '1' then the controller supports the
Doorbell Buffer Config command. Bit 7 is used for Virtualization
Mangement command.
Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
---
include/linux/nvme.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 25d8225..8efff88 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -254,7 +254,7 @@ enum {
NVME_CTRL_VWC_PRESENT = 1 << 0,
NVME_CTRL_OACS_SEC_SUPP = 1 << 0,
NVME_CTRL_OACS_DIRECTIVES = 1 << 5,
- NVME_CTRL_OACS_DBBUF_SUPP = 1 << 7,
+ NVME_CTRL_OACS_DBBUF_SUPP = 1 << 8,
};
struct nvme_lbaf {
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-31 3:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 3:22 [PATCH] nvme: fix the definition of Amin doorbell buffer config support Changpeng Liu
2017-08-30 7:04 ` Christoph Hellwig
2017-08-30 7:17 ` Max Gurtovoy
2017-08-30 7:35 ` Liu, Changpeng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.