[PATCH] nvme: fix the definition of Amin doorbell buffer config support

[PATCH] nvme: fix the definition of Amin doorbell buffer config support

[Christoph Hellwig]

Thanks!

[PATCH] nvme: fix the definition of Amin doorbell buffer config support

[Max Gurtovoy]

On 8/31/2017 6:22 AM, Changpeng Liu wrote:
> NVMe 1.3 specification defines the Optioal Admin Command Support
> feature flags, bit 8 set to '1' then the controller supports the
> Doorbell Buffer Config command. Bit 7 is used for Virtualization
> Mangement command.
> 
> Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
> ---
>   include/linux/nvme.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h

Looks good (need to update the typo Optioal -> Optional during the merge),

Reviewed-by: Max Gurtovoy <maxg at mellanox.com>

[PATCH] nvme: fix the definition of Amin doorbell buffer config support

[Liu, Changpeng]

> -----Original Message-----
> From: Max Gurtovoy [mailto:maxg at mellanox.com]
> Sent: Wednesday, August 30, 2017 3:18 PM
> To: Liu, Changpeng <changpeng.liu at intel.com>; linux-nvme at lists.infradead.org;
> Busch, Keith <keith.busch at intel.com>; axboe at fb.com; hch at lst.de;
> sagi at grimberg.me
> Subject: Re: [PATCH] nvme: fix the definition of Amin doorbell buffer config
> support
> 
> 
> 
> On 8/31/2017 6:22 AM, Changpeng Liu wrote:
> > NVMe 1.3 specification defines the Optioal Admin Command Support
> > feature flags, bit 8 set to '1' then the controller supports the
> > Doorbell Buffer Config command. Bit 7 is used for Virtualization
> > Mangement command.
> >
> > Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
> > ---
> >   include/linux/nvme.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> 
> Looks good (need to update the typo Optioal -> Optional during the merge),
Thanks, will send v2 to fix the typo.
> 
> Reviewed-by: Max Gurtovoy <maxg at mellanox.com>

[PATCH] nvme: fix the definition of Amin doorbell buffer config support

[Changpeng Liu]

NVMe 1.3 specification defines the Optioal Admin Command Support
feature flags, bit 8 set to '1' then the controller supports the
Doorbell Buffer Config command. Bit 7 is used for Virtualization
Mangement command.

Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
---
 include/linux/nvme.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 25d8225..8efff88 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -254,7 +254,7 @@ enum {
 	NVME_CTRL_VWC_PRESENT			= 1 << 0,
 	NVME_CTRL_OACS_SEC_SUPP                 = 1 << 0,
 	NVME_CTRL_OACS_DIRECTIVES		= 1 << 5,
-	NVME_CTRL_OACS_DBBUF_SUPP		= 1 << 7,
+	NVME_CTRL_OACS_DBBUF_SUPP		= 1 << 8,
 };
 
 struct nvme_lbaf {
-- 
1.9.3