All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/18] arm64: renesas: add ULCB Kingfisher board
@ 2017-09-06 22:34 ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:34 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

Hello,

This adds the folowing:
- ULCB Kingfisher infotainment board device tree
- Document DT bindings

Vladimir Barinov (18):
[01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT
[02/18] dt: arm: shmobile: add H3ULCB Kingfisher board DT
[03/18] arm64: dts: ulcb-kf: initial device tree
[04/18] arm64: dts: m3ulcb-kf: initial device tree
[05/18] arm64: dts: h3ulcb-kf: ES1.x SoC initial device tree
[06/18] arm64: dts: h3ulcb-kf: ES2.0+ SoC initial device tree
[07/18] arm64: dts: ulcb-kf: enable SCIF1
[08/18] arm64: dts: ulcb-kf: enable CAN0/1
[09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
[10/18] arm64: dts: ulcb-kf: enable HSUSB
[11/18] arm64: dts: ulcb-kf: enable USB2.0 Host channel 0
[12/18] arm64: dts: ulcb-kf: enable PCIE0/1
[13/18] arm64: dts: ulcb-kf: enable USB3.0 Host
[14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
[15/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C4
[16/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C2
[17/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C4
[18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios

---
This patchset is against the 'kernel/git/horms/renesas.git' repo.

 Documentation/devicetree/bindings/arm/shmobile.txt    |    2 
 arch/arm64/boot/dts/renesas/Makefile                  |    3 
 arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts |   17 +
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts     |   17 +
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts     |   17 +
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi              |  185 ++++++++++++++++++
 6 files changed, 241 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
 create mode 100644 arch/arm64/boot/dts/renesas/ulcb-kf.dts

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* [PATCH 0/18] arm64: renesas: add ULCB Kingfisher board
@ 2017-09-06 22:34 ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:34 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

Hello,

This adds the folowing:
- ULCB Kingfisher infotainment board device tree
- Document DT bindings

Vladimir Barinov (18):
[01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT
[02/18] dt: arm: shmobile: add H3ULCB Kingfisher board DT
[03/18] arm64: dts: ulcb-kf: initial device tree
[04/18] arm64: dts: m3ulcb-kf: initial device tree
[05/18] arm64: dts: h3ulcb-kf: ES1.x SoC initial device tree
[06/18] arm64: dts: h3ulcb-kf: ES2.0+ SoC initial device tree
[07/18] arm64: dts: ulcb-kf: enable SCIF1
[08/18] arm64: dts: ulcb-kf: enable CAN0/1
[09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
[10/18] arm64: dts: ulcb-kf: enable HSUSB
[11/18] arm64: dts: ulcb-kf: enable USB2.0 Host channel 0
[12/18] arm64: dts: ulcb-kf: enable PCIE0/1
[13/18] arm64: dts: ulcb-kf: enable USB3.0 Host
[14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
[15/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C4
[16/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C2
[17/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C4
[18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios

---
This patchset is against the 'kernel/git/horms/renesas.git' repo.

 Documentation/devicetree/bindings/arm/shmobile.txt    |    2 
 arch/arm64/boot/dts/renesas/Makefile                  |    3 
 arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts |   17 +
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts     |   17 +
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts     |   17 +
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi              |  185 ++++++++++++++++++
 6 files changed, 241 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
 create mode 100644 arch/arm64/boot/dts/renesas/ulcb-kf.dts

^ permalink raw reply	[flat|nested] 66+ messages in thread

* [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
  2017-09-06 22:34 ` Vladimir Barinov
@ 2017-09-06 22:35     ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
supported board.

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index ae75cb3..89bd3a6 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -85,6 +85,7 @@ Boards:
   - Lager (RTP0RC7790SEB00010S)
     compatible = "renesas,lager", "renesas,r8a7790"
   - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
+    M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
     compatible = "renesas,m3ulcb", "renesas,r8a7796";
   - Marzen (R0P7779A00010S)
     compatible = "renesas,marzen", "renesas,r8a7779"
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
@ 2017-09-06 22:35     ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
supported board.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index ae75cb3..89bd3a6 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -85,6 +85,7 @@ Boards:
   - Lager (RTP0RC7790SEB00010S)
     compatible = "renesas,lager", "renesas,r8a7790"
   - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
+    M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
     compatible = "renesas,m3ulcb", "renesas,r8a7796";
   - Marzen (R0P7779A00010S)
     compatible = "renesas,marzen", "renesas,r8a7779"
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 02/18] dt: arm: shmobile: add H3ULCB Kingfisher board DT bindings
  2017-09-06 22:34 ` Vladimir Barinov
  (?)
@ 2017-09-06 22:35 ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

Add H3ULCB Kingfisher Device tree bindings Documentation, listing it as a
supported board.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index 89bd3a6..b313fe2 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -65,6 +65,7 @@ Boards:
     compatible = "renesas,gose", "renesas,r8a7793"
   - H3ULCB (R-Car Starter Kit Premier, RTP0RC7795SKBX0010SA00 (H3 ES1.1))
     H3ULCB (R-Car Starter Kit Premier, RTP0RC77951SKBX010SA00 (H3 ES2.0))
+    H3ULCB Kingfisher (SBEV-RCAR-KF-M03)
     compatible = "renesas,h3ulcb", "renesas,r8a7795";
   - Henninger
     compatible = "renesas,henninger", "renesas,r8a7791"
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 03/18] arm64: dts: ulcb-kf: initial device tree
  2017-09-06 22:34 ` Vladimir Barinov
  (?)
  (?)
@ 2017-09-06 22:35 ` Vladimir Barinov
       [not found]   ` <1504737322-22954-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
  -1 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

Add the initial common dtsi file for Kingfisher infotainment board (R-Car
Starter Kit extension)

This commit supports the following peripherals:
- HSCIF0

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
new file mode 100644
index 0000000..849f8b1
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -0,0 +1,31 @@
+/*
+ * Device Tree Source for the Kingfisher (ULCB extension) board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/ {
+	aliases {
+		serial1 = &hscif0;
+	};
+};
+
+&hscif0 {
+	pinctrl-0 = <&hscif0_pins>;
+	pinctrl-names = "default";
+	uart-has-rtscts;
+
+	status = "okay";
+};
+
+&pfc {
+	hscif0_pins: hscif0 {
+		groups = "hscif0_data", "hscif0_ctrl";
+		function = "hscif0";
+	};
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 04/18] arm64: dts: m3ulcb-kf: initial device tree
  2017-09-06 22:34 ` Vladimir Barinov
@ 2017-09-06 22:35     ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

Add the initial device tree for the M3ULCB with Kingfisher extension
infotainment board.

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/Makefile              |  1 +
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 381928b..54e8316 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-xs.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es1-salvator-x.dtb r8a7795-es1-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb r8a7796-m3ulcb.dtb
+dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-m3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb
 
 always		:= $(dtb-y)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
new file mode 100644
index 0000000..22fad76c
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
@@ -0,0 +1,17 @@
+/*
+ * Device Tree Source for the M3ULCB Kingfisher board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+#include "r8a7796-m3ulcb.dts"
+#include "ulcb-kf.dtsi"
+
+/ {
+	model = "Renesas M3ULCB Kingfisher board based on r8a7796";
+};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 04/18] arm64: dts: m3ulcb-kf: initial device tree
@ 2017-09-06 22:35     ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

Add the initial device tree for the M3ULCB with Kingfisher extension
infotainment board.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/Makefile              |  1 +
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 381928b..54e8316 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-xs.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es1-salvator-x.dtb r8a7795-es1-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb r8a7796-m3ulcb.dtb
+dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-m3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb
 
 always		:= $(dtb-y)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
new file mode 100644
index 0000000..22fad76c
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
@@ -0,0 +1,17 @@
+/*
+ * Device Tree Source for the M3ULCB Kingfisher board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+#include "r8a7796-m3ulcb.dts"
+#include "ulcb-kf.dtsi"
+
+/ {
+	model = "Renesas M3ULCB Kingfisher board based on r8a7796";
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 05/18] arm64: dts: h3ulcb-kf: ES1.x SoC initial device tree
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (2 preceding siblings ...)
  (?)
@ 2017-09-06 22:35 ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

Add the initial device tree for the H3ULCB ES1.x SoC with Kingfisher
extension infotainment board.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/Makefile                  |  1 +
 arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 54e8316..e745450 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -1,6 +1,7 @@
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-xs.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es1-salvator-x.dtb r8a7795-es1-h3ulcb.dtb
+dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es1-h3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb r8a7796-m3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-m3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts b/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts
new file mode 100644
index 0000000..dcc9e68
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts
@@ -0,0 +1,17 @@
+/*
+ * Device Tree Source for the H3ULCB Kingfisher board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+#include "r8a7795-es1-h3ulcb.dts"
+#include "ulcb-kf.dtsi"
+
+/ {
+	model = "Renesas H3ULCB Kingfisher board based on r8a7795 ES1.x";
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 06/18] arm64: dts: h3ulcb-kf: ES2.0+ SoC initial device tree
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (3 preceding siblings ...)
  (?)
@ 2017-09-06 22:35 ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

Add the initial device tree for the H3ULCB ES2.0+ SoC with Kingfisher
extension infotainment board.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/Makefile              |  1 +
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index e745450..a865704 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -1,4 +1,5 @@
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
+dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-h3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-xs.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es1-salvator-x.dtb r8a7795-es1-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es1-h3ulcb-kf.dtb
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts
new file mode 100644
index 0000000..427b73b
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts
@@ -0,0 +1,17 @@
+/*
+ * Device Tree Source for the H3ULCB Kingfisher board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+#include "r8a7795-h3ulcb.dts"
+#include "ulcb-kf.dtsi"
+
+/ {
+	model = "Renesas H3ULCB Kingfisher board based on r8a7795 ES2.0+";
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 07/18] arm64: dts: ulcb-kf: enable SCIF1
  2017-09-06 22:34 ` Vladimir Barinov
@ 2017-09-06 22:35     ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

This supports SCIF1 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 849f8b1..2449915 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -12,6 +12,7 @@
 / {
 	aliases {
 		serial1 = &hscif0;
+		serial2 = &scif1;
 	};
 };
 
@@ -28,4 +29,16 @@
 		groups = "hscif0_data", "hscif0_ctrl";
 		function = "hscif0";
 	};
+
+	scif1_pins: scif1 {
+		groups = "scif1_data_b";
+		function = "scif1";
+	};
+};
+
+&scif1 {
+	pinctrl-0 = <&scif1_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 07/18] arm64: dts: ulcb-kf: enable SCIF1
@ 2017-09-06 22:35     ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:35 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports SCIF1 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 849f8b1..2449915 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -12,6 +12,7 @@
 / {
 	aliases {
 		serial1 = &hscif0;
+		serial2 = &scif1;
 	};
 };
 
@@ -28,4 +29,16 @@
 		groups = "hscif0_data", "hscif0_ctrl";
 		function = "hscif0";
 	};
+
+	scif1_pins: scif1 {
+		groups = "scif1_data_b";
+		function = "scif1";
+	};
+};
+
+&scif1 {
+	pinctrl-0 = <&scif1_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 08/18] arm64: dts: ulcb-kf: enable CAN0/1
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (4 preceding siblings ...)
  (?)
@ 2017-09-06 22:36 ` Vladimir Barinov
  2017-09-07  9:50   ` Sergei Shtylyov
  -1 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports CAN0/1 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 2449915..ca8de1a 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -16,6 +16,22 @@
 	};
 };
 
+&can0 {
+	pinctrl-0 = <&can0_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	renesas,can-clock-select = <0x0>;
+};
+
+&can1 {
+	pinctrl-0 = <&can1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	renesas,can-clock-select = <0x0>;
+};
+
 &hscif0 {
 	pinctrl-0 = <&hscif0_pins>;
 	pinctrl-names = "default";
@@ -25,6 +41,16 @@
 };
 
 &pfc {
+	can0_pins: can0 {
+		groups = "can0_data_a";
+		function = "can0";
+	};
+
+	can1_pins: can1 {
+		groups = "can1_data";
+		function = "can1";
+	};
+
 	hscif0_pins: hscif0 {
 		groups = "hscif0_data", "hscif0_ctrl";
 		function = "hscif0";
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
  2017-09-06 22:34 ` Vladimir Barinov
@ 2017-09-06 22:36     ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

This supports USB2 PHY channel #0 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index ca8de1a..0854600 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -60,6 +60,11 @@
 		groups = "scif1_data_b";
 		function = "scif1";
 	};
+
+	usb0_pins: usb0 {
+		groups = "usb0";
+		function = "usb0";
+	};
 };
 
 &scif1 {
@@ -68,3 +73,10 @@
 
 	status = "okay";
 };
+
+&usb2_phy0 {
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
@ 2017-09-06 22:36     ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports USB2 PHY channel #0 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index ca8de1a..0854600 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -60,6 +60,11 @@
 		groups = "scif1_data_b";
 		function = "scif1";
 	};
+
+	usb0_pins: usb0 {
+		groups = "usb0";
+		function = "usb0";
+	};
 };
 
 &scif1 {
@@ -68,3 +73,10 @@
 
 	status = "okay";
 };
+
+&usb2_phy0 {
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 10/18] arm64: dts: ulcb-kf: enable HSUSB
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (5 preceding siblings ...)
  (?)
@ 2017-09-06 22:36 ` Vladimir Barinov
  2017-09-20 12:51   ` Geert Uytterhoeven
  -1 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports HSUSB on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 0854600..8950a52 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -40,6 +40,10 @@
 	status = "okay";
 };
 
+&hsusb {
+	status = "okay";
+};
+
 &pfc {
 	can0_pins: can0 {
 		groups = "can0_data_a";
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 11/18] arm64: dts: ulcb-kf: enable USB2.0 Host channel 0
  2017-09-06 22:34 ` Vladimir Barinov
@ 2017-09-06 22:36     ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

This supports USB2.0 Host channel 0 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 8950a52..46e3a34 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -32,6 +32,10 @@
 	renesas,can-clock-select = <0x0>;
 };
 
+&ehci0 {
+	status = "okay";
+};
+
 &hscif0 {
 	pinctrl-0 = <&hscif0_pins>;
 	pinctrl-names = "default";
@@ -44,6 +48,10 @@
 	status = "okay";
 };
 
+&ohci0 {
+	status = "okay";
+};
+
 &pfc {
 	can0_pins: can0 {
 		groups = "can0_data_a";
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 11/18] arm64: dts: ulcb-kf: enable USB2.0 Host channel 0
@ 2017-09-06 22:36     ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports USB2.0 Host channel 0 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 8950a52..46e3a34 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -32,6 +32,10 @@
 	renesas,can-clock-select = <0x0>;
 };
 
+&ehci0 {
+	status = "okay";
+};
+
 &hscif0 {
 	pinctrl-0 = <&hscif0_pins>;
 	pinctrl-names = "default";
@@ -44,6 +48,10 @@
 	status = "okay";
 };
 
+&ohci0 {
+	status = "okay";
+};
+
 &pfc {
 	can0_pins: can0 {
 		groups = "can0_data_a";
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 12/18] arm64: dts: ulcb-kf: enable PCIE0/1
  2017-09-06 22:34 ` Vladimir Barinov
@ 2017-09-06 22:36     ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

This supports PCIE0/1 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 46e3a34..952d2b7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -52,6 +52,19 @@
 	status = "okay";
 };
 
+&pcie_bus_clk {
+	clock-frequency = <100000000>;
+	status = "okay";
+};
+
+&pciec0 {
+	status = "okay";
+};
+
+&pciec1 {
+	status = "okay";
+};
+
 &pfc {
 	can0_pins: can0 {
 		groups = "can0_data_a";
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 12/18] arm64: dts: ulcb-kf: enable PCIE0/1
@ 2017-09-06 22:36     ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports PCIE0/1 on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 46e3a34..952d2b7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -52,6 +52,19 @@
 	status = "okay";
 };
 
+&pcie_bus_clk {
+	clock-frequency = <100000000>;
+	status = "okay";
+};
+
+&pciec0 {
+	status = "okay";
+};
+
+&pciec1 {
+	status = "okay";
+};
+
 &pfc {
 	can0_pins: can0 {
 		groups = "can0_data_a";
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 13/18] arm64: dts: ulcb-kf: enable USB3.0 Host
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (7 preceding siblings ...)
  (?)
@ 2017-09-06 22:36 ` Vladimir Barinov
  2017-09-20 13:07   ` Geert Uytterhoeven
  -1 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports USB3.0 Host on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 952d2b7..71dee77 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -105,3 +105,7 @@
 
 	status = "okay";
 };
+
+&xhci0 {
+	status = "okay";
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
  2017-09-06 22:34 ` Vladimir Barinov
@ 2017-09-06 22:36     ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 71dee77..40885e7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -48,6 +48,28 @@
 	status = "okay";
 };
 
+&i2c2 {
+	gpio_exp_74: pca9539@74 {
+		compatible = "nxp,pca9539";
+		reg = <0x74>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio6>;
+		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
+	};
+
+	gpio_exp_75: pca9539@75 {
+		compatible = "nxp,pca9539";
+		reg = <0x75>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio6>;
+		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
@ 2017-09-06 22:36     ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 71dee77..40885e7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -48,6 +48,28 @@
 	status = "okay";
 };
 
+&i2c2 {
+	gpio_exp_74: pca9539@74 {
+		compatible = "nxp,pca9539";
+		reg = <0x74>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio6>;
+		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
+	};
+
+	gpio_exp_75: pca9539@75 {
+		compatible = "nxp,pca9539";
+		reg = <0x75>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio6>;
+		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 15/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C4
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (8 preceding siblings ...)
  (?)
@ 2017-09-06 22:37 ` Vladimir Barinov
  2017-09-07 10:50   ` Geert Uytterhoeven
  -1 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:37 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports PCA9539 gpio expanders on I2C4 bus on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 40885e7..1cf8466 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -70,6 +70,28 @@
 	};
 };
 
+&i2c4 {
+	gpio_exp_76: pca9539@76 {
+		compatible = "nxp,pca9539";
+		reg = <0x76>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio7>;
+		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+	};
+
+	gpio_exp_77: pca9539@77 {
+		compatible = "nxp,pca9539";
+		reg = <0x77>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio5>;
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 16/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C2
  2017-09-06 22:34 ` Vladimir Barinov
@ 2017-09-06 22:37     ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:37 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

This supports PCA9548 I2C switch on I2C2 bus on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 1cf8466..3bbc490 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -68,6 +68,14 @@
 		interrupt-parent = <&gpio6>;
 		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
 	};
+
+	i2cswitch2: pca9548@71 {
+		compatible = "nxp,pca9548";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x71>;
+		reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>;
+	};
 };
 
 &i2c4 {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 16/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C2
@ 2017-09-06 22:37     ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:37 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports PCA9548 I2C switch on I2C2 bus on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 1cf8466..3bbc490 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -68,6 +68,14 @@
 		interrupt-parent = <&gpio6>;
 		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
 	};
+
+	i2cswitch2: pca9548@71 {
+		compatible = "nxp,pca9548";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x71>;
+		reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>;
+	};
 };
 
 &i2c4 {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 17/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C4
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (9 preceding siblings ...)
  (?)
@ 2017-09-06 22:37 ` Vladimir Barinov
       [not found]   ` <1504737438-23504-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
  -1 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:37 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports PCA9548 I2C switch on I2C4 bus on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 3bbc490..0c3844f 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -98,6 +98,14 @@
 		interrupt-parent = <&gpio5>;
 		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
 	};
+
+	i2cswitch4: pca9548@74 {
+		compatible = "nxp,pca9548";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x71>;
+		reset-gpios= <&gpio3 15 GPIO_ACTIVE_LOW>;
+	};
 };
 
 &ohci0 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* [PATCH 18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (10 preceding siblings ...)
  (?)
@ 2017-09-06 22:37 ` Vladimir Barinov
       [not found]   ` <1504737444-23544-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
  -1 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:37 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This adds gpio hogs for USB3 hub on ULCB Kingfisher board to power up and
remove from reset the hub

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 0c3844f..7bb9793 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -57,6 +57,20 @@
 		interrupt-controller;
 		interrupt-parent = <&gpio6>;
 		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
+
+		hub_pwen {
+			gpio-hog;
+			gpios = <6 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "HUB pwen";
+		};
+
+		hub_rst {
+			gpio-hog;
+			gpios = <7 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "HUB rst";
+		};
 	};
 
 	gpio_exp_75: pca9539@75 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 66+ messages in thread

* Re: [PATCH 0/18] arm64: renesas: add ULCB Kingfisher board
  2017-09-06 22:34 ` Vladimir Barinov
                   ` (11 preceding siblings ...)
  (?)
@ 2017-09-06 22:45 ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-06 22:45 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc

On 07.09.2017 01:34, Vladimir Barinov wrote:
> Hello,
>
> This adds the folowing:
> - ULCB Kingfisher infotainment board device tree
> - Document DT bindings
Forgot to mention about documentation:

http://elinux.org/R-Car/Boards/Kingfisher
http://www.shimafuji.co.jp/DL/EN/InfotainmentCarrierBoard/
http://www.shimafuji.co.jp/Kingfisher/indexEN.html

-- 
Regards,
Vladimir

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 08/18] arm64: dts: ulcb-kf: enable CAN0/1
  2017-09-06 22:36 ` [PATCH 08/18] arm64: dts: ulcb-kf: enable CAN0/1 Vladimir Barinov
@ 2017-09-07  9:50   ` Sergei Shtylyov
  0 siblings, 0 replies; 66+ messages in thread
From: Sergei Shtylyov @ 2017-09-07  9:50 UTC (permalink / raw)
  To: Vladimir Barinov, Simon Horman, Magnus Damm, Rob Herring,
	Mark Rutland, Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc

Hello!

On 9/7/2017 1:36 AM, Vladimir Barinov wrote:

> This supports CAN0/1 on ULCB Kingfisher board
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
>   arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 2449915..ca8de1a 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -16,6 +16,22 @@
>   	};
>   };
>   
> +&can0 {
> +	pinctrl-0 = <&can0_pins>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +
> +	renesas,can-clock-select = <0x0>;
> +};
> +
> +&can1 {
> +	pinctrl-0 = <&can1_pins>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +
> +	renesas,can-clock-select = <0x0>;

    IIRC, you can omit these Renesas specific props -- the driver uses 0 if it 
doesn't find the prop.

[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 16/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C2
  2017-09-06 22:37     ` Vladimir Barinov
  (?)
@ 2017-09-07 10:37     ` Geert Uytterhoeven
  -1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-07 10:37 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Thu, Sep 7, 2017 at 12:37 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports PCA9548 I2C switch on I2C2 bus on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 1cf8466..3bbc490 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -68,6 +68,14 @@
>                 interrupt-parent = <&gpio6>;
>                 interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
>         };
> +
> +       i2cswitch2: pca9548@71 {

Please use generic node names: i2c-switch@71

> +               compatible = "nxp,pca9548";
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               reg = <0x71>;
> +               reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>;
> +       };
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
  2017-09-06 22:36     ` Vladimir Barinov
  (?)
@ 2017-09-07 10:49     ` Geert Uytterhoeven
  -1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-07 10:49 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 71dee77..40885e7 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -48,6 +48,28 @@
>         status = "okay";
>  };
>
> +&i2c2 {
> +       gpio_exp_74: pca9539@74 {

Please use generic names: gpio@74

> +               compatible = "nxp,pca9539";
> +               reg = <0x74>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-controller;
> +               interrupt-parent = <&gpio6>;
> +               interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> +       };
> +
> +       gpio_exp_75: pca9539@75 {

gpio@75

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 15/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C4
  2017-09-06 22:37 ` [PATCH 15/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C4 Vladimir Barinov
@ 2017-09-07 10:50   ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-07 10:50 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Thu, Sep 7, 2017 at 12:37 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports PCA9539 gpio expanders on I2C4 bus on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -70,6 +70,28 @@
>         };
>  };
>
> +&i2c4 {
> +       gpio_exp_76: pca9539@76 {

gpio@76

> +       gpio_exp_77: pca9539@77 {

gpio@77

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 17/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C4
  2017-09-06 22:37 ` [PATCH 17/18] arm64: dts: ulcb-kf: enable PCA9548 " Vladimir Barinov
@ 2017-09-07 10:51       ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-07 10:51 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

On Thu, Sep 7, 2017 at 12:37 AM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports PCA9548 I2C switch on I2C4 bus on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -98,6 +98,14 @@
>                 interrupt-parent = <&gpio5>;
>                 interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
>         };
> +
> +       i2cswitch4: pca9548@74 {

i2c-switch@74

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 17/18] arm64: dts: ulcb-kf: enable PCA9548 on I2C4
@ 2017-09-07 10:51       ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-07 10:51 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Thu, Sep 7, 2017 at 12:37 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports PCA9548 I2C switch on I2C4 bus on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -98,6 +98,14 @@
>                 interrupt-parent = <&gpio5>;
>                 interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
>         };
> +
> +       i2cswitch4: pca9548@74 {

i2c-switch@74

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
  2017-09-06 22:35     ` Vladimir Barinov
  (?)
@ 2017-09-07 10:58     ` Geert Uytterhoeven
       [not found]       ` <CAMuHMdUi9THE7nTd54C22K6kOo_Ye5LkhTrRZPNfcHfWCiBsUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  -1 siblings, 1 reply; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-07 10:58 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
> supported board.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -85,6 +85,7 @@ Boards:
>    - Lager (RTP0RC7790SEB00010S)
>      compatible = "renesas,lager", "renesas,r8a7790"
>    - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
> +    M3ULCB Kingfisher (SBEV-RCAR-KF-M03)

As the Kingfisher is an extension board (and you added the same board part
number to the H3ULCB section in patch 02/18), shouldn't it have its own
compatible value "shimafuji,kingfisher" instead?

Then this can be used in ulcb-kf.dtsi:

    compatible = "shimafuji,kingfisher";

and appended (overridden, as there's no /append-property/ directive in dtc
yet?) in the board files, e.g. r8a7796-m3ulcb-kf.dts:

    compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796";

Does that make sense?

>      compatible = "renesas,m3ulcb", "renesas,r8a7796";
>    - Marzen (R0P7779A00010S)
>      compatible = "renesas,marzen", "renesas,r8a7779"

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
  2017-09-07 10:58     ` Geert Uytterhoeven
@ 2017-09-08  7:05           ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-08  7:05 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

Hi Geert,

On 07.09.2017 13:58, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
>> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
>> supported board.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> Thanks for your patch!
>
>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>> @@ -85,6 +85,7 @@ Boards:
>>     - Lager (RTP0RC7790SEB00010S)
>>       compatible = "renesas,lager", "renesas,r8a7790"
>>     - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
>> +    M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
> As the Kingfisher is an extension board (and you added the same board part
> number to the H3ULCB section in patch 02/18), shouldn't it have its own
> compatible value "shimafuji,kingfisher" instead?
Thank you for this suggestion.

This looks very meaningful for boards differentiation.

> Then this can be used in ulcb-kf.dtsi:
>
>      compatible = "shimafuji,kingfisher";
>
> and appended (overridden, as there's no /append-property/ directive in dtc
> yet?) in the board files, e.g. r8a7796-m3ulcb-kf.dts:
>
>      compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796";
>
> Does that make sense?
Yes.
I will rework this in V2 patchset according to your suggestion.

>
>>       compatible = "renesas,m3ulcb", "renesas,r8a7796";
>>     - Marzen (R0P7779A00010S)
>>       compatible = "renesas,marzen", "renesas,r8a7779"
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


-- 
Regards,
Vladimir

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings
@ 2017-09-08  7:05           ` Vladimir Barinov
  0 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-08  7:05 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Geert,

On 07.09.2017 13:58, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a
>> supported board.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Thanks for your patch!
>
>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>> @@ -85,6 +85,7 @@ Boards:
>>     - Lager (RTP0RC7790SEB00010S)
>>       compatible = "renesas,lager", "renesas,r8a7790"
>>     - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
>> +    M3ULCB Kingfisher (SBEV-RCAR-KF-M03)
> As the Kingfisher is an extension board (and you added the same board part
> number to the H3ULCB section in patch 02/18), shouldn't it have its own
> compatible value "shimafuji,kingfisher" instead?
Thank you for this suggestion.

This looks very meaningful for boards differentiation.

> Then this can be used in ulcb-kf.dtsi:
>
>      compatible = "shimafuji,kingfisher";
>
> and appended (overridden, as there's no /append-property/ directive in dtc
> yet?) in the board files, e.g. r8a7796-m3ulcb-kf.dts:
>
>      compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796";
>
> Does that make sense?
Yes.
I will rework this in V2 patchset according to your suggestion.

>
>>       compatible = "renesas,m3ulcb", "renesas,r8a7796";
>>     - Marzen (R0P7779A00010S)
>>       compatible = "renesas,marzen", "renesas,r8a7779"
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


-- 
Regards,
Vladimir

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 03/18] arm64: dts: ulcb-kf: initial device tree
  2017-09-06 22:35 ` [PATCH 03/18] arm64: dts: ulcb-kf: initial device tree Vladimir Barinov
@ 2017-09-20 12:20       ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 12:20 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> Add the initial common dtsi file for Kingfisher infotainment board (R-Car
> Starter Kit extension)
>
> This commit supports the following peripherals:
> - HSCIF0
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> new file mode 100644
> index 0000000..849f8b1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -0,0 +1,31 @@
> +/*
> + * Device Tree Source for the Kingfisher (ULCB extension) board
> + *
> + * Copyright (C) 2017 Renesas Electronics Corp.
> + * Copyright (C) 2017 Cogent Embedded, Inc.
> + *
> + * This file is licensed under the terms of the GNU General Public License
> + * version 2.  This program is licensed "as is" without any warranty of any
> + * kind, whether express or implied.
> + */
> +
> +/ {
> +       aliases {
> +               serial1 = &hscif0;
> +       };
> +};
> +
> +&hscif0 {
> +       pinctrl-0 = <&hscif0_pins>;
> +       pinctrl-names = "default";
> +       uart-has-rtscts;
> +
> +       status = "okay";

This serial port is driving Bluetooth and WiFi, right?
So I expect this node to gain a child node for that in the future, cfr.
Documentation/devicetree/bindings/serial/slave-device.txt.

> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 03/18] arm64: dts: ulcb-kf: initial device tree
@ 2017-09-20 12:20       ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 12:20 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> Add the initial common dtsi file for Kingfisher infotainment board (R-Car
> Starter Kit extension)
>
> This commit supports the following peripherals:
> - HSCIF0
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> new file mode 100644
> index 0000000..849f8b1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -0,0 +1,31 @@
> +/*
> + * Device Tree Source for the Kingfisher (ULCB extension) board
> + *
> + * Copyright (C) 2017 Renesas Electronics Corp.
> + * Copyright (C) 2017 Cogent Embedded, Inc.
> + *
> + * This file is licensed under the terms of the GNU General Public License
> + * version 2.  This program is licensed "as is" without any warranty of any
> + * kind, whether express or implied.
> + */
> +
> +/ {
> +       aliases {
> +               serial1 = &hscif0;
> +       };
> +};
> +
> +&hscif0 {
> +       pinctrl-0 = <&hscif0_pins>;
> +       pinctrl-names = "default";
> +       uart-has-rtscts;
> +
> +       status = "okay";

This serial port is driving Bluetooth and WiFi, right?
So I expect this node to gain a child node for that in the future, cfr.
Documentation/devicetree/bindings/serial/slave-device.txt.

> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 07/18] arm64: dts: ulcb-kf: enable SCIF1
  2017-09-06 22:35     ` Vladimir Barinov
@ 2017-09-20 12:40         ` Geert Uytterhoeven
  -1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 12:40 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports SCIF1 on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 849f8b1..2449915 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -12,6 +12,7 @@
>  / {
>         aliases {
>                 serial1 = &hscif0;
> +               serial2 = &scif1;
>         };
>  };
>
> @@ -28,4 +29,16 @@
>                 groups = "hscif0_data", "hscif0_ctrl";
>                 function = "hscif0";
>         };
> +
> +       scif1_pins: scif1 {
> +               groups = "scif1_data_b";

As RTS/CTS is wired, you want to add "scif1_ctrl" here...

> +               function = "scif1";
> +       };
> +};
> +
> +&scif1 {
> +       pinctrl-0 = <&scif1_pins>;
> +       pinctrl-names = "default";
> +

... "uart-has-rtscts" here.

> +       status = "okay";
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 07/18] arm64: dts: ulcb-kf: enable SCIF1
@ 2017-09-20 12:40         ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 12:40 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports SCIF1 on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 849f8b1..2449915 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -12,6 +12,7 @@
>  / {
>         aliases {
>                 serial1 = &hscif0;
> +               serial2 = &scif1;
>         };
>  };
>
> @@ -28,4 +29,16 @@
>                 groups = "hscif0_data", "hscif0_ctrl";
>                 function = "hscif0";
>         };
> +
> +       scif1_pins: scif1 {
> +               groups = "scif1_data_b";

As RTS/CTS is wired, you want to add "scif1_ctrl" here...

> +               function = "scif1";
> +       };
> +};
> +
> +&scif1 {
> +       pinctrl-0 = <&scif1_pins>;
> +       pinctrl-names = "default";
> +

... "uart-has-rtscts" here.

> +       status = "okay";
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 10/18] arm64: dts: ulcb-kf: enable HSUSB
  2017-09-06 22:36 ` [PATCH 10/18] arm64: dts: ulcb-kf: enable HSUSB Vladimir Barinov
@ 2017-09-20 12:51   ` Geert Uytterhoeven
       [not found]     ` <CAMuHMdVVCBUgOrFrTQgVpwkShr8SgE9C7agEov5u5PE2F=h8ng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 12:51 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports HSUSB on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 11/18] arm64: dts: ulcb-kf: enable USB2.0 Host channel 0
  2017-09-06 22:36     ` Vladimir Barinov
  (?)
@ 2017-09-20 12:52     ` Geert Uytterhoeven
       [not found]       ` <CAMuHMdW9e-hSEHDbN9PNjLQHYdoXy6jFF=PgbCFb0neN_0Ho2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  -1 siblings, 1 reply; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 12:52 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports USB2.0 Host channel 0 on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
  2017-09-06 22:36     ` Vladimir Barinov
@ 2017-09-20 12:59         ` Geert Uytterhoeven
  -1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 12:59 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports USB2 PHY channel #0 on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

> index ca8de1a..0854600 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -60,6 +60,11 @@
>                 groups = "scif1_data_b";
>                 function = "scif1";
>         };
> +
> +       usb0_pins: usb0 {
> +               groups = "usb0";
> +               function = "usb0";
> +       };
>  };
>
>  &scif1 {
> @@ -68,3 +73,10 @@
>
>         status = "okay";
>  };
> +
> +&usb2_phy0 {
> +       pinctrl-0 = <&usb0_pins>;
> +       pinctrl-names = "default";
> +

Don't you need

    vbus-supply = <&vbus0_usb2>;

with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
GPIO expander U11 (TCA9539)?
May be optional, though. salvator-common.dtsi has it.

> +       status = "okay";
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
@ 2017-09-20 12:59         ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 12:59 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports USB2 PHY channel #0 on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> index ca8de1a..0854600 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -60,6 +60,11 @@
>                 groups = "scif1_data_b";
>                 function = "scif1";
>         };
> +
> +       usb0_pins: usb0 {
> +               groups = "usb0";
> +               function = "usb0";
> +       };
>  };
>
>  &scif1 {
> @@ -68,3 +73,10 @@
>
>         status = "okay";
>  };
> +
> +&usb2_phy0 {
> +       pinctrl-0 = <&usb0_pins>;
> +       pinctrl-names = "default";
> +

Don't you need

    vbus-supply = <&vbus0_usb2>;

with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
GPIO expander U11 (TCA9539)?
May be optional, though. salvator-common.dtsi has it.

> +       status = "okay";
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 12/18] arm64: dts: ulcb-kf: enable PCIE0/1
  2017-09-06 22:36     ` Vladimir Barinov
  (?)
@ 2017-09-20 13:06     ` Geert Uytterhoeven
  -1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 13:06 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Vladimir,

On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports PCIE0/1 on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 46e3a34..952d2b7 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -52,6 +52,19 @@
>         status = "okay";
>  };
>
> +&pcie_bus_clk {
> +       clock-frequency = <100000000>;
> +       status = "okay";

The status update is superfluous, as the PCIe bus clock is already enabled
in r8a779[56].dtsi.

With that fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 13/18] arm64: dts: ulcb-kf: enable USB3.0 Host
  2017-09-06 22:36 ` [PATCH 13/18] arm64: dts: ulcb-kf: enable USB3.0 Host Vladimir Barinov
@ 2017-09-20 13:07   ` Geert Uytterhoeven
  2017-10-09  7:16     ` Simon Horman
  0 siblings, 1 reply; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 13:07 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports USB3.0 Host on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios
  2017-09-06 22:37 ` [PATCH 18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios Vladimir Barinov
@ 2017-09-20 13:50       ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 13:50 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

On Thu, Sep 7, 2017 at 12:37 AM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This adds gpio hogs for USB3 hub on ULCB Kingfisher board to power up and
> remove from reset the hub
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios
@ 2017-09-20 13:50       ` Geert Uytterhoeven
  0 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 13:50 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Thu, Sep 7, 2017 at 12:37 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This adds gpio hogs for USB3 hub on ULCB Kingfisher board to power up and
> remove from reset the hub
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 03/18] arm64: dts: ulcb-kf: initial device tree
  2017-09-20 12:20       ` Geert Uytterhoeven
  (?)
@ 2017-09-20 14:43       ` Vladimir Barinov
  -1 siblings, 0 replies; 66+ messages in thread
From: Vladimir Barinov @ 2017-09-20 14:43 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Geert,

Thank you for the review.

On 20.09.2017 15:20, Geert Uytterhoeven wrote:
> +};
>> +
>> +&hscif0 {
>> +       pinctrl-0 = <&hscif0_pins>;
>> +       pinctrl-names = "default";
>> +       uart-has-rtscts;
>> +
>> +       status = "okay";
> This serial port is driving Bluetooth and WiFi, right?
Yes.
> So I expect this node to gain a child node for that in the future, cfr.
> Documentation/devicetree/bindings/serial/slave-device.txt.
Got it.

-- 
Regards,
Vladimir

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
  2017-09-20 12:59         ` Geert Uytterhoeven
  (?)
@ 2017-10-06  2:38         ` Vladimir Barinov
  2017-10-06  7:15           ` Geert Uytterhoeven
  -1 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-10-06  2:38 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Geert,

Thank you for the review.

On 20.09.2017 15:59, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> This supports USB2 PHY channel #0 on ULCB Kingfisher board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> index ca8de1a..0854600 100644
>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> @@ -60,6 +60,11 @@
>>                  groups = "scif1_data_b";
>>                  function = "scif1";
>>          };
>> +
>> +       usb0_pins: usb0 {
>> +               groups = "usb0";
>> +               function = "usb0";
>> +       };
>>   };
>>
>>   &scif1 {
>> @@ -68,3 +73,10 @@
>>
>>          status = "okay";
>>   };
>> +
>> +&usb2_phy0 {
>> +       pinctrl-0 = <&usb0_pins>;
>> +       pinctrl-names = "default";
>> +
> Don't you need
>
>      vbus-supply = <&vbus0_usb2>;
>
> with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
> GPIO expander U11 (TCA9539)?
> May be optional, though. salvator-common.dtsi has it.
Yes, I need this gpio.
I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.

I've been considering to use either vbus-supply + gpio hog or use gpio 
hog for both of them for consistency.
What do you think about this?

I plan to add these gpios control as a separate patch.

-- 
Regards,
Vladimir

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
  2017-10-06  2:38         ` Vladimir Barinov
@ 2017-10-06  7:15           ` Geert Uytterhoeven
  2017-10-06 17:28             ` Vladimir Barinov
  0 siblings, 1 reply; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-10-06  7:15 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas,
	Yoshihiro Shimoda

Hi Vladimir,

CC Shimoda-san

On Fri, Oct 6, 2017 at 4:38 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> On 20.09.2017 15:59, Geert Uytterhoeven wrote:
>> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
>> <vladimir.barinov@cogentembedded.com> wrote:
>>> This supports USB2 PHY channel #0 on ULCB Kingfisher board
>>>
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>>> index ca8de1a..0854600 100644
>>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>>> @@ -60,6 +60,11 @@
>>>                  groups = "scif1_data_b";
>>>                  function = "scif1";
>>>          };
>>> +
>>> +       usb0_pins: usb0 {
>>> +               groups = "usb0";
>>> +               function = "usb0";
>>> +       };
>>>   };
>>>
>>>   &scif1 {
>>> @@ -68,3 +73,10 @@
>>>
>>>          status = "okay";
>>>   };
>>> +
>>> +&usb2_phy0 {
>>> +       pinctrl-0 = <&usb0_pins>;
>>> +       pinctrl-names = "default";
>>> +
>>
>> Don't you need
>>
>>      vbus-supply = <&vbus0_usb2>;
>>
>> with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
>> GPIO expander U11 (TCA9539)?
>> May be optional, though. salvator-common.dtsi has it.
>
> Yes, I need this gpio.
> I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.
>
> I've been considering to use either vbus-supply + gpio hog or use gpio hog
> for both of them for consistency.
> What do you think about this?

For OTG_EXTLPn you don't really need a hog, as it will be controlled by the
USB driver/subsystem, like on Salvator-X(S), right?

For OTG_OFFVBUSn, which is (optionally) driven from USB0_PWEN on
Salvator-X(S) I don't know if you need a GPIO hog or not. I have to defer your
question to Shimoda-san.

> I plan to add these gpios control as a separate patch.

OK.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
  2017-10-06  7:15           ` Geert Uytterhoeven
@ 2017-10-06 17:28             ` Vladimir Barinov
       [not found]               ` <1c5fc090-af98-0041-be8b-b06dc81d4670-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
  0 siblings, 1 reply; 66+ messages in thread
From: Vladimir Barinov @ 2017-10-06 17:28 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas,
	Yoshihiro Shimoda

Hi Geert,

On 06.10.2017 10:15, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> CC Shimoda-san
>
> On Fri, Oct 6, 2017 at 4:38 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> On 20.09.2017 15:59, Geert Uytterhoeven wrote:
>>> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
>>> <vladimir.barinov@cogentembedded.com> wrote:
>>>> This supports USB2 PHY channel #0 on ULCB Kingfisher board
>>>>
>>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>
>>>> index ca8de1a..0854600 100644
>>>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>>>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>>>> @@ -60,6 +60,11 @@
>>>>                   groups = "scif1_data_b";
>>>>                   function = "scif1";
>>>>           };
>>>> +
>>>> +       usb0_pins: usb0 {
>>>> +               groups = "usb0";
>>>> +               function = "usb0";
>>>> +       };
>>>>    };
>>>>
>>>>    &scif1 {
>>>> @@ -68,3 +73,10 @@
>>>>
>>>>           status = "okay";
>>>>    };
>>>> +
>>>> +&usb2_phy0 {
>>>> +       pinctrl-0 = <&usb0_pins>;
>>>> +       pinctrl-names = "default";
>>>> +
>>> Don't you need
>>>
>>>       vbus-supply = <&vbus0_usb2>;
>>>
>>> with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
>>> GPIO expander U11 (TCA9539)?
>>> May be optional, though. salvator-common.dtsi has it.
>> Yes, I need this gpio.
>> I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.
>>
>> I've been considering to use either vbus-supply + gpio hog or use gpio hog
>> for both of them for consistency.
>> What do you think about this?
> For OTG_EXTLPn you don't really need a hog, as it will be controlled by the
> USB driver/subsystem, like on Salvator-X(S), right?
Agreed.
>
> For OTG_OFFVBUSn, which is (optionally) driven from USB0_PWEN on
> Salvator-X(S) I don't know if you need a GPIO hog or not. I have to defer your
> question to Shimoda-san.
This pin should be tied permanently low to disable internal MAX3355 
internal VBUS charge pump.
Hence probably gpio hog is enough for OTG_OFFVBUSn.

KF has dedicated VBUS power supply controlled by USB0_PWEN.


-- 
Regards,
Vladimir

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios
  2017-09-20 13:50       ` Geert Uytterhoeven
@ 2017-10-09  7:15           ` Simon Horman
  -1 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:15 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Vladimir Barinov, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

On Wed, Sep 20, 2017 at 03:50:15PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 7, 2017 at 12:37 AM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> > This adds gpio hogs for USB3 hub on ULCB Kingfisher board to power up and
> > remove from reset the hub
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Thanks, applied. There was some fuzz when doing so. Please check that what
I have applied is correct after I have pushed the next branch of the
renesas tree later today.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios
@ 2017-10-09  7:15           ` Simon Horman
  0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:15 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Vladimir Barinov, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Wed, Sep 20, 2017 at 03:50:15PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 7, 2017 at 12:37 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
> > This adds gpio hogs for USB3 hub on ULCB Kingfisher board to power up and
> > remove from reset the hub
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied. There was some fuzz when doing so. Please check that what
I have applied is correct after I have pushed the next branch of the
renesas tree later today.

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 13/18] arm64: dts: ulcb-kf: enable USB3.0 Host
  2017-09-20 13:07   ` Geert Uytterhoeven
@ 2017-10-09  7:16     ` Simon Horman
  0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:16 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Vladimir Barinov, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Wed, Sep 20, 2017 at 03:07:31PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
> > This supports USB3.0 Host on ULCB Kingfisher board
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,

Thanks, applied.

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
  2017-10-06 17:28             ` Vladimir Barinov
@ 2017-10-09  7:17                   ` Simon Horman
  0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:17 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas, Yoshihiro Shimoda

On Fri, Oct 06, 2017 at 08:28:52PM +0300, Vladimir Barinov wrote:
> Hi Geert,
> 
> On 06.10.2017 10:15, Geert Uytterhoeven wrote:
> >Hi Vladimir,
> >
> >CC Shimoda-san
> >
> >On Fri, Oct 6, 2017 at 4:38 AM, Vladimir Barinov
> ><vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> >>On 20.09.2017 15:59, Geert Uytterhoeven wrote:
> >>>On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> >>><vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> >>>>This supports USB2 PHY channel #0 on ULCB Kingfisher board
> >>>>
> >>>>Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> >>>Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> >>>
> >>>>index ca8de1a..0854600 100644
> >>>>--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> >>>>+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> >>>>@@ -60,6 +60,11 @@
> >>>>                  groups = "scif1_data_b";
> >>>>                  function = "scif1";
> >>>>          };
> >>>>+
> >>>>+       usb0_pins: usb0 {
> >>>>+               groups = "usb0";
> >>>>+               function = "usb0";
> >>>>+       };
> >>>>   };
> >>>>
> >>>>   &scif1 {
> >>>>@@ -68,3 +73,10 @@
> >>>>
> >>>>          status = "okay";
> >>>>   };
> >>>>+
> >>>>+&usb2_phy0 {
> >>>>+       pinctrl-0 = <&usb0_pins>;
> >>>>+       pinctrl-names = "default";
> >>>>+
> >>>Don't you need
> >>>
> >>>      vbus-supply = <&vbus0_usb2>;
> >>>
> >>>with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
> >>>GPIO expander U11 (TCA9539)?
> >>>May be optional, though. salvator-common.dtsi has it.
> >>Yes, I need this gpio.
> >>I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.
> >>
> >>I've been considering to use either vbus-supply + gpio hog or use gpio hog
> >>for both of them for consistency.
> >>What do you think about this?
> >For OTG_EXTLPn you don't really need a hog, as it will be controlled by the
> >USB driver/subsystem, like on Salvator-X(S), right?
> Agreed.
> >
> >For OTG_OFFVBUSn, which is (optionally) driven from USB0_PWEN on
> >Salvator-X(S) I don't know if you need a GPIO hog or not. I have to defer your
> >question to Shimoda-san.
> This pin should be tied permanently low to disable internal MAX3355 internal
> VBUS charge pump.
> Hence probably gpio hog is enough for OTG_OFFVBUSn.
> 
> KF has dedicated VBUS power supply controlled by USB0_PWEN.

Hi,

I am expecting an updated version of this patch.

Please post it in a fresh thread.

I have gone through the entire patch-set and applied everything that I
though was appropriate. If I have missed any then please repost them as
well, in a fresh patch-set.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
@ 2017-10-09  7:17                   ` Simon Horman
  0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:17 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas,
	Yoshihiro Shimoda

On Fri, Oct 06, 2017 at 08:28:52PM +0300, Vladimir Barinov wrote:
> Hi Geert,
> 
> On 06.10.2017 10:15, Geert Uytterhoeven wrote:
> >Hi Vladimir,
> >
> >CC Shimoda-san
> >
> >On Fri, Oct 6, 2017 at 4:38 AM, Vladimir Barinov
> ><vladimir.barinov@cogentembedded.com> wrote:
> >>On 20.09.2017 15:59, Geert Uytterhoeven wrote:
> >>>On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> >>><vladimir.barinov@cogentembedded.com> wrote:
> >>>>This supports USB2 PHY channel #0 on ULCB Kingfisher board
> >>>>
> >>>>Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >>>Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>
> >>>>index ca8de1a..0854600 100644
> >>>>--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> >>>>+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> >>>>@@ -60,6 +60,11 @@
> >>>>                  groups = "scif1_data_b";
> >>>>                  function = "scif1";
> >>>>          };
> >>>>+
> >>>>+       usb0_pins: usb0 {
> >>>>+               groups = "usb0";
> >>>>+               function = "usb0";
> >>>>+       };
> >>>>   };
> >>>>
> >>>>   &scif1 {
> >>>>@@ -68,3 +73,10 @@
> >>>>
> >>>>          status = "okay";
> >>>>   };
> >>>>+
> >>>>+&usb2_phy0 {
> >>>>+       pinctrl-0 = <&usb0_pins>;
> >>>>+       pinctrl-names = "default";
> >>>>+
> >>>Don't you need
> >>>
> >>>      vbus-supply = <&vbus0_usb2>;
> >>>
> >>>with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
> >>>GPIO expander U11 (TCA9539)?
> >>>May be optional, though. salvator-common.dtsi has it.
> >>Yes, I need this gpio.
> >>I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.
> >>
> >>I've been considering to use either vbus-supply + gpio hog or use gpio hog
> >>for both of them for consistency.
> >>What do you think about this?
> >For OTG_EXTLPn you don't really need a hog, as it will be controlled by the
> >USB driver/subsystem, like on Salvator-X(S), right?
> Agreed.
> >
> >For OTG_OFFVBUSn, which is (optionally) driven from USB0_PWEN on
> >Salvator-X(S) I don't know if you need a GPIO hog or not. I have to defer your
> >question to Shimoda-san.
> This pin should be tied permanently low to disable internal MAX3355 internal
> VBUS charge pump.
> Hence probably gpio hog is enough for OTG_OFFVBUSn.
> 
> KF has dedicated VBUS power supply controlled by USB0_PWEN.

Hi,

I am expecting an updated version of this patch.

Please post it in a fresh thread.

I have gone through the entire patch-set and applied everything that I
though was appropriate. If I have missed any then please repost them as
well, in a fresh patch-set.

Thanks!

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 11/18] arm64: dts: ulcb-kf: enable USB2.0 Host channel 0
  2017-09-20 12:52     ` Geert Uytterhoeven
@ 2017-10-09  7:17           ` Simon Horman
  0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:17 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Vladimir Barinov, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

On Wed, Sep 20, 2017 at 02:52:12PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> > This supports USB2.0 Host channel 0 on ULCB Kingfisher board
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Thanks, applied.

There was some fuzz when doing so. Please check that what I have applied
is correct after I have pushed the next branch of the renesas tree a little
later today.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 11/18] arm64: dts: ulcb-kf: enable USB2.0 Host channel 0
@ 2017-10-09  7:17           ` Simon Horman
  0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:17 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Vladimir Barinov, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Wed, Sep 20, 2017 at 02:52:12PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
> > This supports USB2.0 Host channel 0 on ULCB Kingfisher board
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied.

There was some fuzz when doing so. Please check that what I have applied
is correct after I have pushed the next branch of the renesas tree a little
later today.

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 10/18] arm64: dts: ulcb-kf: enable HSUSB
  2017-09-20 12:51   ` Geert Uytterhoeven
@ 2017-10-09  7:17         ` Simon Horman
  0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:17 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Vladimir Barinov, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

On Wed, Sep 20, 2017 at 02:51:54PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> > This supports HSUSB on ULCB Kingfisher board
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 10/18] arm64: dts: ulcb-kf: enable HSUSB
@ 2017-10-09  7:17         ` Simon Horman
  0 siblings, 0 replies; 66+ messages in thread
From: Simon Horman @ 2017-10-09  7:17 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Vladimir Barinov, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

On Wed, Sep 20, 2017 at 02:51:54PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
> > This supports HSUSB on ULCB Kingfisher board
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied.

^ permalink raw reply	[flat|nested] 66+ messages in thread

* RE: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
  2017-10-06 17:28             ` Vladimir Barinov
@ 2017-10-12 11:41                   ` Yoshihiro Shimoda
  0 siblings, 0 replies; 66+ messages in thread
From: Yoshihiro Shimoda @ 2017-10-12 11:41 UTC (permalink / raw)
  To: batareich batareich, Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

Hi Geert-san, Vladimir-san,

> From: Vladimir Barinov, Sent: Saturday, October 7, 2017 2:29 AM
> 
> Hi Geert,
> 
> On 06.10.2017 10:15, Geert Uytterhoeven wrote:
> > Hi Vladimir,
> >
> > CC Shimoda-san
> >
> > On Fri, Oct 6, 2017 at 4:38 AM, Vladimir Barinov
> > <vladimir.barinov@cogentembedded.com> wrote:
> >> On 20.09.2017 15:59, Geert Uytterhoeven wrote:
> >>> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> >>> <vladimir.barinov@cogentembedded.com> wrote:
> >>>> This supports USB2 PHY channel #0 on ULCB Kingfisher board
> >>>>
> >>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>
> >>>> index ca8de1a..0854600 100644
> >>>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> >>>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> >>>> @@ -60,6 +60,11 @@
> >>>>                   groups = "scif1_data_b";
> >>>>                   function = "scif1";
> >>>>           };
> >>>> +
> >>>> +       usb0_pins: usb0 {
> >>>> +               groups = "usb0";
> >>>> +               function = "usb0";
> >>>> +       };
> >>>>    };
> >>>>
> >>>>    &scif1 {
> >>>> @@ -68,3 +73,10 @@
> >>>>
> >>>>           status = "okay";
> >>>>    };
> >>>> +
> >>>> +&usb2_phy0 {
> >>>> +       pinctrl-0 = <&usb0_pins>;
> >>>> +       pinctrl-names = "default";
> >>>> +
> >>> Don't you need
> >>>
> >>>       vbus-supply = <&vbus0_usb2>;
> >>>
> >>> with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
> >>> GPIO expander U11 (TCA9539)?
> >>> May be optional, though. salvator-common.dtsi has it.
> >> Yes, I need this gpio.
> >> I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.
> >>
> >> I've been considering to use either vbus-supply + gpio hog or use gpio hog
> >> for both of them for consistency.
> >> What do you think about this?
> > For OTG_EXTLPn you don't really need a hog, as it will be controlled by the
> > USB driver/subsystem, like on Salvator-X(S), right?
> Agreed.
> >
> > For OTG_OFFVBUSn, which is (optionally) driven from USB0_PWEN on
> > Salvator-X(S) I don't know if you need a GPIO hog or not. I have to defer your
> > question to Shimoda-san.

I'm sorry for the delayed response.
I think OTG_OFFVBUSn should be low level to avoid conflict 5V supply from U13's OUT pins.

> This pin should be tied permanently low to disable internal MAX3355
> internal VBUS charge pump.

I agree.

> Hence probably gpio hog is enough for OTG_OFFVBUSn.

I'm afraid but I don't understand this "gpio hog" means.

> KF has dedicated VBUS power supply controlled by USB0_PWEN.

I agree.
I don’t write any documentations though, but I assumed SW15 is pin 3 side
to use MAX3355's charge pump. So, I added "vbus-supply" to disable SHDN# of MAX3355.
But, we can also use U13 for power supply on the Salvator-X[S] without "vbus-supply".

Best regards,
Yoshihiro Shimoda

> 
> --
> Regards,
> Vladimir


^ permalink raw reply	[flat|nested] 66+ messages in thread

* RE: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
@ 2017-10-12 11:41                   ` Yoshihiro Shimoda
  0 siblings, 0 replies; 66+ messages in thread
From: Yoshihiro Shimoda @ 2017-10-12 11:41 UTC (permalink / raw)
  To: batareich batareich, Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Geert-san, Vladimir-san,

> From: Vladimir Barinov, Sent: Saturday, October 7, 2017 2:29 AM
> 
> Hi Geert,
> 
> On 06.10.2017 10:15, Geert Uytterhoeven wrote:
> > Hi Vladimir,
> >
> > CC Shimoda-san
> >
> > On Fri, Oct 6, 2017 at 4:38 AM, Vladimir Barinov
> > <vladimir.barinov@cogentembedded.com> wrote:
> >> On 20.09.2017 15:59, Geert Uytterhoeven wrote:
> >>> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
> >>> <vladimir.barinov@cogentembedded.com> wrote:
> >>>> This supports USB2 PHY channel #0 on ULCB Kingfisher board
> >>>>
> >>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>
> >>>> index ca8de1a..0854600 100644
> >>>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> >>>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> >>>> @@ -60,6 +60,11 @@
> >>>>                   groups = "scif1_data_b";
> >>>>                   function = "scif1";
> >>>>           };
> >>>> +
> >>>> +       usb0_pins: usb0 {
> >>>> +               groups = "usb0";
> >>>> +               function = "usb0";
> >>>> +       };
> >>>>    };
> >>>>
> >>>>    &scif1 {
> >>>> @@ -68,3 +73,10 @@
> >>>>
> >>>>           status = "okay";
> >>>>    };
> >>>> +
> >>>> +&usb2_phy0 {
> >>>> +       pinctrl-0 = <&usb0_pins>;
> >>>> +       pinctrl-names = "default";
> >>>> +
> >>> Don't you need
> >>>
> >>>       vbus-supply = <&vbus0_usb2>;
> >>>
> >>> with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
> >>> GPIO expander U11 (TCA9539)?
> >>> May be optional, though. salvator-common.dtsi has it.
> >> Yes, I need this gpio.
> >> I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.
> >>
> >> I've been considering to use either vbus-supply + gpio hog or use gpio hog
> >> for both of them for consistency.
> >> What do you think about this?
> > For OTG_EXTLPn you don't really need a hog, as it will be controlled by the
> > USB driver/subsystem, like on Salvator-X(S), right?
> Agreed.
> >
> > For OTG_OFFVBUSn, which is (optionally) driven from USB0_PWEN on
> > Salvator-X(S) I don't know if you need a GPIO hog or not. I have to defer your
> > question to Shimoda-san.

I'm sorry for the delayed response.
I think OTG_OFFVBUSn should be low level to avoid conflict 5V supply from U13's OUT pins.

> This pin should be tied permanently low to disable internal MAX3355
> internal VBUS charge pump.

I agree.

> Hence probably gpio hog is enough for OTG_OFFVBUSn.

I'm afraid but I don't understand this "gpio hog" means.

> KF has dedicated VBUS power supply controlled by USB0_PWEN.

I agree.
I don’t write any documentations though, but I assumed SW15 is pin 3 side
to use MAX3355's charge pump. So, I added "vbus-supply" to disable SHDN# of MAX3355.
But, we can also use U13 for power supply on the Salvator-X[S] without "vbus-supply".

Best regards,
Yoshihiro Shimoda

> 
> --
> Regards,
> Vladimir


^ permalink raw reply	[flat|nested] 66+ messages in thread

* Re: [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
  2017-10-12 11:41                   ` Yoshihiro Shimoda
  (?)
@ 2017-10-12 12:27                   ` Geert Uytterhoeven
  -1 siblings, 0 replies; 66+ messages in thread
From: Geert Uytterhoeven @ 2017-10-12 12:27 UTC (permalink / raw)
  To: Yoshihiro Shimoda
  Cc: batareich batareich, Simon Horman, Magnus Damm, Rob Herring,
	Mark Rutland, Catalin Marinas, Will Deacon, devicetree,
	Linux-Renesas

Hi Shimoda-san,

On Thu, Oct 12, 2017 at 1:41 PM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
>> From: Vladimir Barinov, Sent: Saturday, October 7, 2017 2:29 AM
>> On 06.10.2017 10:15, Geert Uytterhoeven wrote:
>> > CC Shimoda-san
>> >
>> > On Fri, Oct 6, 2017 at 4:38 AM, Vladimir Barinov
>> > <vladimir.barinov@cogentembedded.com> wrote:
>> >> On 20.09.2017 15:59, Geert Uytterhoeven wrote:
>> >>> On Thu, Sep 7, 2017 at 12:36 AM, Vladimir Barinov
>> >>> <vladimir.barinov@cogentembedded.com> wrote:
>> >>>> This supports USB2 PHY channel #0 on ULCB Kingfisher board
>> >>>>
>> >>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> >>>
>> >>>> index ca8de1a..0854600 100644
>> >>>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> >>>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> >>>> @@ -60,6 +60,11 @@
>> >>>>                   groups = "scif1_data_b";
>> >>>>                   function = "scif1";
>> >>>>           };
>> >>>> +
>> >>>> +       usb0_pins: usb0 {
>> >>>> +               groups = "usb0";
>> >>>> +               function = "usb0";
>> >>>> +       };
>> >>>>    };
>> >>>>
>> >>>>    &scif1 {
>> >>>> @@ -68,3 +73,10 @@
>> >>>>
>> >>>>           status = "okay";
>> >>>>    };
>> >>>> +
>> >>>> +&usb2_phy0 {
>> >>>> +       pinctrl-0 = <&usb0_pins>;
>> >>>> +       pinctrl-names = "default";
>> >>>> +
>> >>> Don't you need
>> >>>
>> >>>       vbus-supply = <&vbus0_usb2>;
>> >>>
>> >>> with vbus0_usb2 a fixed regulator controlled by GPIO P11 (OTG_EXTLPn) from
>> >>> GPIO expander U11 (TCA9539)?
>> >>> May be optional, though. salvator-common.dtsi has it.
>> >> Yes, I need this gpio.
>> >> I need both OTG_EXTLPn and OTG_OFFVBUSn from the same gpio expander.
>> >>
>> >> I've been considering to use either vbus-supply + gpio hog or use gpio hog
>> >> for both of them for consistency.
>> >> What do you think about this?
>> > For OTG_EXTLPn you don't really need a hog, as it will be controlled by the
>> > USB driver/subsystem, like on Salvator-X(S), right?
>> Agreed.
>> >
>> > For OTG_OFFVBUSn, which is (optionally) driven from USB0_PWEN on
>> > Salvator-X(S) I don't know if you need a GPIO hog or not. I have to defer your
>> > question to Shimoda-san.
>
> I'm sorry for the delayed response.
> I think OTG_OFFVBUSn should be low level to avoid conflict 5V supply from U13's OUT pins.
>
>> This pin should be tied permanently low to disable internal MAX3355
>> internal VBUS charge pump.
>
> I agree.

OK.

>> Hence probably gpio hog is enough for OTG_OFFVBUSn.
>
> I'm afraid but I don't understand this "gpio hog" means.

"gpio hog" is a means to tie a GPIO to a specific level, cfr.
Documentation/devicetree/bindings/gpio/gpio.txt.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 66+ messages in thread

end of thread, other threads:[~2017-10-12 12:27 UTC | newest]

Thread overview: 66+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-06 22:34 [PATCH 0/18] arm64: renesas: add ULCB Kingfisher board Vladimir Barinov
2017-09-06 22:34 ` Vladimir Barinov
2017-09-06 22:35 ` [PATCH 02/18] dt: arm: shmobile: add H3ULCB Kingfisher board DT bindings Vladimir Barinov
2017-09-06 22:35 ` [PATCH 03/18] arm64: dts: ulcb-kf: initial device tree Vladimir Barinov
     [not found]   ` <1504737322-22954-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-20 12:20     ` Geert Uytterhoeven
2017-09-20 12:20       ` Geert Uytterhoeven
2017-09-20 14:43       ` Vladimir Barinov
2017-09-06 22:35 ` [PATCH 05/18] arm64: dts: h3ulcb-kf: ES1.x SoC " Vladimir Barinov
2017-09-06 22:35 ` [PATCH 06/18] arm64: dts: h3ulcb-kf: ES2.0+ " Vladimir Barinov
2017-09-06 22:36 ` [PATCH 08/18] arm64: dts: ulcb-kf: enable CAN0/1 Vladimir Barinov
2017-09-07  9:50   ` Sergei Shtylyov
2017-09-06 22:36 ` [PATCH 10/18] arm64: dts: ulcb-kf: enable HSUSB Vladimir Barinov
2017-09-20 12:51   ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdVVCBUgOrFrTQgVpwkShr8SgE9C7agEov5u5PE2F=h8ng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-09  7:17       ` Simon Horman
2017-10-09  7:17         ` Simon Horman
     [not found] ` <1504737267-22829-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-06 22:35   ` [PATCH 01/18] dt: arm: shmobile: add M3ULCB Kingfisher board DT bindings Vladimir Barinov
2017-09-06 22:35     ` Vladimir Barinov
2017-09-07 10:58     ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdUi9THE7nTd54C22K6kOo_Ye5LkhTrRZPNfcHfWCiBsUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-08  7:05         ` Vladimir Barinov
2017-09-08  7:05           ` Vladimir Barinov
2017-09-06 22:35   ` [PATCH 04/18] arm64: dts: m3ulcb-kf: initial device tree Vladimir Barinov
2017-09-06 22:35     ` Vladimir Barinov
2017-09-06 22:35   ` [PATCH 07/18] arm64: dts: ulcb-kf: enable SCIF1 Vladimir Barinov
2017-09-06 22:35     ` Vladimir Barinov
     [not found]     ` <1504737358-23113-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-20 12:40       ` Geert Uytterhoeven
2017-09-20 12:40         ` Geert Uytterhoeven
2017-09-06 22:36   ` [PATCH 09/18] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0 Vladimir Barinov
2017-09-06 22:36     ` Vladimir Barinov
     [not found]     ` <1504737377-23191-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-20 12:59       ` Geert Uytterhoeven
2017-09-20 12:59         ` Geert Uytterhoeven
2017-10-06  2:38         ` Vladimir Barinov
2017-10-06  7:15           ` Geert Uytterhoeven
2017-10-06 17:28             ` Vladimir Barinov
     [not found]               ` <1c5fc090-af98-0041-be8b-b06dc81d4670-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-10-09  7:17                 ` Simon Horman
2017-10-09  7:17                   ` Simon Horman
2017-10-12 11:41                 ` Yoshihiro Shimoda
2017-10-12 11:41                   ` Yoshihiro Shimoda
2017-10-12 12:27                   ` Geert Uytterhoeven
2017-09-06 22:36   ` [PATCH 11/18] arm64: dts: ulcb-kf: enable USB2.0 Host " Vladimir Barinov
2017-09-06 22:36     ` Vladimir Barinov
2017-09-20 12:52     ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdW9e-hSEHDbN9PNjLQHYdoXy6jFF=PgbCFb0neN_0Ho2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-09  7:17         ` Simon Horman
2017-10-09  7:17           ` Simon Horman
2017-09-06 22:36   ` [PATCH 12/18] arm64: dts: ulcb-kf: enable PCIE0/1 Vladimir Barinov
2017-09-06 22:36     ` Vladimir Barinov
2017-09-20 13:06     ` Geert Uytterhoeven
2017-09-06 22:36   ` [PATCH 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2 Vladimir Barinov
2017-09-06 22:36     ` Vladimir Barinov
2017-09-07 10:49     ` Geert Uytterhoeven
2017-09-06 22:37   ` [PATCH 16/18] arm64: dts: ulcb-kf: enable PCA9548 " Vladimir Barinov
2017-09-06 22:37     ` Vladimir Barinov
2017-09-07 10:37     ` Geert Uytterhoeven
2017-09-06 22:36 ` [PATCH 13/18] arm64: dts: ulcb-kf: enable USB3.0 Host Vladimir Barinov
2017-09-20 13:07   ` Geert Uytterhoeven
2017-10-09  7:16     ` Simon Horman
2017-09-06 22:37 ` [PATCH 15/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C4 Vladimir Barinov
2017-09-07 10:50   ` Geert Uytterhoeven
2017-09-06 22:37 ` [PATCH 17/18] arm64: dts: ulcb-kf: enable PCA9548 " Vladimir Barinov
     [not found]   ` <1504737438-23504-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-07 10:51     ` Geert Uytterhoeven
2017-09-07 10:51       ` Geert Uytterhoeven
2017-09-06 22:37 ` [PATCH 18/18] arm64: dts: ulcb-kf: hog USB3 hub control gpios Vladimir Barinov
     [not found]   ` <1504737444-23544-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-09-20 13:50     ` Geert Uytterhoeven
2017-09-20 13:50       ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdUqvdQZXrsf_p0rTUfKicvWBNPjk+Dt-ke_tSwmU1O=7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-09  7:15         ` Simon Horman
2017-10-09  7:15           ` Simon Horman
2017-09-06 22:45 ` [PATCH 0/18] arm64: renesas: add ULCB Kingfisher board Vladimir Barinov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.