All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mst@redhat.com" <mst@redhat.com>
Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks
Date: Fri, 6 Oct 2017 17:43:22 +0000	[thread overview]
Message-ID: <1507311801.2602.12.camel@wdc.com> (raw)
In-Reply-To: <20171006173538.GA4106@lst.de>

On Fri, 2017-10-06 at 19:35 +0200, Christoph Hellwig wrote:
> On Fri, Oct 06, 2017 at 10:23:53AM -0700, Bart Van Assche wrote:
> > The purpose of patch "linux/types.h: enable endian checks for all
> > sparse builds" was to encourage driver authors to annotate
> > endianness correctly in their drivers. However, since that patch
> > went upstream no endianness annotations in drivers have been fixed.
> > I think that this shows that the followed approach does not work,
> > probably because several driver authors do not use sparse. Restore
> > the ability to disable sparse endianness checks such that it
> > becomes again easy to review other sparse diagnostics for people
> > who want to analyze drivers they are not the author of.
> 
> So how do we get people to do it?  Out of the sparse checks endianess
> warnings are the most useful, together with __user and __iomem.

Hello Christoph,

That's an excellent question. Do you think it would help if the zero-day
kernel testing infrastructure would check whether kernel patches introduce
new sparse complaints and if this is the case post these as a reply to the
e-mail with the patch that introduced the new sparse warnings?

Bart.

  reply	other threads:[~2017-10-06 17:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 17:23 [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Bart Van Assche
2017-10-06 17:35 ` Christoph Hellwig
2017-10-06 17:43   ` Bart Van Assche [this message]
2017-10-16  9:33     ` Javier González
2017-10-09 13:22 ` Michael S. Tsirkin
2017-10-09 15:07   ` Bart Van Assche
2017-10-09 17:42     ` Michael S. Tsirkin
2017-10-10 16:38       ` Bart Van Assche
2017-10-16 13:34         ` Michael S. Tsirkin
2017-10-16 13:57           ` Bart Van Assche
2017-10-16 15:27             ` Michael S. Tsirkin
2017-10-16 15:36               ` Bart Van Assche
2017-10-16 16:50                 ` Michael S. Tsirkin
2017-10-16 17:36                   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507311801.2602.12.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.