From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "mst@redhat.com" <mst@redhat.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"qla2xxx-upstream@qlogic.com" <qla2xxx-upstream@qlogic.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks
Date: Mon, 16 Oct 2017 17:36:31 +0000 [thread overview]
Message-ID: <1508175390.2493.24.camel@wdc.com> (raw)
In-Reply-To: <20171016193921-mutt-send-email-mst@kernel.org>
On Mon, 2017-10-16 at 19:50 +0300, Michael S. Tsirkin wrote:
> Right but qla_nvme also triggers these warnings. That's the problem with
> disabling them tree-wide. To me it looks like the time we are spending
> arguing about work-arounds would be better spent just fixing the
> majority of the code. If a couple of places aren't clean and
> need more thought, that's not a big deal.
Making the drivers that are not endianness clean mostly clean is risky. Such
changes would most likely be done by someone who is not the driver author.
Anyone who tries to fix endianness annotations without having a firmware
manual available risks to introduce incorrect endianness annotations. Such
annotations can make code more confusing instead of less.
Bart.
prev parent reply other threads:[~2017-10-16 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 17:23 [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Bart Van Assche
2017-10-06 17:35 ` Christoph Hellwig
2017-10-06 17:43 ` Bart Van Assche
2017-10-16 9:33 ` Javier González
2017-10-09 13:22 ` Michael S. Tsirkin
2017-10-09 15:07 ` Bart Van Assche
2017-10-09 17:42 ` Michael S. Tsirkin
2017-10-10 16:38 ` Bart Van Assche
2017-10-16 13:34 ` Michael S. Tsirkin
2017-10-16 13:57 ` Bart Van Assche
2017-10-16 15:27 ` Michael S. Tsirkin
2017-10-16 15:36 ` Bart Van Assche
2017-10-16 16:50 ` Michael S. Tsirkin
2017-10-16 17:36 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508175390.2493.24.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=qla2xxx-upstream@qlogic.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.