* [PATCH v3] ARM: dts: aspeed: rainier: Add power-config-full-load gpio
@ 2021-10-05 19:22 ` Adriana Kobylak
0 siblings, 0 replies; 7+ messages in thread
From: Adriana Kobylak @ 2021-10-05 19:22 UTC (permalink / raw)
To: joel, eajames, linux-arm-kernel, linux-aspeed
Cc: openbmc, bjwyman, spinler, derekh, shawnmm, Adriana Kobylak
From: Adriana Kobylak <anoo@us.ibm.com>
Add the power-config-full-load described in:
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md#power-config-full-load
The power-config-full-load gpio is designed to be used to specify how
many power supplies the system should have, in rainier it is 2 or 4. If
enough power supplies fail so that the system no longer has redundancy
(no longer n+1), the hardware will signal to the Onboard Chip Controller
that the system may be oversubscribed, and performance may need to be
reduced so the system can maintain it's powered on state.
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
---
v2: Update commit message.
v3: Updated gpio name to power-config-full-load to match design doc.
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 33fae8ad1305..10bde77fb847 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -1998,6 +1998,19 @@ eeprom@51 {
reg = <0x51>;
};
+ pca_pres3: pca9552@60 {
+ compatible = "nxp,pca9552";
+ reg = <0x60>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ gpio-line-names =
+ "", "", "", "", "", "", "", "",
+ "", "", "", "", "", "", "power-config-full-load", "";
+ };
+
pca_pres2: pca9552@61 {
compatible = "nxp,pca9552";
reg = <0x61>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3] ARM: dts: aspeed: rainier: Add power-config-full-load gpio
2021-10-05 19:22 ` Adriana Kobylak
@ 2021-10-08 4:22 ` Joel Stanley
-1 siblings, 0 replies; 7+ messages in thread
From: Joel Stanley @ 2021-10-08 4:22 UTC (permalink / raw)
To: Adriana Kobylak
Cc: Matt Spinler, Derek Howard, linux-aspeed, OpenBMC Maillist,
Adriana Kobylak, Eddie James, Brandon Wyman, shawnmm, Linux ARM
Hi Adriana,
On Tue, 5 Oct 2021 at 19:22, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> Add the power-config-full-load described in:
> https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md#power-config-full-load
>
> The power-config-full-load gpio is designed to be used to specify how
> many power supplies the system should have, in rainier it is 2 or 4. If
> enough power supplies fail so that the system no longer has redundancy
> (no longer n+1), the hardware will signal to the Onboard Chip Controller
> that the system may be oversubscribed, and performance may need to be
> reduced so the system can maintain it's powered on state.
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
This looks good. I think the name is much easier to understand now.
I notice you've dropped all of the other names. Do you not need them?
It would be great if one of the people you cc'd could provide a
reviewed-by before I merge this.
Cheers,
Joel
> ---
>
> v2: Update commit message.
> v3: Updated gpio name to power-config-full-load to match design doc.
>
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 33fae8ad1305..10bde77fb847 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -1998,6 +1998,19 @@ eeprom@51 {
> reg = <0x51>;
> };
>
> + pca_pres3: pca9552@60 {
> + compatible = "nxp,pca9552";
> + reg = <0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "power-config-full-load", "";
> + };
> +
> pca_pres2: pca9552@61 {
> compatible = "nxp,pca9552";
> reg = <0x61>;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] ARM: dts: aspeed: rainier: Add power-config-full-load gpio
@ 2021-10-08 4:22 ` Joel Stanley
0 siblings, 0 replies; 7+ messages in thread
From: Joel Stanley @ 2021-10-08 4:22 UTC (permalink / raw)
To: Adriana Kobylak
Cc: Eddie James, Linux ARM, linux-aspeed, OpenBMC Maillist,
Brandon Wyman, Matt Spinler, Derek Howard, shawnmm,
Adriana Kobylak
Hi Adriana,
On Tue, 5 Oct 2021 at 19:22, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> Add the power-config-full-load described in:
> https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md#power-config-full-load
>
> The power-config-full-load gpio is designed to be used to specify how
> many power supplies the system should have, in rainier it is 2 or 4. If
> enough power supplies fail so that the system no longer has redundancy
> (no longer n+1), the hardware will signal to the Onboard Chip Controller
> that the system may be oversubscribed, and performance may need to be
> reduced so the system can maintain it's powered on state.
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
This looks good. I think the name is much easier to understand now.
I notice you've dropped all of the other names. Do you not need them?
It would be great if one of the people you cc'd could provide a
reviewed-by before I merge this.
Cheers,
Joel
> ---
>
> v2: Update commit message.
> v3: Updated gpio name to power-config-full-load to match design doc.
>
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 33fae8ad1305..10bde77fb847 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -1998,6 +1998,19 @@ eeprom@51 {
> reg = <0x51>;
> };
>
> + pca_pres3: pca9552@60 {
> + compatible = "nxp,pca9552";
> + reg = <0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "power-config-full-load", "";
> + };
> +
> pca_pres2: pca9552@61 {
> compatible = "nxp,pca9552";
> reg = <0x61>;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] ARM: dts: aspeed: rainier: Add power-config-full-load gpio
2021-10-08 4:22 ` Joel Stanley
(?)
@ 2021-10-11 21:54 ` Adriana Kobylak
-1 siblings, 0 replies; 7+ messages in thread
From: Adriana Kobylak @ 2021-10-11 21:54 UTC (permalink / raw)
To: Joel Stanley
Cc: Matt Spinler, Derek Howard, linux-aspeed, OpenBMC Maillist,
Adriana Kobylak, Eddie James, Brandon Wyman, Shawn McCarney,
Linux ARM
[-- Attachment #1: Type: text/plain, Size: 2631 bytes --]
> On Oct 7, 2021, at 11:22 PM, Joel Stanley <joel@jms.id.au> wrote:
>
> Hi Adriana,
>
> On Tue, 5 Oct 2021 at 19:22, Adriana Kobylak <anoo@linux.ibm.com <mailto:anoo@linux.ibm.com>> wrote:
>>
>> From: Adriana Kobylak <anoo@us.ibm.com>
>>
>> Add the power-config-full-load described in:
>> https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md#power-config-full-load
>>
>> The power-config-full-load gpio is designed to be used to specify how
>> many power supplies the system should have, in rainier it is 2 or 4. If
>> enough power supplies fail so that the system no longer has redundancy
>> (no longer n+1), the hardware will signal to the Onboard Chip Controller
>> that the system may be oversubscribed, and performance may need to be
>> reduced so the system can maintain it's powered on state.
>>
>> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
>
> This looks good. I think the name is much easier to understand now.
Thanks, yeah agree is clearer now.
>
> I notice you've dropped all of the other names. Do you not need them?
Right, don’t need them. If we ever do, we’ll go through the same process of proposing adequate names for them in the openbmc design doc.
>
> It would be great if one of the people you cc'd could provide a
> reviewed-by before I merge this.
Sure, seems Eddie just reviewed it.
>
> Cheers,
>
> Joel
>
>> ---
>>
>> v2: Update commit message.
>> v3: Updated gpio name to power-config-full-load to match design doc.
>>
>> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> index 33fae8ad1305..10bde77fb847 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
>> @@ -1998,6 +1998,19 @@ eeprom@51 {
>> reg = <0x51>;
>> };
>>
>> + pca_pres3: pca9552@60 {
>> + compatible = "nxp,pca9552";
>> + reg = <0x60>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> +
>> + gpio-line-names =
>> + "", "", "", "", "", "", "", "",
>> + "", "", "", "", "", "", "power-config-full-load", "";
>> + };
>> +
>> pca_pres2: pca9552@61 {
>> compatible = "nxp,pca9552";
>> reg = <0x61>;
>> --
>> 2.25.1
[-- Attachment #2: Type: text/html, Size: 14600 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] ARM: dts: aspeed: rainier: Add power-config-full-load gpio
2021-10-05 19:22 ` Adriana Kobylak
@ 2021-10-08 12:27 ` Eddie James
-1 siblings, 0 replies; 7+ messages in thread
From: Eddie James @ 2021-10-08 12:27 UTC (permalink / raw)
To: Adriana Kobylak, joel, linux-arm-kernel, linux-aspeed
Cc: spinler, derekh, openbmc, Adriana Kobylak, bjwyman, shawnmm
On 10/5/21 2:22 PM, Adriana Kobylak wrote:
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> Add the power-config-full-load described in:
> https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md#power-config-full-load
>
> The power-config-full-load gpio is designed to be used to specify how
> many power supplies the system should have, in rainier it is 2 or 4. If
> enough power supplies fail so that the system no longer has redundancy
> (no longer n+1), the hardware will signal to the Onboard Chip Controller
> that the system may be oversubscribed, and performance may need to be
> reduced so the system can maintain it's powered on state.
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
>
> v2: Update commit message.
> v3: Updated gpio name to power-config-full-load to match design doc.
>
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 33fae8ad1305..10bde77fb847 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -1998,6 +1998,19 @@ eeprom@51 {
> reg = <0x51>;
> };
>
> + pca_pres3: pca9552@60 {
> + compatible = "nxp,pca9552";
> + reg = <0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "power-config-full-load", "";
> + };
> +
> pca_pres2: pca9552@61 {
> compatible = "nxp,pca9552";
> reg = <0x61>;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] ARM: dts: aspeed: rainier: Add power-config-full-load gpio
@ 2021-10-08 12:27 ` Eddie James
0 siblings, 0 replies; 7+ messages in thread
From: Eddie James @ 2021-10-08 12:27 UTC (permalink / raw)
To: Adriana Kobylak, joel, linux-arm-kernel, linux-aspeed
Cc: openbmc, bjwyman, spinler, derekh, shawnmm, Adriana Kobylak
On 10/5/21 2:22 PM, Adriana Kobylak wrote:
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> Add the power-config-full-load described in:
> https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md#power-config-full-load
>
> The power-config-full-load gpio is designed to be used to specify how
> many power supplies the system should have, in rainier it is 2 or 4. If
> enough power supplies fail so that the system no longer has redundancy
> (no longer n+1), the hardware will signal to the Onboard Chip Controller
> that the system may be oversubscribed, and performance may need to be
> reduced so the system can maintain it's powered on state.
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
>
> v2: Update commit message.
> v3: Updated gpio name to power-config-full-load to match design doc.
>
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 33fae8ad1305..10bde77fb847 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -1998,6 +1998,19 @@ eeprom@51 {
> reg = <0x51>;
> };
>
> + pca_pres3: pca9552@60 {
> + compatible = "nxp,pca9552";
> + reg = <0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio-line-names =
> + "", "", "", "", "", "", "", "",
> + "", "", "", "", "", "", "power-config-full-load", "";
> + };
> +
> pca_pres2: pca9552@61 {
> compatible = "nxp,pca9552";
> reg = <0x61>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread