From: Gerd Hoffmann <kraxel@redhat.com> To: Tina Zhang <tina.zhang@intel.com>, alex.williamson@redhat.com, chris@chris-wilson.co.uk, joonas.lahtinen@linux.intel.com, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, zhi.a.wang@intel.com, kevin.tian@intel.com, daniel@ffwll.ch, kwankhede@nvidia.com Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch> Subject: Re: [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation Date: Mon, 06 Nov 2017 10:01:27 +0100 [thread overview] Message-ID: <1509958887.30277.4.camel@redhat.com> (raw) In-Reply-To: <1509934758-5003-6-git-send-email-tina.zhang@intel.com> Hi, > +/** > + * VFIO_DEVICE_QUERY_GFX_PLANE - _IOW(VFIO_TYPE, VFIO_BASE + 14, > + * struct > vfio_device_query_gfx_plane) > + * > + * Set the drm_plane_type and flags, then retrieve the gfx plane > info. > + * > + * flags supported: > + * - VFIO_GFX_PLANE_TYPE_PROBE and VFIO_GFX_PLANE_TYPE_DMABUF are > set > + * to ask if the mdev supports dma-buf. 0 on support, -EINVAL on > no > + * support for dma-buf. > + * - VFIO_GFX_PLANE_TYPE_PROBE and VFIO_GFX_PLANE_TYPE_REGION are > set > + * to ask if the mdev supports region. 0 on support, -EINVAL on no > + * support for region. > + * - VFIO_GFX_PLANE_TYPE_DMABUF or VFIO_GFX_PLANE_TYPE_REGION is set > + * with each call to query the plane info. > + * - Others are invalid and return -EINVAL. > + * > + * Return: 0 on success, -ENODEV with all out fields zero on mdev > + * device initialization, -errno on other failure. Should also not here that it is not an error if the guest has not defined a plane yet. The ioctl should return success in that case and zero-initialize plane info (drm_format + size + width + height fields). > + */ > +struct vfio_device_gfx_plane_info { > + __u32 argsz; > + __u32 flags; > +#define VFIO_GFX_PLANE_TYPE_PROBE (1 << 0) > +#define VFIO_GFX_PLANE_TYPE_DMABUF (1 << 1) > +#define VFIO_GFX_PLANE_TYPE_REGION (1 << 2) > + /* in */ > + __u32 drm_plane_type; /* type of plane: > DRM_PLANE_TYPE_* */ Add a head field here? People asked @ kvm forum about multihead support. Even if the initial driver version doesn't support it we could add a field so it becomes easier to add it at some point in the future. Probing for available heads could be done with the PROBE flag, i.e. flags = PROBE | DMABUF, plane_type = PRIMARY, head = 0, 1, ... > + __u32 x_hot; /* horizontal position of cursor hotspot */ > + __u32 y_hot; /* vertical position of cursor hotspot */ Needs documentation how the driver signals "no hotspot information available" (using 0xffffffff for example). cheers, Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com> To: Tina Zhang <tina.zhang@intel.com>, alex.williamson@redhat.com, chris@chris-wilson.co.uk, joonas.lahtinen@linux.intel.com, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, zhi.a.wang@intel.com, kevin.tian@intel.com, daniel@ffwll.ch, kwankhede@nvidia.com Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation Date: Mon, 06 Nov 2017 10:01:27 +0100 [thread overview] Message-ID: <1509958887.30277.4.camel@redhat.com> (raw) In-Reply-To: <1509934758-5003-6-git-send-email-tina.zhang@intel.com> Hi, > +/** > + * VFIO_DEVICE_QUERY_GFX_PLANE - _IOW(VFIO_TYPE, VFIO_BASE + 14, > + * struct > vfio_device_query_gfx_plane) > + * > + * Set the drm_plane_type and flags, then retrieve the gfx plane > info. > + * > + * flags supported: > + * - VFIO_GFX_PLANE_TYPE_PROBE and VFIO_GFX_PLANE_TYPE_DMABUF are > set > + * to ask if the mdev supports dma-buf. 0 on support, -EINVAL on > no > + * support for dma-buf. > + * - VFIO_GFX_PLANE_TYPE_PROBE and VFIO_GFX_PLANE_TYPE_REGION are > set > + * to ask if the mdev supports region. 0 on support, -EINVAL on no > + * support for region. > + * - VFIO_GFX_PLANE_TYPE_DMABUF or VFIO_GFX_PLANE_TYPE_REGION is set > + * with each call to query the plane info. > + * - Others are invalid and return -EINVAL. > + * > + * Return: 0 on success, -ENODEV with all out fields zero on mdev > + * device initialization, -errno on other failure. Should also not here that it is not an error if the guest has not defined a plane yet. The ioctl should return success in that case and zero-initialize plane info (drm_format + size + width + height fields). > + */ > +struct vfio_device_gfx_plane_info { > + __u32 argsz; > + __u32 flags; > +#define VFIO_GFX_PLANE_TYPE_PROBE (1 << 0) > +#define VFIO_GFX_PLANE_TYPE_DMABUF (1 << 1) > +#define VFIO_GFX_PLANE_TYPE_REGION (1 << 2) > + /* in */ > + __u32 drm_plane_type; /* type of plane: > DRM_PLANE_TYPE_* */ Add a head field here? People asked @ kvm forum about multihead support. Even if the initial driver version doesn't support it we could add a field so it becomes easier to add it at some point in the future. Probing for available heads could be done with the PROBE flag, i.e. flags = PROBE | DMABUF, plane_type = PRIMARY, head = 0, 1, ... > + __u32 x_hot; /* horizontal position of cursor hotspot */ > + __u32 y_hot; /* vertical position of cursor hotspot */ Needs documentation how the driver signals "no hotspot information available" (using 0xffffffff for example). cheers, Gerd _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-06 9:01 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-06 2:19 [PATCH v16 0/6] drm/i915/gvt: Dma-buf support for GVT-g Tina Zhang 2017-11-06 2:19 ` [PATCH v16 1/6] drm/i915/gvt: Add framebuffer decoder support Tina Zhang 2017-11-06 8:48 ` Gerd Hoffmann 2017-11-06 8:48 ` Gerd Hoffmann 2017-11-06 9:07 ` Zhang, Tina 2017-11-06 9:07 ` Zhang, Tina 2017-11-06 2:19 ` [PATCH v16 2/6] drm: Introduce RGB 64-bit 16:16:16:16 float format Tina Zhang 2017-11-06 2:19 ` Tina Zhang 2017-11-06 2:19 ` [PATCH v16 3/6] drm/i915/gvt: Add " Tina Zhang 2017-11-06 2:19 ` [PATCH v16 4/6] drm/i915/gvt: Add opregion support Tina Zhang 2017-11-06 2:19 ` [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation Tina Zhang 2017-11-06 2:39 ` Alex Williamson 2017-11-06 2:39 ` Alex Williamson 2017-11-06 6:58 ` Zhang, Tina 2017-11-06 6:58 ` Zhang, Tina 2017-11-06 9:05 ` Gerd Hoffmann 2017-11-06 9:05 ` Gerd Hoffmann 2017-11-06 20:36 ` Alex Williamson 2017-11-06 20:36 ` Alex Williamson 2017-11-07 5:00 ` Zhang, Tina 2017-11-07 5:00 ` Zhang, Tina 2017-11-06 9:01 ` Gerd Hoffmann [this message] 2017-11-06 9:01 ` Gerd Hoffmann 2017-11-07 5:44 ` Zhang, Tina 2017-11-07 5:44 ` Zhang, Tina 2017-11-07 8:03 ` Gerd Hoffmann 2017-11-07 8:03 ` Gerd Hoffmann 2017-11-07 16:48 ` Alex Williamson 2017-11-08 8:25 ` Gerd Hoffmann 2017-11-08 21:19 ` Alex Williamson 2017-11-08 5:21 ` Zhang, Tina 2017-11-08 5:21 ` Zhang, Tina 2017-11-06 2:19 ` [PATCH v16 6/6] drm/i915/gvt: Dmabuf support for GVT-g Tina Zhang 2017-11-06 2:26 ` ✗ Fi.CI.BAT: failure for drm/i915/gvt: Dma-buf " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1509958887.30277.4.camel@redhat.com \ --to=kraxel@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=chris@chris-wilson.co.uk \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel@ffwll.ch \ --cc=intel-gfx@lists.freedesktop.org \ --cc=intel-gvt-dev@lists.freedesktop.org \ --cc=joonas.lahtinen@linux.intel.com \ --cc=kevin.tian@intel.com \ --cc=kwankhede@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=tina.zhang@intel.com \ --cc=zhenyuw@linux.intel.com \ --cc=zhi.a.wang@intel.com \ --cc=zhiyuan.lv@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.