All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Zhang, Tina" <tina.zhang@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"joonas.lahtinen@linux.intel.com"
	<joonas.lahtinen@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
	"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
	"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
	"Lv, Zhiyuan" <zhiyuan.lv@intel.com>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"intel-gvt-dev@lists.freedesktop.org" 
	<intel-gvt-dev@lists.freedesktop.org>,
	"Wang, Zhi A" <zhi.a.wang@intel.com>
Subject: Re: [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation
Date: Mon, 06 Nov 2017 10:05:34 +0100	[thread overview]
Message-ID: <1509959134.30277.6.camel@redhat.com> (raw)
In-Reply-To: <237F54289DF84E4997F34151298ABEBC7C62533C@SHSMSX101.ccr.corp.intel.com>

  Hi,

> > I thought we had agreed to make this behave similar to
> > VFIO_GROUP_GET_DEVICE_FD, the ioctl would take a __u32 dmabuf_id
> > and
> > return the file descriptor as the ioctl return value.  Thanks,
> 
> If we follow VFIO_GROUP_GET_DEVICE_FD, we would lose flags
> functionality.
> Zhi and Zhenyu, how do you think about it?

The ioctl is simple enough that not having flags should not be a
problem I think.

Also note that dmabuf_id is received using the PLANE_INFO ioctl, so
should the need arise to negotiate something in the future chances are
high that it can be done using the PLANE_INFO ioctl flags.

cheers,
  Gerd

WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Zhang, Tina" <tina.zhang@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
	"Lv, Zhiyuan" <zhiyuan.lv@intel.com>,
	"intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation
Date: Mon, 06 Nov 2017 10:05:34 +0100	[thread overview]
Message-ID: <1509959134.30277.6.camel@redhat.com> (raw)
In-Reply-To: <237F54289DF84E4997F34151298ABEBC7C62533C@SHSMSX101.ccr.corp.intel.com>

  Hi,

> > I thought we had agreed to make this behave similar to
> > VFIO_GROUP_GET_DEVICE_FD, the ioctl would take a __u32 dmabuf_id
> > and
> > return the file descriptor as the ioctl return value.  Thanks,
> 
> If we follow VFIO_GROUP_GET_DEVICE_FD, we would lose flags
> functionality.
> Zhi and Zhenyu, how do you think about it?

The ioctl is simple enough that not having flags should not be a
problem I think.

Also note that dmabuf_id is received using the PLANE_INFO ioctl, so
should the need arise to negotiate something in the future chances are
high that it can be done using the PLANE_INFO ioctl flags.

cheers,
  Gerd

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-11-06  9:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06  2:19 [PATCH v16 0/6] drm/i915/gvt: Dma-buf support for GVT-g Tina Zhang
2017-11-06  2:19 ` [PATCH v16 1/6] drm/i915/gvt: Add framebuffer decoder support Tina Zhang
2017-11-06  8:48   ` Gerd Hoffmann
2017-11-06  8:48     ` Gerd Hoffmann
2017-11-06  9:07     ` Zhang, Tina
2017-11-06  9:07       ` Zhang, Tina
2017-11-06  2:19 ` [PATCH v16 2/6] drm: Introduce RGB 64-bit 16:16:16:16 float format Tina Zhang
2017-11-06  2:19   ` Tina Zhang
2017-11-06  2:19 ` [PATCH v16 3/6] drm/i915/gvt: Add " Tina Zhang
2017-11-06  2:19 ` [PATCH v16 4/6] drm/i915/gvt: Add opregion support Tina Zhang
2017-11-06  2:19 ` [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation Tina Zhang
2017-11-06  2:39   ` Alex Williamson
2017-11-06  2:39     ` Alex Williamson
2017-11-06  6:58     ` Zhang, Tina
2017-11-06  6:58       ` Zhang, Tina
2017-11-06  9:05       ` Gerd Hoffmann [this message]
2017-11-06  9:05         ` Gerd Hoffmann
2017-11-06 20:36         ` Alex Williamson
2017-11-06 20:36           ` Alex Williamson
2017-11-07  5:00           ` Zhang, Tina
2017-11-07  5:00             ` Zhang, Tina
2017-11-06  9:01   ` Gerd Hoffmann
2017-11-06  9:01     ` Gerd Hoffmann
2017-11-07  5:44     ` Zhang, Tina
2017-11-07  5:44       ` Zhang, Tina
2017-11-07  8:03       ` Gerd Hoffmann
2017-11-07  8:03         ` Gerd Hoffmann
2017-11-07 16:48         ` Alex Williamson
2017-11-08  8:25           ` Gerd Hoffmann
2017-11-08 21:19             ` Alex Williamson
2017-11-08  5:21         ` Zhang, Tina
2017-11-08  5:21           ` Zhang, Tina
2017-11-06  2:19 ` [PATCH v16 6/6] drm/i915/gvt: Dmabuf support for GVT-g Tina Zhang
2017-11-06  2:26 ` ✗ Fi.CI.BAT: failure for drm/i915/gvt: Dma-buf " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509959134.30277.6.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kevin.tian@intel.com \
    --cc=kwankhede@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tina.zhang@intel.com \
    --cc=zhenyuw@linux.intel.com \
    --cc=zhi.a.wang@intel.com \
    --cc=zhiyuan.lv@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.