All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
	mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
	daniel.lezcano@linaro.org, tglx@linutronix.de,
	ludovic.barre@st.com, julien.thierry@arm.com,
	sudeep.holla@arm.com, arnd@arndb.de
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: [PATCH v8 3/6] clocksource: stm32: increase min delta value
Date: Tue, 14 Nov 2017 09:52:40 +0100	[thread overview]
Message-ID: <1510649563-22975-4-git-send-email-benjamin.gaignard@linaro.org> (raw)
In-Reply-To: <1510649563-22975-1-git-send-email-benjamin.gaignard@linaro.org>

The CPU is a CortexM4 @ 200MHZ and the clocks driving
the timers are at 90MHZ with a min delta at 1 you could
have an interrupt each 0.01 ms which is really to much.
By increase it to 0x60 it give more time (around 1 ms)
to CPU to handle the interrupt.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
---
 drivers/clocksource/timer-stm32.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c
index fc61fd1..ae41a19 100644
--- a/drivers/clocksource/timer-stm32.c
+++ b/drivers/clocksource/timer-stm32.c
@@ -36,6 +36,8 @@
 
 #define TIM_EGR_UG	BIT(0)
 
+#define MIN_DELTA	0x60
+
 static int stm32_clock_event_shutdown(struct clock_event_device *evt)
 {
 	struct timer_of *to = to_timer_of(evt);
@@ -129,7 +131,7 @@ static int __init stm32_clockevent_init(struct device_node *node)
 	writel_relaxed(0, timer_of_base(to) + TIM_SR);
 
 	clockevents_config_and_register(&to->clkevt,
-					timer_of_period(to), 0x1, max_delta);
+					timer_of_period(to), MIN_DELTA, max_delta);
 
 	pr_info("%pOF: STM32 clockevent driver initialized (%d bits)\n",
 			node, bits);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	alexandre.torgue-qxv4g6HH51o@public.gmane.org,
	daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
	ludovic.barre-qxv4g6HH51o@public.gmane.org,
	julien.thierry-5wv7dgnIgG8@public.gmane.org,
	sudeep.holla-5wv7dgnIgG8@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Benjamin Gaignard
	<benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: [PATCH v8 3/6] clocksource: stm32: increase min delta value
Date: Tue, 14 Nov 2017 09:52:40 +0100	[thread overview]
Message-ID: <1510649563-22975-4-git-send-email-benjamin.gaignard@linaro.org> (raw)
In-Reply-To: <1510649563-22975-1-git-send-email-benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

The CPU is a CortexM4 @ 200MHZ and the clocks driving
the timers are at 90MHZ with a min delta at 1 you could
have an interrupt each 0.01 ms which is really to much.
By increase it to 0x60 it give more time (around 1 ms)
to CPU to handle the interrupt.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 drivers/clocksource/timer-stm32.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c
index fc61fd1..ae41a19 100644
--- a/drivers/clocksource/timer-stm32.c
+++ b/drivers/clocksource/timer-stm32.c
@@ -36,6 +36,8 @@
 
 #define TIM_EGR_UG	BIT(0)
 
+#define MIN_DELTA	0x60
+
 static int stm32_clock_event_shutdown(struct clock_event_device *evt)
 {
 	struct timer_of *to = to_timer_of(evt);
@@ -129,7 +131,7 @@ static int __init stm32_clockevent_init(struct device_node *node)
 	writel_relaxed(0, timer_of_base(to) + TIM_SR);
 
 	clockevents_config_and_register(&to->clkevt,
-					timer_of_period(to), 0x1, max_delta);
+					timer_of_period(to), MIN_DELTA, max_delta);
 
 	pr_info("%pOF: STM32 clockevent driver initialized (%d bits)\n",
 			node, bits);
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: benjamin.gaignard@linaro.org (Benjamin Gaignard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 3/6] clocksource: stm32: increase min delta value
Date: Tue, 14 Nov 2017 09:52:40 +0100	[thread overview]
Message-ID: <1510649563-22975-4-git-send-email-benjamin.gaignard@linaro.org> (raw)
In-Reply-To: <1510649563-22975-1-git-send-email-benjamin.gaignard@linaro.org>

The CPU is a CortexM4 @ 200MHZ and the clocks driving
the timers are at 90MHZ with a min delta at 1 you could
have an interrupt each 0.01 ms which is really to much.
By increase it to 0x60 it give more time (around 1 ms)
to CPU to handle the interrupt.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
---
 drivers/clocksource/timer-stm32.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c
index fc61fd1..ae41a19 100644
--- a/drivers/clocksource/timer-stm32.c
+++ b/drivers/clocksource/timer-stm32.c
@@ -36,6 +36,8 @@
 
 #define TIM_EGR_UG	BIT(0)
 
+#define MIN_DELTA	0x60
+
 static int stm32_clock_event_shutdown(struct clock_event_device *evt)
 {
 	struct timer_of *to = to_timer_of(evt);
@@ -129,7 +131,7 @@ static int __init stm32_clockevent_init(struct device_node *node)
 	writel_relaxed(0, timer_of_base(to) + TIM_SR);
 
 	clockevents_config_and_register(&to->clkevt,
-					timer_of_period(to), 0x1, max_delta);
+					timer_of_period(to), MIN_DELTA, max_delta);
 
 	pr_info("%pOF: STM32 clockevent driver initialized (%d bits)\n",
 			node, bits);
-- 
2.7.4

  parent reply	other threads:[~2017-11-14  8:53 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14  8:52 [PATCH v8 0/6] stm32 clocksource driver rework Benjamin Gaignard
2017-11-14  8:52 ` Benjamin Gaignard
2017-11-14  8:52 ` Benjamin Gaignard
2017-11-14  8:52 ` [PATCH v8 1/6] clocksource: timer_of: rename timer_of_exit to timer_of_cleanup Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-14 10:24   ` [tip:timers/urgent] clocksource/timer_of: Rename " tip-bot for Benjamin Gaignard
2017-11-14  8:52 ` [PATCH v8 2/6] clocksource: stm32: convert driver to timer_of Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-14  8:52 ` Benjamin Gaignard [this message]
2017-11-14  8:52   ` [PATCH v8 3/6] clocksource: stm32: increase min delta value Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-12-08  9:28   ` Daniel Lezcano
2017-12-08  9:28     ` Daniel Lezcano
2017-11-14  8:52 ` [PATCH v8 4/6] clocksource: stm32: only use 32 bits timers Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-12-07 15:27   ` Daniel Lezcano
2017-12-07 15:27     ` Daniel Lezcano
2017-12-07 15:27     ` Daniel Lezcano
2017-12-07 16:33     ` Benjamin Gaignard
2017-12-07 16:33       ` Benjamin Gaignard
2017-12-07 16:49       ` Daniel Lezcano
2017-12-07 16:49         ` Daniel Lezcano
2017-12-07 20:36         ` Benjamin Gaignard
2017-12-07 20:36           ` Benjamin Gaignard
2017-12-08  7:52           ` Daniel Lezcano
2017-12-08  7:52             ` Daniel Lezcano
2017-12-08  7:52             ` Daniel Lezcano
2017-12-08  8:34   ` Daniel Lezcano
2017-12-08  8:34     ` Daniel Lezcano
2017-12-08  8:34     ` Daniel Lezcano
2017-12-08  9:25     ` Benjamin Gaignard
2017-12-08  9:25       ` Benjamin Gaignard
2017-12-08  9:25       ` Benjamin Gaignard
2017-12-08  9:29       ` Daniel Lezcano
2017-12-08  9:29         ` Daniel Lezcano
2017-12-08  9:29         ` Daniel Lezcano
2017-12-08  9:31         ` Benjamin Gaignard
2017-12-08  9:31           ` Benjamin Gaignard
2017-12-08  9:31           ` Benjamin Gaignard
2017-11-14  8:52 ` [PATCH v8 5/6] clocksource: stm32: add clocksource support Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-14  8:52 ` [PATCH v8 6/6] arm: dts: stm32: remove useless clocksource nodes Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-14  8:52   ` Benjamin Gaignard
2017-11-27 10:44 ` [PATCH v8 0/6] stm32 clocksource driver rework Benjamin Gaignard
2017-11-27 10:44   ` Benjamin Gaignard
2017-12-05 10:12 ` Alexandre Torgue
2017-12-05 10:12   ` Alexandre Torgue
2017-12-05 10:12   ` Alexandre Torgue
2017-12-05 10:15   ` Daniel Lezcano
2017-12-05 10:15     ` Daniel Lezcano
2017-12-05 10:16     ` Alexandre Torgue
2017-12-05 10:16       ` Alexandre Torgue
2017-12-05 10:16       ` Alexandre Torgue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510649563-22975-4-git-send-email-benjamin.gaignard@linaro.org \
    --to=benjamin.gaignard@linaro.org \
    --cc=alexandre.torgue@st.com \
    --cc=arnd@arndb.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=julien.thierry@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ludovic.barre@st.com \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.