From: Benjamin Gaignard <benjamin.gaignard@linaro.org> To: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King - ARM Linux <linux@armlinux.org.uk>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Thomas Gleixner <tglx@linutronix.de>, Ludovic Barre <ludovic.barre@st.com>, Julien Thierry <julien.thierry@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Arnd Bergmann <arnd@arndb.de>, devicetree@vger.kernel.org, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v8 4/6] clocksource: stm32: only use 32 bits timers Date: Thu, 7 Dec 2017 21:36:09 +0100 [thread overview] Message-ID: <CA+M3ks4KLy0VkJOSGR7tmefOT1rw9nrMsRQvwwK-YZQ7Gm7hQA@mail.gmail.com> (raw) In-Reply-To: <2afa343b-3a23-3352-33b3-2133678a4122@linaro.org> 2017-12-07 17:49 GMT+01:00 Daniel Lezcano <daniel.lezcano@linaro.org>: > On 07/12/2017 17:33, Benjamin Gaignard wrote: >> 2017-12-07 16:27 GMT+01:00 Daniel Lezcano <daniel.lezcano@linaro.org>: >>> On 14/11/2017 09:52, Benjamin Gaignard wrote: >>>> The clock driving counters is at 90MHz so the maximum period >>>> for 16 bis counters is around 750 ms which is a short period >>>> for a clocksource. >>> >>> Isn't it 728us ? >> >> yes it is: 2^16 / 90.000.000 => 728us > > Ok, now I can do the connection with the previous patch. > > So, the real issue of all this is the 16bits clocksource is wrapping up > every 728us, hence the clockevent periodically expires every ~728us to > keep the timekeeping consistent. Unfortunately, the kernel has a too > high overhead for this as the system is consistently processing this > timer leading to a CPU time resource starvation. > > Is that correct ? Yes that is correct > > >>>> For 32 bits counters this period is close >>>> 47 secondes which is more acceptable. >>>> >>>> This patch remove 16 bits counters support and makes sure that >>>> they won't be probed anymore. >>>> >>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> >>>> --- >>>> drivers/clocksource/timer-stm32.c | 26 ++++++++++++-------------- >>>> 1 file changed, 12 insertions(+), 14 deletions(-) >>>> >>>> diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c >>>> index ae41a19..8173bcf 100644 >>>> --- a/drivers/clocksource/timer-stm32.c >>>> +++ b/drivers/clocksource/timer-stm32.c >>>> @@ -83,9 +83,9 @@ static irqreturn_t stm32_clock_event_handler(int irq, void *dev_id) >>>> static int __init stm32_clockevent_init(struct device_node *node) >>>> { >>>> struct reset_control *rstc; >>>> - unsigned long max_delta; >>>> - int ret, bits, prescaler = 1; >>>> + unsigned long max_arr; >>>> struct timer_of *to; >>>> + int ret; >>>> >>>> to = kzalloc(sizeof(*to), GFP_KERNEL); >>>> if (!to) >>>> @@ -115,29 +115,27 @@ static int __init stm32_clockevent_init(struct device_node *node) >>>> >>>> /* Detect whether the timer is 16 or 32 bits */ >>>> writel_relaxed(~0U, timer_of_base(to) + TIM_ARR); >>>> - max_delta = readl_relaxed(timer_of_base(to) + TIM_ARR); >>>> - if (max_delta == ~0U) { >>>> - prescaler = 1; >>>> - bits = 32; >>>> - } else { >>>> - prescaler = 1024; >>>> - bits = 16; >>>> + max_arr = readl_relaxed(timer_of_base(to) + TIM_ARR); >>>> + if (max_arr != ~0U) { >>>> + pr_err("32 bits timer is needed\n"); >>>> + ret = -EINVAL; >>>> + goto deinit; >>>> } >>>> + >>>> writel_relaxed(0, timer_of_base(to) + TIM_ARR); >>>> >>>> - writel_relaxed(prescaler - 1, timer_of_base(to) + TIM_PSC); >>>> + writel_relaxed(0, timer_of_base(to) + TIM_PSC); >>>> writel_relaxed(TIM_EGR_UG, timer_of_base(to) + TIM_EGR); >>>> writel_relaxed(TIM_DIER_UIE, timer_of_base(to) + TIM_DIER); >>>> writel_relaxed(0, timer_of_base(to) + TIM_SR); >>>> >>>> clockevents_config_and_register(&to->clkevt, >>>> - timer_of_period(to), MIN_DELTA, max_delta); >>>> - >>>> - pr_info("%pOF: STM32 clockevent driver initialized (%d bits)\n", >>>> - node, bits); >>>> + timer_of_period(to), MIN_DELTA, ~0U); >>>> >>>> return 0; >>>> >>>> +deinit: >>>> + timer_of_exit(to); >>>> err: >>>> kfree(to); >>>> return ret; >>>> >>> >>> >>> -- >>> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs >>> >>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | >>> <http://twitter.com/#!/linaroorg> Twitter | >>> <http://www.linaro.org/linaro-blog/> Blog >>> >> >> >> > > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog > -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: benjamin.gaignard@linaro.org (Benjamin Gaignard) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v8 4/6] clocksource: stm32: only use 32 bits timers Date: Thu, 7 Dec 2017 21:36:09 +0100 [thread overview] Message-ID: <CA+M3ks4KLy0VkJOSGR7tmefOT1rw9nrMsRQvwwK-YZQ7Gm7hQA@mail.gmail.com> (raw) In-Reply-To: <2afa343b-3a23-3352-33b3-2133678a4122@linaro.org> 2017-12-07 17:49 GMT+01:00 Daniel Lezcano <daniel.lezcano@linaro.org>: > On 07/12/2017 17:33, Benjamin Gaignard wrote: >> 2017-12-07 16:27 GMT+01:00 Daniel Lezcano <daniel.lezcano@linaro.org>: >>> On 14/11/2017 09:52, Benjamin Gaignard wrote: >>>> The clock driving counters is at 90MHz so the maximum period >>>> for 16 bis counters is around 750 ms which is a short period >>>> for a clocksource. >>> >>> Isn't it 728us ? >> >> yes it is: 2^16 / 90.000.000 => 728us > > Ok, now I can do the connection with the previous patch. > > So, the real issue of all this is the 16bits clocksource is wrapping up > every 728us, hence the clockevent periodically expires every ~728us to > keep the timekeeping consistent. Unfortunately, the kernel has a too > high overhead for this as the system is consistently processing this > timer leading to a CPU time resource starvation. > > Is that correct ? Yes that is correct > > >>>> For 32 bits counters this period is close >>>> 47 secondes which is more acceptable. >>>> >>>> This patch remove 16 bits counters support and makes sure that >>>> they won't be probed anymore. >>>> >>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> >>>> --- >>>> drivers/clocksource/timer-stm32.c | 26 ++++++++++++-------------- >>>> 1 file changed, 12 insertions(+), 14 deletions(-) >>>> >>>> diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c >>>> index ae41a19..8173bcf 100644 >>>> --- a/drivers/clocksource/timer-stm32.c >>>> +++ b/drivers/clocksource/timer-stm32.c >>>> @@ -83,9 +83,9 @@ static irqreturn_t stm32_clock_event_handler(int irq, void *dev_id) >>>> static int __init stm32_clockevent_init(struct device_node *node) >>>> { >>>> struct reset_control *rstc; >>>> - unsigned long max_delta; >>>> - int ret, bits, prescaler = 1; >>>> + unsigned long max_arr; >>>> struct timer_of *to; >>>> + int ret; >>>> >>>> to = kzalloc(sizeof(*to), GFP_KERNEL); >>>> if (!to) >>>> @@ -115,29 +115,27 @@ static int __init stm32_clockevent_init(struct device_node *node) >>>> >>>> /* Detect whether the timer is 16 or 32 bits */ >>>> writel_relaxed(~0U, timer_of_base(to) + TIM_ARR); >>>> - max_delta = readl_relaxed(timer_of_base(to) + TIM_ARR); >>>> - if (max_delta == ~0U) { >>>> - prescaler = 1; >>>> - bits = 32; >>>> - } else { >>>> - prescaler = 1024; >>>> - bits = 16; >>>> + max_arr = readl_relaxed(timer_of_base(to) + TIM_ARR); >>>> + if (max_arr != ~0U) { >>>> + pr_err("32 bits timer is needed\n"); >>>> + ret = -EINVAL; >>>> + goto deinit; >>>> } >>>> + >>>> writel_relaxed(0, timer_of_base(to) + TIM_ARR); >>>> >>>> - writel_relaxed(prescaler - 1, timer_of_base(to) + TIM_PSC); >>>> + writel_relaxed(0, timer_of_base(to) + TIM_PSC); >>>> writel_relaxed(TIM_EGR_UG, timer_of_base(to) + TIM_EGR); >>>> writel_relaxed(TIM_DIER_UIE, timer_of_base(to) + TIM_DIER); >>>> writel_relaxed(0, timer_of_base(to) + TIM_SR); >>>> >>>> clockevents_config_and_register(&to->clkevt, >>>> - timer_of_period(to), MIN_DELTA, max_delta); >>>> - >>>> - pr_info("%pOF: STM32 clockevent driver initialized (%d bits)\n", >>>> - node, bits); >>>> + timer_of_period(to), MIN_DELTA, ~0U); >>>> >>>> return 0; >>>> >>>> +deinit: >>>> + timer_of_exit(to); >>>> err: >>>> kfree(to); >>>> return ret; >>>> >>> >>> >>> -- >>> <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs >>> >>> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | >>> <http://twitter.com/#!/linaroorg> Twitter | >>> <http://www.linaro.org/linaro-blog/> Blog >>> >> >> >> > > > -- > <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog > -- Benjamin Gaignard Graphic Study Group Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-12-07 20:36 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-14 8:52 [PATCH v8 0/6] stm32 clocksource driver rework Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` [PATCH v8 1/6] clocksource: timer_of: rename timer_of_exit to timer_of_cleanup Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 10:24 ` [tip:timers/urgent] clocksource/timer_of: Rename " tip-bot for Benjamin Gaignard 2017-11-14 8:52 ` [PATCH v8 2/6] clocksource: stm32: convert driver to timer_of Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` [PATCH v8 3/6] clocksource: stm32: increase min delta value Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-12-08 9:28 ` Daniel Lezcano 2017-12-08 9:28 ` Daniel Lezcano 2017-11-14 8:52 ` [PATCH v8 4/6] clocksource: stm32: only use 32 bits timers Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-12-07 15:27 ` Daniel Lezcano 2017-12-07 15:27 ` Daniel Lezcano 2017-12-07 15:27 ` Daniel Lezcano 2017-12-07 16:33 ` Benjamin Gaignard 2017-12-07 16:33 ` Benjamin Gaignard 2017-12-07 16:49 ` Daniel Lezcano 2017-12-07 16:49 ` Daniel Lezcano 2017-12-07 20:36 ` Benjamin Gaignard [this message] 2017-12-07 20:36 ` Benjamin Gaignard 2017-12-08 7:52 ` Daniel Lezcano 2017-12-08 7:52 ` Daniel Lezcano 2017-12-08 7:52 ` Daniel Lezcano 2017-12-08 8:34 ` Daniel Lezcano 2017-12-08 8:34 ` Daniel Lezcano 2017-12-08 8:34 ` Daniel Lezcano 2017-12-08 9:25 ` Benjamin Gaignard 2017-12-08 9:25 ` Benjamin Gaignard 2017-12-08 9:25 ` Benjamin Gaignard 2017-12-08 9:29 ` Daniel Lezcano 2017-12-08 9:29 ` Daniel Lezcano 2017-12-08 9:29 ` Daniel Lezcano 2017-12-08 9:31 ` Benjamin Gaignard 2017-12-08 9:31 ` Benjamin Gaignard 2017-12-08 9:31 ` Benjamin Gaignard 2017-11-14 8:52 ` [PATCH v8 5/6] clocksource: stm32: add clocksource support Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` [PATCH v8 6/6] arm: dts: stm32: remove useless clocksource nodes Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-14 8:52 ` Benjamin Gaignard 2017-11-27 10:44 ` [PATCH v8 0/6] stm32 clocksource driver rework Benjamin Gaignard 2017-11-27 10:44 ` Benjamin Gaignard 2017-12-05 10:12 ` Alexandre Torgue 2017-12-05 10:12 ` Alexandre Torgue 2017-12-05 10:12 ` Alexandre Torgue 2017-12-05 10:15 ` Daniel Lezcano 2017-12-05 10:15 ` Daniel Lezcano 2017-12-05 10:16 ` Alexandre Torgue 2017-12-05 10:16 ` Alexandre Torgue 2017-12-05 10:16 ` Alexandre Torgue
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+M3ks4KLy0VkJOSGR7tmefOT1rw9nrMsRQvwwK-YZQ7Gm7hQA@mail.gmail.com \ --to=benjamin.gaignard@linaro.org \ --cc=alexandre.torgue@st.com \ --cc=arnd@arndb.de \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=julien.thierry@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=ludovic.barre@st.com \ --cc=mark.rutland@arm.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.