From: Takuo Koguchi <takuo.koguchi@gmail.com> To: lkml@vger.kernel.org, khoroshilov@ispras.ru, takuo.koguchi.sw@gmail.com Cc: Takuo Koguchi <takuo.koguchi.sw@hitachi.com>, Mark Brown <broonie@kernel.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, Chen-Yu Tsai <wens@csie.org>, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: sun4i: disable clocks in the remove function Date: Thu, 7 Dec 2017 00:22:13 +0900 [thread overview] Message-ID: <1512573752-13091-1-git-send-email-takuo.koguchi.sw@hitachi.com> (raw) mclk and hclk need to be disabled explicitly since pm_runtime_disable does not disable the clocks. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@hitachi.com> --- drivers/spi/spi-sun4i.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index c5cd635..9011c09 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -525,6 +525,11 @@ static int sun4i_spi_probe(struct platform_device *pdev) static int sun4i_spi_remove(struct platform_device *pdev) { + struct spi_master *master = dev_get_drvdata(&pdev->dev); + struct sun4i_spi *sspi = spi_master_get_devdata(master); + + clk_disable_unprepare(sspi->mclk); + clk_disable_unprepare(sspi->hclk); pm_runtime_disable(&pdev->dev); return 0; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: takuo.koguchi@gmail.com (Takuo Koguchi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] spi: sun4i: disable clocks in the remove function Date: Thu, 7 Dec 2017 00:22:13 +0900 [thread overview] Message-ID: <1512573752-13091-1-git-send-email-takuo.koguchi.sw@hitachi.com> (raw) mclk and hclk need to be disabled explicitly since pm_runtime_disable does not disable the clocks. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@hitachi.com> --- drivers/spi/spi-sun4i.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index c5cd635..9011c09 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -525,6 +525,11 @@ static int sun4i_spi_probe(struct platform_device *pdev) static int sun4i_spi_remove(struct platform_device *pdev) { + struct spi_master *master = dev_get_drvdata(&pdev->dev); + struct sun4i_spi *sspi = spi_master_get_devdata(master); + + clk_disable_unprepare(sspi->mclk); + clk_disable_unprepare(sspi->hclk); pm_runtime_disable(&pdev->dev); return 0; -- 2.7.4
next reply other threads:[~2017-12-06 14:45 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-06 15:22 Takuo Koguchi [this message] 2017-12-06 15:22 ` [PATCH] spi: sun4i: disable clocks in the remove function Takuo Koguchi 2017-12-06 15:20 ` Maxime Ripard 2017-12-06 15:20 ` Maxime Ripard 2017-12-06 15:20 ` Maxime Ripard 2017-12-06 18:00 ` Takuo Koguchi 2017-12-06 18:00 ` Takuo Koguchi 2017-12-06 18:00 ` Takuo Koguchi 2017-12-07 7:20 ` [PATCH V3] " Takuo Koguchi 2017-12-07 7:20 ` Takuo Koguchi 2017-12-07 7:20 ` Takuo Koguchi 2017-12-07 9:18 ` Maxime Ripard 2017-12-07 9:18 ` Maxime Ripard 2017-12-07 9:18 ` Maxime Ripard 2017-12-07 11:58 ` Mark Brown 2017-12-07 11:58 ` Mark Brown 2017-12-07 11:58 ` Mark Brown 2017-12-07 12:35 ` Applied "spi: sun4i: disable clocks in the remove function" to the spi tree Mark Brown 2017-12-07 12:35 ` Mark Brown 2017-12-07 12:35 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1512573752-13091-1-git-send-email-takuo.koguchi.sw@hitachi.com \ --to=takuo.koguchi@gmail.com \ --cc=broonie@kernel.org \ --cc=khoroshilov@ispras.ru \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=lkml@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=takuo.koguchi.sw@gmail.com \ --cc=takuo.koguchi.sw@hitachi.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.