* [PATCH 0/2] Fix build issues with fitimage
@ 2017-12-14 2:23 Manjukumar Matha
2017-12-14 2:23 ` [PATCH 1/2] kernel.bbclass: Fix fitimage build failure Manjukumar Matha
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Manjukumar Matha @ 2017-12-14 2:23 UTC (permalink / raw)
To: openembedded-core
While building fitimage with initramfs bundle using INITRAMFS_IMAGE and
INITRAMFS_IMAGE_BUNDLE = "1", we have few failures
do_bundle_initramfs fails first stating the below error
| CHK include/generated/compile.h
| CHK kernel/config_data.h
| mv: cannot stat 'arch/arm64/boot/fitImage': No such file or directory
and later in do_deploy
| DEBUG: Python function extend_recipe_sysroot finished
| DEBUG: Executing shell function do_deploy
| install: cannot stat 'arch/arm64/boot/fitImage': No such file or directory
This series fixes both the above issues
Manjukumar Matha (1):
kernel.bbclass: Fix fitimage deploy errors
Thomas Perrot (1):
kernel.bbclass: Fix fitimage build failure
meta/classes/kernel.bbclass | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] kernel.bbclass: Fix fitimage build failure
2017-12-14 2:23 [PATCH 0/2] Fix build issues with fitimage Manjukumar Matha
@ 2017-12-14 2:23 ` Manjukumar Matha
2017-12-14 2:23 ` [PATCH 2/2] kernel.bbclass: Fix fitimage deploy errors Manjukumar Matha
2017-12-14 11:18 ` [PATCH 0/2] Fix build issues with fitimage André Draszik
2 siblings, 0 replies; 6+ messages in thread
From: Manjukumar Matha @ 2017-12-14 2:23 UTC (permalink / raw)
To: openembedded-core
From: Thomas Perrot <thomas.perrot@tupi.fr>
When compiling fitImage with initramfs bundle, the build breaks by
throwing the following error
| CHK include/generated/compile.h
| CHK kernel/config_data.h
| mv: cannot stat 'arch/arm64/boot/fitImage': No such file or directory
Fix the error during this compilation by skipping fitImage in
do_bundle_initramfs function
Signed-off-by: Thomas Perrot <thomas.perrot@tupi.fr>
Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
---
meta/classes/kernel.bbclass | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 7ef4f47..4240752 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -208,7 +208,9 @@ do_bundle_initramfs () {
# Backing up kernel image relies on its type(regular file or symbolic link)
tmp_path=""
for type in ${KERNEL_IMAGETYPES} ; do
- if [ -h ${KERNEL_OUTPUT_DIR}/$type ] ; then
+ if [ "$type" = "fitImage" ] ; then
+ continue
+ elif [ -h ${KERNEL_OUTPUT_DIR}/$type ] ; then
linkpath=`readlink -n ${KERNEL_OUTPUT_DIR}/$type`
realpath=`readlink -fn ${KERNEL_OUTPUT_DIR}/$type`
mv -f $realpath $realpath.bak
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] kernel.bbclass: Fix fitimage deploy errors
2017-12-14 2:23 [PATCH 0/2] Fix build issues with fitimage Manjukumar Matha
2017-12-14 2:23 ` [PATCH 1/2] kernel.bbclass: Fix fitimage build failure Manjukumar Matha
@ 2017-12-14 2:23 ` Manjukumar Matha
2017-12-14 11:18 ` [PATCH 0/2] Fix build issues with fitimage André Draszik
2 siblings, 0 replies; 6+ messages in thread
From: Manjukumar Matha @ 2017-12-14 2:23 UTC (permalink / raw)
To: openembedded-core
When deploying fitImage with initramfs bundle deploy fails with
following error
| DEBUG: Python function extend_recipe_sysroot finished
| DEBUG: Executing shell function do_deploy
| install: cannot stat 'arch/arm64/boot/fitImage': No such file or
directory
Skip using the do_deploy for fitimage in kernel.bbclass, this is handled
by kernel-fitimage.bbclass
Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
---
meta/classes/kernel.bbclass | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 4240752..757bc73 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -630,8 +630,10 @@ MODULE_TARBALL_DEPLOY ?= "1"
kernel_do_deploy() {
for type in ${KERNEL_IMAGETYPES} ; do
- base_name=${type}-${KERNEL_IMAGE_BASE_NAME}
- install -m 0644 ${KERNEL_OUTPUT_DIR}/${type} ${DEPLOYDIR}/${base_name}.bin
+ if [ "$type" != "fitImage" ] ; then
+ base_name=${type}-${KERNEL_IMAGE_BASE_NAME}
+ install -m 0644 ${KERNEL_OUTPUT_DIR}/${type} ${DEPLOYDIR}/${base_name}.bin
+ fi
done
if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
mkdir -p ${D}/lib
@@ -640,10 +642,12 @@ kernel_do_deploy() {
fi
for type in ${KERNEL_IMAGETYPES} ; do
- base_name=${type}-${KERNEL_IMAGE_BASE_NAME}
- symlink_name=${type}-${KERNEL_IMAGE_SYMLINK_NAME}
- ln -sf ${base_name}.bin ${DEPLOYDIR}/${symlink_name}.bin
- ln -sf ${base_name}.bin ${DEPLOYDIR}/${type}
+ if [ "$type" != "fitImage" ] ; then
+ base_name=${type}-${KERNEL_IMAGE_BASE_NAME}
+ symlink_name=${type}-${KERNEL_IMAGE_SYMLINK_NAME}
+ ln -sf ${base_name}.bin ${DEPLOYDIR}/${symlink_name}.bin
+ ln -sf ${base_name}.bin ${DEPLOYDIR}/${type}
+ fi
done
cd ${B}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] Fix build issues with fitimage
2017-12-14 2:23 [PATCH 0/2] Fix build issues with fitimage Manjukumar Matha
2017-12-14 2:23 ` [PATCH 1/2] kernel.bbclass: Fix fitimage build failure Manjukumar Matha
2017-12-14 2:23 ` [PATCH 2/2] kernel.bbclass: Fix fitimage deploy errors Manjukumar Matha
@ 2017-12-14 11:18 ` André Draszik
2017-12-15 0:18 ` Denys Dmytriyenko
2 siblings, 1 reply; 6+ messages in thread
From: André Draszik @ 2017-12-14 11:18 UTC (permalink / raw)
To: openembedded-core
On Wed, 2017-12-13 at 18:23 -0800, Manjukumar Matha wrote:
> While building fitimage with initramfs bundle using INITRAMFS_IMAGE and
> INITRAMFS_IMAGE_BUNDLE = "1", we have few failures
Nothing against these patches, but what is the use-case to do that? Why
don't you just disable INITRAMFS_IMAGE_BUNDLE?
Cheers,
Andre'
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Fix build issues with fitimage
2017-12-14 11:18 ` [PATCH 0/2] Fix build issues with fitimage André Draszik
@ 2017-12-15 0:18 ` Denys Dmytriyenko
2017-12-15 0:56 ` Manjukumar Harthikote Matha
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2017-12-15 0:18 UTC (permalink / raw)
To: André Draszik; +Cc: openembedded-core
On Thu, Dec 14, 2017 at 11:18:15AM +0000, André Draszik wrote:
> On Wed, 2017-12-13 at 18:23 -0800, Manjukumar Matha wrote:
> > While building fitimage with initramfs bundle using INITRAMFS_IMAGE and
> > INITRAMFS_IMAGE_BUNDLE = "1", we have few failures
>
> Nothing against these patches, but what is the use-case to do that? Why
> don't you just disable INITRAMFS_IMAGE_BUNDLE?
+1 here
Also, I don't think this is the first revision of the patch here, so please
specify [PATCH vX] accordingly, with log of changes between revisions.
--
Denys
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Fix build issues with fitimage
2017-12-15 0:18 ` Denys Dmytriyenko
@ 2017-12-15 0:56 ` Manjukumar Harthikote Matha
0 siblings, 0 replies; 6+ messages in thread
From: Manjukumar Harthikote Matha @ 2017-12-15 0:56 UTC (permalink / raw)
To: Denys Dmytriyenko, André Draszik; +Cc: openembedded-core
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Denys Dmytriyenko
> Sent: Thursday, December 14, 2017 4:18 PM
> To: André Draszik <git@andred.net>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 0/2] Fix build issues with fitimage
>
> On Thu, Dec 14, 2017 at 11:18:15AM +0000, André Draszik wrote:
> > On Wed, 2017-12-13 at 18:23 -0800, Manjukumar Matha wrote:
> > > While building fitimage with initramfs bundle using INITRAMFS_IMAGE
> > > and INITRAMFS_IMAGE_BUNDLE = "1", we have few failures
> >
> > Nothing against these patches, but what is the use-case to do that?
> > Why don't you just disable INITRAMFS_IMAGE_BUNDLE?
>
> +1 here
Use case is to deploy fitimage (kernel image + rootfs +dtb) and (kernel image + rootfs) to meet backward compatibility of tools we distribute.
>
> Also, I don't think this is the first revision of the patch here, so please specify [PATCH
> vX] accordingly, with log of changes between revisions.
>
Will do, there was no change in patch. Will add v2 on applicable patch
Thanks,
Manju
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-15 0:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-14 2:23 [PATCH 0/2] Fix build issues with fitimage Manjukumar Matha
2017-12-14 2:23 ` [PATCH 1/2] kernel.bbclass: Fix fitimage build failure Manjukumar Matha
2017-12-14 2:23 ` [PATCH 2/2] kernel.bbclass: Fix fitimage deploy errors Manjukumar Matha
2017-12-14 11:18 ` [PATCH 0/2] Fix build issues with fitimage André Draszik
2017-12-15 0:18 ` Denys Dmytriyenko
2017-12-15 0:56 ` Manjukumar Harthikote Matha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.