From: Bart Van Assche <Bart.VanAssche@wdc.com> To: "ming.lei@redhat.com" <ming.lei@redhat.com>, "axboe@kernel.dk" <axboe@kernel.dk> Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>, "hch@infradead.org" <hch@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "osandov@fb.com" <osandov@fb.com>, "snitzer@redhat.com" <snitzer@redhat.com> Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Date: Fri, 19 Jan 2018 15:20:13 +0000 [thread overview] Message-ID: <1516375212.3190.4.camel@wdc.com> (raw) In-Reply-To: <20180119072623.GB25369@ming.t460p> T24gRnJpLCAyMDE4LTAxLTE5IGF0IDE1OjI2ICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gUGxl YXNlIHNlZSBxdWV1ZV9kZWxheWVkX3dvcmtfb24oKSwgaGN0eC0+cnVuX3dvcmsgaXMgc2hhcmVk IGJ5IGFsbA0KPiBzY2hlZHVsaW5nLCBvbmNlIGJsa19tcV9kZWxheV9ydW5faHdfcXVldWUoMTAw bXMpIHJldHVybnMsIG5vIG5ldw0KPiBzY2hlZHVsaW5nIGNhbiBtYWtlIHByb2dyZXNzIGR1cmlu ZyB0aGUgMTAwbXMuDQoNCkhvdyBhYm91dCBhZGRyZXNzaW5nIHRoYXQgYXMgZm9sbG93czoNCg0K ZGlmZiAtLWdpdCBhL2Jsb2NrL2Jsay1tcS5jIGIvYmxvY2svYmxrLW1xLmMNCmluZGV4IGY3NTE1 ZGQ5NWEzNi4uNTdmODM3OWE0NzZkIDEwMDY0NA0KLS0tIGEvYmxvY2svYmxrLW1xLmMNCisrKyBi L2Jsb2NrL2Jsay1tcS5jDQpAQCAtMTQwMyw5ICsxNDAzLDkgQEAgc3RhdGljIHZvaWQgX19ibGtf bXFfZGVsYXlfcnVuX2h3X3F1ZXVlKHN0cnVjdCBibGtfbXFfaHdfY3R4ICpoY3R4LCBib29sIGFz eW5jLA0KIAkJcHV0X2NwdSgpOw0KIAl9DQogDQotCWtibG9ja2Rfc2NoZWR1bGVfZGVsYXllZF93 b3JrX29uKGJsa19tcV9oY3R4X25leHRfY3B1KGhjdHgpLA0KLQkJCQkJICZoY3R4LT5ydW5fd29y aywNCi0JCQkJCSBtc2Vjc190b19qaWZmaWVzKG1zZWNzKSk7DQorCWtibG9ja2RfbW9kX2RlbGF5 ZWRfd29ya19vbihibGtfbXFfaGN0eF9uZXh0X2NwdShoY3R4KSwNCisJCQkJICAgICZoY3R4LT5y dW5fd29yaywNCisJCQkJICAgIG1zZWNzX3RvX2ppZmZpZXMobXNlY3MpKTsNCiB9DQogDQogdm9p ZCBibGtfbXFfZGVsYXlfcnVuX2h3X3F1ZXVlKHN0cnVjdCBibGtfbXFfaHdfY3R4ICpoY3R4LCB1 bnNpZ25lZCBsb25nIG1zZWNzKQ0KDQpCYXJ0Lg==
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com> To: "ming.lei@redhat.com" <ming.lei@redhat.com>, "axboe@kernel.dk" <axboe@kernel.dk> Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>, "hch@infradead.org" <hch@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "osandov@fb.com" <osandov@fb.com>, "snitzer@redhat.com" <snitzer@redhat.com> Subject: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Date: Fri, 19 Jan 2018 15:20:13 +0000 [thread overview] Message-ID: <1516375212.3190.4.camel@wdc.com> (raw) In-Reply-To: <20180119072623.GB25369@ming.t460p> On Fri, 2018-01-19 at 15:26 +0800, Ming Lei wrote: > Please see queue_delayed_work_on(), hctx->run_work is shared by all > scheduling, once blk_mq_delay_run_hw_queue(100ms) returns, no new > scheduling can make progress during the 100ms. How about addressing that as follows: diff --git a/block/blk-mq.c b/block/blk-mq.c index f7515dd95a36..57f8379a476d 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1403,9 +1403,9 @@ static void __blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async, put_cpu(); } - kblockd_schedule_delayed_work_on(blk_mq_hctx_next_cpu(hctx), - &hctx->run_work, - msecs_to_jiffies(msecs)); + kblockd_mod_delayed_work_on(blk_mq_hctx_next_cpu(hctx), + &hctx->run_work, + msecs_to_jiffies(msecs)); } void blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, unsigned long msecs) Bart.
next prev parent reply other threads:[~2018-01-19 15:20 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-18 2:41 [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Ming Lei 2018-01-18 16:50 ` Bart Van Assche 2018-01-18 17:03 ` Mike Snitzer 2018-01-18 17:03 ` Mike Snitzer 2018-01-18 17:20 ` Bart Van Assche 2018-01-18 17:20 ` Bart Van Assche 2018-01-18 18:30 ` Mike Snitzer 2018-01-18 18:47 ` Bart Van Assche 2018-01-18 18:47 ` Bart Van Assche 2018-01-18 20:11 ` Jens Axboe 2018-01-18 20:11 ` Jens Axboe 2018-01-18 20:48 ` Mike Snitzer 2018-01-18 20:58 ` Bart Van Assche 2018-01-18 20:58 ` Bart Van Assche 2018-01-18 21:23 ` Mike Snitzer 2018-01-18 21:23 ` Mike Snitzer 2018-01-18 21:37 ` Laurence Oberman 2018-01-18 21:39 ` [dm-devel] " Bart Van Assche 2018-01-18 21:39 ` Bart Van Assche 2018-01-18 21:45 ` Laurence Oberman 2018-01-18 21:45 ` Laurence Oberman 2018-01-18 22:01 ` Mike Snitzer 2018-01-18 22:18 ` Laurence Oberman 2018-01-18 22:20 ` Laurence Oberman 2018-01-18 22:20 ` Laurence Oberman 2018-01-18 22:24 ` Bart Van Assche 2018-01-18 22:24 ` Bart Van Assche 2018-01-18 22:35 ` Laurence Oberman 2018-01-18 22:39 ` Jens Axboe 2018-01-18 22:55 ` Bart Van Assche 2018-01-18 22:55 ` Bart Van Assche 2018-01-18 22:20 ` Bart Van Assche 2018-01-18 22:20 ` Bart Van Assche 2018-01-23 9:22 ` [PATCH] block: neutralize blk_insert_cloned_request IO stall regression (was: Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle) Mike Snitzer 2018-01-23 10:53 ` Ming Lei 2018-01-23 12:15 ` Mike Snitzer 2018-01-23 12:17 ` Ming Lei 2018-01-23 12:43 ` Mike Snitzer 2018-01-23 16:43 ` [PATCH] " Bart Van Assche 2018-01-23 16:43 ` Bart Van Assche 2018-01-19 2:32 ` [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle Ming Lei 2018-01-19 4:02 ` Jens Axboe 2018-01-19 7:26 ` Ming Lei 2018-01-19 15:20 ` Bart Van Assche [this message] 2018-01-19 15:20 ` Bart Van Assche 2018-01-19 15:25 ` Jens Axboe 2018-01-19 15:33 ` Ming Lei 2018-01-19 16:06 ` Bart Van Assche 2018-01-19 16:06 ` Bart Van Assche 2018-01-19 15:24 ` Jens Axboe 2018-01-19 15:40 ` Ming Lei 2018-01-19 15:40 ` Ming Lei 2018-01-19 15:48 ` Jens Axboe 2018-01-19 16:05 ` Ming Lei 2018-01-19 16:19 ` Jens Axboe 2018-01-19 16:26 ` Ming Lei 2018-01-19 16:27 ` Jens Axboe 2018-01-19 16:37 ` Ming Lei 2018-01-19 16:41 ` Jens Axboe 2018-01-19 16:41 ` Jens Axboe 2018-01-19 16:47 ` Mike Snitzer 2018-01-19 16:52 ` Jens Axboe 2018-01-19 17:05 ` Ming Lei 2018-01-19 17:09 ` Jens Axboe 2018-01-19 17:20 ` Ming Lei 2018-01-19 17:38 ` Jens Axboe 2018-01-19 18:24 ` Ming Lei 2018-01-19 18:24 ` Ming Lei 2018-01-19 18:33 ` Mike Snitzer 2018-01-19 23:52 ` Ming Lei 2018-01-20 4:27 ` Jens Axboe 2018-01-19 16:13 ` Mike Snitzer 2018-01-19 16:23 ` Jens Axboe 2018-01-19 23:57 ` Ming Lei 2018-01-29 22:37 ` Bart Van Assche 2018-01-19 5:09 ` Bart Van Assche 2018-01-19 5:09 ` Bart Van Assche 2018-01-19 7:34 ` Ming Lei 2018-01-19 19:47 ` Bart Van Assche 2018-01-19 19:47 ` Bart Van Assche
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1516375212.3190.4.camel@wdc.com \ --to=bart.vanassche@wdc.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=hch@infradead.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ming.lei@redhat.com \ --cc=osandov@fb.com \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.