From: Dave Jiang <dave.jiang@intel.com>
To: darrick.wong@oracle.com
Cc: linux-nvdimm@lists.01.org, david@fromorbit.com,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: [PATCH v3 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX
Date: Thu, 08 Feb 2018 17:38:24 -0700 [thread overview]
Message-ID: <151813670468.15926.3966047346830424677.stgit@djiang5-desk3.ch.intel.com> (raw)
In-Reply-To: <151813659955.15926.8922476613392258086.stgit@djiang5-desk3.ch.intel.com>
In a situation where the rt_dev is DAX and data_dev is not DAX, if the user
requests to remove the realtime flag via ioctl we can no longer support DAX
for that file. Dynamic changing of S_DAX on the inode is not supported due
to various complications in the existing implementation. Therefore until we
address the dynamic S_DAX change issues, we must disallow realtime flag
being removed.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
fs/xfs/xfs_ioctl.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index e440d789ed1b..cd5a5c61da39 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -1029,6 +1029,21 @@ xfs_ioctl_setattr_xflags(
{
struct xfs_mount *mp = ip->i_mount;
uint64_t di_flags2;
+ struct inode *inode = VFS_I(ip);
+ struct super_block *sb = inode->i_sb;
+
+ /*
+ * In the case that the inode is realtime, and we are trying to remove
+ * the realtime flag, and the rtdev supports DAX but the datadev does
+ * not support DAX, we can't allow the realtime flag to be removed
+ * since we do not support dynamic S_DAX flag removal yet.
+ */
+ if ((XFS_IS_REALTIME_INODE(ip)) &&
+ !(fa->fsx_xflags & FS_XFLAG_REALTIME) &&
+ bdev_dax_supported(sb, mp->m_rtdev_targp->bt_bdev,
+ sb->s_blocksize) &&
+ !bdev_dax_supported(sb, mp->m_ddev_targp->bt_bdev, sb->s_blocksize))
+ return -ENOTSUPP;
/* Can't change realtime flag if any extents are allocated. */
if ((ip->i_d.di_nextents || ip->i_delayed_blks) &&
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jiang <dave.jiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX
Date: Thu, 08 Feb 2018 17:38:24 -0700 [thread overview]
Message-ID: <151813670468.15926.3966047346830424677.stgit@djiang5-desk3.ch.intel.com> (raw)
In-Reply-To: <151813659955.15926.8922476613392258086.stgit-Cxk7aZI4ujnJARH06PadV2t3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
In a situation where the rt_dev is DAX and data_dev is not DAX, if the user
requests to remove the realtime flag via ioctl we can no longer support DAX
for that file. Dynamic changing of S_DAX on the inode is not supported due
to various complications in the existing implementation. Therefore until we
address the dynamic S_DAX change issues, we must disallow realtime flag
being removed.
Signed-off-by: Dave Jiang <dave.jiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
fs/xfs/xfs_ioctl.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index e440d789ed1b..cd5a5c61da39 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -1029,6 +1029,21 @@ xfs_ioctl_setattr_xflags(
{
struct xfs_mount *mp = ip->i_mount;
uint64_t di_flags2;
+ struct inode *inode = VFS_I(ip);
+ struct super_block *sb = inode->i_sb;
+
+ /*
+ * In the case that the inode is realtime, and we are trying to remove
+ * the realtime flag, and the rtdev supports DAX but the datadev does
+ * not support DAX, we can't allow the realtime flag to be removed
+ * since we do not support dynamic S_DAX flag removal yet.
+ */
+ if ((XFS_IS_REALTIME_INODE(ip)) &&
+ !(fa->fsx_xflags & FS_XFLAG_REALTIME) &&
+ bdev_dax_supported(sb, mp->m_rtdev_targp->bt_bdev,
+ sb->s_blocksize) &&
+ !bdev_dax_supported(sb, mp->m_ddev_targp->bt_bdev, sb->s_blocksize))
+ return -ENOTSUPP;
/* Can't change realtime flag if any extents are allocated. */
if ((ip->i_d.di_nextents || ip->i_delayed_blks) &&
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jiang <dave.jiang@intel.com>
To: darrick.wong@oracle.com
Cc: linux-nvdimm@lists.01.org, david@fromorbit.com,
linux-xfs@vger.kernel.org, ross.zwisler@linux.intel.com,
linux-ext4@vger.kernel.org, dan.j.williams@intel.com
Subject: [PATCH v3 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX
Date: Thu, 08 Feb 2018 17:38:24 -0700 [thread overview]
Message-ID: <151813670468.15926.3966047346830424677.stgit@djiang5-desk3.ch.intel.com> (raw)
In-Reply-To: <151813659955.15926.8922476613392258086.stgit@djiang5-desk3.ch.intel.com>
In a situation where the rt_dev is DAX and data_dev is not DAX, if the user
requests to remove the realtime flag via ioctl we can no longer support DAX
for that file. Dynamic changing of S_DAX on the inode is not supported due
to various complications in the existing implementation. Therefore until we
address the dynamic S_DAX change issues, we must disallow realtime flag
being removed.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
fs/xfs/xfs_ioctl.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index e440d789ed1b..cd5a5c61da39 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -1029,6 +1029,21 @@ xfs_ioctl_setattr_xflags(
{
struct xfs_mount *mp = ip->i_mount;
uint64_t di_flags2;
+ struct inode *inode = VFS_I(ip);
+ struct super_block *sb = inode->i_sb;
+
+ /*
+ * In the case that the inode is realtime, and we are trying to remove
+ * the realtime flag, and the rtdev supports DAX but the datadev does
+ * not support DAX, we can't allow the realtime flag to be removed
+ * since we do not support dynamic S_DAX flag removal yet.
+ */
+ if ((XFS_IS_REALTIME_INODE(ip)) &&
+ !(fa->fsx_xflags & FS_XFLAG_REALTIME) &&
+ bdev_dax_supported(sb, mp->m_rtdev_targp->bt_bdev,
+ sb->s_blocksize) &&
+ !bdev_dax_supported(sb, mp->m_ddev_targp->bt_bdev, sb->s_blocksize))
+ return -ENOTSUPP;
/* Can't change realtime flag if any extents are allocated. */
if ((ip->i_d.di_nextents || ip->i_delayed_blks) &&
next prev parent reply other threads:[~2018-02-09 0:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 0:38 [PATCH v3 0/3] minimal DAX support for XFS realtime device Dave Jiang
2018-02-09 0:38 ` Dave Jiang
2018-02-09 0:38 ` [PATCH v3 1/3] fs: allow per-device dax status checking for filesystems Dave Jiang
2018-02-09 0:38 ` Dave Jiang
2018-02-09 0:38 ` [PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns Dave Jiang
2018-02-09 0:38 ` Dave Jiang
2018-02-09 0:38 ` Dave Jiang
2018-02-13 20:31 ` Ross Zwisler
2018-02-13 20:31 ` Ross Zwisler
2018-02-13 20:31 ` Ross Zwisler
2018-02-13 20:35 ` Dave Jiang
2018-02-13 20:35 ` Dave Jiang
2018-02-13 20:43 ` Ross Zwisler
2018-02-13 20:43 ` Ross Zwisler
2018-02-09 0:38 ` Dave Jiang [this message]
2018-02-09 0:38 ` [PATCH v3 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX Dave Jiang
2018-02-09 0:38 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151813670468.15926.3966047346830424677.stgit@djiang5-desk3.ch.intel.com \
--to=dave.jiang@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.