From: Ryder Lee <ryder.lee@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org,
Garlic Tseng <garlic.tseng@mediatek.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-clk <linux-clk@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [SPAM]Re: [PATCH v3 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device
Date: Wed, 21 Feb 2018 14:04:08 +0800 [thread overview]
Message-ID: <1519193048.18794.42.camel@mtkswgap22> (raw)
In-Reply-To: <CAL_JsqJgo0pKJjrs2fdw+q=DJYwht0X5L3Bomz8gf98mEN7hkg@mail.gmail.com>
On Mon, 2018-02-19 at 12:29 -0600, Rob Herring wrote:
> On Mon, Feb 12, 2018 at 5:28 AM, Ryder Lee <ryder.lee@mediatek.com> wrote:
> > The MediaTek audio hardware block that exposes functionalities that are
> > handled by separate subsystems in the kernel. These functions are all
> > mapped somewhere at 0x112xxxxx, and there are some control bits are mixed
> > up with other functions within the same registers.
>
> I still don't think this change is necessary.
>
> Just because a hardware block in DT maps to different subsystems in a
> particular OS doesn't mean you need a DT node for each OS subsystem.
> What we have subsystems for changes over time and DT shouldn't really
> be changing based on that. And DT is not the only way to instantiate
> drivers.
>
Apart right now we have the definition of both functions. The other
location is here:../sonud/mt2701-afe-pcm.txt. The ways I could come up
with are:
1. Add a dummy MFD driver (need to think a new compatible or just use
'*-audsys' which has already been picked by clock driver) to instantiate
two sub-devices through id_table and mfd_cell.
2. For the sake of simplification - add a new compatible "simple-mfd".
3. The last thing - keep two nodes separated/independent. (x)
I'm not sure which one is better.
@Lee @Matthias: What do you suggest?
Ryder.
WARNING: multiple messages have this Message-ID (diff)
From: Ryder Lee <ryder.lee@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org,
Garlic Tseng <garlic.tseng@mediatek.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-clk <linux-clk@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [SPAM]Re: [PATCH v3 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device
Date: Wed, 21 Feb 2018 14:04:08 +0800 [thread overview]
Message-ID: <1519193048.18794.42.camel@mtkswgap22> (raw)
In-Reply-To: <CAL_JsqJgo0pKJjrs2fdw+q=DJYwht0X5L3Bomz8gf98mEN7hkg@mail.gmail.com>
On Mon, 2018-02-19 at 12:29 -0600, Rob Herring wrote:
> On Mon, Feb 12, 2018 at 5:28 AM, Ryder Lee <ryder.lee@mediatek.com> wrote:
> > The MediaTek audio hardware block that exposes functionalities that are
> > handled by separate subsystems in the kernel. These functions are all
> > mapped somewhere at 0x112xxxxx, and there are some control bits are mixed
> > up with other functions within the same registers.
>
> I still don't think this change is necessary.
>
> Just because a hardware block in DT maps to different subsystems in a
> particular OS doesn't mean you need a DT node for each OS subsystem.
> What we have subsystems for changes over time and DT shouldn't really
> be changing based on that. And DT is not the only way to instantiate
> drivers.
>
Apart right now we have the definition of both functions. The other
location is here:../sonud/mt2701-afe-pcm.txt. The ways I could come up
with are:
1. Add a dummy MFD driver (need to think a new compatible or just use
'*-audsys' which has already been picked by clock driver) to instantiate
two sub-devices through id_table and mfd_cell.
2. For the sake of simplification - add a new compatible "simple-mfd".
3. The last thing - keep two nodes separated/independent. (x)
I'm not sure which one is better.
@Lee @Matthias: What do you suggest?
Ryder.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: ryder.lee@mediatek.com (Ryder Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [SPAM]Re: [PATCH v3 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device
Date: Wed, 21 Feb 2018 14:04:08 +0800 [thread overview]
Message-ID: <1519193048.18794.42.camel@mtkswgap22> (raw)
In-Reply-To: <CAL_JsqJgo0pKJjrs2fdw+q=DJYwht0X5L3Bomz8gf98mEN7hkg@mail.gmail.com>
On Mon, 2018-02-19 at 12:29 -0600, Rob Herring wrote:
> On Mon, Feb 12, 2018 at 5:28 AM, Ryder Lee <ryder.lee@mediatek.com> wrote:
> > The MediaTek audio hardware block that exposes functionalities that are
> > handled by separate subsystems in the kernel. These functions are all
> > mapped somewhere at 0x112xxxxx, and there are some control bits are mixed
> > up with other functions within the same registers.
>
> I still don't think this change is necessary.
>
> Just because a hardware block in DT maps to different subsystems in a
> particular OS doesn't mean you need a DT node for each OS subsystem.
> What we have subsystems for changes over time and DT shouldn't really
> be changing based on that. And DT is not the only way to instantiate
> drivers.
>
Apart right now we have the definition of both functions. The other
location is here:../sonud/mt2701-afe-pcm.txt. The ways I could come up
with are:
1. Add a dummy MFD driver (need to think a new compatible or just use
'*-audsys' which has already been picked by clock driver) to instantiate
two sub-devices through id_table and mfd_cell.
2. For the sake of simplification - add a new compatible "simple-mfd".
3. The last thing - keep two nodes separated/independent. (x)
I'm not sure which one is better.
@Lee @Matthias: What do you suggest?
Ryder.
next prev parent reply other threads:[~2018-02-21 6:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 11:28 [PATCH v3 0/5] switch to MFD device for MediaTek audio subsystem Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` [PATCH v3 1/5] clk: mediatek: update missing clock data for MT7622 audsys Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-13 9:13 ` Matthias Brugger
2018-02-13 9:13 ` Matthias Brugger
2018-02-13 9:13 ` Matthias Brugger
2018-02-13 9:13 ` Matthias Brugger
2018-02-12 11:28 ` [PATCH v3 2/5] clk: mediatek: modify MT7622 audsys to adapt MFD device Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-13 9:24 ` Matthias Brugger
2018-02-13 9:24 ` Matthias Brugger
2018-02-12 11:28 ` [PATCH v3 3/5] clk: mediatek: add audsys support for MT2701 Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` [PATCH v3 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-19 18:29 ` Rob Herring
2018-02-19 18:29 ` Rob Herring
2018-02-19 18:29 ` Rob Herring
2018-02-21 6:04 ` Ryder Lee [this message]
2018-02-21 6:04 ` [SPAM]Re: " Ryder Lee
2018-02-21 6:04 ` Ryder Lee
2018-02-21 14:10 ` Rob Herring
2018-02-21 14:10 ` Rob Herring
2018-02-21 14:10 ` Rob Herring
2018-02-22 4:14 ` Ryder Lee
2018-02-22 4:14 ` Ryder Lee
2018-02-22 4:14 ` Ryder Lee
2018-02-28 15:13 ` Rob Herring
2018-02-28 15:13 ` Rob Herring
2018-02-28 15:13 ` Rob Herring
[not found] ` <CAL_Jsq+NK-sUY-qOZ2Xv1ZfWVm-vG0tyAgN_auKeaQxMq58vkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-28 17:58 ` Sean Wang
2018-02-28 17:58 ` Sean Wang
2018-02-28 17:58 ` Sean Wang
2018-03-05 9:23 ` Ryder Lee
2018-03-05 9:23 ` Ryder Lee
2018-03-05 9:23 ` Ryder Lee
2018-02-12 11:28 ` [PATCH v3 5/5] arm: dts: mediatek: add audio-subsystem node for both MT2701 and MT7623 Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519193048.18794.42.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=garlic.tseng@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.