All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	Garlic Tseng <garlic.tseng@mediatek.com>
Subject: Re: [PATCH v3 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device
Date: Mon, 19 Feb 2018 12:29:24 -0600	[thread overview]
Message-ID: <CAL_JsqJgo0pKJjrs2fdw+q=DJYwht0X5L3Bomz8gf98mEN7hkg@mail.gmail.com> (raw)
In-Reply-To: <61928ad523a7aeffb8f16d4caad56836b65ae407.1518424204.git.ryder.lee@mediatek.com>

On Mon, Feb 12, 2018 at 5:28 AM, Ryder Lee <ryder.lee@mediatek.com> wrote:
> The MediaTek audio hardware block that exposes functionalities that are
> handled by separate subsystems in the kernel.  These functions are all
> mapped somewhere at 0x112xxxxx, and there are some control bits are mixed
> up with other functions within the same registers.

I still don't think this change is necessary.

Just because a hardware block in DT maps to different subsystems in a
particular OS doesn't mean you need a DT node for each OS subsystem.
What we have subsystems for changes over time and DT shouldn't really
be changing based on that. And DT is not the only way to instantiate
drivers.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: devicetree@vger.kernel.org,
	Garlic Tseng <garlic.tseng@mediatek.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device
Date: Mon, 19 Feb 2018 12:29:24 -0600	[thread overview]
Message-ID: <CAL_JsqJgo0pKJjrs2fdw+q=DJYwht0X5L3Bomz8gf98mEN7hkg@mail.gmail.com> (raw)
In-Reply-To: <61928ad523a7aeffb8f16d4caad56836b65ae407.1518424204.git.ryder.lee@mediatek.com>

On Mon, Feb 12, 2018 at 5:28 AM, Ryder Lee <ryder.lee@mediatek.com> wrote:
> The MediaTek audio hardware block that exposes functionalities that are
> handled by separate subsystems in the kernel.  These functions are all
> mapped somewhere at 0x112xxxxx, and there are some control bits are mixed
> up with other functions within the same registers.

I still don't think this change is necessary.

Just because a hardware block in DT maps to different subsystems in a
particular OS doesn't mean you need a DT node for each OS subsystem.
What we have subsystems for changes over time and DT shouldn't really
be changing based on that. And DT is not the only way to instantiate
drivers.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: robh+dt@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device
Date: Mon, 19 Feb 2018 12:29:24 -0600	[thread overview]
Message-ID: <CAL_JsqJgo0pKJjrs2fdw+q=DJYwht0X5L3Bomz8gf98mEN7hkg@mail.gmail.com> (raw)
In-Reply-To: <61928ad523a7aeffb8f16d4caad56836b65ae407.1518424204.git.ryder.lee@mediatek.com>

On Mon, Feb 12, 2018 at 5:28 AM, Ryder Lee <ryder.lee@mediatek.com> wrote:
> The MediaTek audio hardware block that exposes functionalities that are
> handled by separate subsystems in the kernel.  These functions are all
> mapped somewhere at 0x112xxxxx, and there are some control bits are mixed
> up with other functions within the same registers.

I still don't think this change is necessary.

Just because a hardware block in DT maps to different subsystems in a
particular OS doesn't mean you need a DT node for each OS subsystem.
What we have subsystems for changes over time and DT shouldn't really
be changing based on that. And DT is not the only way to instantiate
drivers.

Rob

  reply	other threads:[~2018-02-19 18:29 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 11:28 [PATCH v3 0/5] switch to MFD device for MediaTek audio subsystem Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` Ryder Lee
2018-02-12 11:28 ` [PATCH v3 1/5] clk: mediatek: update missing clock data for MT7622 audsys Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-13  9:13   ` Matthias Brugger
2018-02-13  9:13     ` Matthias Brugger
2018-02-13  9:13     ` Matthias Brugger
2018-02-13  9:13     ` Matthias Brugger
2018-02-12 11:28 ` [PATCH v3 2/5] clk: mediatek: modify MT7622 audsys to adapt MFD device Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-13  9:24   ` Matthias Brugger
2018-02-13  9:24     ` Matthias Brugger
2018-02-12 11:28 ` [PATCH v3 3/5] clk: mediatek: add audsys support for MT2701 Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-12 11:28 ` [PATCH v3 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-19 18:29   ` Rob Herring [this message]
2018-02-19 18:29     ` Rob Herring
2018-02-19 18:29     ` Rob Herring
2018-02-21  6:04     ` [SPAM]Re: " Ryder Lee
2018-02-21  6:04       ` Ryder Lee
2018-02-21  6:04       ` Ryder Lee
2018-02-21 14:10       ` Rob Herring
2018-02-21 14:10         ` Rob Herring
2018-02-21 14:10         ` Rob Herring
2018-02-22  4:14         ` Ryder Lee
2018-02-22  4:14           ` Ryder Lee
2018-02-22  4:14           ` Ryder Lee
2018-02-28 15:13           ` Rob Herring
2018-02-28 15:13             ` Rob Herring
2018-02-28 15:13             ` Rob Herring
     [not found]             ` <CAL_Jsq+NK-sUY-qOZ2Xv1ZfWVm-vG0tyAgN_auKeaQxMq58vkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-28 17:58               ` Sean Wang
2018-02-28 17:58                 ` Sean Wang
2018-02-28 17:58                 ` Sean Wang
2018-03-05  9:23             ` Ryder Lee
2018-03-05  9:23               ` Ryder Lee
2018-03-05  9:23               ` Ryder Lee
2018-02-12 11:28 ` [PATCH v3 5/5] arm: dts: mediatek: add audio-subsystem node for both MT2701 and MT7623 Ryder Lee
2018-02-12 11:28   ` Ryder Lee
2018-02-12 11:28   ` Ryder Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqJgo0pKJjrs2fdw+q=DJYwht0X5L3Bomz8gf98mEN7hkg@mail.gmail.com' \
    --to=robh+dt@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=garlic.tseng@mediatek.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ryder.lee@mediatek.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.