* [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
@ 2018-03-17 6:57 ` Anson Huang
0 siblings, 0 replies; 24+ messages in thread
From: Anson Huang @ 2018-03-17 6:57 UTC (permalink / raw)
To: linux-arm-kernel
Latest pfuze3000 datasheet from:
http://cache.freescale.com/files/analog/doc/data_sheet/PF3000.pdf?fsrch=1&sr=1&pageNum=1
updates sw1a's voltage range, the settings for 1.450V and 1.475V
are replaced with 1.8V and 3.3V:
5b'11110 1.450 (SW1B), 1.8 (SW1A/SW1AB)
5b'11111 1.475 (SW1B), 3.3 (SW1A/SW1AB)
the voltage calculation using steps is NOT available for sw1a now,
use voltage table instead.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
drivers/regulator/pfuze100-regulator.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 63922a2..680f076 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -86,6 +86,13 @@ static const int pfuze100_coin[] = {
2500000, 2700000, 2800000, 2900000, 3000000, 3100000, 3200000, 3300000,
};
+static const int pfuze3000_sw1a[] = {
+ 700000, 725000, 750000, 775000, 800000, 825000, 850000, 875000,
+ 900000, 925000, 950000, 975000, 1000000, 1025000, 1050000, 1075000,
+ 1100000, 1125000, 1150000, 1175000, 1200000, 1225000, 1250000, 1275000,
+ 1300000, 1325000, 1350000, 1375000, 1400000, 1425000, 1800000, 3300000,
+};
+
static const int pfuze3000_sw2lo[] = {
1500000, 1550000, 1600000, 1650000, 1700000, 1750000, 1800000, 1850000,
};
@@ -343,7 +350,7 @@ static struct pfuze_regulator pfuze200_regulators[] = {
};
static struct pfuze_regulator pfuze3000_regulators[] = {
- PFUZE100_SW_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 700000, 1475000, 25000),
+ PFUZE100_SWB_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 0x1f, pfuze3000_sw1a),
PFUZE100_SW_REG(PFUZE3000, SW1B, PFUZE100_SW1CVOL, 700000, 1475000, 25000),
PFUZE100_SWB_REG(PFUZE3000, SW2, PFUZE100_SW2VOL, 0x7, pfuze3000_sw2lo),
PFUZE3000_SW3_REG(PFUZE3000, SW3, PFUZE100_SW3AVOL, 900000, 1650000, 50000),
--
2.7.4
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
@ 2018-03-17 6:57 ` Anson Huang
0 siblings, 0 replies; 24+ messages in thread
From: Anson Huang @ 2018-03-17 6:57 UTC (permalink / raw)
To: yibin.gong, shawnguo, kernel, fabio.estevam, robh+dt,
mark.rutland, linux, lgirdwood, broonie
Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel
Latest pfuze3000 datasheet from:
http://cache.freescale.com/files/analog/doc/data_sheet/PF3000.pdf?fsrch=1&sr=1&pageNum=1
updates sw1a's voltage range, the settings for 1.450V and 1.475V
are replaced with 1.8V and 3.3V:
5b'11110 1.450 (SW1B), 1.8 (SW1A/SW1AB)
5b'11111 1.475 (SW1B), 3.3 (SW1A/SW1AB)
the voltage calculation using steps is NOT available for sw1a now,
use voltage table instead.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
drivers/regulator/pfuze100-regulator.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 63922a2..680f076 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -86,6 +86,13 @@ static const int pfuze100_coin[] = {
2500000, 2700000, 2800000, 2900000, 3000000, 3100000, 3200000, 3300000,
};
+static const int pfuze3000_sw1a[] = {
+ 700000, 725000, 750000, 775000, 800000, 825000, 850000, 875000,
+ 900000, 925000, 950000, 975000, 1000000, 1025000, 1050000, 1075000,
+ 1100000, 1125000, 1150000, 1175000, 1200000, 1225000, 1250000, 1275000,
+ 1300000, 1325000, 1350000, 1375000, 1400000, 1425000, 1800000, 3300000,
+};
+
static const int pfuze3000_sw2lo[] = {
1500000, 1550000, 1600000, 1650000, 1700000, 1750000, 1800000, 1850000,
};
@@ -343,7 +350,7 @@ static struct pfuze_regulator pfuze200_regulators[] = {
};
static struct pfuze_regulator pfuze3000_regulators[] = {
- PFUZE100_SW_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 700000, 1475000, 25000),
+ PFUZE100_SWB_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 0x1f, pfuze3000_sw1a),
PFUZE100_SW_REG(PFUZE3000, SW1B, PFUZE100_SW1CVOL, 700000, 1475000, 25000),
PFUZE100_SWB_REG(PFUZE3000, SW2, PFUZE100_SW2VOL, 0x7, pfuze3000_sw2lo),
PFUZE3000_SW3_REG(PFUZE3000, SW3, PFUZE100_SW3AVOL, 900000, 1650000, 50000),
--
2.7.4
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
2018-03-17 6:57 ` Anson Huang
(?)
@ 2018-03-17 12:35 ` Stefan Wahren
-1 siblings, 0 replies; 24+ messages in thread
From: Stefan Wahren @ 2018-03-17 12:35 UTC (permalink / raw)
To: robh+dt, fabio.estevam, mark.rutland, yibin.gong, linux,
Anson Huang, lgirdwood, shawnguo, kernel, broonie
Cc: Linux-imx, devicetree, linux-kernel, linux-arm-kernel
Hi Anson,
> Anson Huang <Anson.Huang@nxp.com> hat am 17. März 2018 um 07:57 geschrieben:
>
>
> Latest pfuze3000 datasheet from:
>
> http://cache.freescale.com/files/analog/doc/data_sheet/PF3000.pdf?fsrch=1&sr=1&pageNum=1
this link goes to Rev. 7.0, 9/2016, which isn't the latest one.
I guess Rev. 9.0, 8/2017 is the latest.
Regards
Stefan
>
> updates sw1a's voltage range, the settings for 1.450V and 1.475V
> are replaced with 1.8V and 3.3V:
>
> 5b'11110 1.450 (SW1B), 1.8 (SW1A/SW1AB)
> 5b'11111 1.475 (SW1B), 3.3 (SW1A/SW1AB)
>
> the voltage calculation using steps is NOT available for sw1a now,
> use voltage table instead.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> ---
> drivers/regulator/pfuze100-regulator.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
> index 63922a2..680f076 100644
> --- a/drivers/regulator/pfuze100-regulator.c
> +++ b/drivers/regulator/pfuze100-regulator.c
> @@ -86,6 +86,13 @@ static const int pfuze100_coin[] = {
> 2500000, 2700000, 2800000, 2900000, 3000000, 3100000, 3200000, 3300000,
> };
>
> +static const int pfuze3000_sw1a[] = {
> + 700000, 725000, 750000, 775000, 800000, 825000, 850000, 875000,
> + 900000, 925000, 950000, 975000, 1000000, 1025000, 1050000, 1075000,
> + 1100000, 1125000, 1150000, 1175000, 1200000, 1225000, 1250000, 1275000,
> + 1300000, 1325000, 1350000, 1375000, 1400000, 1425000, 1800000, 3300000,
> +};
> +
> static const int pfuze3000_sw2lo[] = {
> 1500000, 1550000, 1600000, 1650000, 1700000, 1750000, 1800000, 1850000,
> };
> @@ -343,7 +350,7 @@ static struct pfuze_regulator pfuze200_regulators[] = {
> };
>
> static struct pfuze_regulator pfuze3000_regulators[] = {
> - PFUZE100_SW_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 700000, 1475000, 25000),
> + PFUZE100_SWB_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 0x1f, pfuze3000_sw1a),
> PFUZE100_SW_REG(PFUZE3000, SW1B, PFUZE100_SW1CVOL, 700000, 1475000, 25000),
> PFUZE100_SWB_REG(PFUZE3000, SW2, PFUZE100_SW2VOL, 0x7, pfuze3000_sw2lo),
> PFUZE3000_SW3_REG(PFUZE3000, SW3, PFUZE100_SW3AVOL, 900000, 1650000, 50000),
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
@ 2018-03-17 12:35 ` Stefan Wahren
0 siblings, 0 replies; 24+ messages in thread
From: Stefan Wahren @ 2018-03-17 12:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Anson,
> Anson Huang <Anson.Huang@nxp.com> hat am 17. M?rz 2018 um 07:57 geschrieben:
>
>
> Latest pfuze3000 datasheet from:
>
> http://cache.freescale.com/files/analog/doc/data_sheet/PF3000.pdf?fsrch=1&sr=1&pageNum=1
this link goes to Rev. 7.0, 9/2016, which isn't the latest one.
I guess Rev. 9.0, 8/2017 is the latest.
Regards
Stefan
>
> updates sw1a's voltage range, the settings for 1.450V and 1.475V
> are replaced with 1.8V and 3.3V:
>
> 5b'11110 1.450 (SW1B), 1.8 (SW1A/SW1AB)
> 5b'11111 1.475 (SW1B), 3.3 (SW1A/SW1AB)
>
> the voltage calculation using steps is NOT available for sw1a now,
> use voltage table instead.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> ---
> drivers/regulator/pfuze100-regulator.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
> index 63922a2..680f076 100644
> --- a/drivers/regulator/pfuze100-regulator.c
> +++ b/drivers/regulator/pfuze100-regulator.c
> @@ -86,6 +86,13 @@ static const int pfuze100_coin[] = {
> 2500000, 2700000, 2800000, 2900000, 3000000, 3100000, 3200000, 3300000,
> };
>
> +static const int pfuze3000_sw1a[] = {
> + 700000, 725000, 750000, 775000, 800000, 825000, 850000, 875000,
> + 900000, 925000, 950000, 975000, 1000000, 1025000, 1050000, 1075000,
> + 1100000, 1125000, 1150000, 1175000, 1200000, 1225000, 1250000, 1275000,
> + 1300000, 1325000, 1350000, 1375000, 1400000, 1425000, 1800000, 3300000,
> +};
> +
> static const int pfuze3000_sw2lo[] = {
> 1500000, 1550000, 1600000, 1650000, 1700000, 1750000, 1800000, 1850000,
> };
> @@ -343,7 +350,7 @@ static struct pfuze_regulator pfuze200_regulators[] = {
> };
>
> static struct pfuze_regulator pfuze3000_regulators[] = {
> - PFUZE100_SW_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 700000, 1475000, 25000),
> + PFUZE100_SWB_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 0x1f, pfuze3000_sw1a),
> PFUZE100_SW_REG(PFUZE3000, SW1B, PFUZE100_SW1CVOL, 700000, 1475000, 25000),
> PFUZE100_SWB_REG(PFUZE3000, SW2, PFUZE100_SW2VOL, 0x7, pfuze3000_sw2lo),
> PFUZE3000_SW3_REG(PFUZE3000, SW3, PFUZE100_SW3AVOL, 900000, 1650000, 50000),
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
@ 2018-03-17 12:35 ` Stefan Wahren
0 siblings, 0 replies; 24+ messages in thread
From: Stefan Wahren @ 2018-03-17 12:35 UTC (permalink / raw)
To: robh+dt, fabio.estevam, mark.rutland, yibin.gong, linux,
Anson Huang, lgirdwood, shawnguo, kernel, broonie
Cc: devicetree, Linux-imx, linux-arm-kernel, linux-kernel
Hi Anson,
> Anson Huang <Anson.Huang@nxp.com> hat am 17. März 2018 um 07:57 geschrieben:
>
>
> Latest pfuze3000 datasheet from:
>
> http://cache.freescale.com/files/analog/doc/data_sheet/PF3000.pdf?fsrch=1&sr=1&pageNum=1
this link goes to Rev. 7.0, 9/2016, which isn't the latest one.
I guess Rev. 9.0, 8/2017 is the latest.
Regards
Stefan
>
> updates sw1a's voltage range, the settings for 1.450V and 1.475V
> are replaced with 1.8V and 3.3V:
>
> 5b'11110 1.450 (SW1B), 1.8 (SW1A/SW1AB)
> 5b'11111 1.475 (SW1B), 3.3 (SW1A/SW1AB)
>
> the voltage calculation using steps is NOT available for sw1a now,
> use voltage table instead.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> ---
> drivers/regulator/pfuze100-regulator.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
> index 63922a2..680f076 100644
> --- a/drivers/regulator/pfuze100-regulator.c
> +++ b/drivers/regulator/pfuze100-regulator.c
> @@ -86,6 +86,13 @@ static const int pfuze100_coin[] = {
> 2500000, 2700000, 2800000, 2900000, 3000000, 3100000, 3200000, 3300000,
> };
>
> +static const int pfuze3000_sw1a[] = {
> + 700000, 725000, 750000, 775000, 800000, 825000, 850000, 875000,
> + 900000, 925000, 950000, 975000, 1000000, 1025000, 1050000, 1075000,
> + 1100000, 1125000, 1150000, 1175000, 1200000, 1225000, 1250000, 1275000,
> + 1300000, 1325000, 1350000, 1375000, 1400000, 1425000, 1800000, 3300000,
> +};
> +
> static const int pfuze3000_sw2lo[] = {
> 1500000, 1550000, 1600000, 1650000, 1700000, 1750000, 1800000, 1850000,
> };
> @@ -343,7 +350,7 @@ static struct pfuze_regulator pfuze200_regulators[] = {
> };
>
> static struct pfuze_regulator pfuze3000_regulators[] = {
> - PFUZE100_SW_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 700000, 1475000, 25000),
> + PFUZE100_SWB_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 0x1f, pfuze3000_sw1a),
> PFUZE100_SW_REG(PFUZE3000, SW1B, PFUZE100_SW1CVOL, 700000, 1475000, 25000),
> PFUZE100_SWB_REG(PFUZE3000, SW2, PFUZE100_SW2VOL, 0x7, pfuze3000_sw2lo),
> PFUZE3000_SW3_REG(PFUZE3000, SW3, PFUZE100_SW3AVOL, 900000, 1650000, 50000),
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
2018-03-17 12:35 ` Stefan Wahren
@ 2018-03-17 18:27 ` Fabio Estevam
-1 siblings, 0 replies; 24+ messages in thread
From: Fabio Estevam @ 2018-03-17 18:27 UTC (permalink / raw)
To: Stefan Wahren
Cc: Rob Herring, Fabio Estevam, Mark Rutland, Robin Gong,
Russell King - ARM Linux, Anson Huang, Liam Girdwood, Shawn Guo,
Sascha Hauer, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
NXP Linux Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
Hi Stefan,
On Sat, Mar 17, 2018 at 9:35 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi Anson,
>
>> Anson Huang <Anson.Huang@nxp.com> hat am 17. März 2018 um 07:57 geschrieben:
>>
>>
>> Latest pfuze3000 datasheet from:
>>
>> http://cache.freescale.com/files/analog/doc/data_sheet/PF3000.pdf?fsrch=1&sr=1&pageNum=1
>
> this link goes to Rev. 7.0, 9/2016, which isn't the latest one.
>
> I guess Rev. 9.0, 8/2017 is the latest.
You are right. This is the link to the latest datasheet:
https://www.nxp.com/docs/en/data-sheet/PF3000.pdf
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
@ 2018-03-17 18:27 ` Fabio Estevam
0 siblings, 0 replies; 24+ messages in thread
From: Fabio Estevam @ 2018-03-17 18:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stefan,
On Sat, Mar 17, 2018 at 9:35 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi Anson,
>
>> Anson Huang <Anson.Huang@nxp.com> hat am 17. M?rz 2018 um 07:57 geschrieben:
>>
>>
>> Latest pfuze3000 datasheet from:
>>
>> http://cache.freescale.com/files/analog/doc/data_sheet/PF3000.pdf?fsrch=1&sr=1&pageNum=1
>
> this link goes to Rev. 7.0, 9/2016, which isn't the latest one.
>
> I guess Rev. 9.0, 8/2017 is the latest.
You are right. This is the link to the latest datasheet:
https://www.nxp.com/docs/en/data-sheet/PF3000.pdf
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
2018-03-17 18:27 ` Fabio Estevam
@ 2018-03-18 2:25 ` Anson Huang
-1 siblings, 0 replies; 24+ messages in thread
From: Anson Huang @ 2018-03-18 2:25 UTC (permalink / raw)
To: Fabio Estevam, Stefan Wahren
Cc: Rob Herring, Fabio Estevam, Mark Rutland, Robin Gong,
Russell King - ARM Linux, Liam Girdwood, Shawn Guo, Sascha Hauer,
Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
dl-linux-imx,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
Anson Huang
Best Regards!
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: Sunday, March 18, 2018 2:27 AM
> To: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Fabio Estevam
> <fabio.estevam@nxp.com>; Mark Rutland <mark.rutland@arm.com>; Robin
> Gong <yibin.gong@nxp.com>; Russell King - ARM Linux
> <linux@armlinux.org.uk>; Anson Huang <anson.huang@nxp.com>; Liam
> Girdwood <lgirdwood@gmail.com>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <kernel@pengutronix.de>; Mark Brown <broonie@kernel.org>;
> open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com>; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@lists.infradead.org>; linux-kernel
> <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 2/2] regulator: pfuze100: update voltage setting for
> pfuze3000 sw1a
>
> Hi Stefan,
>
> On Sat, Mar 17, 2018 at 9:35 AM, Stefan Wahren <stefan.wahren@i2se.com>
> wrote:
> > Hi Anson,
> >
> >> Anson Huang <Anson.Huang@nxp.com> hat am 17. März 2018 um 07:57
> geschrieben:
> >>
> >>
> >> Latest pfuze3000 datasheet from:
> >>
> >>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcache.fr
> eescale.com%2Ffiles%2Fanalog%2Fdoc%2Fdata_sheet%2FPF3000.pdf%3Ffsrch
> %3D1%26sr%3D1%26pageNum%3D1&data=02%7C01%7CAnson.Huang%40nxp
> .com%7Cf6e1374a196741efe49b08d58c34bbab%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C1%7C636569080479216580&sdata=DZQFb2hHbYqXjduHC0
> 1z%2FiAT4xvztN4Gy85S89mULwo%3D&reserved=0
> >
> > this link goes to Rev. 7.0, 9/2016, which isn't the latest one.
> >
> > I guess Rev. 9.0, 8/2017 is the latest.
>
> You are right. This is the link to the latest datasheet:
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.n
> xp.com%2Fdocs%2Fen%2Fdata-sheet%2FPF3000.pdf&data=02%7C01%7CAnson
> .Huang%40nxp.com%7Cf6e1374a196741efe49b08d58c34bbab%7C686ea1d3bc
> 2b4c6fa92cd99c5c301635%7C0%7C1%7C636569080479216580&sdata=WIQYD
> 7WDn0%2FTl4BzM7oJdSuwK31Z64TfekeBAkou9XQ%3D&reserved=0
Yes, thank you for the reminder, I will update the commit message and the link in V2.
Anson.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/2] regulator: pfuze100: update voltage setting for pfuze3000 sw1a
@ 2018-03-18 2:25 ` Anson Huang
0 siblings, 0 replies; 24+ messages in thread
From: Anson Huang @ 2018-03-18 2:25 UTC (permalink / raw)
To: linux-arm-kernel
Anson Huang
Best Regards!
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: Sunday, March 18, 2018 2:27 AM
> To: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Fabio Estevam
> <fabio.estevam@nxp.com>; Mark Rutland <mark.rutland@arm.com>; Robin
> Gong <yibin.gong@nxp.com>; Russell King - ARM Linux
> <linux@armlinux.org.uk>; Anson Huang <anson.huang@nxp.com>; Liam
> Girdwood <lgirdwood@gmail.com>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <kernel@pengutronix.de>; Mark Brown <broonie@kernel.org>;
> open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com>; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@lists.infradead.org>; linux-kernel
> <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 2/2] regulator: pfuze100: update voltage setting for
> pfuze3000 sw1a
>
> Hi Stefan,
>
> On Sat, Mar 17, 2018 at 9:35 AM, Stefan Wahren <stefan.wahren@i2se.com>
> wrote:
> > Hi Anson,
> >
> >> Anson Huang <Anson.Huang@nxp.com> hat am 17. M?rz 2018 um 07:57
> geschrieben:
> >>
> >>
> >> Latest pfuze3000 datasheet from:
> >>
> >>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcache.fr
> eescale.com%2Ffiles%2Fanalog%2Fdoc%2Fdata_sheet%2FPF3000.pdf%3Ffsrch
> %3D1%26sr%3D1%26pageNum%3D1&data=02%7C01%7CAnson.Huang%40nxp
> .com%7Cf6e1374a196741efe49b08d58c34bbab%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C1%7C636569080479216580&sdata=DZQFb2hHbYqXjduHC0
> 1z%2FiAT4xvztN4Gy85S89mULwo%3D&reserved=0
> >
> > this link goes to Rev. 7.0, 9/2016, which isn't the latest one.
> >
> > I guess Rev. 9.0, 8/2017 is the latest.
>
> You are right. This is the link to the latest datasheet:
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.n
> xp.com%2Fdocs%2Fen%2Fdata-sheet%2FPF3000.pdf&data=02%7C01%7CAnson
> .Huang%40nxp.com%7Cf6e1374a196741efe49b08d58c34bbab%7C686ea1d3bc
> 2b4c6fa92cd99c5c301635%7C0%7C1%7C636569080479216580&sdata=WIQYD
> 7WDn0%2FTl4BzM7oJdSuwK31Z64TfekeBAkou9XQ%3D&reserved=0
Yes, thank you for the reminder, I will update the commit message and the link in V2.
Anson.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Applied "regulator: pfuze100: update voltage setting for pfuze3000 sw1a" to the regulator tree
2018-03-17 6:57 ` Anson Huang
(?)
@ 2018-04-18 11:58 ` Mark Brown
-1 siblings, 0 replies; 24+ messages in thread
From: Mark Brown @ 2018-04-18 11:58 UTC (permalink / raw)
To: Anson Huang
Cc: Robin Gong, Mark Brown, yibin.gong, shawnguo, kernel,
fabio.estevam, robh+dt, mark.rutland, linux, lgirdwood, broonie,
Linux-imx, linux-arm-kernel, devicetree, linux-kernel,
linux-kernel
The patch
regulator: pfuze100: update voltage setting for pfuze3000 sw1a
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 1dced996ee702e6af82a57c7b6c56b0cceaa6425 Mon Sep 17 00:00:00 2001
From: Anson Huang <Anson.Huang@nxp.com>
Date: Sun, 18 Mar 2018 11:23:21 +0800
Subject: [PATCH] regulator: pfuze100: update voltage setting for pfuze3000
sw1a
pfuze3000 datasheet(Rev.9.0) from:
https://www.nxp.com/docs/en/data-sheet/PF3000.pdf
updates sw1a's voltage range, the settings for 1.450V and 1.475V
are replaced with 1.8V and 3.3V:
5b'11110 1.450 (SW1B), 1.8 (SW1A/SW1AB)
5b'11111 1.475 (SW1B), 3.3 (SW1A/SW1AB)
the voltage calculation using steps is NOT available for sw1a now,
use voltage table instead.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/pfuze100-regulator.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 63922a2167e5..680f076e3d85 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -86,6 +86,13 @@ static const int pfuze100_coin[] = {
2500000, 2700000, 2800000, 2900000, 3000000, 3100000, 3200000, 3300000,
};
+static const int pfuze3000_sw1a[] = {
+ 700000, 725000, 750000, 775000, 800000, 825000, 850000, 875000,
+ 900000, 925000, 950000, 975000, 1000000, 1025000, 1050000, 1075000,
+ 1100000, 1125000, 1150000, 1175000, 1200000, 1225000, 1250000, 1275000,
+ 1300000, 1325000, 1350000, 1375000, 1400000, 1425000, 1800000, 3300000,
+};
+
static const int pfuze3000_sw2lo[] = {
1500000, 1550000, 1600000, 1650000, 1700000, 1750000, 1800000, 1850000,
};
@@ -343,7 +350,7 @@ static struct pfuze_regulator pfuze200_regulators[] = {
};
static struct pfuze_regulator pfuze3000_regulators[] = {
- PFUZE100_SW_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 700000, 1475000, 25000),
+ PFUZE100_SWB_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 0x1f, pfuze3000_sw1a),
PFUZE100_SW_REG(PFUZE3000, SW1B, PFUZE100_SW1CVOL, 700000, 1475000, 25000),
PFUZE100_SWB_REG(PFUZE3000, SW2, PFUZE100_SW2VOL, 0x7, pfuze3000_sw2lo),
PFUZE3000_SW3_REG(PFUZE3000, SW3, PFUZE100_SW3AVOL, 900000, 1650000, 50000),
--
2.17.0
^ permalink raw reply related [flat|nested] 24+ messages in thread* Applied "regulator: pfuze100: update voltage setting for pfuze3000 sw1a" to the regulator tree
@ 2018-04-18 11:58 ` Mark Brown
0 siblings, 0 replies; 24+ messages in thread
From: Mark Brown @ 2018-04-18 11:58 UTC (permalink / raw)
To: linux-arm-kernel
The patch
regulator: pfuze100: update voltage setting for pfuze3000 sw1a
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 1dced996ee702e6af82a57c7b6c56b0cceaa6425 Mon Sep 17 00:00:00 2001
From: Anson Huang <Anson.Huang@nxp.com>
Date: Sun, 18 Mar 2018 11:23:21 +0800
Subject: [PATCH] regulator: pfuze100: update voltage setting for pfuze3000
sw1a
pfuze3000 datasheet(Rev.9.0) from:
https://www.nxp.com/docs/en/data-sheet/PF3000.pdf
updates sw1a's voltage range, the settings for 1.450V and 1.475V
are replaced with 1.8V and 3.3V:
5b'11110 1.450 (SW1B), 1.8 (SW1A/SW1AB)
5b'11111 1.475 (SW1B), 3.3 (SW1A/SW1AB)
the voltage calculation using steps is NOT available for sw1a now,
use voltage table instead.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/pfuze100-regulator.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 63922a2167e5..680f076e3d85 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -86,6 +86,13 @@ static const int pfuze100_coin[] = {
2500000, 2700000, 2800000, 2900000, 3000000, 3100000, 3200000, 3300000,
};
+static const int pfuze3000_sw1a[] = {
+ 700000, 725000, 750000, 775000, 800000, 825000, 850000, 875000,
+ 900000, 925000, 950000, 975000, 1000000, 1025000, 1050000, 1075000,
+ 1100000, 1125000, 1150000, 1175000, 1200000, 1225000, 1250000, 1275000,
+ 1300000, 1325000, 1350000, 1375000, 1400000, 1425000, 1800000, 3300000,
+};
+
static const int pfuze3000_sw2lo[] = {
1500000, 1550000, 1600000, 1650000, 1700000, 1750000, 1800000, 1850000,
};
@@ -343,7 +350,7 @@ static struct pfuze_regulator pfuze200_regulators[] = {
};
static struct pfuze_regulator pfuze3000_regulators[] = {
- PFUZE100_SW_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 700000, 1475000, 25000),
+ PFUZE100_SWB_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 0x1f, pfuze3000_sw1a),
PFUZE100_SW_REG(PFUZE3000, SW1B, PFUZE100_SW1CVOL, 700000, 1475000, 25000),
PFUZE100_SWB_REG(PFUZE3000, SW2, PFUZE100_SW2VOL, 0x7, pfuze3000_sw2lo),
PFUZE3000_SW3_REG(PFUZE3000, SW3, PFUZE100_SW3AVOL, 900000, 1650000, 50000),
--
2.17.0
^ permalink raw reply related [flat|nested] 24+ messages in thread* Applied "regulator: pfuze100: update voltage setting for pfuze3000 sw1a" to the regulator tree
@ 2018-04-18 11:58 ` Mark Brown
0 siblings, 0 replies; 24+ messages in thread
From: Mark Brown @ 2018-04-18 11:58 UTC (permalink / raw)
To: Anson Huang; +Cc: Robin Gong, Mark Brown
The patch
regulator: pfuze100: update voltage setting for pfuze3000 sw1a
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 1dced996ee702e6af82a57c7b6c56b0cceaa6425 Mon Sep 17 00:00:00 2001
From: Anson Huang <Anson.Huang@nxp.com>
Date: Sun, 18 Mar 2018 11:23:21 +0800
Subject: [PATCH] regulator: pfuze100: update voltage setting for pfuze3000
sw1a
pfuze3000 datasheet(Rev.9.0) from:
https://www.nxp.com/docs/en/data-sheet/PF3000.pdf
updates sw1a's voltage range, the settings for 1.450V and 1.475V
are replaced with 1.8V and 3.3V:
5b'11110 1.450 (SW1B), 1.8 (SW1A/SW1AB)
5b'11111 1.475 (SW1B), 3.3 (SW1A/SW1AB)
the voltage calculation using steps is NOT available for sw1a now,
use voltage table instead.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/pfuze100-regulator.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 63922a2167e5..680f076e3d85 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -86,6 +86,13 @@ static const int pfuze100_coin[] = {
2500000, 2700000, 2800000, 2900000, 3000000, 3100000, 3200000, 3300000,
};
+static const int pfuze3000_sw1a[] = {
+ 700000, 725000, 750000, 775000, 800000, 825000, 850000, 875000,
+ 900000, 925000, 950000, 975000, 1000000, 1025000, 1050000, 1075000,
+ 1100000, 1125000, 1150000, 1175000, 1200000, 1225000, 1250000, 1275000,
+ 1300000, 1325000, 1350000, 1375000, 1400000, 1425000, 1800000, 3300000,
+};
+
static const int pfuze3000_sw2lo[] = {
1500000, 1550000, 1600000, 1650000, 1700000, 1750000, 1800000, 1850000,
};
@@ -343,7 +350,7 @@ static struct pfuze_regulator pfuze200_regulators[] = {
};
static struct pfuze_regulator pfuze3000_regulators[] = {
- PFUZE100_SW_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 700000, 1475000, 25000),
+ PFUZE100_SWB_REG(PFUZE3000, SW1A, PFUZE100_SW1ABVOL, 0x1f, pfuze3000_sw1a),
PFUZE100_SW_REG(PFUZE3000, SW1B, PFUZE100_SW1CVOL, 700000, 1475000, 25000),
PFUZE100_SWB_REG(PFUZE3000, SW2, PFUZE100_SW2VOL, 0x7, pfuze3000_sw2lo),
PFUZE3000_SW3_REG(PFUZE3000, SW3, PFUZE100_SW3AVOL, 900000, 1650000, 50000),
--
2.17.0
^ permalink raw reply related [flat|nested] 24+ messages in thread