From: Sinan Kaya <okaya@codeaurora.org> To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Cc: Sinan Kaya <okaya@codeaurora.org>, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 00/17] netdev: Eliminate duplicate barriers on weakly-ordered archs Date: Mon, 19 Mar 2018 22:42:15 -0400 [thread overview] Message-ID: <1521513753-7325-1-git-send-email-okaya@codeaurora.org> (raw) Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). I did a regex search for wmb() followed by writel() in each drivers directory. I scrubbed the ones I care about in this series. I considered "ease of change", "popular usage" and "performance critical path" as the determining criteria for my filtering. We used relaxed API heavily on ARM for a long time but it did not exist on other architectures. For this reason, relaxed architectures have been paying double penalty in order to use the common drivers. Now that relaxed API is present on all architectures, we can go and scrub all drivers to see what needs to change and what can remain. We start with mostly used ones and hope to increase the coverage over time. It will take a while to cover all drivers. Feel free to apply patches individually. Changes since v3: - https://www.spinics.net/lists/arm-kernel/msg641851.html - group patches together into subsystems net:... - collect reviewed and tested bys - scrub barrier() Sinan Kaya (17): i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs ixgbe: eliminate duplicate barriers on weakly-ordered archs igbvf: eliminate duplicate barriers on weakly-ordered archs igb: eliminate duplicate barriers on weakly-ordered archs ixgbevf: keep writel() closer to wmb() ixgbevf: eliminate duplicate barriers on weakly-ordered archs fm10k: Eliminate duplicate barriers on weakly-ordered archs drivers: net: cxgb: Eliminate duplicate barriers on weakly-ordered archs net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs qlcnic: Eliminate duplicate barriers on weakly-ordered archs bnx2x: Eliminate duplicate barriers on weakly-ordered archs net: cxgb4/cxgb4vf: Eliminate duplicate barriers on weakly-ordered archs net: cxgb3: Eliminate duplicate barriers on weakly-ordered archs net: qlge: Eliminate duplicate barriers on weakly-ordered archs bnxt_en: Eliminate duplicate barriers on weakly-ordered archs qed/qede: Eliminate duplicate barriers on weakly-ordered archs net: ena: Eliminate duplicate barriers on weakly-ordered archs drivers/net/ethernet/amazon/ena/ena_com.c | 6 ++++-- drivers/net/ethernet/amazon/ena/ena_eth_com.h | 22 ++++++++++++++++++++-- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++-- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 9 ++++++++- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 4 ++-- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 21 +++++++++++---------- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 11 ++++++++++- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- drivers/net/ethernet/chelsio/cxgb/sge.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/adapter.h | 7 +++++++ drivers/net/ethernet/chelsio/cxgb3/sge.c | 19 ++++++++++--------- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 6 ++++++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 13 +++++++------ drivers/net/ethernet/chelsio/cxgb4/sge.c | 12 ++++++------ drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 +- drivers/net/ethernet/chelsio/cxgb4vf/adapter.h | 14 ++++++++++++++ drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 18 ++++++++++-------- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 4 ++-- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 ++++---- drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++-- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++---- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 ----- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- drivers/net/ethernet/qlogic/qed/qed.h | 5 ++++- drivers/net/ethernet/qlogic/qed/qed_hw.c | 12 ++++++++++++ drivers/net/ethernet/qlogic/qed/qed_hw.h | 14 ++++++++++++++ drivers/net/ethernet/qlogic/qed/qed_int.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_vf.c | 7 ++++--- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 2 +- drivers/net/ethernet/qlogic/qede/qede_fp.c | 4 ++-- drivers/net/ethernet/qlogic/qla3xxx.c | 4 ++-- .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +- drivers/net/ethernet/qlogic/qlge/qlge.h | 17 +++++++++++++++++ drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +- include/linux/qed/qed_if.h | 17 +++++++++++++---- 42 files changed, 215 insertions(+), 96 deletions(-) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 00/17] netdev: Eliminate duplicate barriers on weakly-ordered archs Date: Mon, 19 Mar 2018 22:42:15 -0400 [thread overview] Message-ID: <1521513753-7325-1-git-send-email-okaya@codeaurora.org> (raw) Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). I did a regex search for wmb() followed by writel() in each drivers directory. I scrubbed the ones I care about in this series. I considered "ease of change", "popular usage" and "performance critical path" as the determining criteria for my filtering. We used relaxed API heavily on ARM for a long time but it did not exist on other architectures. For this reason, relaxed architectures have been paying double penalty in order to use the common drivers. Now that relaxed API is present on all architectures, we can go and scrub all drivers to see what needs to change and what can remain. We start with mostly used ones and hope to increase the coverage over time. It will take a while to cover all drivers. Feel free to apply patches individually. Changes since v3: - https://www.spinics.net/lists/arm-kernel/msg641851.html - group patches together into subsystems net:... - collect reviewed and tested bys - scrub barrier() Sinan Kaya (17): i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs ixgbe: eliminate duplicate barriers on weakly-ordered archs igbvf: eliminate duplicate barriers on weakly-ordered archs igb: eliminate duplicate barriers on weakly-ordered archs ixgbevf: keep writel() closer to wmb() ixgbevf: eliminate duplicate barriers on weakly-ordered archs fm10k: Eliminate duplicate barriers on weakly-ordered archs drivers: net: cxgb: Eliminate duplicate barriers on weakly-ordered archs net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs qlcnic: Eliminate duplicate barriers on weakly-ordered archs bnx2x: Eliminate duplicate barriers on weakly-ordered archs net: cxgb4/cxgb4vf: Eliminate duplicate barriers on weakly-ordered archs net: cxgb3: Eliminate duplicate barriers on weakly-ordered archs net: qlge: Eliminate duplicate barriers on weakly-ordered archs bnxt_en: Eliminate duplicate barriers on weakly-ordered archs qed/qede: Eliminate duplicate barriers on weakly-ordered archs net: ena: Eliminate duplicate barriers on weakly-ordered archs drivers/net/ethernet/amazon/ena/ena_com.c | 6 ++++-- drivers/net/ethernet/amazon/ena/ena_eth_com.h | 22 ++++++++++++++++++++-- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++-- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 9 ++++++++- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 4 ++-- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 21 +++++++++++---------- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 11 ++++++++++- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- drivers/net/ethernet/chelsio/cxgb/sge.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/adapter.h | 7 +++++++ drivers/net/ethernet/chelsio/cxgb3/sge.c | 19 ++++++++++--------- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 6 ++++++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 13 +++++++------ drivers/net/ethernet/chelsio/cxgb4/sge.c | 12 ++++++------ drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 +- drivers/net/ethernet/chelsio/cxgb4vf/adapter.h | 14 ++++++++++++++ drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 18 ++++++++++-------- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 4 ++-- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 8 ++++---- drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++-- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++---- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 ----- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- drivers/net/ethernet/qlogic/qed/qed.h | 5 ++++- drivers/net/ethernet/qlogic/qed/qed_hw.c | 12 ++++++++++++ drivers/net/ethernet/qlogic/qed/qed_hw.h | 14 ++++++++++++++ drivers/net/ethernet/qlogic/qed/qed_int.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_vf.c | 7 ++++--- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 2 +- drivers/net/ethernet/qlogic/qede/qede_fp.c | 4 ++-- drivers/net/ethernet/qlogic/qla3xxx.c | 4 ++-- .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +- drivers/net/ethernet/qlogic/qlge/qlge.h | 17 +++++++++++++++++ drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +- include/linux/qed/qed_if.h | 17 +++++++++++++---- 42 files changed, 215 insertions(+), 96 deletions(-) -- 2.7.4
next reply other threads:[~2018-03-20 2:42 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-20 2:42 Sinan Kaya [this message] 2018-03-20 2:42 ` [PATCH v4 00/17] netdev: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 01/17] i40e/i40evf: " Sinan Kaya 2018-03-20 2:42 ` [Intel-wired-lan] " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 02/17] ixgbe: eliminate " Sinan Kaya 2018-03-20 2:42 ` [Intel-wired-lan] " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 03/17] igbvf: " Sinan Kaya 2018-03-20 2:42 ` [Intel-wired-lan] " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 04/17] igb: " Sinan Kaya 2018-03-20 2:42 ` [Intel-wired-lan] " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 05/17] ixgbevf: keep writel() closer to wmb() Sinan Kaya 2018-03-20 2:42 ` [Intel-wired-lan] " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 06/17] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya 2018-03-20 2:42 ` [Intel-wired-lan] " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 07/17] fm10k: Eliminate " Sinan Kaya 2018-03-20 2:42 ` [Intel-wired-lan] " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 08/17] drivers: net: cxgb: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 09/17] net: qla3xxx: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 10/17] qlcnic: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 11/17] bnx2x: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-22 10:10 ` Kalluru, Sudarsana 2018-03-22 10:10 ` Kalluru, Sudarsana 2018-03-20 2:42 ` [PATCH v4 12/17] net: cxgb4/cxgb4vf: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-21 23:03 ` Casey Leedom 2018-03-21 23:03 ` Casey Leedom 2018-03-22 0:00 ` okaya 2018-03-22 0:00 ` okaya at codeaurora.org 2018-03-20 2:42 ` [PATCH v4 13/17] net: cxgb3: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 14/17] net: qlge: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 15/17] bnxt_en: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 16/17] qed/qede: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-20 2:42 ` [PATCH v4 17/17] net: ena: " Sinan Kaya 2018-03-20 2:42 ` Sinan Kaya 2018-03-25 12:06 ` Belgazal, Netanel 2018-03-25 12:06 ` Belgazal, Netanel 2018-03-25 13:33 ` okaya 2018-03-25 13:33 ` okaya at codeaurora.org 2018-03-21 15:56 ` [PATCH v4 00/17] netdev: " David Miller 2018-03-21 15:56 ` David Miller 2018-03-21 19:06 ` Sinan Kaya 2018-03-21 19:06 ` Sinan Kaya
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1521513753-7325-1-git-send-email-okaya@codeaurora.org \ --to=okaya@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=sulrich@codeaurora.org \ --cc=timur@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.