From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch
Date: Thu, 22 Mar 2018 11:25:58 +0000 [thread overview]
Message-ID: <152171795801.23562.1359992836501611892@mail.alporthouse.com> (raw)
In-Reply-To: <20180322111712.9056-1-tvrtko.ursulin@linux.intel.com>
Quoting Tvrtko Ursulin (2018-03-22 11:17:10)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Pollable spin batch exports a spin->running pointer which can be checked
> by dereferencing it to see if the spinner is actually executing on the
> GPU.
>
> This is useful for tests which want to make sure they do not proceed with
> their next step whilst the spinner is potentially only being processed by
> the driver and not actually executing.
>
> Pollable spinner can be created with igt_spin_batch_new_poll or
> __igt_spin_batch_new_poll, after which a loop similar to:
>
> while (!*(volatile bool *)spin->running)
> ;
Let's actually make READ_ONCE() a common thing and make this a
convenient igt_spin_busywait_until_running() (igt_spin_spin)?
> Can be used to wait until the spinner start execution.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch
Date: Thu, 22 Mar 2018 11:25:58 +0000 [thread overview]
Message-ID: <152171795801.23562.1359992836501611892@mail.alporthouse.com> (raw)
In-Reply-To: <20180322111712.9056-1-tvrtko.ursulin@linux.intel.com>
Quoting Tvrtko Ursulin (2018-03-22 11:17:10)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Pollable spin batch exports a spin->running pointer which can be checked
> by dereferencing it to see if the spinner is actually executing on the
> GPU.
>
> This is useful for tests which want to make sure they do not proceed with
> their next step whilst the spinner is potentially only being processed by
> the driver and not actually executing.
>
> Pollable spinner can be created with igt_spin_batch_new_poll or
> __igt_spin_batch_new_poll, after which a loop similar to:
>
> while (!*(volatile bool *)spin->running)
> ;
Let's actually make READ_ONCE() a common thing and make this a
convenient igt_spin_busywait_until_running() (igt_spin_spin)?
> Can be used to wait until the spinner start execution.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-22 11:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 11:17 [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch Tvrtko Ursulin
2018-03-22 11:17 ` [Intel-gfx] " Tvrtko Ursulin
2018-03-22 11:17 ` [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution Tvrtko Ursulin
2018-03-22 11:17 ` [igt-dev] " Tvrtko Ursulin
2018-03-22 11:27 ` [PATCH i-g-t v2 " Tvrtko Ursulin
2018-03-22 11:27 ` [igt-dev] " Tvrtko Ursulin
2018-03-22 11:39 ` [igt-dev] [PATCH i-g-t " Chris Wilson
2018-03-22 11:39 ` Chris Wilson
2018-03-22 12:36 ` Tvrtko Ursulin
2018-03-22 12:36 ` Tvrtko Ursulin
2018-03-22 12:42 ` Chris Wilson
2018-03-22 12:42 ` Chris Wilson
2018-03-22 17:32 ` Antonio Argenziano
2018-03-22 17:32 ` [igt-dev] [Intel-gfx] " Antonio Argenziano
2018-03-22 18:14 ` [igt-dev] " Chris Wilson
2018-03-22 18:14 ` [igt-dev] [Intel-gfx] " Chris Wilson
2018-03-22 22:25 ` [igt-dev] " Antonio Argenziano
2018-03-22 22:25 ` [Intel-gfx] " Antonio Argenziano
2018-03-23 9:49 ` Tvrtko Ursulin
2018-03-23 9:49 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2018-03-22 11:17 ` [PATCH i-g-t 3/3] tests/perf_pmu: Improve accuracy by waiting on spinner to start Tvrtko Ursulin
2018-03-22 11:17 ` [igt-dev] " Tvrtko Ursulin
2018-03-22 11:25 ` Chris Wilson [this message]
2018-03-22 11:25 ` [Intel-gfx] [igt-dev] [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch Chris Wilson
2018-03-22 11:59 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/dummyload: Add pollable spin batch (rev2) Patchwork
2018-03-22 13:03 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-03-22 17:24 [igt-dev] [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152171795801.23562.1359992836501611892@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.