From: Antonio Argenziano <antonio.argenziano@intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org Subject: Re: [igt-dev] [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution Date: Thu, 22 Mar 2018 15:25:25 -0700 [thread overview] Message-ID: <44a637e3-a591-228a-e2db-8b617b8851bd@intel.com> (raw) In-Reply-To: <152174247057.23562.16458503208522153436@mail.alporthouse.com> On 22/03/18 11:14, Chris Wilson wrote: > Quoting Antonio Argenziano (2018-03-22 17:32:46) >> >> >> On 22/03/18 05:42, Chris Wilson wrote: >>> Quoting Tvrtko Ursulin (2018-03-22 12:36:58) >>>> >>>> On 22/03/2018 11:39, Chris Wilson wrote: >>>>> Quoting Tvrtko Ursulin (2018-03-22 11:17:11) >>>>> >>>>>> trigger_reset(fd); >>>>>> + >>>>>> + /* HACK for CI */ >>>>>> + igt_assert(igt_nsec_elapsed(&ts) < 5e9); >>>>> >>>>> igt_seconds_elapsed() the approximation is worth the readability. >>>>> >>>>> In this case you might like to try igt_set_timeout(), as I think each >>>>> subtest and exithandlers are in place to make them robust against >>>>> premature failures. >>>> >>>> Well this was just to see that will happen on the shards here. As >>>> mentioned in the commit I get that yet unexplained GPU hang at subtest >>>> exit here. So the assert above is just to notice if the same happens on >>>> shards. >>> >>> And I was thinking it was a reasonable enhancement :) Probably more so >>> for igt/gem_wait itself to ask that if we reset the request we are >>> waiting upon it completes in a timely manner. (We don't care about >>> wedged handling there, just reset handling.) >> >> How about checking for reset when we do gem_test_engine(), which seems >> to not fail on reset, (crudely https://paste.debian.net/1016059/)? > > I was thinking that the timeout would be good around the test as a > whole, because it is now meant to be uberfast. Makes sense. Thanks, Antonio > -Chris > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Argenziano <antonio.argenziano@intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution Date: Thu, 22 Mar 2018 15:25:25 -0700 [thread overview] Message-ID: <44a637e3-a591-228a-e2db-8b617b8851bd@intel.com> (raw) In-Reply-To: <152174247057.23562.16458503208522153436@mail.alporthouse.com> On 22/03/18 11:14, Chris Wilson wrote: > Quoting Antonio Argenziano (2018-03-22 17:32:46) >> >> >> On 22/03/18 05:42, Chris Wilson wrote: >>> Quoting Tvrtko Ursulin (2018-03-22 12:36:58) >>>> >>>> On 22/03/2018 11:39, Chris Wilson wrote: >>>>> Quoting Tvrtko Ursulin (2018-03-22 11:17:11) >>>>> >>>>>> trigger_reset(fd); >>>>>> + >>>>>> + /* HACK for CI */ >>>>>> + igt_assert(igt_nsec_elapsed(&ts) < 5e9); >>>>> >>>>> igt_seconds_elapsed() the approximation is worth the readability. >>>>> >>>>> In this case you might like to try igt_set_timeout(), as I think each >>>>> subtest and exithandlers are in place to make them robust against >>>>> premature failures. >>>> >>>> Well this was just to see that will happen on the shards here. As >>>> mentioned in the commit I get that yet unexplained GPU hang at subtest >>>> exit here. So the assert above is just to notice if the same happens on >>>> shards. >>> >>> And I was thinking it was a reasonable enhancement :) Probably more so >>> for igt/gem_wait itself to ask that if we reset the request we are >>> waiting upon it completes in a timely manner. (We don't care about >>> wedged handling there, just reset handling.) >> >> How about checking for reset when we do gem_test_engine(), which seems >> to not fail on reset, (crudely https://paste.debian.net/1016059/)? > > I was thinking that the timeout would be good around the test as a > whole, because it is now meant to be uberfast. Makes sense. Thanks, Antonio > -Chris > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-22 22:25 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-22 11:17 [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch Tvrtko Ursulin 2018-03-22 11:17 ` [Intel-gfx] " Tvrtko Ursulin 2018-03-22 11:17 ` [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution Tvrtko Ursulin 2018-03-22 11:17 ` [igt-dev] " Tvrtko Ursulin 2018-03-22 11:27 ` [PATCH i-g-t v2 " Tvrtko Ursulin 2018-03-22 11:27 ` [igt-dev] " Tvrtko Ursulin 2018-03-22 11:39 ` [igt-dev] [PATCH i-g-t " Chris Wilson 2018-03-22 11:39 ` Chris Wilson 2018-03-22 12:36 ` Tvrtko Ursulin 2018-03-22 12:36 ` Tvrtko Ursulin 2018-03-22 12:42 ` Chris Wilson 2018-03-22 12:42 ` Chris Wilson 2018-03-22 17:32 ` Antonio Argenziano 2018-03-22 17:32 ` [igt-dev] [Intel-gfx] " Antonio Argenziano 2018-03-22 18:14 ` [igt-dev] " Chris Wilson 2018-03-22 18:14 ` [igt-dev] [Intel-gfx] " Chris Wilson 2018-03-22 22:25 ` Antonio Argenziano [this message] 2018-03-22 22:25 ` [Intel-gfx] [igt-dev] " Antonio Argenziano 2018-03-23 9:49 ` Tvrtko Ursulin 2018-03-23 9:49 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin 2018-03-22 11:17 ` [PATCH i-g-t 3/3] tests/perf_pmu: Improve accuracy by waiting on spinner to start Tvrtko Ursulin 2018-03-22 11:17 ` [igt-dev] " Tvrtko Ursulin 2018-03-22 11:25 ` [igt-dev] [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch Chris Wilson 2018-03-22 11:25 ` [Intel-gfx] " Chris Wilson 2018-03-22 11:59 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/dummyload: Add pollable spin batch (rev2) Patchwork 2018-03-22 13:03 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2018-03-22 17:24 [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch Tvrtko Ursulin 2018-03-22 17:24 ` [igt-dev] [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution Tvrtko Ursulin 2018-03-22 17:44 ` Chris Wilson 2018-03-22 17:44 ` Chris Wilson 2018-03-23 9:46 ` Tvrtko Ursulin 2018-03-23 9:54 ` Chris Wilson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=44a637e3-a591-228a-e2db-8b617b8851bd@intel.com \ --to=antonio.argenziano@intel.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=chris@chris-wilson.co.uk \ --cc=igt-dev@lists.freedesktop.org \ --cc=tursulin@ursulin.net \ --cc=tvrtko.ursulin@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.