* [LTP] [PATCH v2 0/2] sctp: add new regression test for CVE-2018-5803
@ 2018-03-23 15:37 Alexey Kodanev
2018-03-23 15:37 ` [LTP] [PATCH v2 1/2] include/lapi: add sctp.h Alexey Kodanev
2018-03-23 15:37 ` [LTP] [PATCH v2 2/2] sctp: new regression test sctp_big_chunk for CVE-2018-5803 Alexey Kodanev
0 siblings, 2 replies; 7+ messages in thread
From: Alexey Kodanev @ 2018-03-23 15:37 UTC (permalink / raw)
To: ltp
* create lapi/sctp.h header and define SCTP_SOCKOPT_BINDX_ADD if
there is no linux/sctp.h.
* add new test to network/sctp for over-sized SCTP chunk.
Alexey Kodanev (2):
include/lapi: add sctp.h
sctp: new regression test sctp_big_chunk for CVE-2018-5803
configure.ac | 1 +
include/lapi/sctp.h | 29 ++++++++
include/lapi/socket.h | 4 +
runtest/cve | 2 +
testcases/network/.gitignore | 1 +
testcases/network/sctp/Makefile | 2 +-
testcases/network/sctp/sctp_big_chunk.c | 121 +++++++++++++++++++++++++++++++
7 files changed, 159 insertions(+), 1 deletions(-)
create mode 100644 include/lapi/sctp.h
create mode 100644 testcases/network/sctp/sctp_big_chunk.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH v2 1/2] include/lapi: add sctp.h
2018-03-23 15:37 [LTP] [PATCH v2 0/2] sctp: add new regression test for CVE-2018-5803 Alexey Kodanev
@ 2018-03-23 15:37 ` Alexey Kodanev
2018-03-26 10:55 ` Petr Vorel
2018-03-23 15:37 ` [LTP] [PATCH v2 2/2] sctp: new regression test sctp_big_chunk for CVE-2018-5803 Alexey Kodanev
1 sibling, 1 reply; 7+ messages in thread
From: Alexey Kodanev @ 2018-03-23 15:37 UTC (permalink / raw)
To: ltp
Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
---
v2: include linux/sctp.h header and check it in the configure
configure.ac | 1 +
include/lapi/sctp.h | 29 +++++++++++++++++++++++++++++
2 files changed, 30 insertions(+), 0 deletions(-)
create mode 100644 include/lapi/sctp.h
diff --git a/configure.ac b/configure.ac
index 85426ad..97d643b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -44,6 +44,7 @@ AC_CHECK_HEADERS([ \
linux/mempolicy.h \
linux/module.h \
linux/netlink.h \
+ linux/sctp.h \
mm.h \
pthread.h \
sys/epoll.h \
diff --git a/include/lapi/sctp.h b/include/lapi/sctp.h
new file mode 100644
index 0000000..69adc7a
--- /dev/null
+++ b/include/lapi/sctp.h
@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) 2018 Oracle and/or its affiliates.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef LAPI_SCTP_H__
+#define LAPI_SCTP_H__
+
+#ifdef HAVE_LINUX_SCTP_H
+# include <linux/sctp.h>
+#endif
+
+#ifndef SCTP_SOCKOPT_BINDX_ADD
+# define SCTP_SOCKOPT_BINDX_ADD 100
+#endif
+
+#endif /* LAPI_SCTP_H__ */
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [LTP] [PATCH v2 2/2] sctp: new regression test sctp_big_chunk for CVE-2018-5803
2018-03-23 15:37 [LTP] [PATCH v2 0/2] sctp: add new regression test for CVE-2018-5803 Alexey Kodanev
2018-03-23 15:37 ` [LTP] [PATCH v2 1/2] include/lapi: add sctp.h Alexey Kodanev
@ 2018-03-23 15:37 ` Alexey Kodanev
2018-03-26 11:05 ` Petr Vorel
1 sibling, 1 reply; 7+ messages in thread
From: Alexey Kodanev @ 2018-03-23 15:37 UTC (permalink / raw)
To: ltp
Added two test-cases in runtest/cve:
* cve-2018-5803 - over-sized INIT_ACK packet
* cve-2018-5803_2 - over-sized INIT packet
Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
---
v2: rename the test file and move it to testcases/network/sctp/
include/lapi/socket.h | 4 +
runtest/cve | 2 +
testcases/network/.gitignore | 1 +
testcases/network/sctp/Makefile | 2 +-
testcases/network/sctp/sctp_big_chunk.c | 121 +++++++++++++++++++++++++++++++
5 files changed, 129 insertions(+), 1 deletions(-)
create mode 100644 testcases/network/sctp/sctp_big_chunk.c
diff --git a/include/lapi/socket.h b/include/lapi/socket.h
index 426906f..d58c460 100644
--- a/include/lapi/socket.h
+++ b/include/lapi/socket.h
@@ -45,6 +45,10 @@
# define SOCK_CLOEXEC 02000000
#endif
+#ifndef SOL_SCTP
+# define SOL_SCTP 132
+#endif
+
#ifndef SOL_UDPLITE
# define SOL_UDPLITE 136 /* UDP-Lite (RFC 3828) */
#endif
diff --git a/runtest/cve b/runtest/cve
index 8b7cbe5..1d9569a 100644
--- a/runtest/cve
+++ b/runtest/cve
@@ -32,3 +32,5 @@ cve-2017-5754 meltdown
cve-2017-17052 cve-2017-17052
cve-2017-16939 cve-2017-16939
cve-2017-17053 cve-2017-17053
+cve-2018-5803 sctp_big_chunk
+cve-2018-5803_2 sctp_big_chunk -a 10000
diff --git a/testcases/network/.gitignore b/testcases/network/.gitignore
index d4ed925..e952f6f 100644
--- a/testcases/network/.gitignore
+++ b/testcases/network/.gitignore
@@ -22,6 +22,7 @@
/nfsv4/locks/locktests
/rpc/basic_tests/rpc01/rpc1
/rpc/basic_tests/rpc01/rpc_server
+/sctp/sctp_big_chunk
/sockets/ltpClient
/sockets/ltpServer
/stress/ns-tools/ns-icmp_redirector
diff --git a/testcases/network/sctp/Makefile b/testcases/network/sctp/Makefile
index 914e389..0fa9125 100644
--- a/testcases/network/sctp/Makefile
+++ b/testcases/network/sctp/Makefile
@@ -15,7 +15,7 @@
top_srcdir ?= ../../..
-include $(top_srcdir)/include/mk/env_pre.mk
+include $(top_srcdir)/include/mk/testcases.mk
INSTALL_TARGETS := sctp01.sh
diff --git a/testcases/network/sctp/sctp_big_chunk.c b/testcases/network/sctp/sctp_big_chunk.c
new file mode 100644
index 0000000..55a2969
--- /dev/null
+++ b/testcases/network/sctp/sctp_big_chunk.c
@@ -0,0 +1,121 @@
+/*
+ * Copyright (c) 2018 Oracle and/or its affiliates. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Regression test-case for the crash caused by over-sized SCTP chunk,
+ * fixed by upstream commit 07f2c7ab6f8d ("sctp: verify size of a new
+ * chunk in _sctp_make_chunk()")
+ */
+
+#include <stdlib.h>
+#include <unistd.h>
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
+#include <netdb.h>
+#include <sys/syscall.h>
+#include <fcntl.h>
+
+#include "tst_test.h"
+#include "tst_safe_stdio.h"
+#include "lapi/netinet_in.h"
+#include "lapi/socket.h"
+#include "lapi/sctp.h"
+
+static int port;
+static int sfd, cfd;
+static struct sockaddr_in6 rmt, loc;
+
+static char *addr_param;
+static int addr_num = 3273;
+
+static void setup_server(void)
+{
+ loc.sin6_family = AF_INET6;
+ loc.sin6_addr = in6addr_loopback;
+
+ sfd = SAFE_SOCKET(AF_INET6, SOCK_STREAM, IPPROTO_SCTP);
+ SAFE_BIND(sfd, (struct sockaddr *)&loc, sizeof(loc));
+
+ port = TST_GETSOCKPORT(sfd);
+ tst_res(TINFO, "sctp server listen on %d", port);
+
+ SAFE_LISTEN(sfd, 1);
+}
+
+static void setup_client(void)
+{
+ struct sockaddr_in6 addr_buf[addr_num];
+ int i;
+
+ cfd = SAFE_SOCKET(AF_INET6, SOCK_STREAM, IPPROTO_SCTP);
+ rmt.sin6_family = AF_INET6;
+ rmt.sin6_addr = in6addr_loopback;
+ rmt.sin6_port = htons(port);
+
+ tst_res(TINFO, "bind %d additional IP addresses", addr_num);
+
+ memset(addr_buf, 0, sizeof(addr_buf));
+ for (i = 0; i < addr_num; ++i) {
+ addr_buf[i].sin6_family = AF_INET6;
+ addr_buf[i].sin6_addr = in6addr_loopback;
+ }
+
+ SAFE_SETSOCKOPT(cfd, SOL_SCTP, SCTP_SOCKOPT_BINDX_ADD, addr_buf,
+ sizeof(addr_buf));
+}
+
+static void setup(void)
+{
+ if (tst_parse_int(addr_param, &addr_num, 1, INT_MAX))
+ tst_brk(TBROK, "wrong address number '%s'", addr_param);
+
+ setup_server();
+ setup_client();
+}
+
+static void run(void)
+{
+ int pid = SAFE_FORK();
+
+ if (!pid) {
+ struct sockaddr_in6 addr6;
+ socklen_t addr_size = sizeof(addr6);
+
+ if (accept(sfd, (struct sockaddr *)&addr6, &addr_size) < 0)
+ tst_brk(TBROK | TERRNO, "accept() failed");
+ exit(0);
+ }
+
+ fcntl(cfd, F_SETFL, O_NONBLOCK);
+ connect(cfd, (struct sockaddr *)&rmt, sizeof(rmt));
+
+ SAFE_KILL(pid, SIGKILL);
+ SAFE_WAITPID(pid, NULL, 0);
+
+ tst_res(TPASS, "test doesn't cause crash");
+}
+
+static struct tst_option options[] = {
+ {"a:", &addr_param, "-a number of additional IP address params"},
+ {NULL, NULL, NULL}
+};
+
+static struct tst_test test = {
+ .setup = setup,
+ .forks_child = 1,
+ .test_all = run,
+ .options = options
+};
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [LTP] [PATCH v2 1/2] include/lapi: add sctp.h
2018-03-23 15:37 ` [LTP] [PATCH v2 1/2] include/lapi: add sctp.h Alexey Kodanev
@ 2018-03-26 10:55 ` Petr Vorel
2018-03-28 14:35 ` Alexey Kodanev
0 siblings, 1 reply; 7+ messages in thread
From: Petr Vorel @ 2018-03-26 10:55 UTC (permalink / raw)
To: ltp
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> ---
> v2: include linux/sctp.h header and check it in the configure
> configure.ac | 1 +
> include/lapi/sctp.h | 29 +++++++++++++++++++++++++++++
> 2 files changed, 30 insertions(+), 0 deletions(-)
> create mode 100644 include/lapi/sctp.h
> diff --git a/configure.ac b/configure.ac
> index 85426ad..97d643b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -44,6 +44,7 @@ AC_CHECK_HEADERS([ \
> linux/mempolicy.h \
> linux/module.h \
> linux/netlink.h \
> + linux/sctp.h \
> mm.h \
> pthread.h \
> sys/epoll.h \
> diff --git a/include/lapi/sctp.h b/include/lapi/sctp.h
> new file mode 100644
> index 0000000..69adc7a
> --- /dev/null
> +++ b/include/lapi/sctp.h
> @@ -0,0 +1,29 @@
> +/*
> + * Copyright (c) 2018 Oracle and/or its affiliates.
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef LAPI_SCTP_H__
> +#define LAPI_SCTP_H__
> +
> +#ifdef HAVE_LINUX_SCTP_H
> +# include <linux/sctp.h>
> +#endif
> +
> +#ifndef SCTP_SOCKOPT_BINDX_ADD
> +# define SCTP_SOCKOPT_BINDX_ADD 100
> +#endif
> +
> +#endif /* LAPI_SCTP_H__ */
Acked-by: Petr Vorel <petr.vorel@gmail.com>
BTW SCTP_SOCKOPT_BINDX_ADD is defined in both <linux/sctp.h> and <netinet/sctp.h>, so if we
ever in future want to have some definitions from netinet/sctp.h, I'd be to create special
file include/lapi/netinet_sctp.h (the same like include/lapi/netinet_in.h - taking that
default is for "kernel/").
And we have included netinet/sctp.h in sources (utils/sctp/include/netinet/sctp.h), IMHO
not good idea to have common headers in our sources.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH v2 2/2] sctp: new regression test sctp_big_chunk for CVE-2018-5803
2018-03-23 15:37 ` [LTP] [PATCH v2 2/2] sctp: new regression test sctp_big_chunk for CVE-2018-5803 Alexey Kodanev
@ 2018-03-26 11:05 ` Petr Vorel
0 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2018-03-26 11:05 UTC (permalink / raw)
To: ltp
Hi Alexey,
> Added two test-cases in runtest/cve:
> * cve-2018-5803 - over-sized INIT_ACK packet
> * cve-2018-5803_2 - over-sized INIT packet
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> ---
> v2: rename the test file and move it to testcases/network/sctp/
> include/lapi/socket.h | 4 +
> runtest/cve | 2 +
> testcases/network/.gitignore | 1 +
> testcases/network/sctp/Makefile | 2 +-
> testcases/network/sctp/sctp_big_chunk.c | 121 +++++++++++++++++++++++++++++++
> 5 files changed, 129 insertions(+), 1 deletions(-)
> create mode 100644 testcases/network/sctp/sctp_big_chunk.c
> diff --git a/include/lapi/socket.h b/include/lapi/socket.h
> index 426906f..d58c460 100644
> --- a/include/lapi/socket.h
> +++ b/include/lapi/socket.h
> @@ -45,6 +45,10 @@
> # define SOCK_CLOEXEC 02000000
> #endif
> +#ifndef SOL_SCTP
> +# define SOL_SCTP 132
> +#endif
> +
> #ifndef SOL_UDPLITE
> # define SOL_UDPLITE 136 /* UDP-Lite (RFC 3828) */
> #endif
> diff --git a/runtest/cve b/runtest/cve
> index 8b7cbe5..1d9569a 100644
> --- a/runtest/cve
> +++ b/runtest/cve
> @@ -32,3 +32,5 @@ cve-2017-5754 meltdown
> cve-2017-17052 cve-2017-17052
> cve-2017-16939 cve-2017-16939
> cve-2017-17053 cve-2017-17053
> +cve-2018-5803 sctp_big_chunk
> +cve-2018-5803_2 sctp_big_chunk -a 10000
> diff --git a/testcases/network/.gitignore b/testcases/network/.gitignore
> index d4ed925..e952f6f 100644
> --- a/testcases/network/.gitignore
> +++ b/testcases/network/.gitignore
> @@ -22,6 +22,7 @@
> /nfsv4/locks/locktests
> /rpc/basic_tests/rpc01/rpc1
> /rpc/basic_tests/rpc01/rpc_server
> +/sctp/sctp_big_chunk
> /sockets/ltpClient
> /sockets/ltpServer
> /stress/ns-tools/ns-icmp_redirector
> diff --git a/testcases/network/sctp/Makefile b/testcases/network/sctp/Makefile
> index 914e389..0fa9125 100644
> --- a/testcases/network/sctp/Makefile
> +++ b/testcases/network/sctp/Makefile
> @@ -15,7 +15,7 @@
> top_srcdir ?= ../../..
> -include $(top_srcdir)/include/mk/env_pre.mk
> +include $(top_srcdir)/include/mk/testcases.mk
> INSTALL_TARGETS := sctp01.sh
> diff --git a/testcases/network/sctp/sctp_big_chunk.c b/testcases/network/sctp/sctp_big_chunk.c
> new file mode 100644
> index 0000000..55a2969
> --- /dev/null
> +++ b/testcases/network/sctp/sctp_big_chunk.c
> @@ -0,0 +1,121 @@
> +/*
> + * Copyright (c) 2018 Oracle and/or its affiliates. All Rights Reserved.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it would be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + *
> + * Regression test-case for the crash caused by over-sized SCTP chunk,
> + * fixed by upstream commit 07f2c7ab6f8d ("sctp: verify size of a new
> + * chunk in _sctp_make_chunk()")
> + */
> +
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <sys/types.h>
> +#include <sys/socket.h>
> +#include <netinet/in.h>
> +#include <netdb.h>
> +#include <sys/syscall.h>
> +#include <fcntl.h>
> +
> +#include "tst_test.h"
> +#include "tst_safe_stdio.h"
> +#include "lapi/netinet_in.h"
> +#include "lapi/socket.h"
> +#include "lapi/sctp.h"
> +
> +static int port;
> +static int sfd, cfd;
> +static struct sockaddr_in6 rmt, loc;
> +
> +static char *addr_param;
> +static int addr_num = 3273;
> +
> +static void setup_server(void)
> +{
> + loc.sin6_family = AF_INET6;
> + loc.sin6_addr = in6addr_loopback;
> +
> + sfd = SAFE_SOCKET(AF_INET6, SOCK_STREAM, IPPROTO_SCTP);
> + SAFE_BIND(sfd, (struct sockaddr *)&loc, sizeof(loc));
> +
> + port = TST_GETSOCKPORT(sfd);
> + tst_res(TINFO, "sctp server listen on %d", port);
> +
> + SAFE_LISTEN(sfd, 1);
> +}
> +
> +static void setup_client(void)
> +{
> + struct sockaddr_in6 addr_buf[addr_num];
> + int i;
> +
> + cfd = SAFE_SOCKET(AF_INET6, SOCK_STREAM, IPPROTO_SCTP);
> + rmt.sin6_family = AF_INET6;
> + rmt.sin6_addr = in6addr_loopback;
> + rmt.sin6_port = htons(port);
> +
> + tst_res(TINFO, "bind %d additional IP addresses", addr_num);
> +
> + memset(addr_buf, 0, sizeof(addr_buf));
> + for (i = 0; i < addr_num; ++i) {
> + addr_buf[i].sin6_family = AF_INET6;
> + addr_buf[i].sin6_addr = in6addr_loopback;
> + }
> +
> + SAFE_SETSOCKOPT(cfd, SOL_SCTP, SCTP_SOCKOPT_BINDX_ADD, addr_buf,
> + sizeof(addr_buf));
> +}
> +
> +static void setup(void)
> +{
> + if (tst_parse_int(addr_param, &addr_num, 1, INT_MAX))
> + tst_brk(TBROK, "wrong address number '%s'", addr_param);
> +
> + setup_server();
> + setup_client();
> +}
> +
> +static void run(void)
> +{
> + int pid = SAFE_FORK();
> +
> + if (!pid) {
> + struct sockaddr_in6 addr6;
> + socklen_t addr_size = sizeof(addr6);
> +
> + if (accept(sfd, (struct sockaddr *)&addr6, &addr_size) < 0)
> + tst_brk(TBROK | TERRNO, "accept() failed");
> + exit(0);
> + }
> +
> + fcntl(cfd, F_SETFL, O_NONBLOCK);
> + connect(cfd, (struct sockaddr *)&rmt, sizeof(rmt));
> +
> + SAFE_KILL(pid, SIGKILL);
> + SAFE_WAITPID(pid, NULL, 0);
> +
> + tst_res(TPASS, "test doesn't cause crash");
> +}
> +
> +static struct tst_option options[] = {
> + {"a:", &addr_param, "-a number of additional IP address params"},
> + {NULL, NULL, NULL}
> +};
> +
> +static struct tst_test test = {
> + .setup = setup,
> + .forks_child = 1,
> + .test_all = run,
> + .options = options
> +};
Acked-by: Petr Vorel <petr.vorel@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH v2 1/2] include/lapi: add sctp.h
2018-03-26 10:55 ` Petr Vorel
@ 2018-03-28 14:35 ` Alexey Kodanev
2018-03-29 6:12 ` Petr Vorel
0 siblings, 1 reply; 7+ messages in thread
From: Alexey Kodanev @ 2018-03-28 14:35 UTC (permalink / raw)
To: ltp
On 26.03.2018 13:55, Petr Vorel wrote:
>> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
>> ---
>> v2: include linux/sctp.h header and check it in the configure
Applied the patch-set.
> BTW SCTP_SOCKOPT_BINDX_ADD is defined in both <linux/sctp.h> and <netinet/sctp.h>, so if we
> ever in future want to have some definitions from netinet/sctp.h, I'd be to create special
> file include/lapi/netinet_sctp.h (the same like include/lapi/netinet_in.h - taking that
> default is for "kernel/").
>
I think if we have netinet/sctp.h it should take precedences
over linux/sctp.h. In OL7 it is provided by optional
lksctp-tools-devel package.
Thanks,
Alexey
> And we have included netinet/sctp.h in sources (utils/sctp/include/netinet/sctp.h), IMHO
> not good idea to have common headers in our sources.
>
>
> Kind regards,
> Petr
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH v2 1/2] include/lapi: add sctp.h
2018-03-28 14:35 ` Alexey Kodanev
@ 2018-03-29 6:12 ` Petr Vorel
0 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2018-03-29 6:12 UTC (permalink / raw)
To: ltp
Hi Alexey,
> > BTW SCTP_SOCKOPT_BINDX_ADD is defined in both <linux/sctp.h> and <netinet/sctp.h>, so if we
> > ever in future want to have some definitions from netinet/sctp.h, I'd be to create special
> > file include/lapi/netinet_sctp.h (the same like include/lapi/netinet_in.h - taking that
> > default is for "kernel/").
> I think if we have netinet/sctp.h it should take precedences
> over linux/sctp.h. In OL7 it is provided by optional
> lksctp-tools-devel package.
But linux/sctp.h has much more definitions than netinet/sctp.h and we use some kernel
specific definitions (e.g. SOL_UDPLITE is just in linux/sctp.h, SOL_SCTP is in both).
> Thanks,
> Alexey
Kind regards,
Petr
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-29 6:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-23 15:37 [LTP] [PATCH v2 0/2] sctp: add new regression test for CVE-2018-5803 Alexey Kodanev
2018-03-23 15:37 ` [LTP] [PATCH v2 1/2] include/lapi: add sctp.h Alexey Kodanev
2018-03-26 10:55 ` Petr Vorel
2018-03-28 14:35 ` Alexey Kodanev
2018-03-29 6:12 ` Petr Vorel
2018-03-23 15:37 ` [LTP] [PATCH v2 2/2] sctp: new regression test sctp_big_chunk for CVE-2018-5803 Alexey Kodanev
2018-03-26 11:05 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.