* [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
@ 2018-03-23 23:44 ` Timur Tabi
0 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2018-03-23 23:44 UTC (permalink / raw)
To: linux-arm-kernel
Two data structures are declared as static globals but are intended to
be per-TLMM. Move them into the msm_pinctrl structure and initialize
them at runtime.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 44 ++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index ad80a17c9990..fa4e94fedb8c 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -58,7 +58,10 @@ struct msm_pinctrl {
struct device *dev;
struct pinctrl_dev *pctrl;
struct gpio_chip chip;
+ struct pinctrl_desc desc;
struct notifier_block restart_nb;
+
+ struct irq_chip irq_chip;
int irq;
raw_spinlock_t lock;
@@ -390,13 +393,6 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
.pin_config_group_set = msm_config_group_set,
};
-static struct pinctrl_desc msm_pinctrl_desc = {
- .pctlops = &msm_pinctrl_ops,
- .pmxops = &msm_pinmux_ops,
- .confops = &msm_pinconf_ops,
- .owner = THIS_MODULE,
-};
-
static int msm_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
{
const struct msm_pingroup *g;
@@ -776,15 +772,6 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on)
return 0;
}
-static struct irq_chip msm_gpio_irq_chip = {
- .name = "msmgpio",
- .irq_mask = msm_gpio_irq_mask,
- .irq_unmask = msm_gpio_irq_unmask,
- .irq_ack = msm_gpio_irq_ack,
- .irq_set_type = msm_gpio_irq_set_type,
- .irq_set_wake = msm_gpio_irq_set_wake,
-};
-
static void msm_gpio_irq_handler(struct irq_desc *desc)
{
struct gpio_chip *gc = irq_desc_get_handler_data(desc);
@@ -877,6 +864,13 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
chip->of_node = pctrl->dev->of_node;
chip->need_valid_mask = msm_gpio_needs_valid_mask(pctrl);
+ pctrl->irq_chip.name = "msmgpio";
+ pctrl->irq_chip.irq_mask = msm_gpio_irq_mask;
+ pctrl->irq_chip.irq_unmask = msm_gpio_irq_unmask;
+ pctrl->irq_chip.irq_ack = msm_gpio_irq_ack;
+ pctrl->irq_chip.irq_set_type = msm_gpio_irq_set_type;
+ pctrl->irq_chip.irq_set_wake = msm_gpio_irq_set_wake;
+
ret = gpiochip_add_data(&pctrl->chip, pctrl);
if (ret) {
dev_err(pctrl->dev, "Failed register gpiochip\n");
@@ -898,7 +892,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
}
ret = gpiochip_irqchip_add(chip,
- &msm_gpio_irq_chip,
+ &pctrl->irq_chip,
0,
handle_edge_irq,
IRQ_TYPE_NONE);
@@ -908,7 +902,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
return -ENOSYS;
}
- gpiochip_set_chained_irqchip(chip, &msm_gpio_irq_chip, pctrl->irq,
+ gpiochip_set_chained_irqchip(chip, &pctrl->irq_chip, pctrl->irq,
msm_gpio_irq_handler);
return 0;
@@ -979,11 +973,15 @@ int msm_pinctrl_probe(struct platform_device *pdev,
return pctrl->irq;
}
- msm_pinctrl_desc.name = dev_name(&pdev->dev);
- msm_pinctrl_desc.pins = pctrl->soc->pins;
- msm_pinctrl_desc.npins = pctrl->soc->npins;
- pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &msm_pinctrl_desc,
- pctrl);
+ pctrl->desc.owner = THIS_MODULE;
+ pctrl->desc.pctlops = &msm_pinctrl_ops;
+ pctrl->desc.pmxops = &msm_pinmux_ops;
+ pctrl->desc.confops = &msm_pinconf_ops;
+ pctrl->desc.name = dev_name(&pdev->dev);
+ pctrl->desc.pins = pctrl->soc->pins;
+ pctrl->desc.npins = pctrl->soc->npins;
+
+ pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &pctrl->desc, pctrl);
if (IS_ERR(pctrl->pctrl)) {
dev_err(&pdev->dev, "Couldn't register pinctrl driver\n");
return PTR_ERR(pctrl->pctrl);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
2018-03-23 23:44 ` Timur Tabi
@ 2018-03-23 23:45 ` Timur Tabi
-1 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2018-03-23 23:45 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Stephen Boyd, linux-arm-kernel,
linux-arm-msm, linux-gpio
Cc: timur
Newer versions of the firmware for the Qualcomm Datacenter Technologies
QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
prevent older kernels from accidentally accessing the restricted GPIOs,
we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
and introduce a new property "gpios". This property is an array of
specific GPIOs that are accessible. When an older kernel boots on
newer (restricted) firmware, it will fail to probe.
To implement the sparse GPIO map, we register all of the GPIOs, but
fill in the data only for available GPIOs. This ensures that the driver
cannot accidentally access an unavailable GPIO.
The pinctrl-msm driver also scans the "gpios" property to determine
which pins are available, and ensure that only those can be registered.
Support for QCOM8001 is removed as there is no longer any firmware that
implements it.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 114 +++++++++++++++++++++------------
1 file changed, 73 insertions(+), 41 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
index bb3ce5c3e18b..1dfbe42dd895 100644
--- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
+++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
@@ -30,9 +30,7 @@
#include "pinctrl-msm.h"
-static struct msm_pinctrl_soc_data qdf2xxx_pinctrl;
-
-/* A reasonable limit to the number of GPIOS */
+/* A maximum of 256 allows us to use a u8 array to hold the GPIO numbers */
#define MAX_GPIOS 256
/* maximum size of each gpio name (enough room for "gpioXXX" + null) */
@@ -40,77 +38,111 @@
static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
{
+ struct msm_pinctrl_soc_data *pinctrl;
struct pinctrl_pin_desc *pins;
struct msm_pingroup *groups;
char (*names)[NAME_SIZE];
unsigned int i;
u32 num_gpios;
+ unsigned int avail_gpios; /* The number of GPIOs we support */
+ u8 gpios[MAX_GPIOS]; /* An array of supported GPIOs */
int ret;
/* Query the number of GPIOs from ACPI */
ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
if (ret < 0) {
- dev_warn(&pdev->dev, "missing num-gpios property\n");
+ dev_err(&pdev->dev, "missing 'num-gpios' property\n");
return ret;
}
-
if (!num_gpios || num_gpios > MAX_GPIOS) {
- dev_warn(&pdev->dev, "invalid num-gpios property\n");
+ dev_err(&pdev->dev, "invalid 'num-gpios' property\n");
+ return -ENODEV;
+ }
+
+ /* The number of GPIOs in the approved list */
+ ret = device_property_read_u8_array(&pdev->dev, "gpios", NULL, 0);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "missing 'gpios' property\n");
+ return ret;
+ }
+ /*
+ * The number of available GPIOs should be non-zero, and no
+ * more than the total number of GPIOS.
+ */
+ if (!ret || ret > num_gpios) {
+ dev_err(&pdev->dev, "invalid 'gpios' property\n");
return -ENODEV;
}
+ avail_gpios = ret;
+ ret = device_property_read_u8_array(&pdev->dev, "gpios", gpios,
+ avail_gpios);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "could not read list of GPIOs\n");
+ return ret;
+ }
+
+ pinctrl = devm_kzalloc(&pdev->dev, sizeof(*pinctrl), GFP_KERNEL);
pins = devm_kcalloc(&pdev->dev, num_gpios,
sizeof(struct pinctrl_pin_desc), GFP_KERNEL);
groups = devm_kcalloc(&pdev->dev, num_gpios,
sizeof(struct msm_pingroup), GFP_KERNEL);
- names = devm_kcalloc(&pdev->dev, num_gpios, NAME_SIZE, GFP_KERNEL);
+ names = devm_kcalloc(&pdev->dev, avail_gpios, NAME_SIZE, GFP_KERNEL);
- if (!pins || !groups || !names)
+ if (!pinctrl || !pins || !groups || !names)
return -ENOMEM;
+ /*
+ * Initialize the array. GPIOs not listed in the 'gpios' array
+ * still need a number, but nothing else.
+ */
for (i = 0; i < num_gpios; i++) {
- snprintf(names[i], NAME_SIZE, "gpio%u", i);
-
pins[i].number = i;
- pins[i].name = names[i];
-
- groups[i].npins = 1;
- groups[i].name = names[i];
groups[i].pins = &pins[i].number;
+ }
- groups[i].ctl_reg = 0x10000 * i;
- groups[i].io_reg = 0x04 + 0x10000 * i;
- groups[i].intr_cfg_reg = 0x08 + 0x10000 * i;
- groups[i].intr_status_reg = 0x0c + 0x10000 * i;
- groups[i].intr_target_reg = 0x08 + 0x10000 * i;
-
- groups[i].mux_bit = 2;
- groups[i].pull_bit = 0;
- groups[i].drv_bit = 6;
- groups[i].oe_bit = 9;
- groups[i].in_bit = 0;
- groups[i].out_bit = 1;
- groups[i].intr_enable_bit = 0;
- groups[i].intr_status_bit = 0;
- groups[i].intr_target_bit = 5;
- groups[i].intr_target_kpss_val = 1;
- groups[i].intr_raw_status_bit = 4;
- groups[i].intr_polarity_bit = 1;
- groups[i].intr_detection_bit = 2;
- groups[i].intr_detection_width = 2;
+ /* Populate the entries that are meant to be exposed as GPIOs. */
+ for (i = 0; i < avail_gpios; i++) {
+ unsigned int gpio = gpios[i];
+
+ groups[gpio].npins = 1;
+ snprintf(names[i], NAME_SIZE, "gpio%u", gpio);
+ pins[gpio].name = names[i];
+ groups[gpio].name = names[i];
+
+ groups[gpio].ctl_reg = 0x10000 * gpio;
+ groups[gpio].io_reg = 0x04 + 0x10000 * gpio;
+ groups[gpio].intr_cfg_reg = 0x08 + 0x10000 * gpio;
+ groups[gpio].intr_status_reg = 0x0c + 0x10000 * gpio;
+ groups[gpio].intr_target_reg = 0x08 + 0x10000 * gpio;
+
+ groups[gpio].mux_bit = 2;
+ groups[gpio].pull_bit = 0;
+ groups[gpio].drv_bit = 6;
+ groups[gpio].oe_bit = 9;
+ groups[gpio].in_bit = 0;
+ groups[gpio].out_bit = 1;
+ groups[gpio].intr_enable_bit = 0;
+ groups[gpio].intr_status_bit = 0;
+ groups[gpio].intr_target_bit = 5;
+ groups[gpio].intr_target_kpss_val = 1;
+ groups[gpio].intr_raw_status_bit = 4;
+ groups[gpio].intr_polarity_bit = 1;
+ groups[gpio].intr_detection_bit = 2;
+ groups[gpio].intr_detection_width = 2;
}
- qdf2xxx_pinctrl.pins = pins;
- qdf2xxx_pinctrl.groups = groups;
- qdf2xxx_pinctrl.npins = num_gpios;
- qdf2xxx_pinctrl.ngroups = num_gpios;
- qdf2xxx_pinctrl.ngpios = num_gpios;
+ pinctrl->pins = pins;
+ pinctrl->groups = groups;
+ pinctrl->npins = num_gpios;
+ pinctrl->ngroups = num_gpios;
+ pinctrl->ngpios = num_gpios;
- return msm_pinctrl_probe(pdev, &qdf2xxx_pinctrl);
+ return msm_pinctrl_probe(pdev, pinctrl);
}
static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
- {"QCOM8001"},
+ {"QCOM8002"},
{},
};
MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
@ 2018-03-23 23:45 ` Timur Tabi
0 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2018-03-23 23:45 UTC (permalink / raw)
To: linux-arm-kernel
Newer versions of the firmware for the Qualcomm Datacenter Technologies
QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
prevent older kernels from accidentally accessing the restricted GPIOs,
we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
and introduce a new property "gpios". This property is an array of
specific GPIOs that are accessible. When an older kernel boots on
newer (restricted) firmware, it will fail to probe.
To implement the sparse GPIO map, we register all of the GPIOs, but
fill in the data only for available GPIOs. This ensures that the driver
cannot accidentally access an unavailable GPIO.
The pinctrl-msm driver also scans the "gpios" property to determine
which pins are available, and ensure that only those can be registered.
Support for QCOM8001 is removed as there is no longer any firmware that
implements it.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 114 +++++++++++++++++++++------------
1 file changed, 73 insertions(+), 41 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
index bb3ce5c3e18b..1dfbe42dd895 100644
--- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
+++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
@@ -30,9 +30,7 @@
#include "pinctrl-msm.h"
-static struct msm_pinctrl_soc_data qdf2xxx_pinctrl;
-
-/* A reasonable limit to the number of GPIOS */
+/* A maximum of 256 allows us to use a u8 array to hold the GPIO numbers */
#define MAX_GPIOS 256
/* maximum size of each gpio name (enough room for "gpioXXX" + null) */
@@ -40,77 +38,111 @@
static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
{
+ struct msm_pinctrl_soc_data *pinctrl;
struct pinctrl_pin_desc *pins;
struct msm_pingroup *groups;
char (*names)[NAME_SIZE];
unsigned int i;
u32 num_gpios;
+ unsigned int avail_gpios; /* The number of GPIOs we support */
+ u8 gpios[MAX_GPIOS]; /* An array of supported GPIOs */
int ret;
/* Query the number of GPIOs from ACPI */
ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
if (ret < 0) {
- dev_warn(&pdev->dev, "missing num-gpios property\n");
+ dev_err(&pdev->dev, "missing 'num-gpios' property\n");
return ret;
}
-
if (!num_gpios || num_gpios > MAX_GPIOS) {
- dev_warn(&pdev->dev, "invalid num-gpios property\n");
+ dev_err(&pdev->dev, "invalid 'num-gpios' property\n");
+ return -ENODEV;
+ }
+
+ /* The number of GPIOs in the approved list */
+ ret = device_property_read_u8_array(&pdev->dev, "gpios", NULL, 0);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "missing 'gpios' property\n");
+ return ret;
+ }
+ /*
+ * The number of available GPIOs should be non-zero, and no
+ * more than the total number of GPIOS.
+ */
+ if (!ret || ret > num_gpios) {
+ dev_err(&pdev->dev, "invalid 'gpios' property\n");
return -ENODEV;
}
+ avail_gpios = ret;
+ ret = device_property_read_u8_array(&pdev->dev, "gpios", gpios,
+ avail_gpios);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "could not read list of GPIOs\n");
+ return ret;
+ }
+
+ pinctrl = devm_kzalloc(&pdev->dev, sizeof(*pinctrl), GFP_KERNEL);
pins = devm_kcalloc(&pdev->dev, num_gpios,
sizeof(struct pinctrl_pin_desc), GFP_KERNEL);
groups = devm_kcalloc(&pdev->dev, num_gpios,
sizeof(struct msm_pingroup), GFP_KERNEL);
- names = devm_kcalloc(&pdev->dev, num_gpios, NAME_SIZE, GFP_KERNEL);
+ names = devm_kcalloc(&pdev->dev, avail_gpios, NAME_SIZE, GFP_KERNEL);
- if (!pins || !groups || !names)
+ if (!pinctrl || !pins || !groups || !names)
return -ENOMEM;
+ /*
+ * Initialize the array. GPIOs not listed in the 'gpios' array
+ * still need a number, but nothing else.
+ */
for (i = 0; i < num_gpios; i++) {
- snprintf(names[i], NAME_SIZE, "gpio%u", i);
-
pins[i].number = i;
- pins[i].name = names[i];
-
- groups[i].npins = 1;
- groups[i].name = names[i];
groups[i].pins = &pins[i].number;
+ }
- groups[i].ctl_reg = 0x10000 * i;
- groups[i].io_reg = 0x04 + 0x10000 * i;
- groups[i].intr_cfg_reg = 0x08 + 0x10000 * i;
- groups[i].intr_status_reg = 0x0c + 0x10000 * i;
- groups[i].intr_target_reg = 0x08 + 0x10000 * i;
-
- groups[i].mux_bit = 2;
- groups[i].pull_bit = 0;
- groups[i].drv_bit = 6;
- groups[i].oe_bit = 9;
- groups[i].in_bit = 0;
- groups[i].out_bit = 1;
- groups[i].intr_enable_bit = 0;
- groups[i].intr_status_bit = 0;
- groups[i].intr_target_bit = 5;
- groups[i].intr_target_kpss_val = 1;
- groups[i].intr_raw_status_bit = 4;
- groups[i].intr_polarity_bit = 1;
- groups[i].intr_detection_bit = 2;
- groups[i].intr_detection_width = 2;
+ /* Populate the entries that are meant to be exposed as GPIOs. */
+ for (i = 0; i < avail_gpios; i++) {
+ unsigned int gpio = gpios[i];
+
+ groups[gpio].npins = 1;
+ snprintf(names[i], NAME_SIZE, "gpio%u", gpio);
+ pins[gpio].name = names[i];
+ groups[gpio].name = names[i];
+
+ groups[gpio].ctl_reg = 0x10000 * gpio;
+ groups[gpio].io_reg = 0x04 + 0x10000 * gpio;
+ groups[gpio].intr_cfg_reg = 0x08 + 0x10000 * gpio;
+ groups[gpio].intr_status_reg = 0x0c + 0x10000 * gpio;
+ groups[gpio].intr_target_reg = 0x08 + 0x10000 * gpio;
+
+ groups[gpio].mux_bit = 2;
+ groups[gpio].pull_bit = 0;
+ groups[gpio].drv_bit = 6;
+ groups[gpio].oe_bit = 9;
+ groups[gpio].in_bit = 0;
+ groups[gpio].out_bit = 1;
+ groups[gpio].intr_enable_bit = 0;
+ groups[gpio].intr_status_bit = 0;
+ groups[gpio].intr_target_bit = 5;
+ groups[gpio].intr_target_kpss_val = 1;
+ groups[gpio].intr_raw_status_bit = 4;
+ groups[gpio].intr_polarity_bit = 1;
+ groups[gpio].intr_detection_bit = 2;
+ groups[gpio].intr_detection_width = 2;
}
- qdf2xxx_pinctrl.pins = pins;
- qdf2xxx_pinctrl.groups = groups;
- qdf2xxx_pinctrl.npins = num_gpios;
- qdf2xxx_pinctrl.ngroups = num_gpios;
- qdf2xxx_pinctrl.ngpios = num_gpios;
+ pinctrl->pins = pins;
+ pinctrl->groups = groups;
+ pinctrl->npins = num_gpios;
+ pinctrl->ngroups = num_gpios;
+ pinctrl->ngpios = num_gpios;
- return msm_pinctrl_probe(pdev, &qdf2xxx_pinctrl);
+ return msm_pinctrl_probe(pdev, pinctrl);
}
static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
- {"QCOM8001"},
+ {"QCOM8002"},
{},
};
MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
2018-03-23 23:45 ` Timur Tabi
@ 2018-04-03 4:07 ` Bjorn Andersson
-1 siblings, 0 replies; 24+ messages in thread
From: Bjorn Andersson @ 2018-04-03 4:07 UTC (permalink / raw)
To: Timur Tabi
Cc: linux-arm-msm, Linus Walleij, Stephen Boyd, linux-arm-kernel, linux-gpio
On Fri 23 Mar 16:45 PDT 2018, Timur Tabi wrote:
> Newer versions of the firmware for the Qualcomm Datacenter Technologies
> QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
> prevent older kernels from accidentally accessing the restricted GPIOs,
> we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
> and introduce a new property "gpios". This property is an array of
> specific GPIOs that are accessible. When an older kernel boots on
> newer (restricted) firmware, it will fail to probe.
>
> To implement the sparse GPIO map, we register all of the GPIOs, but
> fill in the data only for available GPIOs. This ensures that the driver
> cannot accidentally access an unavailable GPIO.
>
> The pinctrl-msm driver also scans the "gpios" property to determine
> which pins are available, and ensure that only those can be registered.
>
> Support for QCOM8001 is removed as there is no longer any firmware that
> implements it.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 114 +++++++++++++++++++++------------
> 1 file changed, 73 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> index bb3ce5c3e18b..1dfbe42dd895 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> @@ -30,9 +30,7 @@
>
> #include "pinctrl-msm.h"
>
> -static struct msm_pinctrl_soc_data qdf2xxx_pinctrl;
> -
> -/* A reasonable limit to the number of GPIOS */
> +/* A maximum of 256 allows us to use a u8 array to hold the GPIO numbers */
> #define MAX_GPIOS 256
>
> /* maximum size of each gpio name (enough room for "gpioXXX" + null) */
> @@ -40,77 +38,111 @@
>
> static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
> {
> + struct msm_pinctrl_soc_data *pinctrl;
> struct pinctrl_pin_desc *pins;
> struct msm_pingroup *groups;
> char (*names)[NAME_SIZE];
> unsigned int i;
> u32 num_gpios;
> + unsigned int avail_gpios; /* The number of GPIOs we support */
> + u8 gpios[MAX_GPIOS]; /* An array of supported GPIOs */
> int ret;
>
> /* Query the number of GPIOs from ACPI */
> ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
> if (ret < 0) {
> - dev_warn(&pdev->dev, "missing num-gpios property\n");
> + dev_err(&pdev->dev, "missing 'num-gpios' property\n");
> return ret;
> }
> -
> if (!num_gpios || num_gpios > MAX_GPIOS) {
> - dev_warn(&pdev->dev, "invalid num-gpios property\n");
> + dev_err(&pdev->dev, "invalid 'num-gpios' property\n");
> + return -ENODEV;
> + }
> +
> + /* The number of GPIOs in the approved list */
> + ret = device_property_read_u8_array(&pdev->dev, "gpios", NULL, 0);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "missing 'gpios' property\n");
> + return ret;
> + }
> + /*
> + * The number of available GPIOs should be non-zero, and no
> + * more than the total number of GPIOS.
> + */
> + if (!ret || ret > num_gpios) {
> + dev_err(&pdev->dev, "invalid 'gpios' property\n");
> return -ENODEV;
> }
> + avail_gpios = ret;
>
> + ret = device_property_read_u8_array(&pdev->dev, "gpios", gpios,
> + avail_gpios);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "could not read list of GPIOs\n");
> + return ret;
> + }
> +
> + pinctrl = devm_kzalloc(&pdev->dev, sizeof(*pinctrl), GFP_KERNEL);
> pins = devm_kcalloc(&pdev->dev, num_gpios,
> sizeof(struct pinctrl_pin_desc), GFP_KERNEL);
> groups = devm_kcalloc(&pdev->dev, num_gpios,
> sizeof(struct msm_pingroup), GFP_KERNEL);
> - names = devm_kcalloc(&pdev->dev, num_gpios, NAME_SIZE, GFP_KERNEL);
> + names = devm_kcalloc(&pdev->dev, avail_gpios, NAME_SIZE, GFP_KERNEL);
>
> - if (!pins || !groups || !names)
> + if (!pinctrl || !pins || !groups || !names)
> return -ENOMEM;
>
> + /*
> + * Initialize the array. GPIOs not listed in the 'gpios' array
> + * still need a number, but nothing else.
> + */
> for (i = 0; i < num_gpios; i++) {
> - snprintf(names[i], NAME_SIZE, "gpio%u", i);
> -
> pins[i].number = i;
> - pins[i].name = names[i];
> -
> - groups[i].npins = 1;
> - groups[i].name = names[i];
> groups[i].pins = &pins[i].number;
> + }
>
> - groups[i].ctl_reg = 0x10000 * i;
> - groups[i].io_reg = 0x04 + 0x10000 * i;
> - groups[i].intr_cfg_reg = 0x08 + 0x10000 * i;
> - groups[i].intr_status_reg = 0x0c + 0x10000 * i;
> - groups[i].intr_target_reg = 0x08 + 0x10000 * i;
> -
> - groups[i].mux_bit = 2;
> - groups[i].pull_bit = 0;
> - groups[i].drv_bit = 6;
> - groups[i].oe_bit = 9;
> - groups[i].in_bit = 0;
> - groups[i].out_bit = 1;
> - groups[i].intr_enable_bit = 0;
> - groups[i].intr_status_bit = 0;
> - groups[i].intr_target_bit = 5;
> - groups[i].intr_target_kpss_val = 1;
> - groups[i].intr_raw_status_bit = 4;
> - groups[i].intr_polarity_bit = 1;
> - groups[i].intr_detection_bit = 2;
> - groups[i].intr_detection_width = 2;
> + /* Populate the entries that are meant to be exposed as GPIOs. */
> + for (i = 0; i < avail_gpios; i++) {
> + unsigned int gpio = gpios[i];
> +
> + groups[gpio].npins = 1;
> + snprintf(names[i], NAME_SIZE, "gpio%u", gpio);
> + pins[gpio].name = names[i];
> + groups[gpio].name = names[i];
> +
> + groups[gpio].ctl_reg = 0x10000 * gpio;
> + groups[gpio].io_reg = 0x04 + 0x10000 * gpio;
> + groups[gpio].intr_cfg_reg = 0x08 + 0x10000 * gpio;
> + groups[gpio].intr_status_reg = 0x0c + 0x10000 * gpio;
> + groups[gpio].intr_target_reg = 0x08 + 0x10000 * gpio;
> +
> + groups[gpio].mux_bit = 2;
> + groups[gpio].pull_bit = 0;
> + groups[gpio].drv_bit = 6;
> + groups[gpio].oe_bit = 9;
> + groups[gpio].in_bit = 0;
> + groups[gpio].out_bit = 1;
> + groups[gpio].intr_enable_bit = 0;
> + groups[gpio].intr_status_bit = 0;
> + groups[gpio].intr_target_bit = 5;
> + groups[gpio].intr_target_kpss_val = 1;
> + groups[gpio].intr_raw_status_bit = 4;
> + groups[gpio].intr_polarity_bit = 1;
> + groups[gpio].intr_detection_bit = 2;
> + groups[gpio].intr_detection_width = 2;
> }
>
> - qdf2xxx_pinctrl.pins = pins;
> - qdf2xxx_pinctrl.groups = groups;
> - qdf2xxx_pinctrl.npins = num_gpios;
> - qdf2xxx_pinctrl.ngroups = num_gpios;
> - qdf2xxx_pinctrl.ngpios = num_gpios;
> + pinctrl->pins = pins;
> + pinctrl->groups = groups;
> + pinctrl->npins = num_gpios;
> + pinctrl->ngroups = num_gpios;
> + pinctrl->ngpios = num_gpios;
>
> - return msm_pinctrl_probe(pdev, &qdf2xxx_pinctrl);
> + return msm_pinctrl_probe(pdev, pinctrl);
> }
>
> static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
> - {"QCOM8001"},
> + {"QCOM8002"},
I presume you're okay with not being able to run mainline on your old
firmware?
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
@ 2018-04-03 4:07 ` Bjorn Andersson
0 siblings, 0 replies; 24+ messages in thread
From: Bjorn Andersson @ 2018-04-03 4:07 UTC (permalink / raw)
To: linux-arm-kernel
On Fri 23 Mar 16:45 PDT 2018, Timur Tabi wrote:
> Newer versions of the firmware for the Qualcomm Datacenter Technologies
> QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
> prevent older kernels from accidentally accessing the restricted GPIOs,
> we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
> and introduce a new property "gpios". This property is an array of
> specific GPIOs that are accessible. When an older kernel boots on
> newer (restricted) firmware, it will fail to probe.
>
> To implement the sparse GPIO map, we register all of the GPIOs, but
> fill in the data only for available GPIOs. This ensures that the driver
> cannot accidentally access an unavailable GPIO.
>
> The pinctrl-msm driver also scans the "gpios" property to determine
> which pins are available, and ensure that only those can be registered.
>
> Support for QCOM8001 is removed as there is no longer any firmware that
> implements it.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 114 +++++++++++++++++++++------------
> 1 file changed, 73 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> index bb3ce5c3e18b..1dfbe42dd895 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> @@ -30,9 +30,7 @@
>
> #include "pinctrl-msm.h"
>
> -static struct msm_pinctrl_soc_data qdf2xxx_pinctrl;
> -
> -/* A reasonable limit to the number of GPIOS */
> +/* A maximum of 256 allows us to use a u8 array to hold the GPIO numbers */
> #define MAX_GPIOS 256
>
> /* maximum size of each gpio name (enough room for "gpioXXX" + null) */
> @@ -40,77 +38,111 @@
>
> static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
> {
> + struct msm_pinctrl_soc_data *pinctrl;
> struct pinctrl_pin_desc *pins;
> struct msm_pingroup *groups;
> char (*names)[NAME_SIZE];
> unsigned int i;
> u32 num_gpios;
> + unsigned int avail_gpios; /* The number of GPIOs we support */
> + u8 gpios[MAX_GPIOS]; /* An array of supported GPIOs */
> int ret;
>
> /* Query the number of GPIOs from ACPI */
> ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
> if (ret < 0) {
> - dev_warn(&pdev->dev, "missing num-gpios property\n");
> + dev_err(&pdev->dev, "missing 'num-gpios' property\n");
> return ret;
> }
> -
> if (!num_gpios || num_gpios > MAX_GPIOS) {
> - dev_warn(&pdev->dev, "invalid num-gpios property\n");
> + dev_err(&pdev->dev, "invalid 'num-gpios' property\n");
> + return -ENODEV;
> + }
> +
> + /* The number of GPIOs in the approved list */
> + ret = device_property_read_u8_array(&pdev->dev, "gpios", NULL, 0);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "missing 'gpios' property\n");
> + return ret;
> + }
> + /*
> + * The number of available GPIOs should be non-zero, and no
> + * more than the total number of GPIOS.
> + */
> + if (!ret || ret > num_gpios) {
> + dev_err(&pdev->dev, "invalid 'gpios' property\n");
> return -ENODEV;
> }
> + avail_gpios = ret;
>
> + ret = device_property_read_u8_array(&pdev->dev, "gpios", gpios,
> + avail_gpios);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "could not read list of GPIOs\n");
> + return ret;
> + }
> +
> + pinctrl = devm_kzalloc(&pdev->dev, sizeof(*pinctrl), GFP_KERNEL);
> pins = devm_kcalloc(&pdev->dev, num_gpios,
> sizeof(struct pinctrl_pin_desc), GFP_KERNEL);
> groups = devm_kcalloc(&pdev->dev, num_gpios,
> sizeof(struct msm_pingroup), GFP_KERNEL);
> - names = devm_kcalloc(&pdev->dev, num_gpios, NAME_SIZE, GFP_KERNEL);
> + names = devm_kcalloc(&pdev->dev, avail_gpios, NAME_SIZE, GFP_KERNEL);
>
> - if (!pins || !groups || !names)
> + if (!pinctrl || !pins || !groups || !names)
> return -ENOMEM;
>
> + /*
> + * Initialize the array. GPIOs not listed in the 'gpios' array
> + * still need a number, but nothing else.
> + */
> for (i = 0; i < num_gpios; i++) {
> - snprintf(names[i], NAME_SIZE, "gpio%u", i);
> -
> pins[i].number = i;
> - pins[i].name = names[i];
> -
> - groups[i].npins = 1;
> - groups[i].name = names[i];
> groups[i].pins = &pins[i].number;
> + }
>
> - groups[i].ctl_reg = 0x10000 * i;
> - groups[i].io_reg = 0x04 + 0x10000 * i;
> - groups[i].intr_cfg_reg = 0x08 + 0x10000 * i;
> - groups[i].intr_status_reg = 0x0c + 0x10000 * i;
> - groups[i].intr_target_reg = 0x08 + 0x10000 * i;
> -
> - groups[i].mux_bit = 2;
> - groups[i].pull_bit = 0;
> - groups[i].drv_bit = 6;
> - groups[i].oe_bit = 9;
> - groups[i].in_bit = 0;
> - groups[i].out_bit = 1;
> - groups[i].intr_enable_bit = 0;
> - groups[i].intr_status_bit = 0;
> - groups[i].intr_target_bit = 5;
> - groups[i].intr_target_kpss_val = 1;
> - groups[i].intr_raw_status_bit = 4;
> - groups[i].intr_polarity_bit = 1;
> - groups[i].intr_detection_bit = 2;
> - groups[i].intr_detection_width = 2;
> + /* Populate the entries that are meant to be exposed as GPIOs. */
> + for (i = 0; i < avail_gpios; i++) {
> + unsigned int gpio = gpios[i];
> +
> + groups[gpio].npins = 1;
> + snprintf(names[i], NAME_SIZE, "gpio%u", gpio);
> + pins[gpio].name = names[i];
> + groups[gpio].name = names[i];
> +
> + groups[gpio].ctl_reg = 0x10000 * gpio;
> + groups[gpio].io_reg = 0x04 + 0x10000 * gpio;
> + groups[gpio].intr_cfg_reg = 0x08 + 0x10000 * gpio;
> + groups[gpio].intr_status_reg = 0x0c + 0x10000 * gpio;
> + groups[gpio].intr_target_reg = 0x08 + 0x10000 * gpio;
> +
> + groups[gpio].mux_bit = 2;
> + groups[gpio].pull_bit = 0;
> + groups[gpio].drv_bit = 6;
> + groups[gpio].oe_bit = 9;
> + groups[gpio].in_bit = 0;
> + groups[gpio].out_bit = 1;
> + groups[gpio].intr_enable_bit = 0;
> + groups[gpio].intr_status_bit = 0;
> + groups[gpio].intr_target_bit = 5;
> + groups[gpio].intr_target_kpss_val = 1;
> + groups[gpio].intr_raw_status_bit = 4;
> + groups[gpio].intr_polarity_bit = 1;
> + groups[gpio].intr_detection_bit = 2;
> + groups[gpio].intr_detection_width = 2;
> }
>
> - qdf2xxx_pinctrl.pins = pins;
> - qdf2xxx_pinctrl.groups = groups;
> - qdf2xxx_pinctrl.npins = num_gpios;
> - qdf2xxx_pinctrl.ngroups = num_gpios;
> - qdf2xxx_pinctrl.ngpios = num_gpios;
> + pinctrl->pins = pins;
> + pinctrl->groups = groups;
> + pinctrl->npins = num_gpios;
> + pinctrl->ngroups = num_gpios;
> + pinctrl->ngpios = num_gpios;
>
> - return msm_pinctrl_probe(pdev, &qdf2xxx_pinctrl);
> + return msm_pinctrl_probe(pdev, pinctrl);
> }
>
> static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
> - {"QCOM8001"},
> + {"QCOM8002"},
I presume you're okay with not being able to run mainline on your old
firmware?
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
2018-04-03 4:07 ` Bjorn Andersson
@ 2018-04-03 12:03 ` Timur Tabi
-1 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2018-04-03 12:03 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Linus Walleij, Stephen Boyd, linux-arm-kernel, linux-gpio
On 4/2/18 11:07 PM, Bjorn Andersson wrote:
> I presume you're okay with not being able to run mainline on your old
> firmware?
Yes, that firmware is very old now, and it doesn't even support our
current production silicon.
>
> Acked-by: Bjorn Andersson<bjorn.andersson@linaro.org>
Thank you.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
@ 2018-04-03 12:03 ` Timur Tabi
0 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2018-04-03 12:03 UTC (permalink / raw)
To: linux-arm-kernel
On 4/2/18 11:07 PM, Bjorn Andersson wrote:
> I presume you're okay with not being able to run mainline on your old
> firmware?
Yes, that firmware is very old now, and it doesn't even support our
current production silicon.
>
> Acked-by: Bjorn Andersson<bjorn.andersson@linaro.org>
Thank you.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
2018-03-23 23:45 ` Timur Tabi
@ 2018-04-07 12:33 ` Stephen Boyd
-1 siblings, 0 replies; 24+ messages in thread
From: Stephen Boyd @ 2018-04-07 12:33 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Stephen Boyd, linux-arm-kernel,
linux-arm-msm, linux-gpio
Cc: timur
Quoting Timur Tabi (2018-03-23 16:45:00)
> Newer versions of the firmware for the Qualcomm Datacenter Technologies
> QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
> prevent older kernels from accidentally accessing the restricted GPIOs,
> we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
> and introduce a new property "gpios". This property is an array of
> specific GPIOs that are accessible. When an older kernel boots on
> newer (restricted) firmware, it will fail to probe.
>
> To implement the sparse GPIO map, we register all of the GPIOs, but
> fill in the data only for available GPIOs. This ensures that the driver
> cannot accidentally access an unavailable GPIO.
>
> The pinctrl-msm driver also scans the "gpios" property to determine
> which pins are available, and ensure that only those can be registered.
>
> Support for QCOM8001 is removed as there is no longer any firmware that
> implements it.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
@ 2018-04-07 12:33 ` Stephen Boyd
0 siblings, 0 replies; 24+ messages in thread
From: Stephen Boyd @ 2018-04-07 12:33 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Timur Tabi (2018-03-23 16:45:00)
> Newer versions of the firmware for the Qualcomm Datacenter Technologies
> QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
> prevent older kernels from accidentally accessing the restricted GPIOs,
> we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
> and introduce a new property "gpios". This property is an array of
> specific GPIOs that are accessible. When an older kernel boots on
> newer (restricted) firmware, it will fail to probe.
>
> To implement the sparse GPIO map, we register all of the GPIOs, but
> fill in the data only for available GPIOs. This ensures that the driver
> cannot accidentally access an unavailable GPIO.
>
> The pinctrl-msm driver also scans the "gpios" property to determine
> which pins are available, and ensure that only those can be registered.
>
> Support for QCOM8001 is removed as there is no longer any firmware that
> implements it.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
2018-03-23 23:44 ` Timur Tabi
@ 2018-03-27 13:33 ` Linus Walleij
-1 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2018-03-27 13:33 UTC (permalink / raw)
To: Timur Tabi, Stephen Boyd, Stephen Boyd
Cc: linux-arm-msm, open list:GPIO SUBSYSTEM, Linux ARM, Bjorn Andersson
On Sat, Mar 24, 2018 at 12:44 AM, Timur Tabi <timur@codeaurora.org> wrote:
> Two data structures are declared as static globals but are intended to
> be per-TLMM. Move them into the msm_pinctrl structure and initialize
> them at runtime.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Waiting for a review from Stephen or Bjorn on these two
patches.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
@ 2018-03-27 13:33 ` Linus Walleij
0 siblings, 0 replies; 24+ messages in thread
From: Linus Walleij @ 2018-03-27 13:33 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Mar 24, 2018 at 12:44 AM, Timur Tabi <timur@codeaurora.org> wrote:
> Two data structures are declared as static globals but are intended to
> be per-TLMM. Move them into the msm_pinctrl structure and initialize
> them at runtime.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Waiting for a review from Stephen or Bjorn on these two
patches.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
2018-03-27 13:33 ` Linus Walleij
@ 2018-04-02 20:52 ` Timur Tabi
-1 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2018-04-02 20:52 UTC (permalink / raw)
To: Stephen Boyd, Stephen Boyd
Cc: linux-arm-msm, Linus Walleij, open list:GPIO SUBSYSTEM,
Linux ARM, Bjorn Andersson
On 03/27/2018 08:33 AM, Linus Walleij wrote:
>> Two data structures are declared as static globals but are intended to
>> be per-TLMM. Move them into the msm_pinctrl structure and initialize
>> them at runtime.
>>
>> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> Waiting for a review from Stephen or Bjorn on these two
> patches.
Stephen? Bjorn? I really hope I don't miss the 4.17 release. I've been
working on these patches for months.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
@ 2018-04-02 20:52 ` Timur Tabi
0 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2018-04-02 20:52 UTC (permalink / raw)
To: linux-arm-kernel
On 03/27/2018 08:33 AM, Linus Walleij wrote:
>> Two data structures are declared as static globals but are intended to
>> be per-TLMM. Move them into the msm_pinctrl structure and initialize
>> them at runtime.
>>
>> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> Waiting for a review from Stephen or Bjorn on these two
> patches.
Stephen? Bjorn? I really hope I don't miss the 4.17 release. I've been
working on these patches for months.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
2018-03-23 23:44 ` Timur Tabi
@ 2018-04-03 4:04 ` Bjorn Andersson
-1 siblings, 0 replies; 24+ messages in thread
From: Bjorn Andersson @ 2018-04-03 4:04 UTC (permalink / raw)
To: Timur Tabi
Cc: linux-arm-msm, Linus Walleij, Stephen Boyd, linux-arm-kernel, linux-gpio
On Fri 23 Mar 16:44 PDT 2018, Timur Tabi wrote:
> Two data structures are declared as static globals but are intended to
> be per-TLMM. Move them into the msm_pinctrl structure and initialize
> them at runtime.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 44 ++++++++++++++++++--------------------
> 1 file changed, 21 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index ad80a17c9990..fa4e94fedb8c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -58,7 +58,10 @@ struct msm_pinctrl {
> struct device *dev;
> struct pinctrl_dev *pctrl;
> struct gpio_chip chip;
> + struct pinctrl_desc desc;
> struct notifier_block restart_nb;
> +
> + struct irq_chip irq_chip;
> int irq;
>
> raw_spinlock_t lock;
> @@ -390,13 +393,6 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
> .pin_config_group_set = msm_config_group_set,
> };
>
> -static struct pinctrl_desc msm_pinctrl_desc = {
> - .pctlops = &msm_pinctrl_ops,
> - .pmxops = &msm_pinmux_ops,
> - .confops = &msm_pinconf_ops,
> - .owner = THIS_MODULE,
> -};
> -
> static int msm_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> {
> const struct msm_pingroup *g;
> @@ -776,15 +772,6 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on)
> return 0;
> }
>
> -static struct irq_chip msm_gpio_irq_chip = {
> - .name = "msmgpio",
> - .irq_mask = msm_gpio_irq_mask,
> - .irq_unmask = msm_gpio_irq_unmask,
> - .irq_ack = msm_gpio_irq_ack,
> - .irq_set_type = msm_gpio_irq_set_type,
> - .irq_set_wake = msm_gpio_irq_set_wake,
> -};
> -
> static void msm_gpio_irq_handler(struct irq_desc *desc)
> {
> struct gpio_chip *gc = irq_desc_get_handler_data(desc);
> @@ -877,6 +864,13 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> chip->of_node = pctrl->dev->of_node;
> chip->need_valid_mask = msm_gpio_needs_valid_mask(pctrl);
>
> + pctrl->irq_chip.name = "msmgpio";
> + pctrl->irq_chip.irq_mask = msm_gpio_irq_mask;
> + pctrl->irq_chip.irq_unmask = msm_gpio_irq_unmask;
> + pctrl->irq_chip.irq_ack = msm_gpio_irq_ack;
> + pctrl->irq_chip.irq_set_type = msm_gpio_irq_set_type;
> + pctrl->irq_chip.irq_set_wake = msm_gpio_irq_set_wake;
> +
> ret = gpiochip_add_data(&pctrl->chip, pctrl);
> if (ret) {
> dev_err(pctrl->dev, "Failed register gpiochip\n");
> @@ -898,7 +892,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> }
>
> ret = gpiochip_irqchip_add(chip,
> - &msm_gpio_irq_chip,
> + &pctrl->irq_chip,
> 0,
> handle_edge_irq,
> IRQ_TYPE_NONE);
> @@ -908,7 +902,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> return -ENOSYS;
> }
>
> - gpiochip_set_chained_irqchip(chip, &msm_gpio_irq_chip, pctrl->irq,
> + gpiochip_set_chained_irqchip(chip, &pctrl->irq_chip, pctrl->irq,
> msm_gpio_irq_handler);
>
> return 0;
> @@ -979,11 +973,15 @@ int msm_pinctrl_probe(struct platform_device *pdev,
> return pctrl->irq;
> }
>
> - msm_pinctrl_desc.name = dev_name(&pdev->dev);
> - msm_pinctrl_desc.pins = pctrl->soc->pins;
> - msm_pinctrl_desc.npins = pctrl->soc->npins;
> - pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &msm_pinctrl_desc,
> - pctrl);
> + pctrl->desc.owner = THIS_MODULE;
> + pctrl->desc.pctlops = &msm_pinctrl_ops;
> + pctrl->desc.pmxops = &msm_pinmux_ops;
> + pctrl->desc.confops = &msm_pinconf_ops;
> + pctrl->desc.name = dev_name(&pdev->dev);
> + pctrl->desc.pins = pctrl->soc->pins;
> + pctrl->desc.npins = pctrl->soc->npins;
> +
> + pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &pctrl->desc, pctrl);
> if (IS_ERR(pctrl->pctrl)) {
> dev_err(&pdev->dev, "Couldn't register pinctrl driver\n");
> return PTR_ERR(pctrl->pctrl);
> --
> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
> Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
@ 2018-04-03 4:04 ` Bjorn Andersson
0 siblings, 0 replies; 24+ messages in thread
From: Bjorn Andersson @ 2018-04-03 4:04 UTC (permalink / raw)
To: linux-arm-kernel
On Fri 23 Mar 16:44 PDT 2018, Timur Tabi wrote:
> Two data structures are declared as static globals but are intended to
> be per-TLMM. Move them into the msm_pinctrl structure and initialize
> them at runtime.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 44 ++++++++++++++++++--------------------
> 1 file changed, 21 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index ad80a17c9990..fa4e94fedb8c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -58,7 +58,10 @@ struct msm_pinctrl {
> struct device *dev;
> struct pinctrl_dev *pctrl;
> struct gpio_chip chip;
> + struct pinctrl_desc desc;
> struct notifier_block restart_nb;
> +
> + struct irq_chip irq_chip;
> int irq;
>
> raw_spinlock_t lock;
> @@ -390,13 +393,6 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
> .pin_config_group_set = msm_config_group_set,
> };
>
> -static struct pinctrl_desc msm_pinctrl_desc = {
> - .pctlops = &msm_pinctrl_ops,
> - .pmxops = &msm_pinmux_ops,
> - .confops = &msm_pinconf_ops,
> - .owner = THIS_MODULE,
> -};
> -
> static int msm_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> {
> const struct msm_pingroup *g;
> @@ -776,15 +772,6 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on)
> return 0;
> }
>
> -static struct irq_chip msm_gpio_irq_chip = {
> - .name = "msmgpio",
> - .irq_mask = msm_gpio_irq_mask,
> - .irq_unmask = msm_gpio_irq_unmask,
> - .irq_ack = msm_gpio_irq_ack,
> - .irq_set_type = msm_gpio_irq_set_type,
> - .irq_set_wake = msm_gpio_irq_set_wake,
> -};
> -
> static void msm_gpio_irq_handler(struct irq_desc *desc)
> {
> struct gpio_chip *gc = irq_desc_get_handler_data(desc);
> @@ -877,6 +864,13 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> chip->of_node = pctrl->dev->of_node;
> chip->need_valid_mask = msm_gpio_needs_valid_mask(pctrl);
>
> + pctrl->irq_chip.name = "msmgpio";
> + pctrl->irq_chip.irq_mask = msm_gpio_irq_mask;
> + pctrl->irq_chip.irq_unmask = msm_gpio_irq_unmask;
> + pctrl->irq_chip.irq_ack = msm_gpio_irq_ack;
> + pctrl->irq_chip.irq_set_type = msm_gpio_irq_set_type;
> + pctrl->irq_chip.irq_set_wake = msm_gpio_irq_set_wake;
> +
> ret = gpiochip_add_data(&pctrl->chip, pctrl);
> if (ret) {
> dev_err(pctrl->dev, "Failed register gpiochip\n");
> @@ -898,7 +892,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> }
>
> ret = gpiochip_irqchip_add(chip,
> - &msm_gpio_irq_chip,
> + &pctrl->irq_chip,
> 0,
> handle_edge_irq,
> IRQ_TYPE_NONE);
> @@ -908,7 +902,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
> return -ENOSYS;
> }
>
> - gpiochip_set_chained_irqchip(chip, &msm_gpio_irq_chip, pctrl->irq,
> + gpiochip_set_chained_irqchip(chip, &pctrl->irq_chip, pctrl->irq,
> msm_gpio_irq_handler);
>
> return 0;
> @@ -979,11 +973,15 @@ int msm_pinctrl_probe(struct platform_device *pdev,
> return pctrl->irq;
> }
>
> - msm_pinctrl_desc.name = dev_name(&pdev->dev);
> - msm_pinctrl_desc.pins = pctrl->soc->pins;
> - msm_pinctrl_desc.npins = pctrl->soc->npins;
> - pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &msm_pinctrl_desc,
> - pctrl);
> + pctrl->desc.owner = THIS_MODULE;
> + pctrl->desc.pctlops = &msm_pinctrl_ops;
> + pctrl->desc.pmxops = &msm_pinmux_ops;
> + pctrl->desc.confops = &msm_pinconf_ops;
> + pctrl->desc.name = dev_name(&pdev->dev);
> + pctrl->desc.pins = pctrl->soc->pins;
> + pctrl->desc.npins = pctrl->soc->npins;
> +
> + pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &pctrl->desc, pctrl);
> if (IS_ERR(pctrl->pctrl)) {
> dev_err(&pdev->dev, "Couldn't register pinctrl driver\n");
> return PTR_ERR(pctrl->pctrl);
> --
> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
> Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
2018-03-23 23:44 ` Timur Tabi
@ 2018-04-07 12:30 ` Stephen Boyd
-1 siblings, 0 replies; 24+ messages in thread
From: Stephen Boyd @ 2018-04-07 12:30 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Stephen Boyd, linux-arm-kernel,
linux-arm-msm, linux-gpio
Cc: timur
Quoting Timur Tabi (2018-03-23 16:44:59)
> Two data structures are declared as static globals but are intended to
> be per-TLMM. Move them into the msm_pinctrl structure and initialize
> them at runtime.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] pinctrl: qcom: remove static globals to allow multiple TLMMs
@ 2018-04-07 12:30 ` Stephen Boyd
0 siblings, 0 replies; 24+ messages in thread
From: Stephen Boyd @ 2018-04-07 12:30 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Timur Tabi (2018-03-23 16:44:59)
> Two data structures are declared as static globals but are intended to
> be per-TLMM. Move them into the msm_pinctrl structure and initialize
> them at runtime.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
2017-07-13 21:52 [PATCH 0/2] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
@ 2017-07-13 21:52 ` Timur Tabi
0 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2017-07-13 21:52 UTC (permalink / raw)
To: andy.gross, david.brown, Linus Walleij, Bjorn Andersson,
linux-gpio, linux-arm-msm, linux-arm-kernel
Cc: timur
Newer versions of the firmware for the Qualcomm Datacenter Technologies
QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
prevent older kernels from accidentally accessing the restricted GPIOs,
we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
and introduce a new property "gpios". This property is an array of
specific GPIOs that are accessible. When an older kernel boots on
newer (restricted) firmware, it will fail to probe.
To implement the sparse GPIO map, we register all of the GPIOs, but set
the pin count for the unavailable GPIOs to zero. The pinctrl-msm
driver will block those unavailable GPIOs from being accessed.
To allow newer kernels to support older firmware, the driver retains
support for QCOM8001.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 157 +++++++++++++++++++++++----------
1 file changed, 111 insertions(+), 46 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
index bb3ce5c..266f2e6 100644
--- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
+++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
@@ -38,83 +38,148 @@
/* maximum size of each gpio name (enough room for "gpioXXX" + null) */
#define NAME_SIZE 8
+enum {
+ QDF2XXX_V1,
+ QDF2XXX_V2,
+};
+
+static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
+ {"QCOM8001", QDF2XXX_V1},
+ {"QCOM8002", QDF2XXX_V2},
+ {},
+};
+MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
+
static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
{
+ const struct acpi_device_id *id =
+ acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
+ struct device *dev = &pdev->dev;
struct pinctrl_pin_desc *pins;
struct msm_pingroup *groups;
char (*names)[NAME_SIZE];
unsigned int i;
- u32 num_gpios;
+ unsigned int num_gpios; /* The number of GPIOs we support */
+ u32 max_gpios; /* The highest number GPIO that exists */
+ u16 *gpios; /* An array of supported GPIOs */
int ret;
- /* Query the number of GPIOs from ACPI */
- ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
+ /* The total number of GPIOs that exist */
+ ret = device_property_read_u32(dev, "num-gpios", &max_gpios);
if (ret < 0) {
- dev_warn(&pdev->dev, "missing num-gpios property\n");
+ dev_err(dev, "missing or invalid 'num-gpios' property\n");
return ret;
}
+ if (!max_gpios || max_gpios > MAX_GPIOS) {
+ dev_err(dev, "invalid 'num-gpios' property\n");
+ return -EINVAL;
+ }
- if (!num_gpios || num_gpios > MAX_GPIOS) {
- dev_warn(&pdev->dev, "invalid num-gpios property\n");
- return -ENODEV;
+ /*
+ * The QCOM8001 HID contains only the number of GPIOs, and assumes
+ * that all of them are available. num_gpios is the same as max_gpios.
+ *
+ * The QCOM8002 HID introduces the 'gpios' DSD, which lists
+ * specific GPIOs that the driver is allowed to access.
+ *
+ * The make the common code simpler, in both cases we create an
+ * array of GPIOs that are accessible. So for QCOM8001, that would
+ * be all of the GPIOs.
+ */
+ if (id->driver_data == QDF2XXX_V1) {
+ num_gpios = max_gpios;
+
+ gpios = devm_kcalloc(dev, num_gpios, sizeof(u16), GFP_KERNEL);
+ if (!gpios)
+ return -ENOMEM;
+
+ for (i = 0; i < num_gpios; i++)
+ gpios[i] = i;
+ } else {
+ /* The number of GPIOs in the approved list */
+ ret = device_property_read_u16_array(dev, "gpios", NULL, 0);
+ if (ret < 0) {
+ dev_err(dev, "missing/invalid 'gpios' property\n");
+ return ret;
+ }
+ if (ret == 0) {
+ dev_warn(dev, "no GPIOs defined\n");
+ return -ENODEV;
+ }
+ num_gpios = ret;
+
+ gpios = devm_kcalloc(dev, num_gpios, sizeof(u16), GFP_KERNEL);
+ if (!gpios)
+ return -ENOMEM;
+
+ ret = device_property_read_u16_array(dev, "gpios", gpios,
+ num_gpios);
+ if (ret < 0) {
+ dev_err(dev, "could not read list of GPIOs\n");
+ return ret;
+ }
}
- pins = devm_kcalloc(&pdev->dev, num_gpios,
+ pins = devm_kcalloc(dev, max_gpios,
sizeof(struct pinctrl_pin_desc), GFP_KERNEL);
- groups = devm_kcalloc(&pdev->dev, num_gpios,
+ groups = devm_kcalloc(dev, max_gpios,
sizeof(struct msm_pingroup), GFP_KERNEL);
- names = devm_kcalloc(&pdev->dev, num_gpios, NAME_SIZE, GFP_KERNEL);
+ names = devm_kcalloc(dev, num_gpios, NAME_SIZE, GFP_KERNEL);
if (!pins || !groups || !names)
return -ENOMEM;
- for (i = 0; i < num_gpios; i++) {
- snprintf(names[i], NAME_SIZE, "gpio%u", i);
-
+ /*
+ * Initialize the array. GPIOs not listed in the 'gpios' array
+ * still need a number and a name, but nothing else.
+ */
+ for (i = 0; i < max_gpios; i++) {
pins[i].number = i;
- pins[i].name = names[i];
-
- groups[i].npins = 1;
- groups[i].name = names[i];
groups[i].pins = &pins[i].number;
+ }
- groups[i].ctl_reg = 0x10000 * i;
- groups[i].io_reg = 0x04 + 0x10000 * i;
- groups[i].intr_cfg_reg = 0x08 + 0x10000 * i;
- groups[i].intr_status_reg = 0x0c + 0x10000 * i;
- groups[i].intr_target_reg = 0x08 + 0x10000 * i;
-
- groups[i].mux_bit = 2;
- groups[i].pull_bit = 0;
- groups[i].drv_bit = 6;
- groups[i].oe_bit = 9;
- groups[i].in_bit = 0;
- groups[i].out_bit = 1;
- groups[i].intr_enable_bit = 0;
- groups[i].intr_status_bit = 0;
- groups[i].intr_target_bit = 5;
- groups[i].intr_target_kpss_val = 1;
- groups[i].intr_raw_status_bit = 4;
- groups[i].intr_polarity_bit = 1;
- groups[i].intr_detection_bit = 2;
- groups[i].intr_detection_width = 2;
+ /* Populate the entries that are meant to be exposes as GPIOs. */
+ for (i = 0; i < num_gpios; i++) {
+ unsigned int gpio = gpios[i];
+
+ groups[gpio].npins = 1;
+ snprintf(names[i], NAME_SIZE, "gpio%u", gpio);
+ pins[gpio].name = names[i];
+ groups[gpio].name = names[i];
+
+ groups[gpio].ctl_reg = 0x10000 * gpio;
+ groups[gpio].io_reg = 0x04 + 0x10000 * gpio;
+ groups[gpio].intr_cfg_reg = 0x08 + 0x10000 * gpio;
+ groups[gpio].intr_status_reg = 0x0c + 0x10000 * gpio;
+ groups[gpio].intr_target_reg = 0x08 + 0x10000 * gpio;
+
+ groups[gpio].mux_bit = 2;
+ groups[gpio].pull_bit = 0;
+ groups[gpio].drv_bit = 6;
+ groups[gpio].oe_bit = 9;
+ groups[gpio].in_bit = 0;
+ groups[gpio].out_bit = 1;
+ groups[gpio].intr_enable_bit = 0;
+ groups[gpio].intr_status_bit = 0;
+ groups[gpio].intr_target_bit = 5;
+ groups[gpio].intr_target_kpss_val = 1;
+ groups[gpio].intr_raw_status_bit = 4;
+ groups[gpio].intr_polarity_bit = 1;
+ groups[gpio].intr_detection_bit = 2;
+ groups[gpio].intr_detection_width = 2;
}
+ devm_kfree(dev, gpios);
+
qdf2xxx_pinctrl.pins = pins;
qdf2xxx_pinctrl.groups = groups;
- qdf2xxx_pinctrl.npins = num_gpios;
- qdf2xxx_pinctrl.ngroups = num_gpios;
- qdf2xxx_pinctrl.ngpios = num_gpios;
+ qdf2xxx_pinctrl.npins = max_gpios;
+ qdf2xxx_pinctrl.ngroups = max_gpios;
+ qdf2xxx_pinctrl.ngpios = max_gpios;
return msm_pinctrl_probe(pdev, &qdf2xxx_pinctrl);
}
-static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
- {"QCOM8001"},
- {},
-};
-MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
-
static struct platform_driver qdf2xxx_pinctrl_driver = {
.driver = {
.name = "qdf2xxx-pinctrl",
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
@ 2017-07-13 21:52 ` Timur Tabi
0 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2017-07-13 21:52 UTC (permalink / raw)
To: linux-arm-kernel
Newer versions of the firmware for the Qualcomm Datacenter Technologies
QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
prevent older kernels from accidentally accessing the restricted GPIOs,
we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
and introduce a new property "gpios". This property is an array of
specific GPIOs that are accessible. When an older kernel boots on
newer (restricted) firmware, it will fail to probe.
To implement the sparse GPIO map, we register all of the GPIOs, but set
the pin count for the unavailable GPIOs to zero. The pinctrl-msm
driver will block those unavailable GPIOs from being accessed.
To allow newer kernels to support older firmware, the driver retains
support for QCOM8001.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 157 +++++++++++++++++++++++----------
1 file changed, 111 insertions(+), 46 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
index bb3ce5c..266f2e6 100644
--- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
+++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
@@ -38,83 +38,148 @@
/* maximum size of each gpio name (enough room for "gpioXXX" + null) */
#define NAME_SIZE 8
+enum {
+ QDF2XXX_V1,
+ QDF2XXX_V2,
+};
+
+static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
+ {"QCOM8001", QDF2XXX_V1},
+ {"QCOM8002", QDF2XXX_V2},
+ {},
+};
+MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
+
static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
{
+ const struct acpi_device_id *id =
+ acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
+ struct device *dev = &pdev->dev;
struct pinctrl_pin_desc *pins;
struct msm_pingroup *groups;
char (*names)[NAME_SIZE];
unsigned int i;
- u32 num_gpios;
+ unsigned int num_gpios; /* The number of GPIOs we support */
+ u32 max_gpios; /* The highest number GPIO that exists */
+ u16 *gpios; /* An array of supported GPIOs */
int ret;
- /* Query the number of GPIOs from ACPI */
- ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
+ /* The total number of GPIOs that exist */
+ ret = device_property_read_u32(dev, "num-gpios", &max_gpios);
if (ret < 0) {
- dev_warn(&pdev->dev, "missing num-gpios property\n");
+ dev_err(dev, "missing or invalid 'num-gpios' property\n");
return ret;
}
+ if (!max_gpios || max_gpios > MAX_GPIOS) {
+ dev_err(dev, "invalid 'num-gpios' property\n");
+ return -EINVAL;
+ }
- if (!num_gpios || num_gpios > MAX_GPIOS) {
- dev_warn(&pdev->dev, "invalid num-gpios property\n");
- return -ENODEV;
+ /*
+ * The QCOM8001 HID contains only the number of GPIOs, and assumes
+ * that all of them are available. num_gpios is the same as max_gpios.
+ *
+ * The QCOM8002 HID introduces the 'gpios' DSD, which lists
+ * specific GPIOs that the driver is allowed to access.
+ *
+ * The make the common code simpler, in both cases we create an
+ * array of GPIOs that are accessible. So for QCOM8001, that would
+ * be all of the GPIOs.
+ */
+ if (id->driver_data == QDF2XXX_V1) {
+ num_gpios = max_gpios;
+
+ gpios = devm_kcalloc(dev, num_gpios, sizeof(u16), GFP_KERNEL);
+ if (!gpios)
+ return -ENOMEM;
+
+ for (i = 0; i < num_gpios; i++)
+ gpios[i] = i;
+ } else {
+ /* The number of GPIOs in the approved list */
+ ret = device_property_read_u16_array(dev, "gpios", NULL, 0);
+ if (ret < 0) {
+ dev_err(dev, "missing/invalid 'gpios' property\n");
+ return ret;
+ }
+ if (ret == 0) {
+ dev_warn(dev, "no GPIOs defined\n");
+ return -ENODEV;
+ }
+ num_gpios = ret;
+
+ gpios = devm_kcalloc(dev, num_gpios, sizeof(u16), GFP_KERNEL);
+ if (!gpios)
+ return -ENOMEM;
+
+ ret = device_property_read_u16_array(dev, "gpios", gpios,
+ num_gpios);
+ if (ret < 0) {
+ dev_err(dev, "could not read list of GPIOs\n");
+ return ret;
+ }
}
- pins = devm_kcalloc(&pdev->dev, num_gpios,
+ pins = devm_kcalloc(dev, max_gpios,
sizeof(struct pinctrl_pin_desc), GFP_KERNEL);
- groups = devm_kcalloc(&pdev->dev, num_gpios,
+ groups = devm_kcalloc(dev, max_gpios,
sizeof(struct msm_pingroup), GFP_KERNEL);
- names = devm_kcalloc(&pdev->dev, num_gpios, NAME_SIZE, GFP_KERNEL);
+ names = devm_kcalloc(dev, num_gpios, NAME_SIZE, GFP_KERNEL);
if (!pins || !groups || !names)
return -ENOMEM;
- for (i = 0; i < num_gpios; i++) {
- snprintf(names[i], NAME_SIZE, "gpio%u", i);
-
+ /*
+ * Initialize the array. GPIOs not listed in the 'gpios' array
+ * still need a number and a name, but nothing else.
+ */
+ for (i = 0; i < max_gpios; i++) {
pins[i].number = i;
- pins[i].name = names[i];
-
- groups[i].npins = 1;
- groups[i].name = names[i];
groups[i].pins = &pins[i].number;
+ }
- groups[i].ctl_reg = 0x10000 * i;
- groups[i].io_reg = 0x04 + 0x10000 * i;
- groups[i].intr_cfg_reg = 0x08 + 0x10000 * i;
- groups[i].intr_status_reg = 0x0c + 0x10000 * i;
- groups[i].intr_target_reg = 0x08 + 0x10000 * i;
-
- groups[i].mux_bit = 2;
- groups[i].pull_bit = 0;
- groups[i].drv_bit = 6;
- groups[i].oe_bit = 9;
- groups[i].in_bit = 0;
- groups[i].out_bit = 1;
- groups[i].intr_enable_bit = 0;
- groups[i].intr_status_bit = 0;
- groups[i].intr_target_bit = 5;
- groups[i].intr_target_kpss_val = 1;
- groups[i].intr_raw_status_bit = 4;
- groups[i].intr_polarity_bit = 1;
- groups[i].intr_detection_bit = 2;
- groups[i].intr_detection_width = 2;
+ /* Populate the entries that are meant to be exposes as GPIOs. */
+ for (i = 0; i < num_gpios; i++) {
+ unsigned int gpio = gpios[i];
+
+ groups[gpio].npins = 1;
+ snprintf(names[i], NAME_SIZE, "gpio%u", gpio);
+ pins[gpio].name = names[i];
+ groups[gpio].name = names[i];
+
+ groups[gpio].ctl_reg = 0x10000 * gpio;
+ groups[gpio].io_reg = 0x04 + 0x10000 * gpio;
+ groups[gpio].intr_cfg_reg = 0x08 + 0x10000 * gpio;
+ groups[gpio].intr_status_reg = 0x0c + 0x10000 * gpio;
+ groups[gpio].intr_target_reg = 0x08 + 0x10000 * gpio;
+
+ groups[gpio].mux_bit = 2;
+ groups[gpio].pull_bit = 0;
+ groups[gpio].drv_bit = 6;
+ groups[gpio].oe_bit = 9;
+ groups[gpio].in_bit = 0;
+ groups[gpio].out_bit = 1;
+ groups[gpio].intr_enable_bit = 0;
+ groups[gpio].intr_status_bit = 0;
+ groups[gpio].intr_target_bit = 5;
+ groups[gpio].intr_target_kpss_val = 1;
+ groups[gpio].intr_raw_status_bit = 4;
+ groups[gpio].intr_polarity_bit = 1;
+ groups[gpio].intr_detection_bit = 2;
+ groups[gpio].intr_detection_width = 2;
}
+ devm_kfree(dev, gpios);
+
qdf2xxx_pinctrl.pins = pins;
qdf2xxx_pinctrl.groups = groups;
- qdf2xxx_pinctrl.npins = num_gpios;
- qdf2xxx_pinctrl.ngroups = num_gpios;
- qdf2xxx_pinctrl.ngpios = num_gpios;
+ qdf2xxx_pinctrl.npins = max_gpios;
+ qdf2xxx_pinctrl.ngroups = max_gpios;
+ qdf2xxx_pinctrl.ngpios = max_gpios;
return msm_pinctrl_probe(pdev, &qdf2xxx_pinctrl);
}
-static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
- {"QCOM8001"},
- {},
-};
-MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
-
static struct platform_driver qdf2xxx_pinctrl_driver = {
.driver = {
.name = "qdf2xxx-pinctrl",
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
2017-07-13 21:52 ` Timur Tabi
@ 2017-07-14 17:21 ` Bjorn Andersson
-1 siblings, 0 replies; 24+ messages in thread
From: Bjorn Andersson @ 2017-07-14 17:21 UTC (permalink / raw)
To: Timur Tabi
Cc: andy.gross, david.brown, Linus Walleij, linux-gpio,
linux-arm-msm, linux-arm-kernel
On Thu 13 Jul 14:52 PDT 2017, Timur Tabi wrote:
> Newer versions of the firmware for the Qualcomm Datacenter Technologies
> QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
> prevent older kernels from accidentally accessing the restricted GPIOs,
> we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
> and introduce a new property "gpios". This property is an array of
> specific GPIOs that are accessible. When an older kernel boots on
> newer (restricted) firmware, it will fail to probe.
>
> To implement the sparse GPIO map, we register all of the GPIOs, but set
> the pin count for the unavailable GPIOs to zero. The pinctrl-msm
> driver will block those unavailable GPIOs from being accessed.
>
> To allow newer kernels to support older firmware, the driver retains
> support for QCOM8001.
>
This approach looks sane.
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 157 +++++++++++++++++++++++----------
> 1 file changed, 111 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> index bb3ce5c..266f2e6 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> @@ -38,83 +38,148 @@
> /* maximum size of each gpio name (enough room for "gpioXXX" + null) */
> #define NAME_SIZE 8
>
> +enum {
> + QDF2XXX_V1,
> + QDF2XXX_V2,
> +};
> +
> +static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
> + {"QCOM8001", QDF2XXX_V1},
> + {"QCOM8002", QDF2XXX_V2},
> + {},
> +};
> +MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
NB. too bad there doesn't seem to be an equivalent of
of_device_get_match_data().
> +
> static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
> {
> + const struct acpi_device_id *id =
> + acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
> + struct device *dev = &pdev->dev;
> struct pinctrl_pin_desc *pins;
> struct msm_pingroup *groups;
> char (*names)[NAME_SIZE];
> unsigned int i;
The result of the patch looks fine, but unfortunately there's some noise
in the patch due to the transition from &pdev->dev to dev and num_gpios
to max_gpios.
> - u32 num_gpios;
> + unsigned int num_gpios; /* The number of GPIOs we support */
> + u32 max_gpios; /* The highest number GPIO that exists */
Could you please keep the "num_gpios" naming and name the new variable
"avail_gpios" or something similar.
> + u16 *gpios; /* An array of supported GPIOs */
> int ret;
>
> - /* Query the number of GPIOs from ACPI */
> - ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
> + /* The total number of GPIOs that exist */
> + ret = device_property_read_u32(dev, "num-gpios", &max_gpios);
> if (ret < 0) {
> - dev_warn(&pdev->dev, "missing num-gpios property\n");
> + dev_err(dev, "missing or invalid 'num-gpios' property\n");
While this makes sense it's not entirely related to this patch. My
suggestion is that you prepend a patch transitioning &pdev->dev to dev
and change these to dev_err in the same.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
@ 2017-07-14 17:21 ` Bjorn Andersson
0 siblings, 0 replies; 24+ messages in thread
From: Bjorn Andersson @ 2017-07-14 17:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thu 13 Jul 14:52 PDT 2017, Timur Tabi wrote:
> Newer versions of the firmware for the Qualcomm Datacenter Technologies
> QDF2400 restricts access to a subset of the GPIOs on the TLMM. To
> prevent older kernels from accidentally accessing the restricted GPIOs,
> we change the ACPI HID for the TLMM block from QCOM8001 to QCOM8002,
> and introduce a new property "gpios". This property is an array of
> specific GPIOs that are accessible. When an older kernel boots on
> newer (restricted) firmware, it will fail to probe.
>
> To implement the sparse GPIO map, we register all of the GPIOs, but set
> the pin count for the unavailable GPIOs to zero. The pinctrl-msm
> driver will block those unavailable GPIOs from being accessed.
>
> To allow newer kernels to support older firmware, the driver retains
> support for QCOM8001.
>
This approach looks sane.
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 157 +++++++++++++++++++++++----------
> 1 file changed, 111 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> index bb3ce5c..266f2e6 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c
> @@ -38,83 +38,148 @@
> /* maximum size of each gpio name (enough room for "gpioXXX" + null) */
> #define NAME_SIZE 8
>
> +enum {
> + QDF2XXX_V1,
> + QDF2XXX_V2,
> +};
> +
> +static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
> + {"QCOM8001", QDF2XXX_V1},
> + {"QCOM8002", QDF2XXX_V2},
> + {},
> +};
> +MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
NB. too bad there doesn't seem to be an equivalent of
of_device_get_match_data().
> +
> static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
> {
> + const struct acpi_device_id *id =
> + acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
> + struct device *dev = &pdev->dev;
> struct pinctrl_pin_desc *pins;
> struct msm_pingroup *groups;
> char (*names)[NAME_SIZE];
> unsigned int i;
The result of the patch looks fine, but unfortunately there's some noise
in the patch due to the transition from &pdev->dev to dev and num_gpios
to max_gpios.
> - u32 num_gpios;
> + unsigned int num_gpios; /* The number of GPIOs we support */
> + u32 max_gpios; /* The highest number GPIO that exists */
Could you please keep the "num_gpios" naming and name the new variable
"avail_gpios" or something similar.
> + u16 *gpios; /* An array of supported GPIOs */
> int ret;
>
> - /* Query the number of GPIOs from ACPI */
> - ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
> + /* The total number of GPIOs that exist */
> + ret = device_property_read_u32(dev, "num-gpios", &max_gpios);
> if (ret < 0) {
> - dev_warn(&pdev->dev, "missing num-gpios property\n");
> + dev_err(dev, "missing or invalid 'num-gpios' property\n");
While this makes sense it's not entirely related to this patch. My
suggestion is that you prepend a patch transitioning &pdev->dev to dev
and change these to dev_err in the same.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
2017-07-14 17:21 ` Bjorn Andersson
@ 2017-07-14 18:30 ` Timur Tabi
-1 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2017-07-14 18:30 UTC (permalink / raw)
To: Bjorn Andersson
Cc: andy.gross, david.brown, Linus Walleij, linux-gpio,
linux-arm-msm, linux-arm-kernel
On 07/14/2017 12:21 PM, Bjorn Andersson wrote:
>> +enum {
>> + QDF2XXX_V1,
>> + QDF2XXX_V2,
>> +};
>> +
>> +static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
>> + {"QCOM8001", QDF2XXX_V1},
>> + {"QCOM8002", QDF2XXX_V2},
>> + {},
>> +};
>> +MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
>
> NB. too bad there doesn't seem to be an equivalent of
> of_device_get_match_data().
There's acpi_match_device(), which I use.
>
>> +
>> static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
>> {
>> + const struct acpi_device_id *id =
>> + acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
>> + struct device *dev = &pdev->dev;
>> struct pinctrl_pin_desc *pins;
>> struct msm_pingroup *groups;
>> char (*names)[NAME_SIZE];
>> unsigned int i;
>
> The result of the patch looks fine, but unfortunately there's some noise
> in the patch due to the transition from &pdev->dev to dev and num_gpios
> to max_gpios.
I did that to shrink the line lengths. I can put it back if you want.
>
>> - u32 num_gpios;
>> + unsigned int num_gpios; /* The number of GPIOs we support */
>> + u32 max_gpios; /* The highest number GPIO that exists */
>
> Could you please keep the "num_gpios" naming and name the new variable
> "avail_gpios" or something similar.
Sure.
>
>> + u16 *gpios; /* An array of supported GPIOs */
>> int ret;
>
>>
>> - /* Query the number of GPIOs from ACPI */
>> - ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
>> + /* The total number of GPIOs that exist */
>> + ret = device_property_read_u32(dev, "num-gpios", &max_gpios);
>> if (ret < 0) {
>> - dev_warn(&pdev->dev, "missing num-gpios property\n");
>> + dev_err(dev, "missing or invalid 'num-gpios' property\n");
>
> While this makes sense it's not entirely related to this patch. My
> suggestion is that you prepend a patch transitioning &pdev->dev to dev
> and change these to dev_err in the same.
I'd rather put pdev->dev back.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002
@ 2017-07-14 18:30 ` Timur Tabi
0 siblings, 0 replies; 24+ messages in thread
From: Timur Tabi @ 2017-07-14 18:30 UTC (permalink / raw)
To: linux-arm-kernel
On 07/14/2017 12:21 PM, Bjorn Andersson wrote:
>> +enum {
>> + QDF2XXX_V1,
>> + QDF2XXX_V2,
>> +};
>> +
>> +static const struct acpi_device_id qdf2xxx_acpi_ids[] = {
>> + {"QCOM8001", QDF2XXX_V1},
>> + {"QCOM8002", QDF2XXX_V2},
>> + {},
>> +};
>> +MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids);
>
> NB. too bad there doesn't seem to be an equivalent of
> of_device_get_match_data().
There's acpi_match_device(), which I use.
>
>> +
>> static int qdf2xxx_pinctrl_probe(struct platform_device *pdev)
>> {
>> + const struct acpi_device_id *id =
>> + acpi_match_device(qdf2xxx_acpi_ids, &pdev->dev);
>> + struct device *dev = &pdev->dev;
>> struct pinctrl_pin_desc *pins;
>> struct msm_pingroup *groups;
>> char (*names)[NAME_SIZE];
>> unsigned int i;
>
> The result of the patch looks fine, but unfortunately there's some noise
> in the patch due to the transition from &pdev->dev to dev and num_gpios
> to max_gpios.
I did that to shrink the line lengths. I can put it back if you want.
>
>> - u32 num_gpios;
>> + unsigned int num_gpios; /* The number of GPIOs we support */
>> + u32 max_gpios; /* The highest number GPIO that exists */
>
> Could you please keep the "num_gpios" naming and name the new variable
> "avail_gpios" or something similar.
Sure.
>
>> + u16 *gpios; /* An array of supported GPIOs */
>> int ret;
>
>>
>> - /* Query the number of GPIOs from ACPI */
>> - ret = device_property_read_u32(&pdev->dev, "num-gpios", &num_gpios);
>> + /* The total number of GPIOs that exist */
>> + ret = device_property_read_u32(dev, "num-gpios", &max_gpios);
>> if (ret < 0) {
>> - dev_warn(&pdev->dev, "missing num-gpios property\n");
>> + dev_err(dev, "missing or invalid 'num-gpios' property\n");
>
> While this makes sense it's not entirely related to this patch. My
> suggestion is that you prepend a patch transitioning &pdev->dev to dev
> and change these to dev_err in the same.
I'd rather put pdev->dev back.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 24+ messages in thread