From: Joe Perches <joe@perches.com> To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net> Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com Subject: [PATCH script] hwmon: Use octal not symbolic permissions Date: Mon, 26 Mar 2018 13:28:56 -0700 [thread overview] Message-ID: <1522096136.12357.21.camel@perches.com> (raw) drivers/hwmon is the most frequent user of symbolic permissions like S_IRUGO in the kernel tree. $ git grep -w -P "S_[A-Z]{5,5}" | \ cut -f1 -d: | cut -f1-2 -d"/" | sed -r 's/[A-Za-z0-9_-]+\.[ch]$//' | \ sort | uniq -c | sort -rn | head 3862 drivers/hwmon 814 drivers/scsi 763 drivers/net 242 drivers/infiniband 184 drivers/staging 181 drivers/usb 158 fs/proc 150 fs/xfs 148 fs/ 142 drivers/misc But using octal and not symbolic permissions is preferred by many as it can be more readable. https://lkml.org/lkml/2016/8/2/1945 Rather than converting these piecemeal, perhaps just do them all at once via a trivial script like the below: $ git grep -w -P --name-only "S_[A-Z]{5,5}" drivers/hwmon | \ xargs ./scripts/checkpatch.pl -f --types=symbolic_perms --fix-inplace $ git grep -w -P --name-only "S_[A-Z]{5,5}" drivers/hwmon | \ xargs ./scripts/checkpatch.pl -f --types=symbolic_perms --fix-inplace It's run twice because checkpatch only does 1 conversion per line and there are some multiple instance lines. This currently results in a 669 KB patch which is too large to post but can be easily generated when appropriate.
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH script] hwmon: Use octal not symbolic permissions Date: Mon, 26 Mar 2018 13:28:56 -0700 [thread overview] Message-ID: <1522096136.12357.21.camel@perches.com> (raw) drivers/hwmon is the most frequent user of symbolic permissions like S_IRUGO in the kernel tree. $ git grep -w -P "S_[A-Z]{5,5}" | \ cut -f1 -d: | cut -f1-2 -d"/" | sed -r 's/[A-Za-z0-9_-]+\.[ch]$//' | \ sort | uniq -c | sort -rn | head 3862 drivers/hwmon 814 drivers/scsi 763 drivers/net 242 drivers/infiniband 184 drivers/staging 181 drivers/usb 158 fs/proc 150 fs/xfs 148 fs/ 142 drivers/misc But using octal and not symbolic permissions is preferred by many as it can be more readable. https://lkml.org/lkml/2016/8/2/1945 Rather than converting these piecemeal, perhaps just do them all at once via a trivial script like the below: $ git grep -w -P --name-only "S_[A-Z]{5,5}" drivers/hwmon | \ xargs ./scripts/checkpatch.pl -f --types=symbolic_perms --fix-inplace $ git grep -w -P --name-only "S_[A-Z]{5,5}" drivers/hwmon | \ xargs ./scripts/checkpatch.pl -f --types=symbolic_perms --fix-inplace It's run twice because checkpatch only does 1 conversion per line and there are some multiple instance lines. This currently results in a 669 KB patch which is too large to post but can be easily generated when appropriate.
next reply other threads:[~2018-03-26 20:38 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-26 20:28 Joe Perches [this message] 2018-03-26 20:28 ` [PATCH script] hwmon: Use octal not symbolic permissions Joe Perches 2018-03-27 6:33 ` Guenter Roeck 2018-03-27 6:33 ` Guenter Roeck 2018-03-27 6:52 ` Joe Perches 2018-03-27 6:52 ` Joe Perches 2018-03-27 7:35 ` Joe Perches 2018-03-27 7:35 ` Joe Perches 2018-03-27 10:28 ` Guenter Roeck 2018-03-27 10:28 ` Guenter Roeck 2018-03-27 11:48 ` Joe Perches 2018-03-27 11:48 ` Joe Perches 2018-03-27 15:44 ` Guenter Roeck 2018-03-27 15:44 ` Guenter Roeck 2018-03-27 16:52 ` Joe Perches 2018-03-27 16:52 ` Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1522096136.12357.21.camel@perches.com \ --to=joe@perches.com \ --cc=jdelvare@suse.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=patches@opensource.cirrus.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.