From: Joe Perches <joe@perches.com> To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com> Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com Subject: Re: [PATCH script] hwmon: Use octal not symbolic permissions Date: Mon, 26 Mar 2018 23:52:04 -0700 [thread overview] Message-ID: <1522133524.12357.56.camel@perches.com> (raw) In-Reply-To: <9b112651-d0cf-5f3b-b643-3328028a95cd@roeck-us.net> On Mon, 2018-03-26 at 23:33 -0700, Guenter Roeck wrote: > On 03/26/2018 01:28 PM, Joe Perches wrote: > > drivers/hwmon is the most frequent user of symbolic permissions > > like S_IRUGO in the kernel tree. [] > I have something similar using coccinelle, Please post the script. I expect it doesn't work quite the same as checkpatch. > which has the added benefit > of also adjusting multi-line alignments. That's a benefit, but it's makes it difficult to review. I also have the same patch rewrap alignment post this automated patch, done with emacs formatting. This patch is somewhat simpler to review which is why it's not sent along with this script. > But then I am hesitant to pull > it in because I don't really see the point. A more intelligent approach > would be to convert hwmon drivers to the latest API, and/or to introduce > more intelligent macros such as SENSOR_DEVICE_ATTR_{RO,RW,WO}. Another approach would be to separate the const bits from the non-const bits to reduce data. > But that > would require active work as well as reviewers, and especially the latter > is extremely difficult if not impossible to find for the hwmon subsystem. [] > Since the hwmon subsystem has been labeled as both "obsolete" and "obscure", > that is maybe not entirely surprising, and I think we are good as we are. Maybe true. > I am happy to accept patches updating permissions as other changes are made > to a file, but I don't see a pressing need to change all files just to make > statistics happy (and backports more difficult). Not sure backports are a real issue. If it were a real issue, the updated permissions are noise and shouldn't be accepted for the other changes.
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH script] hwmon: Use octal not symbolic permissions Date: Mon, 26 Mar 2018 23:52:04 -0700 [thread overview] Message-ID: <1522133524.12357.56.camel@perches.com> (raw) In-Reply-To: <9b112651-d0cf-5f3b-b643-3328028a95cd@roeck-us.net> On Mon, 2018-03-26 at 23:33 -0700, Guenter Roeck wrote: > On 03/26/2018 01:28 PM, Joe Perches wrote: > > drivers/hwmon is the most frequent user of symbolic permissions > > like S_IRUGO in the kernel tree. [] > I have something similar using coccinelle, Please post the script. I expect it doesn't work quite the same as checkpatch. > which has the added benefit > of also adjusting multi-line alignments. That's a benefit, but it's makes it difficult to review. I also have the same patch rewrap alignment post this automated patch, done with emacs formatting. This patch is somewhat simpler to review which is why it's not sent along with this script. > But then I am hesitant to pull > it in because I don't really see the point. A more intelligent approach > would be to convert hwmon drivers to the latest API, and/or to introduce > more intelligent macros such as SENSOR_DEVICE_ATTR_{RO,RW,WO}. Another approach would be to separate the const bits from the non-const bits to reduce data. > But that > would require active work as well as reviewers, and especially the latter > is extremely difficult if not impossible to find for the hwmon subsystem. [] > Since the hwmon subsystem has been labeled as both "obsolete" and "obscure", > that is maybe not entirely surprising, and I think we are good as we are. Maybe true. > I am happy to accept patches updating permissions as other changes are made > to a file, but I don't see a pressing need to change all files just to make > statistics happy (and backports more difficult). Not sure backports are a real issue. If it were a real issue, the updated permissions are noise and shouldn't be accepted for the other changes.
next prev parent reply other threads:[~2018-03-27 6:52 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-26 20:28 [PATCH script] hwmon: Use octal not symbolic permissions Joe Perches 2018-03-26 20:28 ` Joe Perches 2018-03-27 6:33 ` Guenter Roeck 2018-03-27 6:33 ` Guenter Roeck 2018-03-27 6:52 ` Joe Perches [this message] 2018-03-27 6:52 ` Joe Perches 2018-03-27 7:35 ` Joe Perches 2018-03-27 7:35 ` Joe Perches 2018-03-27 10:28 ` Guenter Roeck 2018-03-27 10:28 ` Guenter Roeck 2018-03-27 11:48 ` Joe Perches 2018-03-27 11:48 ` Joe Perches 2018-03-27 15:44 ` Guenter Roeck 2018-03-27 15:44 ` Guenter Roeck 2018-03-27 16:52 ` Joe Perches 2018-03-27 16:52 ` Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1522133524.12357.56.camel@perches.com \ --to=joe@perches.com \ --cc=jdelvare@suse.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=patches@opensource.cirrus.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.