All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] meta-oe/numactl: Enable NUMA in the kernel config
@ 2018-04-10 17:09 Alistair Francis
  2018-04-10 17:32 ` ✗ patchtest: failure for " Patchwork
  2018-04-12 15:49 ` [PATCH] " Khem Raj
  0 siblings, 2 replies; 5+ messages in thread
From: Alistair Francis @ 2018-04-10 17:09 UTC (permalink / raw)
  To: openembedded-core

If a user has specified numa in their DISTRO_FEATURES then they should
have NUMA support enabled in the kernel. Without kernel support the
numactl program is not very useful.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 meta-oe/recipes-kernel/linux/linux-yocto.inc           | 2 ++
 meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend | 1 +
 meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend | 1 +
 meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend | 1 +
 meta-oe/recipes-support/numactl/numactl/numa.cfg       | 2 ++
 meta-oe/recipes-support/numactl/numactl_git.bb         | 1 +
 6 files changed, 8 insertions(+)
 create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto.inc
 create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
 create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
 create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
 create mode 100644 meta-oe/recipes-support/numactl/numactl/numa.cfg

diff --git a/meta-oe/recipes-kernel/linux/linux-yocto.inc b/meta-oe/recipes-kernel/linux/linux-yocto.inc
new file mode 100644
index 0000000..9533eb6
--- /dev/null
+++ b/meta-oe/recipes-kernel/linux/linux-yocto.inc
@@ -0,0 +1,2 @@
+KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'numa', 'features/numa/numa.scc', '', d)}"
+
diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
new file mode 100644
index 0000000..161f9d3
--- /dev/null
+++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
@@ -0,0 +1 @@
+require linux-yocto.inc
diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
new file mode 100644
index 0000000..161f9d3
--- /dev/null
+++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
@@ -0,0 +1 @@
+require linux-yocto.inc
diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
new file mode 100644
index 0000000..161f9d3
--- /dev/null
+++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
@@ -0,0 +1 @@
+require linux-yocto.inc
diff --git a/meta-oe/recipes-support/numactl/numactl/numa.cfg b/meta-oe/recipes-support/numactl/numactl/numa.cfg
new file mode 100644
index 0000000..fe1394d
--- /dev/null
+++ b/meta-oe/recipes-support/numactl/numactl/numa.cfg
@@ -0,0 +1,2 @@
+CONFIG_NUMA=y
+CONFIG_ACPI_NUMA=y
diff --git a/meta-oe/recipes-support/numactl/numactl_git.bb b/meta-oe/recipes-support/numactl/numactl_git.bb
index b9cbcf0..ef2dab2 100644
--- a/meta-oe/recipes-support/numactl/numactl_git.bb
+++ b/meta-oe/recipes-support/numactl/numactl_git.bb
@@ -21,6 +21,7 @@ SRC_URI = "git://github.com/numactl/numactl \
     file://run-ptest \
     file://0001-define-run-test-target.patch \
 "
+SRC_URI += "${@bb.utils.contains('DISTRO_FEATURES', 'numa', ' file://numa.cfg', '', d)}"
 
 S = "${WORKDIR}/git"
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* ✗ patchtest: failure for meta-oe/numactl: Enable NUMA in the kernel config
  2018-04-10 17:09 [PATCH] meta-oe/numactl: Enable NUMA in the kernel config Alistair Francis
@ 2018-04-10 17:32 ` Patchwork
  2018-04-12 15:49 ` [PATCH] " Khem Raj
  1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-04-10 17:32 UTC (permalink / raw)
  To: Alistair Francis; +Cc: openembedded-core

== Series Details ==

Series: meta-oe/numactl: Enable NUMA in the kernel config
Revision: 1
URL   : https://patchwork.openembedded.org/series/11753/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists [test_target_mailing_list] 
  Suggested fix    Send the series again to the correct mailing list (ML)
  Suggested ML     openembedded-devel@lists.openembedded.org [http://git.openembedded.org/meta-openembedded/]
  Patch's path:    meta-oe/recipes-kernel/linux/linux-yocto.inc

* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 9b9897fc03)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] meta-oe/numactl: Enable NUMA in the kernel config
  2018-04-10 17:09 [PATCH] meta-oe/numactl: Enable NUMA in the kernel config Alistair Francis
  2018-04-10 17:32 ` ✗ patchtest: failure for " Patchwork
@ 2018-04-12 15:49 ` Khem Raj
  2018-04-12 18:26   ` Alistair Francis
  1 sibling, 1 reply; 5+ messages in thread
From: Khem Raj @ 2018-04-12 15:49 UTC (permalink / raw)
  To: Alistair Francis, openembedded-core

On 4/10/18 10:09 AM, Alistair Francis wrote:
> If a user has specified numa in their DISTRO_FEATURES then they should
> have NUMA support enabled in the kernel. Without kernel support the
> numactl program is not very useful.
> 

This should be done in OE-Core as part of main recipe.

Note that this patch is sent to oe-core ml but is actually against
meta-oe layer which follows oe-devel mailing list.

> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  meta-oe/recipes-kernel/linux/linux-yocto.inc           | 2 ++
>  meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend | 1 +
>  meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend | 1 +
>  meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend | 1 +
>  meta-oe/recipes-support/numactl/numactl/numa.cfg       | 2 ++
>  meta-oe/recipes-support/numactl/numactl_git.bb         | 1 +
>  6 files changed, 8 insertions(+)
>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto.inc
>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>  create mode 100644 meta-oe/recipes-support/numactl/numactl/numa.cfg
> 
> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto.inc b/meta-oe/recipes-kernel/linux/linux-yocto.inc
> new file mode 100644
> index 0000000..9533eb6
> --- /dev/null
> +++ b/meta-oe/recipes-kernel/linux/linux-yocto.inc
> @@ -0,0 +1,2 @@
> +KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'numa', 'features/numa/numa.scc', '', d)}"
> +
> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
> new file mode 100644
> index 0000000..161f9d3
> --- /dev/null
> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
> @@ -0,0 +1 @@
> +require linux-yocto.inc
> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
> new file mode 100644
> index 0000000..161f9d3
> --- /dev/null
> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
> @@ -0,0 +1 @@
> +require linux-yocto.inc
> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
> new file mode 100644
> index 0000000..161f9d3
> --- /dev/null
> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
> @@ -0,0 +1 @@
> +require linux-yocto.inc
> diff --git a/meta-oe/recipes-support/numactl/numactl/numa.cfg b/meta-oe/recipes-support/numactl/numactl/numa.cfg
> new file mode 100644
> index 0000000..fe1394d
> --- /dev/null
> +++ b/meta-oe/recipes-support/numactl/numactl/numa.cfg
> @@ -0,0 +1,2 @@
> +CONFIG_NUMA=y
> +CONFIG_ACPI_NUMA=y
> diff --git a/meta-oe/recipes-support/numactl/numactl_git.bb b/meta-oe/recipes-support/numactl/numactl_git.bb
> index b9cbcf0..ef2dab2 100644
> --- a/meta-oe/recipes-support/numactl/numactl_git.bb
> +++ b/meta-oe/recipes-support/numactl/numactl_git.bb
> @@ -21,6 +21,7 @@ SRC_URI = "git://github.com/numactl/numactl \
>      file://run-ptest \
>      file://0001-define-run-test-target.patch \
>  "
> +SRC_URI += "${@bb.utils.contains('DISTRO_FEATURES', 'numa', ' file://numa.cfg', '', d)}"
>  
>  S = "${WORKDIR}/git"
>  
> 



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] meta-oe/numactl: Enable NUMA in the kernel config
  2018-04-12 15:49 ` [PATCH] " Khem Raj
@ 2018-04-12 18:26   ` Alistair Francis
  2018-04-12 19:06     ` Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: Alistair Francis @ 2018-04-12 18:26 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE-core

On Thu, Apr 12, 2018 at 8:49 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On 4/10/18 10:09 AM, Alistair Francis wrote:
>> If a user has specified numa in their DISTRO_FEATURES then they should
>> have NUMA support enabled in the kernel. Without kernel support the
>> numactl program is not very useful.
>>
>
> This should be done in OE-Core as part of main recipe.

Do you mean in core linux-yocto
(meta/recipes-kernel/linux/linux-yocto.inc)? That seemed a little odd
to me as the numactl package comes from the meta-oe layer. I was
thinking it made sense to keep them together.

Alistair

>
> Note that this patch is sent to oe-core ml but is actually against
> meta-oe layer which follows oe-devel mailing list.
>
>> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>> ---
>>  meta-oe/recipes-kernel/linux/linux-yocto.inc           | 2 ++
>>  meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend | 1 +
>>  meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend | 1 +
>>  meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend | 1 +
>>  meta-oe/recipes-support/numactl/numactl/numa.cfg       | 2 ++
>>  meta-oe/recipes-support/numactl/numactl_git.bb         | 1 +
>>  6 files changed, 8 insertions(+)
>>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto.inc
>>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>>  create mode 100644 meta-oe/recipes-support/numactl/numactl/numa.cfg
>>
>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto.inc b/meta-oe/recipes-kernel/linux/linux-yocto.inc
>> new file mode 100644
>> index 0000000..9533eb6
>> --- /dev/null
>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto.inc
>> @@ -0,0 +1,2 @@
>> +KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'numa', 'features/numa/numa.scc', '', d)}"
>> +
>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>> new file mode 100644
>> index 0000000..161f9d3
>> --- /dev/null
>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>> @@ -0,0 +1 @@
>> +require linux-yocto.inc
>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>> new file mode 100644
>> index 0000000..161f9d3
>> --- /dev/null
>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>> @@ -0,0 +1 @@
>> +require linux-yocto.inc
>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>> new file mode 100644
>> index 0000000..161f9d3
>> --- /dev/null
>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>> @@ -0,0 +1 @@
>> +require linux-yocto.inc
>> diff --git a/meta-oe/recipes-support/numactl/numactl/numa.cfg b/meta-oe/recipes-support/numactl/numactl/numa.cfg
>> new file mode 100644
>> index 0000000..fe1394d
>> --- /dev/null
>> +++ b/meta-oe/recipes-support/numactl/numactl/numa.cfg
>> @@ -0,0 +1,2 @@
>> +CONFIG_NUMA=y
>> +CONFIG_ACPI_NUMA=y
>> diff --git a/meta-oe/recipes-support/numactl/numactl_git.bb b/meta-oe/recipes-support/numactl/numactl_git.bb
>> index b9cbcf0..ef2dab2 100644
>> --- a/meta-oe/recipes-support/numactl/numactl_git.bb
>> +++ b/meta-oe/recipes-support/numactl/numactl_git.bb
>> @@ -21,6 +21,7 @@ SRC_URI = "git://github.com/numactl/numactl \
>>      file://run-ptest \
>>      file://0001-define-run-test-target.patch \
>>  "
>> +SRC_URI += "${@bb.utils.contains('DISTRO_FEATURES', 'numa', ' file://numa.cfg', '', d)}"
>>
>>  S = "${WORKDIR}/git"
>>
>>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] meta-oe/numactl: Enable NUMA in the kernel config
  2018-04-12 18:26   ` Alistair Francis
@ 2018-04-12 19:06     ` Khem Raj
  0 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2018-04-12 19:06 UTC (permalink / raw)
  To: Alistair Francis; +Cc: OE-core

On Thu, Apr 12, 2018 at 11:26 AM, Alistair Francis <alistair23@gmail.com> wrote:
> On Thu, Apr 12, 2018 at 8:49 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> On 4/10/18 10:09 AM, Alistair Francis wrote:
>>> If a user has specified numa in their DISTRO_FEATURES then they should
>>> have NUMA support enabled in the kernel. Without kernel support the
>>> numactl program is not very useful.
>>>
>>
>> This should be done in OE-Core as part of main recipe.
>
> Do you mean in core linux-yocto
> (meta/recipes-kernel/linux/linux-yocto.inc)? That seemed a little odd
> to me as the numactl package comes from the meta-oe layer. I was
> thinking it made sense to keep them together.
>

its controlled by a distro feature which would add right knobs to it in core.
it wont be changing any functionality therefore and hence would be ok

> Alistair
>
>>
>> Note that this patch is sent to oe-core ml but is actually against
>> meta-oe layer which follows oe-devel mailing list.
>>
>>> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>>> ---
>>>  meta-oe/recipes-kernel/linux/linux-yocto.inc           | 2 ++
>>>  meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend | 1 +
>>>  meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend | 1 +
>>>  meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend | 1 +
>>>  meta-oe/recipes-support/numactl/numactl/numa.cfg       | 2 ++
>>>  meta-oe/recipes-support/numactl/numactl_git.bb         | 1 +
>>>  6 files changed, 8 insertions(+)
>>>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto.inc
>>>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>>>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>>>  create mode 100644 meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>>>  create mode 100644 meta-oe/recipes-support/numactl/numactl/numa.cfg
>>>
>>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto.inc b/meta-oe/recipes-kernel/linux/linux-yocto.inc
>>> new file mode 100644
>>> index 0000000..9533eb6
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto.inc
>>> @@ -0,0 +1,2 @@
>>> +KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'numa', 'features/numa/numa.scc', '', d)}"
>>> +
>>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>>> new file mode 100644
>>> index 0000000..161f9d3
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.12.bbappend
>>> @@ -0,0 +1 @@
>>> +require linux-yocto.inc
>>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>>> new file mode 100644
>>> index 0000000..161f9d3
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.14.bbappend
>>> @@ -0,0 +1 @@
>>> +require linux-yocto.inc
>>> diff --git a/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>>> new file mode 100644
>>> index 0000000..161f9d3
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-kernel/linux/linux-yocto_4.15.bbappend
>>> @@ -0,0 +1 @@
>>> +require linux-yocto.inc
>>> diff --git a/meta-oe/recipes-support/numactl/numactl/numa.cfg b/meta-oe/recipes-support/numactl/numactl/numa.cfg
>>> new file mode 100644
>>> index 0000000..fe1394d
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-support/numactl/numactl/numa.cfg
>>> @@ -0,0 +1,2 @@
>>> +CONFIG_NUMA=y
>>> +CONFIG_ACPI_NUMA=y
>>> diff --git a/meta-oe/recipes-support/numactl/numactl_git.bb b/meta-oe/recipes-support/numactl/numactl_git.bb
>>> index b9cbcf0..ef2dab2 100644
>>> --- a/meta-oe/recipes-support/numactl/numactl_git.bb
>>> +++ b/meta-oe/recipes-support/numactl/numactl_git.bb
>>> @@ -21,6 +21,7 @@ SRC_URI = "git://github.com/numactl/numactl \
>>>      file://run-ptest \
>>>      file://0001-define-run-test-target.patch \
>>>  "
>>> +SRC_URI += "${@bb.utils.contains('DISTRO_FEATURES', 'numa', ' file://numa.cfg', '', d)}"
>>>
>>>  S = "${WORKDIR}/git"
>>>
>>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-04-12 19:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 17:09 [PATCH] meta-oe/numactl: Enable NUMA in the kernel config Alistair Francis
2018-04-10 17:32 ` ✗ patchtest: failure for " Patchwork
2018-04-12 15:49 ` [PATCH] " Khem Raj
2018-04-12 18:26   ` Alistair Francis
2018-04-12 19:06     ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.