[PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[Laurent Pinchart]

The adv7511 IRQ is low level triggered, not falling edge triggered. The
wrong sense configuration results in no interrupt being triggered at
all, breaking hotplug detection. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 74c3212f1f11..824ddab9c3ad 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -545,7 +545,7 @@
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
 		interrupt-parent = <&gpio3>;
-		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
 
 		adi,input-depth = <8>;
 		adi,input-colorspace = "rgb";
-- 
Regards,

Laurent Pinchart

Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[Simon Horman]

Hi Laurent,

On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote:
> The adv7511 IRQ is low level triggered, not falling edge triggered. The
> wrong sense configuration results in no interrupt being triggered at
> all, breaking hotplug detection. Fix it.

Would I be correct in adding the following and queuing it up
as a fix for v4.1 and v4.0-stable?

Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")


> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index 74c3212f1f11..824ddab9c3ad 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -545,7 +545,7 @@
>  		compatible = "adi,adv7511w";
>  		reg = <0x39>;
>  		interrupt-parent = <&gpio3>;
> -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
>  
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[Laurent Pinchart]

Hi Simon,

On Thursday 30 April 2015 13:56:40 Simon Horman wrote:
> Hi Laurent,
> 
> On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote:
> > The adv7511 IRQ is low level triggered, not falling edge triggered. The
> > wrong sense configuration results in no interrupt being triggered at
> > all, breaking hotplug detection. Fix it.
> 
> Would I be correct in adding the following and queuing it up
> as a fix for v4.1 and v4.0-stable?
> 
> Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")

I think that would be fine. It's not a regression fix in the traditional 
sense, but it fixes a shortcoming of the original commit.

> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad
> > 100644
> > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > @@ -545,7 +545,7 @@
> >  		compatible = "adi,adv7511w";
> >  		reg = <0x39>;
> >  		interrupt-parent = <&gpio3>;
> > -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> > +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
> > 
> >  		adi,input-depth = <8>;
> >  		adi,input-colorspace = "rgb";

-- 
Regards,

Laurent Pinchart

Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[Simon Horman]

Hi Laurent,

On Thu, Apr 30, 2015 at 10:30:48AM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Thursday 30 April 2015 13:56:40 Simon Horman wrote:
> > Hi Laurent,
> > 
> > On Wed, Apr 29, 2015 at 04:55:43PM +0300, Laurent Pinchart wrote:
> > > The adv7511 IRQ is low level triggered, not falling edge triggered. The
> > > wrong sense configuration results in no interrupt being triggered at
> > > all, breaking hotplug detection. Fix it.
> > 
> > Would I be correct in adding the following and queuing it up
> > as a fix for v4.1 and v4.0-stable?
> > 
> > Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")
> 
> I think that would be fine. It's not a regression fix in the traditional 
> sense, but it fixes a shortcoming of the original commit.

Thanks, got it.

> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> > > 
> > >  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad
> > > 100644
> > > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > > @@ -545,7 +545,7 @@
> > >  		compatible = "adi,adv7511w";
> > >  		reg = <0x39>;
> > >  		interrupt-parent = <&gpio3>;
> > > -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> > > +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
> > > 
> > >  		adi,input-depth = <8>;
> > >  		adi,input-colorspace = "rgb";
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[Ben Hutchings]

On Wed, 2015-04-29 at 16:55 +0300, Laurent Pinchart wrote:
> The adv7511 IRQ is low level triggered, not falling edge triggered. The
> wrong sense configuration results in no interrupt being triggered at
> all, breaking hotplug detection. Fix it.

The Lager DT has the same bug; will you send a fix for that or should I?

Ben.

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index 74c3212f1f11..824ddab9c3ad 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -545,7 +545,7 @@
>  		compatible = "adi,adv7511w";
>  		reg = <0x39>;
>  		interrupt-parent = <&gpio3>;
> -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
>  
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";

Re: [PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[Laurent Pinchart]

Hi Ben,

On Tuesday 05 May 2015 22:17:56 Ben Hutchings wrote:
> On Wed, 2015-04-29 at 16:55 +0300, Laurent Pinchart wrote:
> > The adv7511 IRQ is low level triggered, not falling edge triggered. The
> > wrong sense configuration results in no interrupt being triggered at
> > all, breaking hotplug detection. Fix it.
> 
> The Lager DT has the same bug; will you send a fix for that or should I?

I've sent it and CC'ed you.

> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 74c3212f1f11..824ddab9c3ad
> > 100644
> > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > @@ -545,7 +545,7 @@
> >  		compatible = "adi,adv7511w";
> >  		reg = <0x39>;
> >  		interrupt-parent = <&gpio3>;
> > -		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
> > +		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
> > 
> >  		adi,input-depth = <8>;
> >  		adi,input-colorspace = "rgb";

-- 
Regards,

Laurent Pinchart

[GIT PULL] Renesas ARM Based SoC Fixes for v4.1

[Simon Horman]

Hi Olof, Hi Kevin, Hi Arnd,

Please consider these Renesas ARM based SoC fixes for v4.1.

This addresses a short-coming which was introduced when
the adv7511 was enabled on the koelsch board.


The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031:

  Linux 4.1-rc1 (2015-04-26 17:59:10 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes-for-v4.1

for you to fetch changes up to 12392f5896c9affc03c1ddd95a83c32238862a58:

  ARM: shmobile: koelsch: Fix adv7511 IRQ sensing (2015-05-01 09:13:03 +0900)

----------------------------------------------------------------
Renesas ARM Based SoC Fixes for v4.1

* Fix adv7511 IRQ sensing on koelsch board

----------------------------------------------------------------
Laurent Pinchart (1):
      ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[Simon Horman]

From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

The adv7511 IRQ is low level triggered, not falling edge triggered. The
wrong sense configuration results in no interrupt being triggered at
all, breaking hotplug detection. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 74c3212f1f11..824ddab9c3ad 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -545,7 +545,7 @@
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
 		interrupt-parent = <&gpio3>;
-		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
 
 		adi,input-depth = <8>;
 		adi,input-colorspace = "rgb";
-- 
2.1.4

[PATCH] ARM: shmobile: koelsch: Fix adv7511 IRQ sensing

[Simon Horman]

From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

The adv7511 IRQ is low level triggered, not falling edge triggered. The
wrong sense configuration results in no interrupt being triggered at
all, breaking hotplug detection. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Fixes: 83a0731b39f3 ("ARM: shmobile: koelsch: Add DU HDMI output support")
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 74c3212f1f11..824ddab9c3ad 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -545,7 +545,7 @@
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
 		interrupt-parent = <&gpio3>;
-		interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
 
 		adi,input-depth = <8>;
 		adi,input-colorspace = "rgb";
-- 
2.1.4